fix(recorder): "already started" notification

This commit is contained in:
Hristo Terezov 2021-11-09 12:58:49 -06:00
parent 981fc2f410
commit bcb0fe919c
3 changed files with 19 additions and 4 deletions

View File

@ -501,6 +501,7 @@
"expandedPending": "The live streaming is being started...", "expandedPending": "The live streaming is being started...",
"failedToStart": "Live Streaming failed to start", "failedToStart": "Live Streaming failed to start",
"getStreamKeyManually": "We werent able to fetch any live streams. Try getting your live stream key from YouTube.", "getStreamKeyManually": "We werent able to fetch any live streams. Try getting your live stream key from YouTube.",
"inProgress": "Recording or live streaming in progress",
"invalidStreamKey": "Live stream key may be incorrect.", "invalidStreamKey": "Live stream key may be incorrect.",
"off": "Live Streaming stopped", "off": "Live Streaming stopped",
"offBy": "{{name}} stopped the live streaming", "offBy": "{{name}} stopped the live streaming",
@ -761,6 +762,7 @@
"expandedPending": "Recording is being started...", "expandedPending": "Recording is being started...",
"failedToStart": "Recording failed to start", "failedToStart": "Recording failed to start",
"fileSharingdescription": "Share recording with meeting participants", "fileSharingdescription": "Share recording with meeting participants",
"inProgress": "Recording or live streaming in progress",
"linkGenerated": "We have generated a link to your recording.", "linkGenerated": "We have generated a link to your recording.",
"live": "LIVE", "live": "LIVE",
"loggedIn": "Logged in as {{userName}}", "loggedIn": "Logged in as {{userName}}",

View File

@ -9,7 +9,8 @@ import {
NOTIFICATION_TIMEOUT, NOTIFICATION_TIMEOUT,
hideNotification, hideNotification,
showErrorNotification, showErrorNotification,
showNotification showNotification,
showWarningNotification
} from '../notifications'; } from '../notifications';
import { import {
@ -115,6 +116,16 @@ export function showRecordingError(props: Object) {
return showErrorNotification(props); return showErrorNotification(props);
} }
/**
* Signals that the recording warning notification should be shown.
*
* @param {Object} props - The Props needed to render the notification.
* @returns {showWarningNotification}
*/
export function showRecordingWarning(props: Object) {
return showWarningNotification(props);
}
/** /**
* Signals that the stopped recording notification should be shown on the * Signals that the stopped recording notification should be shown on the
* screen for a given period. * screen for a given period.

View File

@ -27,6 +27,7 @@ import {
showPendingRecordingNotification, showPendingRecordingNotification,
showRecordingError, showRecordingError,
showRecordingLimitNotification, showRecordingLimitNotification,
showRecordingWarning,
showStartedRecordingNotification, showStartedRecordingNotification,
showStoppedRecordingNotification, showStoppedRecordingNotification,
updateRecordingSessionData updateRecordingSessionData
@ -262,10 +263,11 @@ function _showRecordingErrorNotification(recorderSession, dispatch) {
})); }));
break; break;
case JitsiMeetJS.constants.recording.error.UNEXPECTED_REQUEST: case JitsiMeetJS.constants.recording.error.UNEXPECTED_REQUEST:
dispatch(showRecordingError({ dispatch(showRecordingWarning({
titleKey: isStreamMode descriptionKey: isStreamMode
? 'liveStreaming.sessionAlreadyActive' ? 'liveStreaming.sessionAlreadyActive'
: 'recording.sessionAlreadyActive' : 'recording.sessionAlreadyActive',
titleKey: isStreamMode ? 'liveStreaming.inProgress' : 'recording.inProgress'
})); }));
break; break;
default: default: