fix(filmstrip/toolbox) mobile ui adjustments

This commit is contained in:
Calin Chitu 2022-02-25 13:57:07 +02:00 committed by Calinteodor
parent c2a3d29353
commit be152b12d7
3 changed files with 30 additions and 5 deletions

View File

@ -1,13 +1,15 @@
// @flow // @flow
import React, { PureComponent } from 'react'; import React, { PureComponent } from 'react';
import { FlatList, SafeAreaView } from 'react-native'; import { FlatList } from 'react-native';
import { SafeAreaView } from 'react-native-safe-area-context';
import { getLocalParticipant } from '../../../base/participants'; import { getLocalParticipant } from '../../../base/participants';
import { Platform } from '../../../base/react'; import { Platform } from '../../../base/react';
import { connect } from '../../../base/redux'; import { connect } from '../../../base/redux';
import { ASPECT_RATIO_NARROW } from '../../../base/responsive-ui/constants'; import { ASPECT_RATIO_NARROW } from '../../../base/responsive-ui/constants';
import { shouldHideSelfView } from '../../../base/settings/functions.any'; import { shouldHideSelfView } from '../../../base/settings/functions.any';
import { isToolboxVisible } from '../../../toolbox/functions';
import { setVisibleRemoteParticipants } from '../../actions'; import { setVisibleRemoteParticipants } from '../../actions';
import { isFilmstripVisible, shouldRemoteVideosBeVisible } from '../../functions'; import { isFilmstripVisible, shouldRemoteVideosBeVisible } from '../../functions';
@ -37,6 +39,11 @@ type Props = {
*/ */
_disableSelfView: boolean, _disableSelfView: boolean,
/**
* Whether or not the toolbox is displayed.
*/
_isToolboxVisible: Boolean,
_localParticipantId: string, _localParticipantId: string,
/** /**
@ -223,7 +230,14 @@ class Filmstrip extends PureComponent<Props> {
* @returns {ReactElement} * @returns {ReactElement}
*/ */
render() { render() {
const { _aspectRatio, _localParticipantId, _participants, _visible, _disableSelfView } = this.props; const {
_aspectRatio,
_disableSelfView,
_isToolboxVisible,
_localParticipantId,
_participants,
_visible
} = this.props;
if (!_visible) { if (!_visible) {
return null; return null;
@ -248,7 +262,14 @@ class Filmstrip extends PureComponent<Props> {
} }
return ( return (
<SafeAreaView style = { filmstripStyle }> <SafeAreaView
edges = { [
!_isToolboxVisible && 'bottom',
'top',
'left',
'right'
].filter(Boolean) }
style = { filmstripStyle }>
{ {
this._separateLocalThumbnail this._separateLocalThumbnail
&& !isNarrowAspectRatio && !isNarrowAspectRatio
@ -299,6 +320,7 @@ function _mapStateToProps(state) {
_clientHeight: responsiveUI.clientHeight, _clientHeight: responsiveUI.clientHeight,
_clientWidth: responsiveUI.clientWidth, _clientWidth: responsiveUI.clientWidth,
_disableSelfView: disableSelfView, _disableSelfView: disableSelfView,
_isToolboxVisible: isToolboxVisible(state),
_localParticipantId: getLocalParticipant(state)?.id, _localParticipantId: getLocalParticipant(state)?.id,
_participants: showRemoteVideos ? remoteParticipants : NO_REMOTE_VIDEOS, _participants: showRemoteVideos ? remoteParticipants : NO_REMOTE_VIDEOS,
_visible: enabled && isFilmstripVisible(state) _visible: enabled && isFilmstripVisible(state)

View File

@ -45,7 +45,7 @@ export default {
flexDirection: 'row', flexDirection: 'row',
flexGrow: 0, flexGrow: 0,
justifyContent: 'flex-end', justifyContent: 'flex-end',
marginBottom: 5 marginBottom: BaseTheme.spacing[1]
}, },
/** /**

View File

@ -100,7 +100,10 @@ const styles = {
flexGrow: 0, flexGrow: 0,
height: '100%', height: '100%',
width: '100%', width: '100%',
maxHeight: 80,
// TODO revisit this
maxHeight: 76,
maxWidth: 580, maxWidth: 580,
marginLeft: 'auto', marginLeft: 'auto',
marginRight: 'auto' marginRight: 'auto'