haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Fixes startWithAudioMuted on quickly moving away from pre-join screen. 

When gUM is slow, and we quickly join the conference, then startWithAudioMuted was not respected.
This commit is contained in:
Дамян Минков 2022-01-07 10:25:01 -06:00 committed by Jaya Allamsetty
parent 4878a00014
commit c5821d7a5f
1 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
conference.js
View File

@ -796,6 +796,20 @@ export default {
logger.warn('initial device list initialization failed', error); logger.warn('initial device list initialization failed', error);
} }
const handleStartAudioMuted = (options, tracks) => {
if (options.startWithAudioMuted) {
// Always add the track on Safari because of a known issue where audio playout doesn't happen
// if the user joins audio and video muted, i.e., if there is no local media capture.
if (browser.isWebKitBased()) {
this.muteAudio(true, true);
} else {
return tracks.filter(track => track.getType() !== MEDIA_TYPE.AUDIO);
}
}
return tracks;
};
if (isPrejoinPageVisible(APP.store.getState())) { if (isPrejoinPageVisible(APP.store.getState())) {
_connectionPromise = connect(roomName).then(c => { _connectionPromise = connect(roomName).then(c => {
// we want to initialize it early, in case of errors to be able // we want to initialize it early, in case of errors to be able
@ -827,25 +841,14 @@ export default {
this._displayErrorsForCreateInitialLocalTracks(errors); this._displayErrorsForCreateInitialLocalTracks(errors);
return this._setLocalAudioVideoStreams(tracks); return this._setLocalAudioVideoStreams(handleStartAudioMuted(initialOptions, tracks));
} }
const [ tracks, con ] = await this.createInitialLocalTracksAndConnect(roomName, initialOptions); const [ tracks, con ] = await this.createInitialLocalTracksAndConnect(roomName, initialOptions);
let localTracks = tracks;
this._initDeviceList(true); this._initDeviceList(true);
if (initialOptions.startWithAudioMuted) { return this.startConference(con, handleStartAudioMuted(initialOptions, tracks));
// Always add the track on Safari because of a known issue where audio playout doesn't happen
// if the user joins audio and video muted, i.e., if there is no local media capture.
if (browser.isWebKitBased()) {
this.muteAudio(true, true);
} else {
localTracks = localTracks.filter(track => track.getType() !== MEDIA_TYPE.AUDIO);
}
}
return this.startConference(con, localTracks);
}, },
/** /**