haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[RN] Fix handling XMPP connection failures 

After the connection is established, it can either be properly disconnected or
fail. We need to make sure to be listening for events for either.
This commit is contained in:
Saúl Ibarra Corretgé 2018-05-23 13:43:40 +02:00 committed by Lyubo Marinov
parent f12ba37cf3
commit d557a6505d
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
react/features/base/connection/actions.native.js
View File

@ -108,10 +108,7 @@ export function connect(id: ?string, password: ?string) {
* @returns {void}
*/
function _onConnectionDisconnected(message: string) {
connection.removeEventListener(
JitsiConnectionEvents.CONNECTION_DISCONNECTED,
_onConnectionDisconnected);
unsubscribe();
dispatch(_connectionDisconnected(connection, message));
}
@ -122,7 +119,9 @@ export function connect(id: ?string, password: ?string) {
* @returns {void}
*/
function _onConnectionEstablished() {
unsubscribe();
connection.removeEventListener(
JitsiConnectionEvents.CONNECTION_ESTABLISHED,
_onConnectionEstablished);
dispatch(connectionEstablished(connection));
}
@ -141,7 +140,6 @@ export function connect(id: ?string, password: ?string) {
function _onConnectionFailed(
err: string, msg: string, credentials: Object) {
unsubscribe();
console.error('CONNECTION FAILED:', err, msg);
dispatch(
connectionFailed(
connection, {
@ -153,15 +151,15 @@ export function connect(id: ?string, password: ?string) {
}
/**
* Unsubscribes connection instance from {@code CONNECTION_ESTABLISHED}
* and {@code CONNECTION_FAILED} events.
* Unsubscribe the connection instance from
* {@code CONNECTION_DISCONNECTED} and {@code CONNECTION_FAILED} events.
*
* @returns {void}
*/
function unsubscribe() {
connection.removeEventListener(
JitsiConnectionEvents.CONNECTION_ESTABLISHED,
_onConnectionEstablished);
JitsiConnectionEvents.CONNECTION_DISCONNECTED,
_onConnectionDisconnected);
connection.removeEventListener(
JitsiConnectionEvents.CONNECTION_FAILED,
_onConnectionFailed);