haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Adds a FIXME (comment) to make a note of the fact that loading analytics.js after modules/statistics/AnalyticsAdapter.js forces the method AnalyticsAdapter.sendEvent to a no-op.

This commit is contained in:
Lyubomir Marinov 2016-01-13 19:05:44 +02:00
parent dc07fd733f
commit d7c9a97e8d
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
index.html
View File

@ -226,6 +226,13 @@
if (!config.disableThirdPartyRequests) { if (!config.disableThirdPartyRequests) {
[ [
'https://api.callstats.io/static/callstats.min.js', 'https://api.callstats.io/static/callstats.min.js',
// FIXME The implementation provided by analytics.js starts an
// asynchronous download of the Google Analytics integration.
// Unfortunately, modules/statistics/AnalyticsAdapter.js has already
// made the decision to not use it at the current point of the
// execution and has initialized itself with the NoopAnalytics
// implementation i.e. the implementation of the method
// AnalyticsAdapter.sendEvent will amount to nothing.
'analytics.js?v=1' 'analytics.js?v=1'
].forEach(function(extSrc) { ].forEach(function(extSrc) {
var extScript = document.createElement('script'); var extScript = document.createElement('script');