haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Address review

This commit is contained in:
Horatiu Muresan 2023-02-23 14:30:15 +02:00
parent ca06802f18
commit d9096faecc
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
react/features/invite/components/dial-in-summary/web/NumbersList.tsx
View File

@ -10,7 +10,7 @@ import { Icon, IconSip } from '../../../../base/icons';
countries.registerLocale(en); countries.registerLocale(en);
type NormalizedNumber = { interface INormalizedNumber {
/** /**
* The country code. * The country code.
@ -26,9 +26,11 @@ type NormalizedNumber = {
* Whether the number is toll-free. * Whether the number is toll-free.
*/ */
tollFree?: boolean; tollFree?: boolean;
}; }
type NumbersMapping = { [countryName: string]: Array<NormalizedNumber>; }; interface INumbersMapping {
[countryName: string]: Array<INormalizedNumber>;
}
interface IProps extends WithTranslation { interface IProps extends WithTranslation {
@ -46,7 +48,7 @@ interface IProps extends WithTranslation {
* The phone numbers to display. Can be an array of number Objects or an * The phone numbers to display. Can be an array of number Objects or an
* object with countries as keys and an array of numbers as values. * object with countries as keys and an array of numbers as values.
*/ */
numbers: NumbersMapping; numbers: INumbersMapping;
} }
@ -82,7 +84,7 @@ const NumbersList: React.FC<IProps> = ({ t, conferenceID, clickableNumbers, numb
return number; return number;
}, [ conferenceID, clickableNumbers ]); }, [ conferenceID, clickableNumbers ]);
const renderNumbersList = useCallback((numbers: Array<NormalizedNumber>) => { const renderNumbersList = useCallback((numbers: Array<INormalizedNumber>) => {
const numbersListItems = numbers.map(number => const numbersListItems = numbers.map(number =>
(<li (<li
className = 'dial-in-number' className = 'dial-in-number'
@ -97,7 +99,7 @@ const NumbersList: React.FC<IProps> = ({ t, conferenceID, clickableNumbers, numb
); );
}, []); }, []);
const renderNumbersTollFreeList = useCallback((numbers: Array<NormalizedNumber>) => { const renderNumbersTollFreeList = useCallback((numbers: Array<INormalizedNumber>) => {
const tollNumbersListItems = numbers.map(number => const tollNumbersListItems = numbers.map(number =>
(<li (<li
className = 'toll-free' className = 'toll-free'
@ -113,7 +115,7 @@ const NumbersList: React.FC<IProps> = ({ t, conferenceID, clickableNumbers, numb
}, []); }, []);
const renderNumbers = useMemo(() => { const renderNumbers = useMemo(() => {
let numbers: NumbersMapping; let numbers: INumbersMapping;
if (!numbersMapping) { if (!numbersMapping) {
return; return;
@ -167,7 +169,7 @@ const NumbersList: React.FC<IProps> = ({ t, conferenceID, clickableNumbers, numb
const rows: [JSX.Element] = [] as unknown as [JSX.Element]; const rows: [JSX.Element] = [] as unknown as [JSX.Element];
Object.keys(numbers).forEach((countryName: string) => { Object.keys(numbers).forEach((countryName: string) => {
const numbersArray: Array<NormalizedNumber> = numbers[countryName]; const numbersArray: Array<INormalizedNumber> = numbers[countryName];
const countryCode = numbersArray[0].countryCode const countryCode = numbersArray[0].countryCode
|| countries.getAlpha2Code(countryName, 'en')?.toUpperCase() || countries.getAlpha2Code(countryName, 'en')?.toUpperCase()
|| countryName; || countryName;