haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ref(callstats): Removes redundant config.js option.

This commit is contained in:
George Politis 2022-09-16 14:15:52 +00:00 committed by George Politis
parent 9bb0decb30
commit df9185f92a
2 changed files with 4 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
config.js
View File

@ -824,7 +824,7 @@ var config = {
// Application ID and Secret.
// callStatsID: '',
// callStatsSecret: '',
// callstatsStoreLogs: true,
// callStatsApplicationLogsDisabled: false,
// The callstats initialize config params as described in the API:
// https://docs.callstats.io/docs/javascript#callstatsinitialize-with-app-secret

22
react/features/base/logging/JitsiMeetLogStorage.ts
View File

@ -50,22 +50,6 @@ export default class JitsiMeetLogStorage {
return Boolean(conference);
}
/**
* Checks whether callstats logs storage is enabled.
*
* @returns {boolean} <tt>true</tt> when this storage can store logs to
* callstats, <tt>false</tt> otherwise.
*/
canStoreLogsCallstats() {
const { callstatsStoreLogs } = this.getState()['features/base/config'];
// The behavior prior to adding this configuration parameter, is to send logs to callstats (if callstats is
// enabled). So, in order to maintain backwards compatibility I set the default of this option to be true, i.e.
// if the config.callstatsStoreLogs is not set, the JS console logs will be sent to callstats (if callstats is
// enabled)
return callstatsStoreLogs || callstatsStoreLogs === undefined;
}
/**
* Checks whether rtcstats logs storage is enabled.
*
@ -92,9 +76,9 @@ export default class JitsiMeetLogStorage {
*/
storeLogs(logEntries: Array<string | any>) {
if (this.canStoreLogsCallstats()) {
this.storeLogsCallstats(logEntries);
}
// XXX the config.callStatsApplicationLogsDisabled controls whether or not the logs will be sent to callstats.
// this is done in LJM
this.storeLogsCallstats(logEntries);
if (this.canStoreLogsRtcstats()) {
RTCStats.sendLogs(logEntries);