haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(suboptimal-browser): remove inserting of app name in notification 

This prevents inserting any user overridden APP_NAME
values into html. A new translation key is being used
to immediately stop non-english languages from using the
problematic string.

Also tweaked the copy to remove the "eer" and fix
some grammar.
This commit is contained in:
Leonard Kim 2019-08-04 08:51:10 -07:00 committed by virtuacoplenny
parent 1409d6fb5e
commit e8eb7e1e1f
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lang/main.json
View File

@ -429,7 +429,7 @@
"somebody": "Somebody",
"startSilentTitle": "You joined with no audio output!",
"startSilentDescription": "Rejoin the meeting to enable audio",
"suboptimalExperienceDescription": "Eer... we are afraid your experience with {{appName}} isn't going to be that great here. We are looking for ways to improve this but, until then, please try using one of the <a href='static/recommendedBrowsers.html' target='_blank'>fully supported browsers</a>.",
"suboptimalBrowserWarning": "We are afraid your meeting experience isn't going to be that great here. We are looking for ways to improve this, but until then please try using one of the <a href='static/recommendedBrowsers.html' target='_blank'>fully supported browsers</a>.",
"suboptimalExperienceTitle": "Browser Warning",
"unmute": "Unmute",
"newDeviceCameraTitle": "New camera detected",

7
react/features/conference/functions.js
View File

@ -2,7 +2,6 @@ import { translateToHTML } from '../base/i18n';
import { isSuboptimalBrowser } from '../base/environment';
import { toState } from '../base/redux';
import { getName } from '../app';
import {
areThereNotifications,
showWarningNotification
@ -24,10 +23,8 @@ export function maybeShowSuboptimalExperienceNotification(dispatch, t) {
titleKey: 'notify.suboptimalExperienceTitle',
description: translateToHTML(
t,
'notify.suboptimalExperienceDescription',
{
appName: getName()
})
'notify.suboptimalBrowserWarning'
)
}
)
);