Makes sure we always resolve(call the callback) in feedback dialog.

Call the callback even when clicking outside the dialog, or escaping to close it.
This commit is contained in:
damencho 2016-09-22 16:55:08 -05:00
parent 06247266ad
commit eb2e709749
1 changed files with 7 additions and 5 deletions

View File

@ -176,6 +176,13 @@ export default class Dialog {
}); });
this.$el = this.window.$el; this.$el = this.window.$el;
AJS.dialog2(selector).on("hide", function() {
if (this.onCloseCallback) {
this.onCloseCallback();
this.onCloseCallback = null;
}
}.bind(this));
this.setState(); this.setState();
} }
@ -201,11 +208,6 @@ export default class Dialog {
hide() { hide() {
this.window.hide(); this.window.hide();
if (this.onCloseCallback) {
this.onCloseCallback();
this.onCloseCallback = null;
}
} }
onFeedbackSubmitted() { onFeedbackSubmitted() {