haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ref(toolbar): replace custom debounce with lodash throttle 

The current custom debounce function sets a timeout and ensures
additional calls are not executed while the timeout is pending.
Regulating the call of a function while also ensuring it gets
called at a certain time is a throttle.
This commit is contained in:
Leonard Kim 2017-08-21 17:15:40 -07:00
parent 28b4595561
commit ec7c10c99b
2 changed files with 5 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
modules/UI/UI.js
View File

@ -4,6 +4,8 @@ const logger = require("jitsi-meet-logger").getLogger(__filename);
var UI = {}; var UI = {};
import _ from 'lodash';
import Chat from "./side_pannels/chat/Chat"; import Chat from "./side_pannels/chat/Chat";
import SidePanels from "./side_pannels/SidePanels"; import SidePanels from "./side_pannels/SidePanels";
import Avatar from "./avatar/Avatar"; import Avatar from "./avatar/Avatar";
@ -20,7 +22,6 @@ import Filmstrip from "./videolayout/Filmstrip";
import SettingsMenu from "./side_pannels/settings/SettingsMenu"; import SettingsMenu from "./side_pannels/settings/SettingsMenu";
import Profile from "./side_pannels/profile/Profile"; import Profile from "./side_pannels/profile/Profile";
import Settings from "./../settings/Settings"; import Settings from "./../settings/Settings";
import { debounce } from "../util/helpers";
import { updateDeviceList } from '../../react/features/base/devices'; import { updateDeviceList } from '../../react/features/base/devices';
import { import {
@ -278,13 +279,13 @@ UI.start = function () {
sharedVideoManager = new SharedVideoManager(eventEmitter); sharedVideoManager = new SharedVideoManager(eventEmitter);
if (!interfaceConfig.filmStripOnly) { if (!interfaceConfig.filmStripOnly) {
let debouncedShowToolbar let throttledShowToolbar
= debounce( = _.throttle(
() => UI.showToolbar(), () => UI.showToolbar(),
100, 100,
{ leading: true, trailing: false }); { leading: true, trailing: false });
$("#videoconference_page").mousemove(debouncedShowToolbar); $("#videoconference_page").mousemove(throttledShowToolbar);
// Initialise the recording module. // Initialise the recording module.
if (config.enableRecording) { if (config.enableRecording) {

30
modules/util/helpers.js
View File

@ -16,36 +16,6 @@ export function createDeferred() {
return deferred; return deferred;
} }
/**
* Creates a debounced function that delays invoking func until after wait
* milliseconds have elapsed since the last time the debounced function was
* invoked.
*
* @param fn
* @param wait
* @param options
* @returns {function(...[*])}
*/
export function debounce(fn, wait = 0, options = {}) {
const leading = options.leading || false;
const trailing
= (typeof options.trailing === 'undefined') || options.trailing;
let called = false;
return (...args) => {
if (!called) {
leading && fn(...args);
setTimeout(() => {
called = false;
trailing && fn(...args);
}, wait);
called = true;
}
};
}
/** /**
* Returns the namespace for all global variables, functions, etc that we need. * Returns the namespace for all global variables, functions, etc that we need.
* *