haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(LargeVideoManager): frozen displayname in a msg 

The "data-i18n-options" attribute value is stored in jQuery cache and
at the time when i18-next tries to access it to do the translation
it gets the old value from the cache and the message is not updated
correctly. Passing the "msgOptions" explicitly to "translateElement"
fixes the problem by avoiding jQuery cache.
This commit is contained in:
paweldomas 2016-11-02 11:28:44 -05:00
parent 0bf372b8ab
commit ede4808ec4
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
modules/UI/videolayout/LargeVideoManager.js
View File

@ -382,7 +382,8 @@ export default class LargeVideoManager {
$('#remoteConnectionMessage') $('#remoteConnectionMessage')
.attr("data-i18n", msgKey) .attr("data-i18n", msgKey)
.attr("data-i18n-options", JSON.stringify(msgOptions)); .attr("data-i18n-options", JSON.stringify(msgOptions));
APP.translation.translateElement($('#remoteConnectionMessage')); APP.translation.translateElement(
$('#remoteConnectionMessage'), msgOptions);
} }
this.videoContainer.positionRemoteConnectionMessage(); this.videoContainer.positionRemoteConnectionMessage();
@ -394,14 +395,12 @@ export default class LargeVideoManager {
* *
* @param {string} msgKey the translation key which will be used to get * @param {string} msgKey the translation key which will be used to get
* the message text to be displayed on the large video. * the message text to be displayed on the large video.
* @param {object} msgOptions translation options object
* *
* @private * @private
*/ */
_setLocalConnectionMessage (msgKey, msgOptions) { _setLocalConnectionMessage (msgKey) {
$('#localConnectionMessage') $('#localConnectionMessage')
.attr("data-i18n", msgKey) .attr("data-i18n", msgKey);
.attr("data-i18n-options", JSON.stringify(msgOptions));
APP.translation.translateElement($('#localConnectionMessage')); APP.translation.translateElement($('#localConnectionMessage'));
} }