fix(info): show dialog after joining the conference
Delay showing the dialog until after joining the conference instead of as soon as possible. This resolves a few issues. One is the dialog displaying right before the permissions overlay is shown. Another is that logically it does not make sense to show the invite options when unable to invite. It also sidesteps the initial react UI bootstrapping that can cause race conditions with toolbar re-renders causing misalignment. Lastly, it prepares prematurely for what I assume will be changes for when the info dialog will actually be shown automatically.
This commit is contained in:
parent
323d38ac94
commit
f539240840
|
@ -1,5 +1,7 @@
|
|||
import { CONFERENCE_JOINED } from '../base/conference';
|
||||
import { MiddlewareRegistry } from '../base/redux';
|
||||
|
||||
import { setInfoDialogVisibility } from './actions';
|
||||
import { UPDATE_DIAL_IN_NUMBERS_FAILED } from './actionTypes';
|
||||
|
||||
const logger = require('jitsi-meet-logger').getLogger(__filename);
|
||||
|
@ -15,6 +17,10 @@ MiddlewareRegistry.register(store => next => action => {
|
|||
const result = next(action);
|
||||
|
||||
switch (action.type) {
|
||||
case CONFERENCE_JOINED:
|
||||
store.dispatch(setInfoDialogVisibility(true));
|
||||
break;
|
||||
|
||||
case UPDATE_DIAL_IN_NUMBERS_FAILED:
|
||||
logger.error(
|
||||
'Error encountered while fetching dial-in numbers:',
|
||||
|
|
|
@ -7,10 +7,6 @@ import {
|
|||
} from './actionTypes';
|
||||
|
||||
const DEFAULT_STATE = {
|
||||
|
||||
// By default show the info dialog when joining the conference.
|
||||
infoDialogVisible: true,
|
||||
|
||||
numbersEnabled: true
|
||||
};
|
||||
|
||||
|
|
Loading…
Reference in New Issue