haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(rtcstats): Fix rtcstats poll interval typo and increase default value (#12024) 

* fix(rtcstats): fixed typo in rtcstats pollInterval

* fix(rtcstats): set rtcstats default poll interval value to 10s
This commit is contained in:
Nils Ohlmeier 2022-08-16 10:37:04 -07:00 committed by GitHub
parent 123ab32e75
commit f70ed9cb8a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
config.js
View File

@ -968,7 +968,7 @@ var config = {
// The interval at which rtcstats will poll getStats, defaults to 1000ms. // The interval at which rtcstats will poll getStats, defaults to 1000ms.
// If the value is set to 0 getStats won't be polled and the rtcstats client // If the value is set to 0 getStats won't be polled and the rtcstats client
// will only send data related to RTCPeerConnection events. // will only send data related to RTCPeerConnection events.
// rtcstatsPolIInterval: 1000, // rtcstatsPollInterval: 1000,
// Array of script URLs to load as lib-jitsi-meet "analytics handlers". // Array of script URLs to load as lib-jitsi-meet "analytics handlers".
// scriptURLs: [ // scriptURLs: [

2
react/features/base/config/configType.ts
View File

@ -99,7 +99,7 @@ export interface IConfig {
obfuscateRoomName?: boolean; obfuscateRoomName?: boolean;
rtcstatsEnabled?: boolean; rtcstatsEnabled?: boolean;
rtcstatsEndpoint?: string; rtcstatsEndpoint?: string;
rtcstatsPolIInterval?: number; rtcstatsPollInterval?: number;
scriptURLs?: Array<string>; scriptURLs?: Array<string>;
}; };
apiLogLevels?: Array<'warn' | 'log' | 'error' | 'info' | 'debug'>; apiLogLevels?: Array<'warn' | 'log' | 'error' | 'info' | 'debug'>;

2
react/features/rtcstats/middleware.js
View File

@ -42,7 +42,7 @@ MiddlewareRegistry.register(store => next => action => {
// original non proxy versions of these functions. // original non proxy versions of these functions.
try { try {
// Default poll interval is 1000ms and standard stats will be used, if not provided in the config. // Default poll interval is 1000ms and standard stats will be used, if not provided in the config.
const pollInterval = analytics.rtcstatsPollInterval || 1000; const pollInterval = analytics.rtcstatsPollInterval || 10000;
const useLegacy = analytics.rtcstatsUseLegacy || false; const useLegacy = analytics.rtcstatsUseLegacy || false;