haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ref(toolbar): remove old recording button logic

This commit is contained in:
Leonard Kim 2018-04-10 15:09:57 -07:00 committed by Saúl Ibarra Corretgé
parent abee3331aa
commit fe473bf426
2 changed files with 2 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/UI/UI.js
View File

@ -530,8 +530,6 @@ UI.onPeerVideoTypeChanged
UI.updateLocalRole = isModerator => { UI.updateLocalRole = isModerator => {
VideoLayout.showModeratorIndicator(); VideoLayout.showModeratorIndicator();
Recording.showRecordingButton(isModerator);
if (isModerator) { if (isModerator) {
if (!interfaceConfig.DISABLE_FOCUS_INDICATOR) { if (!interfaceConfig.DISABLE_FOCUS_INDICATOR) {
messageHandler.participantNotification( messageHandler.participantNotification(

51
modules/UI/recording/Recording.js
View File

@ -1,4 +1,4 @@
/* global APP, $, config, interfaceConfig */ /* global APP, config, interfaceConfig */
/* /*
* Copyright @ 2015 Atlassian Pty Ltd * Copyright @ 2015 Atlassian Pty Ltd
* *
@ -192,8 +192,7 @@ function isStartingStatus(status) {
/** /**
* Manages the recording user interface and user experience. * Manages the recording user interface and user experience.
* @type {{init, initRecordingButton, showRecordingButton, updateRecordingState, * @type {{init, updateRecordingState, updateRecordingUI, checkAutoRecord}}
* updateRecordingUI, checkAutoRecord}}
*/ */
const Recording = { const Recording = {
/** /**
@ -215,13 +214,6 @@ const Recording = {
Object.assign(this, RECORDING_TRANSLATION_KEYS); Object.assign(this, RECORDING_TRANSLATION_KEYS);
} }
// XXX Due to the React-ification of Toolbox, the HTMLElement with id
// toolbar_button_record may not exist yet.
$(document).on(
'click',
'#toolbar_button_record',
ev => this._onToolbarButtonClick(ev));
this.eventEmitter.on(UIEvents.TOGGLE_RECORDING, this.eventEmitter.on(UIEvents.TOGGLE_RECORDING,
() => this._onToolbarButtonClick()); () => this._onToolbarButtonClick());
@ -242,28 +234,6 @@ const Recording = {
} }
}, },
/**
* Initialise the recording button.
*/
initRecordingButton() {
const selector = $('#toolbar_button_record');
selector.addClass(this.baseClass);
selector.attr('data-i18n', `[content]${this.recordingButtonTooltip}`);
APP.translation.translateElement(selector);
},
/**
* Shows or hides the 'recording' button.
* @param show {true} to show the recording button, {false} to hide it
*/
showRecordingButton(show) {
const shouldShow = show && _isRecordingButtonEnabled();
const id = 'toolbar_button_record';
UIUtil.setVisible(id, shouldShow);
},
/** /**
* Updates the recording state UI. * Updates the recording state UI.
* @param recordingState gives us the current recording state * @param recordingState gives us the current recording state
@ -304,7 +274,6 @@ const Recording = {
showSpinner: recordingState === JitsiRecordingStatus.RETRYING showSpinner: recordingState === JitsiRecordingStatus.RETRYING
}; };
this._setToolbarButtonToggled(true);
isRecording = true; isRecording = true;
break; break;
@ -330,8 +299,6 @@ const Recording = {
: this.recordingOffKey : this.recordingOffKey
}; };
this._setToolbarButtonToggled(false);
setTimeout(() => { setTimeout(() => {
APP.store.dispatch(hideRecordingLabel()); APP.store.dispatch(hideRecordingLabel());
}, 5000); }, 5000);
@ -345,8 +312,6 @@ const Recording = {
key: this.recordingPendingKey key: this.recordingPendingKey
}; };
this._setToolbarButtonToggled(false);
break; break;
} }
@ -356,8 +321,6 @@ const Recording = {
key: this.recordingErrorKey key: this.recordingErrorKey
}; };
this._setToolbarButtonToggled(false);
break; break;
} }
@ -488,16 +451,6 @@ const Recording = {
}); });
} }
} }
},
/**
* Sets the toggled state of the recording toolbar button.
*
* @param {boolean} isToggled indicates if the button should be toggled
* or not
*/
_setToolbarButtonToggled(isToggled) {
$('#toolbar_button_record').toggleClass('toggled', isToggled);
} }
}; };