haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removes unused parameters, adds documentation.

This commit is contained in:
Boris Grozev 2015-10-01 15:37:28 -05:00
parent ebdd91df4e
commit ff2b7ca921
2 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
modules/xmpp/JingleSessionPC.js
View File

@ -858,7 +858,11 @@ JingleSessionPC.prototype.sendTerminate = function (reason, text) {
} }
}; };
JingleSessionPC.prototype.addSource = function (elem, fromJid) { /**
* Handles a Jingle source-add message for this Jingle session.
* @param elem An array of Jingle "content" elements.
*/
JingleSessionPC.prototype.addSource = function (elem) {
var self = this; var self = this;
// FIXME: dirty waiting // FIXME: dirty waiting
@ -866,7 +870,7 @@ JingleSessionPC.prototype.addSource = function (elem, fromJid) {
console.warn("addSource - localDescription not ready yet"); console.warn("addSource - localDescription not ready yet");
setTimeout(function() setTimeout(function()
{ {
self.addSource(elem, fromJid); self.addSource(elem);
}, },
200 200
); );
@ -939,14 +943,18 @@ JingleSessionPC.prototype.addSource = function (elem, fromJid) {
}); });
}; };
JingleSessionPC.prototype.removeSource = function (elem, fromJid) { /**
* Handles a Jingle source-remove message for this Jingle session.
* @param elem An array of Jingle "content" elements.
*/
JingleSessionPC.prototype.removeSource = function (elem) {
var self = this; var self = this;
// FIXME: dirty waiting // FIXME: dirty waiting
if (!this.peerconnection.localDescription) { if (!this.peerconnection.localDescription) {
console.warn("removeSource - localDescription not ready yet"); console.warn("removeSource - localDescription not ready yet");
setTimeout(function() { setTimeout(function() {
self.removeSource(elem, fromJid); self.removeSource(elem);
}, },
200 200
); );

4
modules/xmpp/strophe.jingle.js
View File

@ -174,11 +174,11 @@ module.exports = function(XMPP, eventEmitter) {
break; break;
case 'addsource': // FIXME: proprietary, un-jingleish case 'addsource': // FIXME: proprietary, un-jingleish
case 'source-add': // FIXME: proprietary case 'source-add': // FIXME: proprietary
sess.addSource($(iq).find('>jingle>content'), fromJid); sess.addSource($(iq).find('>jingle>content'));
break; break;
case 'removesource': // FIXME: proprietary, un-jingleish case 'removesource': // FIXME: proprietary, un-jingleish
case 'source-remove': // FIXME: proprietary case 'source-remove': // FIXME: proprietary
sess.removeSource($(iq).find('>jingle>content'), fromJid); sess.removeSource($(iq).find('>jingle>content'));
break; break;
default: default:
console.warn('jingle action not implemented', action); console.warn('jingle action not implemented', action);