haskal/jiti-meet - GitLain - Git with a cup of Lain

Author	SHA1	Message	Date
Leonard Kim	486e8e35d9	ref: move all prop type declaration to flow For the most part the changes are taking the "static propTypes" declaration off of components and declaring them as Flow types. Sometimes to support flow some method signatures had to be added. There are some exceptions in which more had to be done to tame the beast: - AbstractVideoTrack: put in additional truthy checks for videoTrack. - Video: add truthy checks for the _videoElement ref. - shouldRenderVideoTrack function: Some component could pass null for the videoTrack argument and Flow wanted that called out explicitly. - DisplayName: Add a truthy check for the input ref before acting on it. - NumbersList: Move array checks inline for Flow to comprehend array methods could be called. Add type checks in the Object.entries loop as the value is assumed to be a mixed type by Flow. - AbstractToolbarButton: add additional truthy check for passed in type.	2018-11-07 17:38:10 +01:00
Lyubo Marinov	d1e5e6b93b	Coding style: consistency, jsdocs These modification are not necessarily directly related to the containing PR, I merely saw them while reviewing the containing PR.	2017-11-27 17:45:17 -06:00
Lyubo Marinov	2e2129fa44	Import PropTypes from prop-types Prepare for React 16.	2017-09-27 16:24:53 -05:00
Lyubo Marinov	ec454d1da0	Move ConferenceUrl.inviteURL into React and redux	2017-06-01 21:04:31 -05:00
Lyubo Marinov	4dc658c270	Fix 'Missing JSDoc comment require-jsdoc'	2017-06-01 21:01:50 -05:00
Lyubo Marinov	a9bdde193d	Approach consistent filmstrip naming We seemed to be using the names "film strip" and "filmstrip" (and, consequently, their source code-conscious forms such as film-strip, FilmStrip, etc.) In order to comply with our coding style which requires a consistent one name for a given abstraction, choose one name and rename the uses of the other name. Wikipedia has a definition of a "filmstrip", I couldn't find a "film strip". I guess our abstraction can be seen as what's described there. When I google "film strip", I get results about "filmstrip" at the top. That's why I chose "filmstrip". Certain uses of "film strip" such as interfaceConfig.filmStripOnly and in the external API I left untouched in an attempt to preserve compatibility. I wasn't sure whether CSS was tangled in compatibility so I made a choice and renamed there was well.	2017-04-10 12:59:44 -05:00