jiti-meet

6,237 Commits 336 Branches 13,729 Tags 589 MiB

Author	SHA1	Message	Date
Saúl Ibarra Corretgé	35da39becf	[RN] NetworkActivityIndicator The basic indicator is extracted into a LoadingIndicator component, which then NetworkActivityIndicator displays (or not) based on network activity.	2017-09-20 15:59:56 -05:00
Lyubo Marinov	7f8e8177d0	[RN] Refactor "Keep track of ongoing network requests" and "Show a progress indicator in the BlankPage" I'm not saying that the two commits in question were wrong or worse than what I'm offering. Anyway, I think what I'm offering brings: * Compliance with expectations i.e. the middleware doesn't compute the next state from the current state, the reducer does; * Clarity and/or simplicity i.e. there's no global variable (reqIndex), there's no need for the term "index" (a.k.a "reqIndex") in the redux store. * By renaming net-interceptor to network-activity feels like it's preparing the feature to implement a NetworkActivityIndicator React Component which will take on more of the knowledge about the specifics of what is the network activity redux state exactly, is it maintained by interception or some other mechanism, and abstracts it in the feature itself allowing outsiders to merely render a React Component.	2017-08-29 18:54:04 -05:00

Author

SHA1

Message

Date

Saúl Ibarra Corretgé

35da39becf

[RN] NetworkActivityIndicator

The basic indicator is extracted into a LoadingIndicator component,
which then NetworkActivityIndicator displays (or not) based on network
activity.

2017-09-20 15:59:56 -05:00

Lyubo Marinov

7f8e8177d0

[RN] Refactor "Keep track of ongoing network requests" and "Show a progress indicator in the BlankPage"

I'm not saying that the two commits in question were wrong or worse than
what I'm offering. Anyway, I think what I'm offering brings:

* Compliance with expectations i.e. the middleware doesn't compute the
next state from the current state, the reducer does;

* Clarity and/or simplicity i.e. there's no global variable (reqIndex),
there's no need for the term "index" (a.k.a "reqIndex") in the redux
store.

* By renaming net-interceptor to network-activity feels like it's
preparing the feature to implement a NetworkActivityIndicator React
Component which will take on more of the knowledge about the specifics
of what is the network activity redux state exactly, is it maintained by
interception or some other mechanism, and abstracts it in the feature
itself allowing outsiders to merely render a React Component.

2017-08-29 18:54:04 -05:00

Renamed from react/features/mobile/net-interceptor/index.js (Browse further)

2 Commits