Commit Graph

365 Commits

Author SHA1 Message Date
Saúl Ibarra Corretgé 5fbf741278 fix(rn,filmstrip) avoid "red" screen sharing tile
Mobile does not render screen-shares in tiles for performance reasons.
This coincidentally fixes the "red" tile that was attempted to be
rendered when the local partitipant started screen-sharing.
2022-08-30 14:13:17 +02:00
Robert Pintilii 3bd3be4df0
ref: Convert files to TS (#12007)
Convert files that use material-ui to TS (needed for material-ui upgrade)
2022-08-26 12:54:03 +03:00
Robert Pintilii dfb2a07cfa
ref: Convert material-ui files to TS (#12013)
Convert files that use material-ui to TS (needed for material-ui upgrade)
2022-08-25 14:35:19 +03:00
Robert Pintilii 372c2cb0f9
fix(participant) Avoid unnecessary unpin calls (#12060) 2022-08-24 11:26:09 +03:00
Robert Pintilii 05fdd5f31f
ref: Convert some reducers to TS (#11994) 2022-08-09 15:22:18 +03:00
Robert Pintilii 8e0cb583af
ref(thumbnail) Use new button component for video menu trigger (#11921) 2022-08-01 10:05:17 +03:00
Robert Pintilii 5783e8992a
fix(screenshare-filmstrip) Fix pin screenshare (#11892)
On click on a screenshare pin that to stage (allows users to choose between multiple screenshares)
2022-07-29 14:13:02 +03:00
Jaya Allamsetty 2a5e169c2f fix(filmstrip): Remove SS ep from list of active speakers.
This fixes a case where duplicate SS tile appears when SS ep is the dominant speaker and all the active speakers are currently visisble.
2022-07-21 12:25:26 -04:00
Jaya Allamsetty c727b603af
fix(filmstrip) Make dominant speaker visible at all times (#11874)
* fix(filmstrip) Make dominant speaker visible at all times.

* squash: address review comments.
2022-07-20 15:51:47 -04:00
Robert Pintilii 5dbb17bc81
fix(filmstrip) Fix pinning (#11889) 2022-07-20 18:34:46 +03:00
Robert Pintilii 08173ac1df
fix(screensharing-pinning) Clear pin on tile view (#11864) 2022-07-15 15:03:45 +03:00
luzpaz c7f96de787
fix(misc) fix typos
Found via `codespell -q 3 -S ./lang -L miliseconds`
2022-07-14 09:10:08 +02:00
Robert Pintilii d910b9db57
fix(filmstrip) Fix screensharing filmstrip (#11775) 2022-07-04 10:32:59 +03:00
Robert Pintilii 21cf7f23c2
feat: Add screenshare filmstrip (#11714)
Add new screen share layout with resizable top panel
Only enable new layout in large meetings (min 50 participants - configurable)
2022-06-29 16:59:49 +03:00
Robert Pintilii ec47f530bc
fix(tile-view, rn) Fix tile view in landscape (#11749)
Increase number of max columns to 4
2022-06-27 15:20:58 +03:00
Robert Pintilii 38b21e986d
fix(pinning) Fix pinning (#11693)
Hide Pin to Stage button while screensharing
Fix pin indicator while screensharing
2022-06-17 15:15:14 +03:00
Robert Pintilii d06d190229
fix(keyboard-shortcut) Fix error on number keypress (#11680)
Fix error when pressing a number bigger than the number of participants
Fix local recording issue
2022-06-15 14:04:06 +03:00
robertpin 59ee984e09 fix(tile-view, rn) Fix landscape mode tile view 2022-06-14 13:38:24 +02:00
Jaya Allamsetty 1397b9ac80
fix(multi-stream) RN Add listeners for track streaming status updates on large-video.
* fix(multi-stream) RN Add listeners for track streaming status updates on large-video.
Fixes an issue where video on large-video is not being rendered when there is no filmstrip, i.e., there is only 1 remote participant in the call with source-name signaling enabled. Also do not show the screensharing indicator on the camera thumbnail when a virtual SS tile is created for the local screenshare.

* squash: add a comment
2022-06-01 16:13:27 -04:00
Jaya Allamsetty ad70f12cb4
fix(filmstrip) Add handlers for track streaming status on RN. (#11584)
* fix(filmstrip) Add handlers for track streaming status on RN.
This is needed for switching between video and avatar when the track's streaming status changes in source-name signaling mode.

* squash: Add comment.
2022-05-24 21:37:08 -04:00
Jaya Allamsetty f5004a2a0c ref(multi-stream) Use helper function to get the video track. 2022-05-19 17:05:36 -04:00
Jaya Allamsetty a707022d0b fix(multi-stream): Add a virtual SS tile on RN.
Add a second virtual SS tile on RN when a remote participant that has multi-stream mode enabled starts a screenshare.
2022-05-19 17:05:36 -04:00
Jaya Allamsetty 97ca3fb622 fix(multi-stream): fix virtual screenshare participant's thumbnail.
Add a screenshare status indicator at the bottom.
Fix the font and size of the resolution/fps stats so that it matches with that of the other thumbnails.
2022-05-19 17:05:36 -04:00
Hristo Terezov 39d30ea0b4 fix(stage-filmstrip): resize. 2022-05-09 18:17:53 -05:00
Hristo Terezov 084f911699 fix(stage-tile-view): crash when pinning 2022-05-06 16:59:39 -05:00
Hristo Terezov adef5095da
feat(RN-filmtrip) stop reordering small meetings 2022-05-06 12:18:57 +02:00
Hristo Terezov f34dde3376 feat(tile-view): expand tiles from last row.
If we have enough space on the last row we expand the width of the tiles
up to 16:9 ratio.
2022-05-05 08:55:02 -05:00
Robert Pintilii bb0d3b4c66
fix: Stage filmstrip (#11495) 2022-05-05 12:20:20 +03:00
William Liang d3fe246f61
refactor(multi-stream) refactor virtual screenshare creation and support plan-b clients (#11445)
* fix(multi-stream) update selector to find ss track by videoType or mediaType

* ref(multi-stream) move fake ss creation logic and support video type changed

* refactor(multi-stream) decouple sending and receiving multiple screenshare streams

* fix(multi-stream) fix receiver constraints with signaling and without multi-stream

* fix(mutli-stream) ensure plan b original SS thumbnail displays avatar

* fix(multi-stream) show fake SS for plan b sender

* refactor(multi-stream) poc for moving SS creation to state listener

* remove reference to fake SS creation

* fix lint errors

* rename to virtual screenshare participants

* fix minor bugs

* rename participant subscriber to specify web support only
2022-04-29 10:32:16 -04:00
pangrr f62cb7a0c7
Fix(multi-stream) fix an issue where avatar shows up occasionally.
* fix occasional unexpected avatar

* fix ss stats popover not shown

* fix linter issue
2022-04-28 18:25:45 -04:00
Hristo Terezov 550c730ed4 fix(tile-view):Recalculate on window height change 2022-04-28 08:35:39 +02:00
pangrr c03d86e0e3
fix: disabled connectStatusIndicatorIcon cause video not displayed (#11377)
* add and remove JitsiTrackEvents.TRACK_STREAMING_STATUS_CHANGED listener in middlewares

* add/remove listeners in components that use track streaming status

* remove track streaming status handler from ConnectionIndicatorIcon and ConnectionIndicatorContent

* check video track change before hanlding track streaming status
2022-04-26 15:33:50 -05:00
Robert Pintilii 97b958e9ea Fix import and naming 2022-04-21 09:01:51 -05:00
Robert Pintilii b00fc92ee6 Native fix 2022-04-21 09:01:51 -05:00
Robert Pintilii f9d1003527 Fixes 2022-04-21 09:01:51 -05:00
robertpin 0abefa87aa ref(stage-filmstrip) Refactor as new layout
Fixes screensharing selection issues. Now when there’s a screen share we just use the old VERTICAL_FILMSTRIP_VIEW layout
Add THUMBAIL_TYPE to determine how to display thumbnails
2022-04-21 09:01:51 -05:00
Hristo Terezov 221ecac12d feat(tile-vew): Calculate maxColumns dynamically 2022-04-18 11:19:58 -05:00
Jaya Allamsetty 744607a5cc fix(stageFilmstrip) Disable stage filmstrip by default. 2022-04-18 09:57:25 -05:00
William Liang 4a375aa2a4
fix(multi-stream) update screenshare display name (#11376) 2022-04-14 13:07:17 -04:00
Robert Pintilii 8bf42e79a0
fix(stage-filmstrip) Fix issues (#11360)
Fix dominant speaker not removed on leave
Fix video not shown in vertical filmstrip when a remote screensharing was on
Refactor pin/ unpin. Add click to unpin
Remove from stage on unpin, except dominant (just change pin state)
Fix local shows video on both stage and vertical filmstrip
Don't reorder on stage base on queue (sort all by id)
2022-04-12 09:57:01 +03:00
Calinteodor 7c523f3250
language(typescript) actionTypes.js -> actionTypes.ts (#10940)
* language(typescript) first ts component, added ts configurations, actionTypes.js are now ts files
2022-04-08 15:24:58 +03:00
Robert Pintilii c05a983c98
feat(stage-filmstrip) Added user configurable max (#11324)
The user can set the max number of participants that can be displayed on stage
Send the number on follow me to all participants
2022-04-07 11:31:53 +03:00
Дамян Минков 6687c3f4ab fix: Adds undefined check to avoid error.
Was breaking DisableSelfViewTest.
2022-04-06 12:30:05 -05:00
Avram Tudor 42703fed47
ref(face-landmarks) refactor namings (#11307)
* ref(face-landmarks) refactor namings

* code review
2022-04-06 12:10:31 +03:00
William Liang eb716af29b fix(multi-stream) support screenshare tile in stage filmstrip 2022-04-05 17:09:08 -04:00
Robert Pintilii d7c8164b74
fix(follow-me) Make follow me work with stage filmstrip (#11306)
On follow me enabled all participants will see the participants pinned by the moderator
Fix pinned indicator to work when stage filmstrip is disabled
Fix add participant on dominant speaker change: if the participant was already pinned keep it as pinned
Don’t add local participant on stage (on automatic selection)
2022-04-05 16:00:32 +03:00
William Liang 70090fd716
feat(multi-stream) Add fake participant tile for screen share.
prioritize participants with screen shares
support local screen share track
auto pin screen share
support screen share for large video
ensure fake screen share participants are sorted
fix local screen share in vertical filmstrip
fix local screen share in tile mode
use FakeScreenShareParticipant component for screen share thumbnails
ensure changes are behind feature flag and update jsdocs
fix bug where local screen share was not rendering
update receiver constraints to include SS source names
remove fake ss participant creation on track update
fix: handle screenshare muted change and track removal
refactor: update key values for sortedFakeScreenShareParticipants
address PR comments
refactor getter for screenshare tracks
rename state to sortedRemoteFakeScreenShareParticipants
2022-04-04 14:57:58 -04:00
Avram Tudor 2c165d4313
feat(face-landmarks) merge face expressions and face centering (#11283)
* feat(face-landmarks) merge face expressions and face centering

* code review

* code review

* code review
2022-04-04 16:09:14 +03:00
Robert Pintilii 4b84f71021
fix(filmstrip) Fix resizing on chat toggle (#11305)
Fix pinned indicator to be displayed only for pinned participants
2022-04-04 15:39:32 +03:00
Robert Pintilii ec0e824a43
feat(rn, thumbnail) Updated indicators on native (#11280)
Remove tint for participant in large view
Change pinned indicator from border to icon
On stage view move screen sharing indicator from top to bottom
On stage view show pinned indicator instead of moderator indicator
2022-03-31 14:39:49 +03:00
Robert Pintilii 343a1b87e2
fix(thumbnails) Fix recalculate tile dimensions on client resize (#11267)
Recalculate after new dimensions are in the store
Fixes issue where on participant pane toggle the tiles would not recalculate correctly
2022-03-31 12:13:33 +03:00
Robert Pintilii 1355876f83
feat(gif, rn) Added GIPHY integration on native (#11236)
Update Android build to support gif
Use GIF format instead of animated webp
Show GIFs in chat messages
Display GIF over tile
Add Giphy button in reactions menu
Added Giphy dialog
Fix isGifMessage to also allow upper case
2022-03-30 16:54:03 +03:00
Robert Pintilii 1a3432d580
fix(gif) Keep showing GIF on hover (#11266) 2022-03-30 16:08:19 +03:00
Robert Pintilii 45e8140209
fix(rn) Fix native after stage filmstrip merge (#11247) 2022-03-29 13:42:01 +03:00
Robert Pintilii c4db12cbd6
feat(stage) Add stage filmstrip (multiple participants on stage) (#11145)
See multiple participants on stage
Pin and unpin to stage
Automatic selection of participants to be displayed on the stage filmstrip based on dominant speaker changes
Make Filmstrip a reusable component. Used by MainFilmstrip (old functionality) and the new StageFilmstrip
Rename DominantSpeakerName to StageParticipantNameLabel
Active border now showed only for the dominant speaker (no longer for the pinned participant)
Hide video from the vertical filmstrip for the participants on stage
Update video constraints
Updated pinned indicator
2022-03-29 11:45:09 +03:00
Hristo Terezov 16bcb1b217 feat(filmstrip): Don't reorder in small meetings. 2022-03-15 14:56:46 -05:00
Hristo Terezov cb9511ef2c fix(resizable-filmstrip): grid view paddings. 2022-03-15 07:48:51 -05:00
Hristo Terezov e7c4a55add feat(tile-view): Optimize grid dimnsions.
Now the algorithm that calculates the
rows/columns/thumbnail-width/thumbnail-height configuration will
go trough all possible configurations and will choose the one
that covers with thumbnails the biggest area of the window.
2022-03-15 07:48:51 -05:00
Robert Pintilii 096ba054db
fix(filmstrip) Fix resizable filmstrip with shared video (#11124)
Calculate shared video width with the filmstrip width
Make resizable filmstrip mouseup event work with shared video iframe
2022-03-14 13:11:22 +02:00
Robert Pintilii 190041fc5a
feat(gif) Added GIF support (GIPHY integration) (#11021)
Show GIF menu in reactions menu
Search GIFs using the GIPHY API
Show GIFs as images in chat
Show GIFs on the thumbnail of the participant that sent it
Move GIF focus using up/ down arrows and send with Enter
Added analytics
2022-03-11 15:00:49 +02:00
Hristo Terezov 74384bfa66 fix(video-layout):Screenshares not updated on time 2022-03-04 18:13:36 -06:00
Tudor-Ovidiu Avram d718d9d8fb feat(face-centering) implement centering of faces in a video
Config options:

faceCoordinatesSharing.enabled
faceCoordinatesSharig.threshold
faceCoordinatesSharing.captureInterval
2022-03-04 18:13:36 -06:00
Robert Pintilii 2863b05f37
fix(dominant-label) Fix dominant speaker stage view label (#11071)
Move label to LargeVideo so that's it's centred in the view instead of the whole screen
Move vertical filmstrip max width calculation to a function and use it to set the large video width
2022-03-04 15:10:57 +02:00
Robert Pintilii 8bb5c114f8
fix(filmstrip) Fix resizable filmstrip (#11025)
Re-calculate tile sizes after config loaded
Make local tile always respect the ratio in interface_config
Merge calculate size for vertical view functions into one function
2022-03-02 16:46:20 +02:00
Calinteodor 577d62ea53
feat(filmstrip/toolbox) mobile ui updates (#11051) 2022-03-01 17:41:45 +02:00
Calin Chitu 1ab086247b feat(filmstrip/toolbox) mobile ui undo changes 2022-02-28 17:54:50 +02:00
Robert Pintilii 06800f88bf
fix(thumbnail) Fix pinned participant in the resizable filmstrip (#11042)
Show border on the pinned participant in the vertical filmstrip grid view
2022-02-28 17:03:47 +02:00
Calin Chitu be152b12d7 fix(filmstrip/toolbox) mobile ui adjustments 2022-02-25 14:26:56 +02:00
Robert Pintilii 2dda749b1f
feat(filmstrip) Make filmstrip user resizable (#10884)
Make conference info and toolbar appear on top of the filmstrip
After a breakpoint, filmstrip pushes over the stage view instead of appearing on top
On user resize make tiles wider; after a breakpoint show grid view in the filmstrip
On filmstrip visibility toggle animate stage view resize
Added config for filmstrip with disableResizableFilmstrip
2022-02-24 14:20:37 +02:00
Robert Pintilii fde33b72d0
fix(thumbnails, rn) Hide empty indicators container on native (#11019) 2022-02-24 14:17:02 +02:00
Saúl Ibarra Corretgé 011fe40853 fix(rn,filmstrip) fix local participant location
This applies to android only, where we don't separate the local
thumbnail.

In portrait mode the local thumbnail needs to be on the right, aka the
last one. In landscape mode it needs to be on top, aka the first.
2022-02-24 13:13:08 +01:00
Calin Chitu 34d8843a35 fix(mobile-ui) ui fixes 2022-02-23 16:56:41 +02:00
William Liang 05dc018671
feat(multi-stream-support) Replace participant connection status logic with track streaming status (#10934) 2022-02-23 07:30:10 -06:00
Robert Pintilii 59065d10f8
feat(thumbnails, rn) Native thumbnails redesign (#10954) 2022-02-14 12:13:18 +02:00
Hristo Terezov 2a8d0b6e33 fix(thumbnail): mouse enter is not triggered
Workaround for the issue when the mouse enter event is not triggered in
the use case where the layout changes and the mouse appears onn top of the
thumbnail. Example: Closing the participant pane.
2022-02-02 17:37:08 -06:00
Robert Pintilii 7e5c283e3c
feat(disableSelfView) Toggle self view on native (#10871)
Added toggle button in overflow menu
Created video menu with connection info and self view toggle buttons for local participant
2022-01-28 12:47:54 +02:00
Mihaela Dumitru 49dd007167
fix(config): use hide display name flag for dominant speaker (#10839) 2022-01-25 13:17:27 +02:00
Robert Pintilii 820ff8473c
feat(filmstrip) Updated filmstrip design (#10791)
Added background on hover
Updated toggle button
Made vertical filmstrip full height on desktop
2022-01-14 14:13:13 +02:00
Saúl Ibarra Corretgé 30f2fe3577 fix(filmstrip) don't display filmstrip toggle in Jibri 2022-01-12 16:32:44 +01:00
Robert Pintilii 0b836acad9
fix(thumbnail) Fixed screensharing indicator tooltip (#10780) 2022-01-12 15:32:30 +02:00
Robert Pintilii 44c2a6ce93
fix(thumbnail) Fix screenshare indicator (#10774) 2022-01-12 11:31:31 +02:00
Calin Chitu cce27baaf4 feat(filmstrip) fixed context menus for thumbnail 2022-01-07 17:42:38 +02:00
Robert Pintilii d44660527b
fix(thumbnail) Update tile resizing constraints (#10645)
disableTileEnlargement config now uses old behaviour (small tiles, not just small video in the tiles)
Update Firefox scrollbar style to match webkit
Show more rows when height allows it instead of stretching a fixed number of rows, but make sure we always try to fill the whole viewport
Added constraints for how narrow portrait tiles can be and how wide landscape tiles can be
Video should cover whole tile in tile view unless disableTileEnlargement is set or video is portrait
Added min height in px for tiles
2021-12-20 11:32:31 +02:00
Mihaela Dumitru 5cc3fade8f
feat(config): add flag to hide the participant display name (#10650) 2021-12-20 10:46:47 +02:00
Robert Pintilii a7bf037363
feat(raise-hand) Update raised hand design (#10651)
Updated indicator color and background color
Added border on thumbnails
Web and Native
2021-12-20 10:44:22 +02:00
Robert Pintilii a42483c84b
fix(rn, tileview) Add SafeAreaView to Tile View (#10642) 2021-12-20 10:27:55 +02:00
Дамян Минков 5dee37dd82
Self view refactor (#10620)
* feat: Drops hide self-view setting from profile tab.

* feat: Moves function for disableSelfView value in base/settings.

* squash: Drops notification.

* feat: Move hide self view option in more tab.

* feat: Move hide self view option in more tab.

* feat: Adds option to disable self view UI settings.

* squash: Disable settings when controlled from config.
2021-12-16 10:55:45 -06:00
Avram Tudor ffe74ca68b
fix(tile-view) fix screensharing size in self view (#10634)
clean-up overriden css for tileview video tags
2021-12-16 15:33:30 +02:00
Robert Pintilii 91437c50e3
feat(thumbnail) Video thumbnails redesign and refactor (#10351)
Update video thumbnail design
Update design of indicators
In filmstrip view move Screen Sharing indicator to the top
Removed dominant speaker indicator
Use ContextMenu component for the connection stats popover
Combine Remove video menu and Meeting participant context menu into one component
Moved some styles from SCSS to JSS
Fix mobile avatars too big
Fix mobile horizontal scroll
Created button for Send to breakout room action
2021-12-15 15:18:41 +02:00
Robert Pintilii f8908c143e
fix(disableSelfView) Fix issue with remote participant video (#10582)
Fix issue where last participant is shown as inactive when the self view is hidden
2021-12-10 15:16:02 +02:00
robertpin 41f11e5adb feat(self-view) Added ability to hide self view
Added config option disableSelfView. This disables it on web and native

Added button on local video menu and toggle in settings on web to change the setting
2021-12-09 08:45:16 +01:00
robertpin 2e22eb5169 fix(overflow-drawer) Only use overflow drawer on mobile 2021-12-08 19:55:16 +01:00
Jasper Hugo ed6f6cf766 feat(tile-view): allow disabling thumbnail enlargement 2021-12-02 21:21:12 +01:00
Calin Chitu 5c67e8b4ce feat(config) defaultLocalDisplayName and defaultRemoteDisplayName 2021-11-26 18:52:43 +02:00
Avram Tudor 42e62e013d
fix(filmstrip) remove border from filmstrip (#10367) 2021-11-24 05:26:22 +02:00
Saúl Ibarra Corretgé 162a67fe8b chore(lint) tame the (uppdated) linter 2021-11-09 09:43:55 +01:00
Vlad Piersec 8983ea41fd fix(Drawer): Close drawer on item click
Clicking on an item when the popup drawer is displayed would keep it open.
Now clicking on any item should automatically close the drawer.

Popup was also refactored and no longer uses refs.
2021-11-02 15:45:29 +02:00
Avram Tudor 1793bf460e
fix(tileview) Enlarge tiles to fill whole space (#10201) 2021-10-26 11:46:01 +03:00
Vlad Piersec b0f8b34d94 refactor(toolbox): Rename touch start action for toggle button & move teranry 2021-10-26 09:10:35 +03:00
Vlad Piersec 366dc8d11b fix(toolbar): Hide/Show toolbar on tap on mobile web.
* A tap on video space will toggle the toolbar.
* Double tapping on a tile will pin the participant.
2021-10-26 09:10:35 +03:00