jiti-meet

Commit Graph

Author	SHA1	Message	Date
Saúl Ibarra Corretgé	8d1d3a9c42	[RN] Use same video mute indicator icon as on the web	2017-07-06 17:10:32 -05:00
Lyubo Marinov	ca94563c51	[RN] Coding style The files styles.js are used (pretty much) on React Native only and each of them exports 1 name. Export it as default to cut down on source code.	2017-06-10 18:07:51 -05:00
Lyubo Marinov	a9bdde193d	Approach consistent filmstrip naming We seemed to be using the names "film strip" and "filmstrip" (and, consequently, their source code-conscious forms such as film-strip, FilmStrip, etc.) In order to comply with our coding style which requires a consistent one name for a given abstraction, choose one name and rename the uses of the other name. Wikipedia has a definition of a "filmstrip", I couldn't find a "film strip". I guess our abstraction can be seen as what's described there. When I google "film strip", I get results about "filmstrip" at the top. That's why I chose "filmstrip". Certain uses of "film strip" such as interfaceConfig.filmStripOnly and in the external API I left untouched in an attempt to preserve compatibility. I wasn't sure whether CSS was tangled in compatibility so I made a choice and renamed there was well.	2017-04-10 12:59:44 -05:00

Author

SHA1

Message

Date

Saúl Ibarra Corretgé

8d1d3a9c42

[RN] Use same video mute indicator icon as on the web

2017-07-06 17:10:32 -05:00

Lyubo Marinov

ca94563c51

[RN] Coding style

The files styles.js are used (pretty much) on React Native only and each
of them exports 1 name. Export it as default to cut down on source code.

2017-06-10 18:07:51 -05:00

Lyubo Marinov

a9bdde193d

Approach consistent filmstrip naming

We seemed to be using the names "film strip" and "filmstrip" (and,
consequently, their source code-conscious forms such as film-strip,
FilmStrip, etc.) In order to comply with our coding style which requires
a consistent one name for a given abstraction, choose one name and
rename the uses of the other name.

Wikipedia has a definition of a "filmstrip", I couldn't find a "film
strip". I guess our abstraction can be seen as what's described there.
When I google "film strip", I get results about "filmstrip" at the top.
That's why I chose "filmstrip".

Certain uses of "film strip" such as interfaceConfig.filmStripOnly and
in the external API I left untouched in an attempt to preserve
compatibility.

I wasn't sure whether CSS was tangled in compatibility so I made a
choice and renamed there was well.

2017-04-10 12:59:44 -05:00

3 Commits