jiti-meet/react/features/base/conference
zbettenbuk 008645568c Fix startAudioOnly and startWithVideoMuted collision on start from URL
Zoltan Bettenbuk suggested the following:

         const state = getState();

          if (desiredTypes.length === 0) {
 -            const { audio, video } = state['features/base/media'];
 -
 -            audio.muted || desiredTypes.push(MEDIA_TYPE.AUDIO);
 -            video.muted || desiredTypes.push(MEDIA_TYPE.VIDEO);
 +            const startAudioOnly = getPropertyValue(state, 'startAudioOnly');
 +            const startWithAudioMuted
 +                = getPropertyValue(state, 'startWithAudioMuted');
 +            const startWithVideoMuted
 +                = getPropertyValue(state, 'startWithVideoMuted');
 +
 +            if (!startWithAudioMuted) {
 +                desiredTypes.push(MEDIA_TYPE.AUDIO);
 +            }
 +            if (!startAudioOnly && !startWithVideoMuted) {
 +                desiredTypes.push(MEDIA_TYPE.VIDEO);
 +            }
          }

          const availableTypes

The final commit is really a different implementation of the same idea
but takes into account that the state of base/media already contains the
intent of the URL and notices the delay in the realization of the
background app state.

Additionally, unbreaks one more case where setAudioOnly is incorrectly
dispatched on CONFERENCE_LEFT or CONFERENCE_FAILED and, consequently,
overrides the intent of the URL.
2018-04-16 22:02:37 -05:00
..
actionTypes.js feat(mobile): handle kicked out of the conference 2018-04-03 16:02:15 -05:00
actions.js feat(mobile): handle kicked out of the conference 2018-04-03 16:02:15 -05:00
constants.js feat(1080p): pass new-style constraints to createLocalTracks (#2087) 2017-10-31 17:08:07 -07:00
functions.js Flow, coding style 2017-10-13 14:34:09 -05:00
index.js [RN] fix(Avatar): Match the implementation for web 2017-03-08 13:21:34 -06:00
middleware.js Fix startAudioOnly and startWithVideoMuted collision on start from URL 2018-04-16 22:02:37 -05:00
reducer.js feat(new-toolbars): initial implementation 2018-03-27 00:54:30 -05:00