haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
kicad/gerbview/dialogs/dialog_select_one_pcb_layer...

267 lines
9.2 KiB
C++
Raw Permalink Normal View History

More missing source license fixes.
2014-10-21 18:36:45 +00:00
/*
* This program source code file is part of KiCad, a free EDA CAD application.
*
* Copyright (C) 2012-2014 Jean-Pierre Charras jp.charras at wanadoo.fr
Fix static event table derived object definitions.
2023-01-28 19:08:38 +00:00
* Copyright (C) 1992-2023 KiCad Developers, see AUTHORS.txt for contributors.
More missing source license fixes.
2014-10-21 18:36:45 +00:00
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, you may find one here:
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
* or you may search the http://www.gnu.org website for the version 2 license,
* or you may write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
*/
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
/**
Doxygen warning fixes.
2012-12-18 13:54:44 +00:00
* @file dialog_select_one_pcb_layer.cpp
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
* @brief Set up a dialog to choose a PCB Layer.
*/
#include <gerbview_frame.h>
gerbview: Move more items to actions and tools * Create a new inspection tool to hold the measure tool and the other inspection items * Move some control functions from the frame to a tool and rearrange the code to be cleaner.
2020-10-08 22:59:16 +00:00
#include <dialogs/dialog_layers_select_to_pcb.h>
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
Remove a few include<wx/wx.h> in many files that do not actually use this include.
2020-10-18 18:24:20 +00:00
#include <wx/radiobox.h>
Refactor layer enumerations to all live in the same place
2017-03-13 03:19:33 +00:00
#define NB_PCB_LAYERS PCB_LAYER_ID_COUNT
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
#define FIRST_COPPER_LAYER 0
#define LAST_COPPER_LAYER 31
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
// Exported function
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
const wxString GetPCBDefaultLayerName( int aLayerId );
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
enum layer_sel_id {
ID_LAYER_SELECT_TOP = 1800,
ID_LAYER_SELECT_BOTTOM,
ID_LAYER_SELECT
};
Better approximation for pads in Export Gerber to Pcbnew We can't get all the way there because we can't create pads outside of modules and the Gerbers don't store any grouping/footprint info. This change moves us from outputing a via for every flashed item (some of which don't even have holes) to synthesizing pads from flashed items using a via (when they have holes) and a copper polygon. This is much better for SMD pads, perhaps better for regular pads, and no worse for vias.
2020-06-06 15:35:46 +00:00
class SELECT_LAYER_DIALOG : public DIALOG_SHIM
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
{
public:
Add Gerber filename to 'Select Layer:' dialog The 'Select Layer:' dialog pops up directly over the dialog with the loaded Gerbers and hides all Gerber file names. This is just an aid so users remember exactly which Gerber layer they're working on without having to move the dialog. Fixes https://gitlab.com/kicad/code/kicad/-/issues/4893
2020-07-22 02:03:43 +00:00
SELECT_LAYER_DIALOG( GERBVIEW_FRAME* parent, int aDefaultLayer, int aCopperLayerCount,
Stop using wxDialog::EndModal() from inside dialogs. Calling wxDialog::EndModal() directly from inside the dialog is a potential bug if the dialog is shown in the modeless or window modal (quasi-modal). Use the internal button events where possible and check for the appropriate mode before calling the correct end dialog function.
2021-07-21 21:37:49 +00:00
wxString aGerberName );
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
~SELECT_LAYER_DIALOG() { };
Stop using wxDialog::EndModal() from inside dialogs. Calling wxDialog::EndModal() directly from inside the dialog is a potential bug if the dialog is shown in the modeless or window modal (quasi-modal). Use the internal button events where possible and check for the appropriate mode before calling the correct end dialog function.
2021-07-21 21:37:49 +00:00
int GetSelectedLayer() { return m_selectedLayer; }
protected:
bool TransferDataFromWindow() override;
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
private:
void OnLayerSelected( wxCommandEvent& event );
DECLARE_EVENT_TABLE()
Stop using wxDialog::EndModal() from inside dialogs. Calling wxDialog::EndModal() directly from inside the dialog is a potential bug if the dialog is shown in the modeless or window modal (quasi-modal). Use the internal button events where possible and check for the appropriate mode before calling the correct end dialog function.
2021-07-21 21:37:49 +00:00
int m_selectedLayer;
wxRadioBox* m_layerRadioBox;
std::vector <int> m_layerId;
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
};
Fix static event table derived object definitions.
2023-01-28 19:08:38 +00:00
BEGIN_EVENT_TABLE( SELECT_LAYER_DIALOG, DIALOG_SHIM )
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
EVT_RADIOBOX( ID_LAYER_SELECT, SELECT_LAYER_DIALOG::OnLayerSelected )
END_EVENT_TABLE()
Pass wxString objects by reference instead of on the stack.
2021-07-27 12:22:27 +00:00
int GERBVIEW_FRAME::SelectPCBLayer( int aDefaultLayer, int aCopperLayerCount,
const wxString& aGerberName )
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
{
Add Gerber filename to 'Select Layer:' dialog The 'Select Layer:' dialog pops up directly over the dialog with the loaded Gerbers and hides all Gerber file names. This is just an aid so users remember exactly which Gerber layer they're working on without having to move the dialog. Fixes https://gitlab.com/kicad/code/kicad/-/issues/4893
2020-07-22 02:03:43 +00:00
SELECT_LAYER_DIALOG* frame =
new SELECT_LAYER_DIALOG( this, aDefaultLayer, aCopperLayerCount, aGerberName );
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
Stop using wxDialog::EndModal() from inside dialogs. Calling wxDialog::EndModal() directly from inside the dialog is a potential bug if the dialog is shown in the modeless or window modal (quasi-modal). Use the internal button events where possible and check for the appropriate mode before calling the correct end dialog function.
2021-07-21 21:37:49 +00:00
frame->ShowModal();
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
frame->Destroy();
Stop using wxDialog::EndModal() from inside dialogs. Calling wxDialog::EndModal() directly from inside the dialog is a potential bug if the dialog is shown in the modeless or window modal (quasi-modal). Use the internal button events where possible and check for the appropriate mode before calling the correct end dialog function.
2021-07-21 21:37:49 +00:00
return frame->GetSelectedLayer();
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
}
Stop using wxDialog::EndModal() from inside dialogs. Calling wxDialog::EndModal() directly from inside the dialog is a potential bug if the dialog is shown in the modeless or window modal (quasi-modal). Use the internal button events where possible and check for the appropriate mode before calling the correct end dialog function.
2021-07-21 21:37:49 +00:00
SELECT_LAYER_DIALOG::SELECT_LAYER_DIALOG( GERBVIEW_FRAME* parent, int aDefaultLayer,
int aCopperLayerCount, wxString aGerberName )
: DIALOG_SHIM( parent, -1, wxString::Format( _( "Select Layer: %s" ), aGerberName ),
wxDefaultPosition, wxDefaultSize, wxDEFAULT_DIALOG_STYLE | wxRESIZE_BORDER )
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
{
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
wxButton* button;
Make gerbview compilable and working (does not use now layers and layer masks from Pcbnew). Export to Pcbnew is broken, but it is a very rarely used feature. It will be fixed later.
2014-06-27 17:07:42 +00:00
int ii;
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
wxArrayString layerList;
Better approximation for pads in Export Gerber to Pcbnew We can't get all the way there because we can't create pads outside of modules and the Gerbers don't store any grouping/footprint info. This change moves us from outputing a via for every flashed item (some of which don't even have holes) to synthesizing pads from flashed items using a via (when they have holes) and a copper polygon. This is much better for SMD pads, perhaps better for regular pads, and no worse for vias.
2020-06-06 15:35:46 +00:00
int selected = -1;
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
Gerbview: Keep existing layer selected if user clicks Cancel on 'Select Layer' dialog Fixes https://gitlab.com/kicad/code/kicad/-/issues/4752
2020-07-11 09:40:46 +00:00
// Store the passed default layer in case the user hits Cancel
Stop using wxDialog::EndModal() from inside dialogs. Calling wxDialog::EndModal() directly from inside the dialog is a potential bug if the dialog is shown in the modeless or window modal (quasi-modal). Use the internal button events where possible and check for the appropriate mode before calling the correct end dialog function.
2021-07-21 21:37:49 +00:00
m_selectedLayer = aDefaultLayer;
Gerbview: Keep existing layer selected if user clicks Cancel on 'Select Layer' dialog Fixes https://gitlab.com/kicad/code/kicad/-/issues/4752
2020-07-11 09:40:46 +00:00
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
// Build the layer list; first build copper layers list
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
int layerCount = 0;
Make gerbview compilable and working (does not use now layers and layer masks from Pcbnew). Export to Pcbnew is broken, but it is a very rarely used feature. It will be fixed later.
2014-06-27 17:07:42 +00:00
for( ii = FIRST_COPPER_LAYER; ii <= LAST_COPPER_LAYER; ++ii )
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
{
Implemented the LAYER_NUM typedef (LAYER was already taken as a class name...) to represent a layer number.
2013-03-31 13:27:46 +00:00
if( ii == FIRST_COPPER_LAYER || ii == LAST_COPPER_LAYER || ii < aCopperLayerCount-1 )
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
{
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
layerList.Add( GetPCBDefaultLayerName( ii ) );
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
Better approximation for pads in Export Gerber to Pcbnew We can't get all the way there because we can't create pads outside of modules and the Gerbers don't store any grouping/footprint info. This change moves us from outputing a via for every flashed item (some of which don't even have holes) to synthesizing pads from flashed items using a via (when they have holes) and a copper polygon. This is much better for SMD pads, perhaps better for regular pads, and no worse for vias.
2020-06-06 15:35:46 +00:00
if( aDefaultLayer == ii )
selected = layerCount;
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
m_layerId.push_back( ii );
layerCount++;
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
}
}
Make gerbview compilable and working (does not use now layers and layer masks from Pcbnew). Export to Pcbnew is broken, but it is a very rarely used feature. It will be fixed later.
2014-06-27 17:07:42 +00:00
Removed ugly usage of an extra layer slot for the layer count in gerbview Fixed layer picker for exporting to pcbnew Realigned pcb layer name with class BOARD
2013-04-10 07:03:19 +00:00
// Build the layer list; build non copper layers list
Gerbview exporter: fix a wxASSERT.
2018-12-21 12:48:00 +00:00
for( ; ; ++ii )
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
{
Gerbview exporter: fix a wxASSERT.
2018-12-21 12:48:00 +00:00
if( GetPCBDefaultLayerName( ii ) == "" ) // End of list
break;
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
layerList.Add( GetPCBDefaultLayerName( ii ) );
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
Better approximation for pads in Export Gerber to Pcbnew We can't get all the way there because we can't create pads outside of modules and the Gerbers don't store any grouping/footprint info. This change moves us from outputing a via for every flashed item (some of which don't even have holes) to synthesizing pads from flashed items using a via (when they have holes) and a copper polygon. This is much better for SMD pads, perhaps better for regular pads, and no worse for vias.
2020-06-06 15:35:46 +00:00
if( aDefaultLayer == ii )
selected = layerCount;
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
m_layerId.push_back( ii );
layerCount++;
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
}
Better approximation for pads in Export Gerber to Pcbnew We can't get all the way there because we can't create pads outside of modules and the Gerbers don't store any grouping/footprint info. This change moves us from outputing a via for every flashed item (some of which don't even have holes) to synthesizing pads from flashed items using a via (when they have holes) and a copper polygon. This is much better for SMD pads, perhaps better for regular pads, and no worse for vias.
2020-06-06 15:35:46 +00:00
layerList.Add( _( "Hole data" ) );
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
Better approximation for pads in Export Gerber to Pcbnew We can't get all the way there because we can't create pads outside of modules and the Gerbers don't store any grouping/footprint info. This change moves us from outputing a via for every flashed item (some of which don't even have holes) to synthesizing pads from flashed items using a via (when they have holes) and a copper polygon. This is much better for SMD pads, perhaps better for regular pads, and no worse for vias.
2020-06-06 15:35:46 +00:00
if( aDefaultLayer == UNDEFINED_LAYER )
selected = layerCount;
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
Better approximation for pads in Export Gerber to Pcbnew We can't get all the way there because we can't create pads outside of modules and the Gerbers don't store any grouping/footprint info. This change moves us from outputing a via for every flashed item (some of which don't even have holes) to synthesizing pads from flashed items using a via (when they have holes) and a copper polygon. This is much better for SMD pads, perhaps better for regular pads, and no worse for vias.
2020-06-06 15:35:46 +00:00
m_layerId.push_back( UNDEFINED_LAYER );
layerCount++;
layerList.Add( _( "Do not export" ) );
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
Better approximation for pads in Export Gerber to Pcbnew We can't get all the way there because we can't create pads outside of modules and the Gerbers don't store any grouping/footprint info. This change moves us from outputing a via for every flashed item (some of which don't even have holes) to synthesizing pads from flashed items using a via (when they have holes) and a copper polygon. This is much better for SMD pads, perhaps better for regular pads, and no worse for vias.
2020-06-06 15:35:46 +00:00
if( aDefaultLayer == UNSELECTED_LAYER )
selected = layerCount;
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
Better approximation for pads in Export Gerber to Pcbnew We can't get all the way there because we can't create pads outside of modules and the Gerbers don't store any grouping/footprint info. This change moves us from outputing a via for every flashed item (some of which don't even have holes) to synthesizing pads from flashed items using a via (when they have holes) and a copper polygon. This is much better for SMD pads, perhaps better for regular pads, and no worse for vias.
2020-06-06 15:35:46 +00:00
m_layerId.push_back( UNSELECTED_LAYER );
layerCount++;
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
Better approximation for pads in Export Gerber to Pcbnew We can't get all the way there because we can't create pads outside of modules and the Gerbers don't store any grouping/footprint info. This change moves us from outputing a via for every flashed item (some of which don't even have holes) to synthesizing pads from flashed items using a via (when they have holes) and a copper polygon. This is much better for SMD pads, perhaps better for regular pads, and no worse for vias.
2020-06-06 15:35:46 +00:00
m_layerRadioBox = new wxRadioBox( this, ID_LAYER_SELECT, _( "Layer" ), wxDefaultPosition,
wxDefaultSize, layerList, std::min( layerCount, 12 ),
wxRA_SPECIFY_ROWS );
if( selected >= 0 )
m_layerRadioBox->SetSelection( selected );
wxBoxSizer* mainSizer = new wxBoxSizer( wxHORIZONTAL );
SetSizer( mainSizer );
mainSizer->Add( m_layerRadioBox, 1, wxEXPAND | wxALIGN_TOP | wxALL, 5 );
wxBoxSizer* buttonsSizer = new wxBoxSizer( wxVERTICAL );
mainSizer->Add( buttonsSizer, 0, wxALIGN_BOTTOM | wxALL, 5 );
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
button = new wxButton( this, wxID_OK, _( "OK" ) );
button->SetDefault();
Better approximation for pads in Export Gerber to Pcbnew We can't get all the way there because we can't create pads outside of modules and the Gerbers don't store any grouping/footprint info. This change moves us from outputing a via for every flashed item (some of which don't even have holes) to synthesizing pads from flashed items using a via (when they have holes) and a copper polygon. This is much better for SMD pads, perhaps better for regular pads, and no worse for vias.
2020-06-06 15:35:46 +00:00
buttonsSizer->Add( button, 0, wxGROW | wxALL, 5 );
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
button = new wxButton( this, wxID_CANCEL, _( "Cancel" ) );
Better approximation for pads in Export Gerber to Pcbnew We can't get all the way there because we can't create pads outside of modules and the Gerbers don't store any grouping/footprint info. This change moves us from outputing a via for every flashed item (some of which don't even have holes) to synthesizing pads from flashed items using a via (when they have holes) and a copper polygon. This is much better for SMD pads, perhaps better for regular pads, and no worse for vias.
2020-06-06 15:35:46 +00:00
buttonsSizer->Add( button, 0, wxGROW | wxALL, 5 );
#ifdef __WXOSX__
// Hack to fix clipped radio buttons on OSX
wxSize size = m_layerRadioBox->GetBestSize() + wxSize( 20, 0 );
m_layerRadioBox->SetMinSize( size );
#endif
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
GetSizer()->SetSizeHints( this );
Center();
}
void SELECT_LAYER_DIALOG::OnLayerSelected( wxCommandEvent& event )
{
Stop using wxDialog::EndModal() from inside dialogs. Calling wxDialog::EndModal() directly from inside the dialog is a potential bug if the dialog is shown in the modeless or window modal (quasi-modal). Use the internal button events where possible and check for the appropriate mode before calling the correct end dialog function.
2021-07-21 21:37:49 +00:00
wxPostEvent( this, wxCommandEvent( wxEVT_COMMAND_BUTTON_CLICKED, wxID_OK ) );
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
}
Stop using wxDialog::EndModal() from inside dialogs. Calling wxDialog::EndModal() directly from inside the dialog is a potential bug if the dialog is shown in the modeless or window modal (quasi-modal). Use the internal button events where possible and check for the appropriate mode before calling the correct end dialog function.
2021-07-21 21:37:49 +00:00
bool SELECT_LAYER_DIALOG::TransferDataFromWindow()
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
{
Stop using wxDialog::EndModal() from inside dialogs. Calling wxDialog::EndModal() directly from inside the dialog is a potential bug if the dialog is shown in the modeless or window modal (quasi-modal). Use the internal button events where possible and check for the appropriate mode before calling the correct end dialog function.
2021-07-21 21:37:49 +00:00
if( !wxDialog::TransferDataFromWindow() )
return false;
m_selectedLayer = m_layerId[m_layerRadioBox->GetSelection()];
return true;
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
}
Stop using wxDialog::EndModal() from inside dialogs. Calling wxDialog::EndModal() directly from inside the dialog is a potential bug if the dialog is shown in the modeless or window modal (quasi-modal). Use the internal button events where possible and check for the appropriate mode before calling the correct end dialog function.
2021-07-21 21:37:49 +00:00
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
// This function is a duplicate of
Refactor layer enumerations to all live in the same place
2017-03-13 03:19:33 +00:00
// const wxChar* LSET::Name( PCB_LAYER_ID aLayerId )
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
// However it avoids a dependency to Pcbnew code.
const wxString GetPCBDefaultLayerName( int aLayerId )
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
{
const wxChar* txt;
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
// using a switch to explicitly show the mapping more clearly
switch( aLayerId )
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
{
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
case F_Cu: txt = wxT( "F.Cu" ); break;
case In1_Cu: txt = wxT( "In1.Cu" ); break;
case In2_Cu: txt = wxT( "In2.Cu" ); break;
case In3_Cu: txt = wxT( "In3.Cu" ); break;
case In4_Cu: txt = wxT( "In4.Cu" ); break;
case In5_Cu: txt = wxT( "In5.Cu" ); break;
case In6_Cu: txt = wxT( "In6.Cu" ); break;
case In7_Cu: txt = wxT( "In7.Cu" ); break;
case In8_Cu: txt = wxT( "In8.Cu" ); break;
case In9_Cu: txt = wxT( "In9.Cu" ); break;
case In10_Cu: txt = wxT( "In10.Cu" ); break;
case In11_Cu: txt = wxT( "In11.Cu" ); break;
case In12_Cu: txt = wxT( "In12.Cu" ); break;
case In13_Cu: txt = wxT( "In13.Cu" ); break;
case In14_Cu: txt = wxT( "In14.Cu" ); break;
case In15_Cu: txt = wxT( "In15.Cu" ); break;
case In16_Cu: txt = wxT( "In16.Cu" ); break;
case In17_Cu: txt = wxT( "In17.Cu" ); break;
case In18_Cu: txt = wxT( "In18.Cu" ); break;
case In19_Cu: txt = wxT( "In19.Cu" ); break;
case In20_Cu: txt = wxT( "In20.Cu" ); break;
case In21_Cu: txt = wxT( "In21.Cu" ); break;
case In22_Cu: txt = wxT( "In22.Cu" ); break;
case In23_Cu: txt = wxT( "In23.Cu" ); break;
case In24_Cu: txt = wxT( "In24.Cu" ); break;
case In25_Cu: txt = wxT( "In25.Cu" ); break;
case In26_Cu: txt = wxT( "In26.Cu" ); break;
case In27_Cu: txt = wxT( "In27.Cu" ); break;
case In28_Cu: txt = wxT( "In28.Cu" ); break;
case In29_Cu: txt = wxT( "In29.Cu" ); break;
case In30_Cu: txt = wxT( "In30.Cu" ); break;
case B_Cu: txt = wxT( "B.Cu" ); break;
// Technicals
case B_Adhes: txt = wxT( "B.Adhes" ); break;
case F_Adhes: txt = wxT( "F.Adhes" ); break;
case B_Paste: txt = wxT( "B.Paste" ); break;
case F_Paste: txt = wxT( "F.Paste" ); break;
case B_SilkS: txt = wxT( "B.SilkS" ); break;
case F_SilkS: txt = wxT( "F.SilkS" ); break;
case B_Mask: txt = wxT( "B.Mask" ); break;
case F_Mask: txt = wxT( "F.Mask" ); break;
// Users
case Dwgs_User: txt = wxT( "Dwgs.User" ); break;
case Cmts_User: txt = wxT( "Cmts.User" ); break;
case Eco1_User: txt = wxT( "Eco1.User" ); break;
case Eco2_User: txt = wxT( "Eco2.User" ); break;
case Edge_Cuts: txt = wxT( "Edge.Cuts" ); break;
Gerbview: Keep existing layer selected if user clicks Cancel on 'Select Layer' dialog Fixes https://gitlab.com/kicad/code/kicad/-/issues/4752
2020-07-11 09:40:46 +00:00
// Pcbnew knows some other layers, but any other layer is not suitable for export.
Gerbview: fix scaling error in x.6 file format. Minor cleaning code. Better separation between Pcbnew code and Gerber code. Update export to Pcb code (uses now the version 4 kicad_pcb file format).
2014-07-14 18:59:41 +00:00
Gerbview exporter: fix a wxASSERT.
2018-12-21 12:48:00 +00:00
default: // Sentinel
txt = wxT( "" ); break;
Gerbview: remove dependencies from Pcbnew. Should allow Pcbnew code easier to change and Gerbview code more understandable and easier to maintain. Code cleaning (remove dead code, add comments). Minor other enhancements.
2012-05-04 17:44:42 +00:00
}
return wxString( txt );
}