2021-08-11 13:01:30 +00:00
|
|
|
/*
|
|
|
|
* This program source code file is part of KiCad, a free EDA CAD application.
|
|
|
|
*
|
2022-03-11 20:13:47 +00:00
|
|
|
* Copyright (C) 2021-2022 KiCad Developers.
|
2021-08-11 13:01:30 +00:00
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public License
|
|
|
|
* as published by the Free Software Foundation; either version 2
|
|
|
|
* of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, you may find one here:
|
|
|
|
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
|
|
|
|
* or you may search the http://www.gnu.org website for the version 2 license,
|
|
|
|
* or you may write to the Free Software Foundation, Inc.,
|
|
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
|
|
|
|
*/
|
|
|
|
|
2022-03-11 22:02:43 +00:00
|
|
|
#include <atomic>
|
2021-08-11 13:01:30 +00:00
|
|
|
#include <board.h>
|
|
|
|
#include <board_design_settings.h>
|
|
|
|
#include <zone.h>
|
|
|
|
#include <footprint.h>
|
|
|
|
#include <pcb_shape.h>
|
|
|
|
#include <geometry/shape_poly_set.h>
|
|
|
|
#include <drc/drc_rule.h>
|
2021-12-01 14:42:44 +00:00
|
|
|
#include <drc/drc_item.h>
|
2021-08-11 13:01:30 +00:00
|
|
|
#include <drc/drc_test_provider.h>
|
|
|
|
#include <advanced_config.h>
|
2022-06-15 00:41:10 +00:00
|
|
|
#include <progress_reporter.h>
|
|
|
|
#include <thread_pool.h>
|
2021-08-11 13:01:30 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
Checks for slivers in copper layers
|
|
|
|
|
|
|
|
Errors generated:
|
|
|
|
- DRCE_COPPER_SLIVER
|
|
|
|
*/
|
|
|
|
|
|
|
|
class DRC_TEST_PROVIDER_SLIVER_CHECKER : public DRC_TEST_PROVIDER
|
|
|
|
{
|
|
|
|
public:
|
|
|
|
DRC_TEST_PROVIDER_SLIVER_CHECKER()
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual ~DRC_TEST_PROVIDER_SLIVER_CHECKER()
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual bool Run() override;
|
|
|
|
|
|
|
|
virtual const wxString GetName() const override
|
|
|
|
{
|
2022-03-11 21:16:52 +00:00
|
|
|
return wxT( "sliver checker" );
|
2021-08-11 13:01:30 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
virtual const wxString GetDescription() const override
|
|
|
|
{
|
2022-03-11 21:16:52 +00:00
|
|
|
return wxT( "Checks copper layers for slivers" );
|
2021-08-11 13:01:30 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
|
|
|
wxString layerDesc( PCB_LAYER_ID aLayer );
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
wxString DRC_TEST_PROVIDER_SLIVER_CHECKER::layerDesc( PCB_LAYER_ID aLayer )
|
|
|
|
{
|
|
|
|
return wxString::Format( wxT( "(%s)" ), m_drcEngine->GetBoard()->GetLayerName( aLayer ) );
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
bool DRC_TEST_PROVIDER_SLIVER_CHECKER::Run()
|
|
|
|
{
|
|
|
|
if( m_drcEngine->IsErrorLimitExceeded( DRCE_COPPER_SLIVER ) )
|
|
|
|
return true; // Continue with other tests
|
|
|
|
|
|
|
|
if( !reportPhase( _( "Running sliver detection on copper layers..." ) ) )
|
|
|
|
return false; // DRC cancelled
|
|
|
|
|
|
|
|
int widthTolerance = Millimeter2iu( ADVANCED_CFG::GetCfg().m_SliverWidthTolerance );
|
|
|
|
double angleTolerance = ADVANCED_CFG::GetCfg().m_SliverAngleTolerance;
|
|
|
|
int testLength = widthTolerance / ( 2 * sin( DEG2RAD( angleTolerance / 2 ) ) );
|
2022-03-11 20:13:47 +00:00
|
|
|
LSET copperLayerSet = m_drcEngine->GetBoard()->GetEnabledLayers() & LSET::AllCuMask();
|
|
|
|
LSEQ copperLayers = copperLayerSet.Seq();
|
|
|
|
int layerCount = copperLayers.size();
|
2021-08-11 13:01:30 +00:00
|
|
|
|
2022-03-09 00:47:37 +00:00
|
|
|
// Report progress on board zones only. Everything else is in the noise.
|
|
|
|
int zoneLayerCount = 0;
|
2022-06-15 00:41:10 +00:00
|
|
|
std::atomic<size_t> done( 1 );
|
2022-03-09 00:47:37 +00:00
|
|
|
|
2022-03-11 20:13:47 +00:00
|
|
|
for( PCB_LAYER_ID layer : copperLayers )
|
2022-03-09 00:47:37 +00:00
|
|
|
{
|
|
|
|
for( ZONE* zone : m_drcEngine->GetBoard()->Zones() )
|
|
|
|
{
|
|
|
|
if( !zone->GetIsRuleArea() && zone->IsOnLayer( layer ) )
|
|
|
|
zoneLayerCount++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
PROGRESS_REPORTER* reporter = m_drcEngine->GetProgressReporter();
|
2022-03-12 13:34:25 +00:00
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
if( reporter && reporter->IsCancelled() )
|
2022-03-12 13:34:25 +00:00
|
|
|
return false; // DRC cancelled
|
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
std::vector<SHAPE_POLY_SET> layerPolys( layerCount );
|
2021-08-11 13:01:30 +00:00
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
auto sliver_checker =
|
|
|
|
[&]( int aItem ) -> size_t
|
2021-08-11 13:01:30 +00:00
|
|
|
{
|
2022-06-15 00:41:10 +00:00
|
|
|
PCB_LAYER_ID layer = copperLayers[aItem];
|
|
|
|
SHAPE_POLY_SET& poly = layerPolys[aItem];
|
2022-03-11 20:13:47 +00:00
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
if( m_drcEngine->IsCancelled() )
|
|
|
|
return 0;
|
2022-03-12 13:34:25 +00:00
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
SHAPE_POLY_SET fill;
|
2022-03-11 20:13:47 +00:00
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
forEachGeometryItem( s_allBasicItems, LSET().set( layer ),
|
|
|
|
[&]( BOARD_ITEM* item ) -> bool
|
|
|
|
{
|
|
|
|
if( dynamic_cast<ZONE*>( item) )
|
|
|
|
{
|
|
|
|
ZONE* zone = static_cast<ZONE*>( item );
|
|
|
|
|
|
|
|
if( !zone->GetIsRuleArea() )
|
2022-03-11 20:13:47 +00:00
|
|
|
{
|
2022-06-15 00:41:10 +00:00
|
|
|
fill = zone->GetFill( layer )->CloneDropTriangulation();
|
|
|
|
fill.Unfracture( SHAPE_POLY_SET::PM_FAST );
|
|
|
|
|
|
|
|
for( int jj = 0; jj < fill.OutlineCount(); ++jj )
|
|
|
|
poly.AddOutline( fill.Outline( jj ) );
|
|
|
|
|
|
|
|
// Report progress on board zones only. Everything
|
|
|
|
// else is in the noise.
|
|
|
|
done.fetch_add( 1 );
|
2022-03-11 20:13:47 +00:00
|
|
|
}
|
2022-06-15 00:41:10 +00:00
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
item->TransformShapeWithClearanceToPolygon( poly, layer, 0,
|
|
|
|
ARC_LOW_DEF,
|
|
|
|
ERROR_OUTSIDE );
|
|
|
|
}
|
2022-03-11 20:13:47 +00:00
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
if( m_drcEngine->IsCancelled() )
|
|
|
|
return false;
|
2022-03-11 20:13:47 +00:00
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
return true;
|
|
|
|
} );
|
2022-03-11 20:13:47 +00:00
|
|
|
|
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
if( m_drcEngine->IsCancelled() )
|
|
|
|
return 0;
|
2022-03-11 20:13:47 +00:00
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
poly.Simplify( SHAPE_POLY_SET::PM_FAST );
|
2022-03-09 00:47:37 +00:00
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
// Sharpen corners
|
|
|
|
poly.Deflate( widthTolerance / 2, ARC_LOW_DEF,
|
|
|
|
SHAPE_POLY_SET::ALLOW_ACUTE_CORNERS );
|
2021-08-11 13:01:30 +00:00
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
return 1;
|
|
|
|
};
|
|
|
|
|
|
|
|
thread_pool& tp = GetKiCadThreadPool();
|
|
|
|
std::vector<std::future<size_t>> returns;
|
|
|
|
|
|
|
|
returns.reserve( copperLayers.size() );
|
2022-03-11 20:13:47 +00:00
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
for( size_t ii = 0; ii < copperLayers.size(); ++ii )
|
|
|
|
returns.emplace_back( tp.submit( sliver_checker, ii ) );
|
|
|
|
|
|
|
|
for( auto& retval : returns )
|
2022-03-11 20:13:47 +00:00
|
|
|
{
|
2022-06-15 00:41:10 +00:00
|
|
|
std::future_status status;
|
|
|
|
|
|
|
|
do
|
|
|
|
{
|
|
|
|
m_drcEngine->ReportProgress( static_cast<double>( zoneLayerCount ) / done );
|
|
|
|
|
|
|
|
status = retval.wait_for( std::chrono::milliseconds( 100 ) );
|
|
|
|
} while( status != std::future_status::ready );
|
2022-03-11 20:13:47 +00:00
|
|
|
}
|
2021-08-11 13:01:30 +00:00
|
|
|
|
2022-06-15 00:41:10 +00:00
|
|
|
|
2022-03-11 20:13:47 +00:00
|
|
|
for( int ii = 0; ii < layerCount; ++ii )
|
|
|
|
{
|
|
|
|
PCB_LAYER_ID layer = copperLayers[ii];
|
|
|
|
SHAPE_POLY_SET& poly = layerPolys[ii];
|
|
|
|
|
|
|
|
if( m_drcEngine->IsErrorLimitExceeded( DRCE_COPPER_SLIVER ) )
|
|
|
|
continue;
|
2021-08-11 13:01:30 +00:00
|
|
|
|
2022-01-10 10:31:29 +00:00
|
|
|
// Frequently, in filled areas, some points of the polygons are very near (dist is only
|
|
|
|
// a few internal units, like 2 or 3 units.
|
|
|
|
// We skip very small vertices: one cannot really compute a valid orientation of
|
|
|
|
// such a vertex
|
|
|
|
// So skip points near than min_len (in internal units).
|
|
|
|
const int min_len = 3;
|
|
|
|
|
2021-08-11 13:01:30 +00:00
|
|
|
for( int jj = 0; jj < poly.OutlineCount(); ++jj )
|
|
|
|
{
|
|
|
|
const std::vector<VECTOR2I>& pts = poly.Outline( jj ).CPoints();
|
|
|
|
int ptCount = pts.size();
|
|
|
|
|
|
|
|
for( int kk = 0; kk < ptCount; ++kk )
|
|
|
|
{
|
|
|
|
VECTOR2I pt = pts[ kk ];
|
2022-03-11 20:13:47 +00:00
|
|
|
VECTOR2I ptPrior = pts[ ( ptCount + kk - 1 ) % ptCount ];
|
|
|
|
VECTOR2I vPrior = ( ptPrior - pt );
|
2022-01-10 10:31:29 +00:00
|
|
|
|
2022-03-11 20:13:47 +00:00
|
|
|
if( std::abs( vPrior.x ) < min_len && std::abs( vPrior.y ) < min_len && ptCount > 5)
|
2022-01-10 10:31:29 +00:00
|
|
|
{
|
2022-03-11 20:13:47 +00:00
|
|
|
ptPrior = pts[ ( ptCount + kk - 2 ) % ptCount ];
|
|
|
|
vPrior = ( ptPrior - pt );
|
2022-01-10 10:31:29 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
VECTOR2I ptAfter = pts[ ( kk + 1 ) % ptCount ];
|
2021-08-11 13:01:30 +00:00
|
|
|
VECTOR2I vAfter = ( ptAfter - pt );
|
2022-01-10 10:31:29 +00:00
|
|
|
|
2022-03-11 20:13:47 +00:00
|
|
|
if( std::abs( vAfter.x ) < min_len && std::abs( vAfter.y ) < min_len && ptCount > 5 )
|
2022-01-10 10:31:29 +00:00
|
|
|
{
|
|
|
|
ptAfter = pts[ ( kk + 2 ) % ptCount ];
|
|
|
|
vAfter = ( ptAfter - pt );
|
|
|
|
}
|
|
|
|
|
2022-03-11 20:13:47 +00:00
|
|
|
VECTOR2I vIncluded = vPrior.Resize( testLength ) - vAfter.Resize( testLength );
|
2021-08-11 13:01:30 +00:00
|
|
|
|
|
|
|
if( vIncluded.SquaredEuclideanNorm() < SEG::Square( widthTolerance ) )
|
|
|
|
{
|
|
|
|
std::shared_ptr<DRC_ITEM> drce = DRC_ITEM::Create( DRCE_COPPER_SLIVER );
|
|
|
|
drce->SetErrorMessage( drce->GetErrorText() + wxS( " " ) + layerDesc( layer ) );
|
2022-01-02 02:06:40 +00:00
|
|
|
reportViolation( drce, pt, layer );
|
2021-08-11 13:01:30 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
namespace detail
|
|
|
|
{
|
|
|
|
static DRC_REGISTER_TEST_PROVIDER<DRC_TEST_PROVIDER_SLIVER_CHECKER> dummy;
|
|
|
|
}
|