2020-08-25 17:42:52 +00:00
|
|
|
/*
|
|
|
|
* This program source code file is part of KiCad, a free EDA CAD application.
|
|
|
|
*
|
|
|
|
* Copyright (C) 2004-2020 KiCad Developers.
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public License
|
|
|
|
* as published by the Free Software Foundation; either version 2
|
|
|
|
* of the License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
* GNU General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, you may find one here:
|
|
|
|
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
|
|
|
|
* or you may search the http://www.gnu.org website for the version 2 license,
|
|
|
|
* or you may write to the Free Software Foundation, Inc.,
|
|
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
|
|
|
|
*/
|
|
|
|
|
2020-09-11 21:50:53 +00:00
|
|
|
#include <drc/drc_engine.h>
|
2020-09-11 15:04:11 +00:00
|
|
|
#include <drc/drc_item.h>
|
|
|
|
#include <drc/drc_rule.h>
|
2020-09-11 21:50:53 +00:00
|
|
|
#include <drc/drc_test_provider.h>
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-10-14 00:23:36 +00:00
|
|
|
#include <page_layout/ws_draw_item.h>
|
|
|
|
#include <page_layout/ws_proxy_view_item.h>
|
2020-08-25 17:42:52 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
Miscellaneous tests:
|
|
|
|
|
|
|
|
- DRCE_DISABLED_LAYER_ITEM, ///< item on a disabled layer
|
|
|
|
- DRCE_INVALID_OUTLINE, ///< invalid board outline
|
|
|
|
- DRCE_UNRESOLVED_VARIABLE,
|
|
|
|
|
|
|
|
TODO:
|
|
|
|
- if grows too big, split into separate providers
|
|
|
|
*/
|
|
|
|
|
|
|
|
class DRC_TEST_PROVIDER_MISC : public DRC_TEST_PROVIDER
|
|
|
|
{
|
|
|
|
public:
|
2020-09-16 10:27:46 +00:00
|
|
|
DRC_TEST_PROVIDER_MISC() :
|
|
|
|
m_board( nullptr )
|
2020-08-25 17:42:52 +00:00
|
|
|
{
|
|
|
|
m_isRuleDriven = false;
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual ~DRC_TEST_PROVIDER_MISC()
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual bool Run() override;
|
|
|
|
|
|
|
|
virtual const wxString GetName() const override
|
|
|
|
{
|
|
|
|
return "miscellanous";
|
|
|
|
};
|
|
|
|
|
|
|
|
virtual const wxString GetDescription() const override
|
|
|
|
{
|
|
|
|
return "Misc checks (board outline, missing textvars)";
|
|
|
|
}
|
|
|
|
|
2020-09-13 10:37:20 +00:00
|
|
|
virtual std::set<DRC_CONSTRAINT_TYPE_T> GetConstraintTypes() const override;
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-09-14 17:54:14 +00:00
|
|
|
int GetNumPhases() const override;
|
|
|
|
|
2020-08-25 17:42:52 +00:00
|
|
|
private:
|
|
|
|
void testOutline();
|
|
|
|
void testDisabledLayers();
|
|
|
|
void testTextVars();
|
|
|
|
|
|
|
|
BOARD* m_board;
|
|
|
|
};
|
|
|
|
|
|
|
|
|
2020-09-11 21:50:53 +00:00
|
|
|
void DRC_TEST_PROVIDER_MISC::testOutline()
|
2020-08-25 17:42:52 +00:00
|
|
|
{
|
2020-10-22 20:27:46 +00:00
|
|
|
std::vector<wxPoint> discontinuities;
|
|
|
|
std::vector<wxPoint> intersections;
|
2020-08-25 17:42:52 +00:00
|
|
|
|
|
|
|
SHAPE_POLY_SET boardOutlines;
|
|
|
|
|
2020-10-22 20:27:46 +00:00
|
|
|
if( m_board->GetBoardPolygonOutlines( boardOutlines, nullptr, &discontinuities,
|
|
|
|
&intersections ) )
|
|
|
|
{
|
2020-08-25 17:42:52 +00:00
|
|
|
return;
|
2020-10-22 20:27:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
for( wxPoint pt : discontinuities )
|
|
|
|
{
|
|
|
|
std::shared_ptr<DRC_ITEM> drcItem = DRC_ITEM::Create( DRCE_INVALID_OUTLINE );
|
|
|
|
|
|
|
|
m_msg.Printf( drcItem->GetErrorText() + wxS( " " ) + _( "(not a closed shape)" ) );
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-10-22 20:27:46 +00:00
|
|
|
drcItem->SetErrorMessage( m_msg );
|
|
|
|
drcItem->SetItems( m_board );
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-10-22 20:27:46 +00:00
|
|
|
reportViolation( drcItem, pt );
|
|
|
|
}
|
|
|
|
|
|
|
|
for( wxPoint pt : intersections )
|
|
|
|
{
|
|
|
|
std::shared_ptr<DRC_ITEM> drcItem = DRC_ITEM::Create( DRCE_INVALID_OUTLINE );
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-10-22 20:27:46 +00:00
|
|
|
m_msg.Printf( drcItem->GetErrorText() + wxS( " " ) + _( "(self-intersecting)" ) );
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-10-22 20:27:46 +00:00
|
|
|
drcItem->SetErrorMessage( m_msg );
|
|
|
|
drcItem->SetItems( m_board );
|
|
|
|
|
|
|
|
reportViolation( drcItem, pt );
|
|
|
|
}
|
2020-08-25 17:42:52 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
2020-09-11 21:50:53 +00:00
|
|
|
void DRC_TEST_PROVIDER_MISC::testDisabledLayers()
|
2020-08-25 17:42:52 +00:00
|
|
|
{
|
|
|
|
LSET disabledLayers = m_board->GetEnabledLayers().flip();
|
|
|
|
|
|
|
|
// Perform the test only for copper layers
|
|
|
|
disabledLayers &= LSET::AllCuMask();
|
|
|
|
|
2020-09-11 21:50:53 +00:00
|
|
|
auto checkDisabledLayers =
|
|
|
|
[&]( BOARD_ITEM* item ) -> bool
|
|
|
|
{
|
|
|
|
LSET refLayers ( item->GetLayer() );
|
2020-09-04 23:12:15 +00:00
|
|
|
|
2020-09-11 21:50:53 +00:00
|
|
|
if( ( disabledLayers & refLayers ).any() )
|
|
|
|
{
|
|
|
|
std::shared_ptr<DRC_ITEM>drcItem = DRC_ITEM::Create( DRCE_DISABLED_LAYER_ITEM );
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-10-20 19:05:04 +00:00
|
|
|
m_msg.Printf( drcItem->GetErrorText() + wxS( " " ) + _( "(layer %s)" ),
|
2020-09-11 21:50:53 +00:00
|
|
|
item->GetLayerName() );
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-09-11 21:50:53 +00:00
|
|
|
drcItem->SetErrorMessage( m_msg );
|
|
|
|
drcItem->SetItems( item );
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-09-14 17:54:14 +00:00
|
|
|
reportViolation( drcItem, item->GetPosition());
|
2020-09-11 21:50:53 +00:00
|
|
|
}
|
|
|
|
return true;
|
|
|
|
};
|
2020-08-25 17:42:52 +00:00
|
|
|
|
|
|
|
// fixme: what about graphical items?
|
|
|
|
forEachGeometryItem( { PCB_TRACE_T, PCB_ARC_T, PCB_VIA_T, PCB_ZONE_AREA_T, PCB_PAD_T },
|
2020-09-11 21:50:53 +00:00
|
|
|
LSET::AllLayersMask(), checkDisabledLayers );
|
2020-08-25 17:42:52 +00:00
|
|
|
}
|
|
|
|
|
2020-09-11 21:50:53 +00:00
|
|
|
void DRC_TEST_PROVIDER_MISC::testTextVars()
|
2020-08-25 17:42:52 +00:00
|
|
|
{
|
2020-09-11 21:50:53 +00:00
|
|
|
auto checkUnresolvedTextVar =
|
|
|
|
[&]( EDA_ITEM* item ) -> bool
|
|
|
|
{
|
2020-09-12 19:28:22 +00:00
|
|
|
if( m_drcEngine->IsErrorLimitExceeded( DRCE_UNRESOLVED_VARIABLE ) )
|
|
|
|
return false;
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-09-12 19:28:22 +00:00
|
|
|
EDA_TEXT* text = dynamic_cast<EDA_TEXT*>( item );
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-09-12 19:28:22 +00:00
|
|
|
if( text && text->GetShownText().Matches( wxT( "*${*}*" ) ) )
|
2020-09-11 21:50:53 +00:00
|
|
|
{
|
|
|
|
std::shared_ptr<DRC_ITEM>drcItem = DRC_ITEM::Create( DRCE_UNRESOLVED_VARIABLE );
|
|
|
|
drcItem->SetItems( item );
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-09-14 17:54:14 +00:00
|
|
|
reportViolation( drcItem, item->GetPosition());
|
2020-09-11 21:50:53 +00:00
|
|
|
}
|
|
|
|
return true;
|
|
|
|
};
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-10-04 14:19:33 +00:00
|
|
|
forEachGeometryItem( { PCB_FP_TEXT_T, PCB_TEXT_T }, LSET::AllLayersMask(),
|
2020-09-11 21:50:53 +00:00
|
|
|
checkUnresolvedTextVar );
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-09-11 21:50:53 +00:00
|
|
|
KIGFX::WS_PROXY_VIEW_ITEM* worksheet = m_drcEngine->GetWorksheet();
|
|
|
|
WS_DRAW_ITEM_LIST wsItems;
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-09-12 19:28:22 +00:00
|
|
|
if( !worksheet || m_drcEngine->IsErrorLimitExceeded( DRCE_UNRESOLVED_VARIABLE ) )
|
2020-08-25 17:42:52 +00:00
|
|
|
return;
|
|
|
|
|
|
|
|
wsItems.SetMilsToIUfactor( IU_PER_MILS );
|
2020-10-18 20:30:37 +00:00
|
|
|
wsItems.SetPageNumber( "1" );
|
2020-09-11 21:50:53 +00:00
|
|
|
wsItems.SetSheetCount( 1 );
|
|
|
|
wsItems.SetFileName( "dummyFilename" );
|
|
|
|
wsItems.SetSheetName( "dummySheet" );
|
|
|
|
wsItems.SetSheetLayer( "dummyLayer" );
|
|
|
|
wsItems.SetProject( m_board->GetProject() );
|
2020-08-25 17:42:52 +00:00
|
|
|
wsItems.BuildWorkSheetGraphicList( worksheet->GetPageInfo(), worksheet->GetTitleBlock() );
|
|
|
|
|
|
|
|
for( WS_DRAW_ITEM_BASE* item = wsItems.GetFirst(); item; item = wsItems.GetNext() )
|
|
|
|
{
|
2020-09-12 19:28:22 +00:00
|
|
|
if( m_drcEngine->IsErrorLimitExceeded( DRCE_UNRESOLVED_VARIABLE ) )
|
|
|
|
break;
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-09-12 19:28:22 +00:00
|
|
|
WS_DRAW_ITEM_TEXT* text = dynamic_cast<WS_DRAW_ITEM_TEXT*>( item );
|
|
|
|
|
|
|
|
if( text && text->GetShownText().Matches( wxT( "*${*}*" ) ) )
|
|
|
|
{
|
|
|
|
std::shared_ptr<DRC_ITEM> drcItem = DRC_ITEM::Create( DRCE_UNRESOLVED_VARIABLE );
|
|
|
|
drcItem->SetItems( text );
|
2020-08-25 17:42:52 +00:00
|
|
|
|
2020-09-14 17:54:14 +00:00
|
|
|
reportViolation( drcItem, text->GetPosition());
|
2020-08-25 17:42:52 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2020-09-11 21:50:53 +00:00
|
|
|
bool DRC_TEST_PROVIDER_MISC::Run()
|
2020-08-25 17:42:52 +00:00
|
|
|
{
|
|
|
|
m_board = m_drcEngine->GetBoard();
|
|
|
|
|
2020-09-18 19:57:54 +00:00
|
|
|
if( !reportPhase( _( "Checking board outline..." ) ) )
|
|
|
|
return false;
|
|
|
|
|
2020-08-25 17:42:52 +00:00
|
|
|
testOutline();
|
|
|
|
|
2020-09-18 19:57:54 +00:00
|
|
|
if( !reportPhase( _( "Checking disabled layers..." ) ) )
|
|
|
|
return false;
|
|
|
|
|
2020-08-25 17:42:52 +00:00
|
|
|
testDisabledLayers();
|
|
|
|
|
2020-09-18 19:57:54 +00:00
|
|
|
if( !reportPhase( _( "Checking text variables..." ) ) )
|
|
|
|
return false;
|
|
|
|
|
2020-08-25 17:42:52 +00:00
|
|
|
testTextVars();
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2020-09-14 17:54:14 +00:00
|
|
|
int DRC_TEST_PROVIDER_MISC::GetNumPhases() const
|
|
|
|
{
|
|
|
|
return 3;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2020-09-13 10:37:20 +00:00
|
|
|
std::set<DRC_CONSTRAINT_TYPE_T> DRC_TEST_PROVIDER_MISC::GetConstraintTypes() const
|
2020-08-25 17:42:52 +00:00
|
|
|
{
|
|
|
|
return {};
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
namespace detail
|
|
|
|
{
|
2020-09-11 21:50:53 +00:00
|
|
|
static DRC_REGISTER_TEST_PROVIDER<DRC_TEST_PROVIDER_MISC> dummy;
|
2020-08-25 17:42:52 +00:00
|
|
|
}
|