haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
kicad/cmake/Warnings.cmake

243 lines
10 KiB
CMake
Raw Normal View History

Enable new warnings
2020-04-24 23:46:29 +00:00
#
# This program source code file is part of KICAD, a free EDA CAD application.
#
# Copyright (C) 2007-2020 Kicad Developers, see AUTHORS.txt for contributors.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, you may find one here:
# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
# or you may search the http://www.gnu.org website for the version 2 license,
# or you may write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
#
Enable warnings on msvc
2023-02-18 02:13:10 +00:00
# Configure warnings for Clang and GCC
Enable new warnings
2020-04-24 23:46:29 +00:00
if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang" )
Overhaul compiler warnings infrastructure * Track our warnings separate from normal flags * Remove all warnings from the SWIG code * Add more GCC warnings
2020-05-06 00:47:20 +00:00
# The SWIG-generated files tend to throw a lot of warnings, so
# we do not add the warnings directly to the flags here but instead
# keep track of them and add them to the flags later in a controlled manner
# (that way we can not put any warnings on the SWIG-generated files)
set( COMPILER_SUPPORTS_WARNINGS TRUE )
# Establish -Wall early, so specialized relaxations of this may come
# subsequently on the command line, such as in pcbnew/github/CMakeLists.txt
set( WARN_FLAGS_C "-Wall" )
set( WARN_FLAGS_CXX "-Wall" )
Enable new warnings
2020-04-24 23:46:29 +00:00
# Warn about missing override specifiers
CHECK_CXX_COMPILER_FLAG( "-Wsuggest-override" COMPILER_SUPPORTS_WSUGGEST_OVERRIDE )
if( COMPILER_SUPPORTS_WSUGGEST_OVERRIDE )
Overhaul compiler warnings infrastructure * Track our warnings separate from normal flags * Remove all warnings from the SWIG code * Add more GCC warnings
2020-05-06 00:47:20 +00:00
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wsuggest-override" )
Fix typo
2020-04-30 14:03:18 +00:00
message( STATUS "Enabling warning -Wsuggest-override" )
Enable new warnings
2020-04-24 23:46:29 +00:00
endif()
Add Clang's version of -Wsuggest-override
2020-04-25 00:09:30 +00:00
# This is Clang's version of -Wsuggest-override
CHECK_CXX_COMPILER_FLAG( "-Winconsistent-missing-override" COMPILER_SUPPORTS_WINCONSISTENT_MISSING_OVERRIDE )
if( COMPILER_SUPPORTS_WINCONSISTENT_MISSING_OVERRIDE )
Overhaul compiler warnings infrastructure * Track our warnings separate from normal flags * Remove all warnings from the SWIG code * Add more GCC warnings
2020-05-06 00:47:20 +00:00
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Winconsistent-missing-override" )
Disable inconsistent missing override warnings in qa mocks turtlemocks doesn't seem to provide a way to annotate that these methods override a base class method, so it triggers a lot of warnings about missing override when the classes are instantiated.
2022-09-24 01:11:41 +00:00
# Also use this to guard warning removal of the warning inside the code
set( HAVE_WINCONSISTENT_MISSING_OVERRIDE true )
Add Clang's version of -Wsuggest-override
2020-04-25 00:09:30 +00:00
message( STATUS "Enabling warning -Winconsistent-missing-override" )
endif()
Overhaul compiler warnings infrastructure * Track our warnings separate from normal flags * Remove all warnings from the SWIG code * Add more GCC warnings
2020-05-06 00:47:20 +00:00
# Warn on duplicated branches
CHECK_CXX_COMPILER_FLAG( "-Wduplicated-branches" COMPILER_SUPPORTS_WDUPLICATED_BRANCHES )
if( COMPILER_SUPPORTS_WDUPLICATED_BRANCHES )
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wduplicated-branches" )
message( STATUS "Enabling warning -Wduplicated-branches" )
endif()
# Warn on duplicated conditions
CHECK_CXX_COMPILER_FLAG( "-Wduplicated-cond" COMPILER_SUPPORTS_WDUPLICATED_COND )
if( COMPILER_SUPPORTS_WDUPLICATED_COND )
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wduplicated-cond" )
message( STATUS "Enabling warning -Wduplicated-cond" )
endif()
Document what -Wvla does and why we want to treat it as an error
2020-10-09 18:20:50 +00:00
# Error on variable length arrays (gcc extension)
Enable new warnings
2020-04-24 23:46:29 +00:00
CHECK_CXX_COMPILER_FLAG( "-Wvla" COMPILER_SUPPORTS_WVLA )
if( COMPILER_SUPPORTS_WVLA )
Overhaul compiler warnings infrastructure * Track our warnings separate from normal flags * Remove all warnings from the SWIG code * Add more GCC warnings
2020-05-06 00:47:20 +00:00
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Werror=vla" )
Enable new warnings
2020-04-24 23:46:29 +00:00
message( STATUS "Enabling error for -Wvla" )
endif()
# Warn on implicit switch fallthrough
CHECK_CXX_COMPILER_FLAG( "-Wimplicit-fallthrough" COMPILER_SUPPORTS_WIMPLICIT_FALLTHROUGH )
if( COMPILER_SUPPORTS_WIMPLICIT_FALLTHROUGH )
Overhaul compiler warnings infrastructure * Track our warnings separate from normal flags * Remove all warnings from the SWIG code * Add more GCC warnings
2020-05-06 00:47:20 +00:00
if( CMAKE_COMPILER_IS_GNUCXX )
# GCC level 5 does not allow comments - mirrors the Clang warning
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wimplicit-fallthrough=5" )
else()
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wimplicit-fallthrough" )
endif()
Enable new warnings
2020-04-24 23:46:29 +00:00
message( STATUS "Enabling warning -Wimplicit-fallthrough" )
endif()
# Error if there is a problem with function returns
CHECK_CXX_COMPILER_FLAG( "-Wreturn-type" COMPILER_SUPPORTS_WRETURN_TYPE )
if( COMPILER_SUPPORTS_WRETURN_TYPE )
Overhaul compiler warnings infrastructure * Track our warnings separate from normal flags * Remove all warnings from the SWIG code * Add more GCC warnings
2020-05-06 00:47:20 +00:00
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Werror=return-type" )
Enable new warnings
2020-04-24 23:46:29 +00:00
message( STATUS "Enabling error for -Wreturn-type" )
endif()
Overhaul compiler warnings infrastructure * Track our warnings separate from normal flags * Remove all warnings from the SWIG code * Add more GCC warnings
2020-05-06 00:47:20 +00:00
# Warn about shadowed variables
Enable new warnings
2020-04-24 23:46:29 +00:00
CHECK_CXX_COMPILER_FLAG( "-Wshadow" COMPILER_SUPPORTS_WSHADOW )
if( COMPILER_SUPPORTS_WSHADOW )
Overhaul compiler warnings infrastructure * Track our warnings separate from normal flags * Remove all warnings from the SWIG code * Add more GCC warnings
2020-05-06 00:47:20 +00:00
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wshadow" )
Enable new warnings
2020-04-24 23:46:29 +00:00
message( STATUS "Enabling warning -Wshadow" )
endif()
Move warning flags to proper place Cleans unitialized warnings in wxApps
2020-07-02 19:17:45 +00:00
# Add additional warning flags to avoid signed/unsigned comparison
CHECK_CXX_COMPILER_FLAG( "-Wsign-compare" COMPILER_SUPPORTS_WSIGN )
if( COMPILER_SUPPORTS_WSIGN )
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wsign-compare" )
message( STATUS "Enabling warning -Wsign-compare" )
endif()
Cleanup some compiler warnings
2020-07-02 23:10:31 +00:00
Move warning flags to proper place Cleans unitialized warnings in wxApps
2020-07-02 19:17:45 +00:00
# Warn about missing initializers in construction
CHECK_CXX_COMPILER_FLAG( "-Wmissing-field-initializers" COMPILER_SUPPORTS_WMISSING_INIT )
if( COMPILER_SUPPORTS_WMISSING_INIT )
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wmissing-field-initializers" )
message( STATUS "Enabling warning -Wmissing-field-initializers" )
endif()
Cleanup some compiler warnings
2020-07-02 23:10:31 +00:00
# Warn about empty if/for/while bodies
CHECK_CXX_COMPILER_FLAG( "-Wempty-body" COMPILER_SUPPORTS_WEMPTY_BODY )
if( COMPILER_SUPPORTS_WEMPTY_BODY )
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wempty-body" )
message( STATUS "Enabling warning -Wempty-body" )
endif()
# Warn about out of order intialization
CHECK_CXX_COMPILER_FLAG( "-Wreorder" COMPILER_SUPPORTS_WREORDER )
if( COMPILER_SUPPORTS_WREORDER )
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wreorder" )
message( STATUS "Enabling warning -Wreorder" )
endif()
# Warn about mismatched class/struct declarations
CHECK_CXX_COMPILER_FLAG( "-Wmismatched-tags" COMPILER_SUPPORTS_WMISMATCHED_TAGS )
if( COMPILER_SUPPORTS_WMISMATCHED_TAGS )
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wmismatched-tags" )
message( STATUS "Enabling warning -Wmismatched-tags" )
endif()
Only try to remove the implicit conversion warning if it is supported
2020-07-03 01:59:19 +00:00
# See if the compiler will throw warnings on these conversions
CHECK_CXX_COMPILER_FLAG( "-Wimplicit-int-float-conversion" COMPILER_SUPPORTS_WIMPLICIT_FLOAT_CONVERSION )
if( COMPILER_SUPPORTS_WIMPLICIT_FLOAT_CONVERSION )
# This one is different, it is used to guard warning removal for this inside the code
set( HAVE_WIMPLICIT_FLOAT_CONVERSION true )
endif()
Disable -Wpsabi There was an ABI change for 64 bit aligned vectors between gcc 5 and gcc 6 on a few 64 bit platforms, and gcc 10 reports "note" level warnings for each affected access, which is very noisy and hides more important information. These notes are issued because there is no reliable diagnostic for actual problems.
2020-10-09 18:21:24 +00:00
Move warning setting to Warnings.cmake
2022-08-24 21:21:06 +00:00
# Suppress GCC warnings about unknown/unused attributes (e.g. cdecl, [[maybe_unused, etc)
if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-attributes" )
endif()
Disable -Wpsabi There was an ABI change for 64 bit aligned vectors between gcc 5 and gcc 6 on a few 64 bit platforms, and gcc 10 reports "note" level warnings for each affected access, which is very noisy and hides more important information. These notes are issued because there is no reliable diagnostic for actual problems.
2020-10-09 18:21:24 +00:00
# Avoid ABI warnings, specifically one about an ABI change on ppc64el from gcc5 to gcc 6.
CHECK_CXX_COMPILER_FLAG( "-Wpsabi" COMPILER_SUPPORTS_WPSABI )
if( COMPILER_SUPPORTS_WPSABI )
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wno-psabi" )
message( STATUS "Disabling warning -Wpsabi" )
endif()
Add a new warnings variable that can be used for injecting new warnings This variable can be used to add in more warnings to the compilation that only apply to the KiCad code and not the SWIG or third-party code.
2021-04-22 21:08:00 +00:00
# Append any additional warning flags so the end of the warning string
if( KICAD_ADDITIONAL_WARN_FLAGS )
set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} ${KICAD_ADDITIONAL_WARN_FLAGS}" )
message( STATUS "Adding additional warning flags: ${KICAD_ADDITIONAL_WARN_FLAGS}")
endif()
Enable new warnings
2020-04-24 23:46:29 +00:00
endif()
Enable warnings on msvc
2023-02-18 02:13:10 +00:00
# MSVC specific warnings
if( MSVC )
set( COMPILER_SUPPORTS_WARNINGS TRUE )
# Establish /Wall early and selectively disable some very common warnings in kicad code
# or warnings that really shouldn't be warnings. Also some warnings like implicit fallthrough
# in case statements happen in msvc std lib and despite /external:env:INCLUDE leak
# into build log generating thousands of noise entries.
# Unlike gcc /Wall actually enables all warnings on msvc.
# Warnings for C are not enabled since C files are mostly generated
# set( WARN_FLAGS_C "/external:W0 /external:env:INCLUDE /external:I${CMAKE_SOURCE_DIR}/thirdparty /Wall" )
set( WARN_FLAGS_CXX "/external:W0 /external:env:INCLUDE /external:I${CMAKE_SOURCE_DIR}/thirdparty /Wall" )
# disable "function not inlined"
string( APPEND WARN_FLAGS_CXX " /wd4710" )
# disable "bytes padding added"
string( APPEND WARN_FLAGS_CXX " /wd4820" )
# disable "unreferenced formal parameter"
string( APPEND WARN_FLAGS_CXX " /wd4100" )
# disable default/copy/move constructor/assignment implicitly defined as deleted
string( APPEND WARN_FLAGS_CXX " /wd4623 /wd4625 /wd5026 /wd4626 /wd5027" )
# disable "compiler will insert Spectre mitigation for..."
string( APPEND WARN_FLAGS_CXX " /wd5045" )
# disable "enumerator in switch for enum is not explicitly handled"
string( APPEND WARN_FLAGS_CXX " /wd4061" )
# disable "conversion from 'type_1' to 'type_2', signed/unsigned mismatch"
string( APPEND WARN_FLAGS_CXX " /wd4245 /wd4365" )
# disable "conversion from 'type1' to 'type2', possible loss of data"
string( APPEND WARN_FLAGS_CXX " /wd4242 /wd5219" )
# disable "no override available for virtual member function, function is hidden"
string( APPEND WARN_FLAGS_CXX " /wd4266" )
# disable "class has virtual functions, but its (non)trivial destructor is not virtual"
string( APPEND WARN_FLAGS_CXX " /wd5204 /wd4265" )
# disable "layout of class may have changed from a previous version of the compiler"
string( APPEND WARN_FLAGS_CXX " /wd4371" )
# disable "relative include path contains '..'"
string( APPEND WARN_FLAGS_CXX " /wd4464" )
# disable "'const' variable is not used"
string( APPEND WARN_FLAGS_CXX " /wd5264" )
# disable "implicit fall-through occurs here" in case statement
string( APPEND WARN_FLAGS_CXX " /wd5262" )
# disable "unreferenced inline function has been removed"
string( APPEND WARN_FLAGS_CXX " /wd4514" )
# disable "compiler may not enforce left-to-right evaluation order in ..."
string( APPEND WARN_FLAGS_CXX " /wd4868 /wd4866" )
# disable "XXX is not defined as a preprocessor macro, replacing with '0'"
string( APPEND WARN_FLAGS_CXX " /wd4668" )
endif()