haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Silence Altium polygon-needs-at-least-3-verticies warning. 

Too many Altium files appear to have these.  Just ignore them instead.

Fixes https://gitlab.com/kicad/code/kicad/issues/8183
This commit is contained in:
Jeff Young 2021-07-04 11:02:05 +01:00
parent e0146f73b9
commit 0116e9c94e
1 changed files with 26 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
pcbnew/plugins/altium/altium_pcb.cpp
View File

@ -1385,10 +1385,15 @@ void ALTIUM_PCB::ParsePolygons6Data( const CFB::CompoundFileReader& aReader,
if( linechain.PointCount() < 2 )
{
wxLogError( _( "Polygon has only %d point extracted from %ld vertices. At least 2 "
"points are required." ),
linechain.PointCount(),
elem.vertices.size() );
// We have found multiple Altium files with polygon records containing nothing but two
// coincident vertices. These polygons do not appear when opening the file in Altium.
// https://gitlab.com/kicad/code/kicad/-/issues/8183
//
// wxLogError( _( "Polygon has only %d point extracted from %ld vertices. At least 2 "
// "points are required." ),
// linechain.PointCount(),
// elem.vertices.size() );
m_polygons.emplace_back( nullptr );
continue;
}
@ -1566,10 +1571,14 @@ void ALTIUM_PCB::ParseShapeBasedRegions6Data( const CFB::CompoundFileReader& aRe
if( linechain.PointCount() < 2 )
{
wxLogError( _( "ShapeBasedRegion has only %d point extracted from %ld vertices. "
"At least 2 points are required." ),
linechain.PointCount(),
elem.outline.size() );
// We have found multiple Altium files with polygon records containing nothing but
// two coincident vertices. These polygons do not appear when opening the file in
// Altium. https://gitlab.com/kicad/code/kicad/-/issues/8183
//
// wxLogError( _( "ShapeBasedRegion has only %d point extracted from %ld vertices. "
// "At least 2 points are required." ),
// linechain.PointCount(),
// elem.outline.size() );
continue;
}
@ -1628,10 +1637,15 @@ void ALTIUM_PCB::ParseShapeBasedRegions6Data( const CFB::CompoundFileReader& aRe
if( linechain.PointCount() < 2 )
{
wxLogError( _( "Polygon has only %d point extracted from %ld vertices. At "
"least 2 points are required." ),
linechain.PointCount(),
elem.outline.size() );
// We have found multiple Altium files with polygon records containing nothing
// but two coincident vertices. These polygons do not appear when opening the
// file in Altium. https://gitlab.com/kicad/code/kicad/-/issues/8183
//
// wxLogError( _( "Polygon has only %d point extracted from %ld vertices. At "
// "least 2 points are required." ),
// linechain.PointCount(),
// elem.outline.size() );
continue;
}