haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Test pad:hole violations in footprints as long as not same pad number. 

Fixes https://gitlab.com/kicad/code/kicad/issues/12124
This commit is contained in:
Jeff Young 2022-08-07 19:49:11 +01:00
parent 51b905ba32
commit 015bde8cb0
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pcbnew/drc/drc_test_provider_copper_clearance.cpp
View File

@ -497,8 +497,8 @@ bool DRC_TEST_PROVIDER_COPPER_CLEARANCE::testPadAgainstItem( PAD* pad, SHAPE* pa
if( fp->IsNetTie() && ( other->Type() == PCB_FP_SHAPE_T || other->Type() == PCB_PAD_T ) )
testClearance = false;
// No hole testing within a footprint
testHoles = false;
if( other->Type() == PCB_PAD_T && pad->SameLogicalPadAs( static_cast<PAD*>( other ) ) )
testHoles = false;
}
PAD* otherPad = nullptr;

3
pcbnew/pad.h
View File

@ -158,7 +158,8 @@ public:
bool SameLogicalPadAs( const PAD* other ) const
{
// hide tricks behind sensible API
return GetParentFootprint() == other->GetParentFootprint() && m_number == other->m_number;
return GetParentFootprint() == other->GetParentFootprint()
&& !m_number.IsEmpty() && m_number == other->m_number;
}
/**