haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fp editor, DIALOG_FOOTPRINT_FP_EDITOR: fix a very annoying issue: the value field was copuled to the fp name. Unlike schematic symbols, the value field and the footprint name are 2 different fields. So coupling these fields in the DIALOG_FOOTPRINT_FP_EDITOR dialog created serious issues. 

Fixes: lp:1846533
https://bugs.launchpad.net/kicad/+bug/1846533
This commit is contained in:
jean-pierre charras 2019-10-09 18:53:41 +02:00
parent 41231e8ae2
commit 0210e414d2
1 changed files with 3 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
pcbnew/dialogs/dialog_edit_footprint_for_fp_editor.cpp
View File

@ -675,26 +675,7 @@ static bool footprintIsFromBoard( MODULE* aFootprint )
void DIALOG_FOOTPRINT_FP_EDITOR::OnGridCellChanging( wxGridEvent& event ) void DIALOG_FOOTPRINT_FP_EDITOR::OnGridCellChanging( wxGridEvent& event )
{ {
if( event.GetRow() == 1 && event.GetCol() == TMC_TEXT ) // Currently: nothing to do
{
if( !checkFootprintName( event.GetString() ) )
{
event.Veto();
if( m_NoteBook->GetSelection() != 0 )
m_NoteBook->SetSelection( 0 );
m_delayedFocusGrid = m_itemsGrid;
m_delayedFocusRow = event.GetRow();
m_delayedFocusColumn = event.GetCol();
m_delayedFocusPage = 0;
}
else if( !footprintIsFromBoard( m_footprint ) )
{
// Keep Name and Value of footprints in library in sync
m_FootprintNameCtrl->ChangeValue( event.GetString() );
}
}
} }
@ -702,8 +683,7 @@ void DIALOG_FOOTPRINT_FP_EDITOR::OnFootprintNameText( wxCommandEvent& event )
{ {
if( !footprintIsFromBoard( m_footprint ) ) if( !footprintIsFromBoard( m_footprint ) )
{ {
// Keep Name and Value of footprints in library in sync // Currently: nothing to do
m_itemsGrid->SetCellValue( 1, TMC_TEXT, m_FootprintNameCtrl->GetValue() );
} }
} }
@ -803,15 +783,7 @@ void DIALOG_FOOTPRINT_FP_EDITOR::OnUpdateUI( wxUpdateUIEvent& event )
if( m_itemsGrid->IsCellEditControlShown() ) if( m_itemsGrid->IsCellEditControlShown() )
{ {
int row = m_itemsGrid->GetGridCursorRow(); // Currently: nonthing to do
int col = m_itemsGrid->GetGridCursorCol();
if( row == 1 && col == TMC_TEXT )
{
wxGridCellEditor* editor = m_itemsGrid->GetCellEditor( row, col );
m_FootprintNameCtrl->ChangeValue( editor->GetValue() );
editor->DecRef();
}
} }
// Handle a delayed focus. The delay allows us to: // Handle a delayed focus. The delay allows us to: