haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

All: fix spurious wheel scroll events caused when using modern mice. 

Modern mice feature horizontal scrolling capabilities and those end
up being treated by KiCad as regular scroll events causing confusion
among users.

The fix works by discarding the handling of wheel events other than
the ones for the vertical axis.

Fixes: lp:1828080
https://bugs.launchpad.net/kicad/+bug/1828080
(cherry picked from commit e10c01aaff)
This commit is contained in:
Adrian Scripca 2019-05-07 19:17:02 +03:00 committed by John Beard
parent 7bafc5fa8b
commit 055d36abd7
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
common/view/wx_view_controls.cpp
View File

@ -159,6 +159,12 @@ void WX_VIEW_CONTROLS::onWheel( wxMouseEvent& aEvent )
m_lastTimestamp = aEvent.GetTimestamp(); m_lastTimestamp = aEvent.GetTimestamp();
#endif #endif
// Fix issue caused by modern mice that feature horizontal scrolling by only handling
// vertical axis, otherwise horizontal scrolling events end up interpreted as vertical
// scroll events and confuse the user.
if( aEvent.GetWheelAxis() > 0 )
return;
// mousewheelpan disabled: // mousewheelpan disabled:
// wheel + ctrl -> horizontal scrolling; // wheel + ctrl -> horizontal scrolling;
// wheel + shift -> vertical scrolling; // wheel + shift -> vertical scrolling;