Re-entrancy blocker for line/wire/bus tool.

Also clear infobar messages after a cancelInteractive.

Fixes https://gitlab.com/kicad/code/kicad/issues/11155
This commit is contained in:
Jeff Young 2022-03-17 15:26:49 +00:00
parent 0f359c8a3b
commit 05bca282f7
6 changed files with 33 additions and 5 deletions

View File

@ -197,6 +197,8 @@ int SCH_DRAWING_TOOLS::PlaceSymbol( const TOOL_EVENT& aEvent )
if( evt->IsCancelInteractive() ) if( evt->IsCancelInteractive() )
{ {
m_frame->GetInfoBar()->Dismiss();
if( symbol ) if( symbol )
{ {
cleanup(); cleanup();
@ -435,6 +437,8 @@ int SCH_DRAWING_TOOLS::PlaceImage( const TOOL_EVENT& aEvent )
if( evt->IsCancelInteractive() ) if( evt->IsCancelInteractive() )
{ {
m_frame->GetInfoBar()->Dismiss();
if( image ) if( image )
{ {
cleanup(); cleanup();
@ -1124,6 +1128,8 @@ int SCH_DRAWING_TOOLS::TwoClickPlace( const TOOL_EVENT& aEvent )
if( evt->IsCancelInteractive() ) if( evt->IsCancelInteractive() )
{ {
m_frame->GetInfoBar()->Dismiss();
if( item ) if( item )
{ {
cleanup(); cleanup();
@ -1535,6 +1541,8 @@ int SCH_DRAWING_TOOLS::DrawSheet( const TOOL_EVENT& aEvent )
if( evt->IsCancelInteractive() ) if( evt->IsCancelInteractive() )
{ {
m_frame->GetInfoBar()->Dismiss();
if( sheet ) if( sheet )
{ {
cleanup(); cleanup();

View File

@ -163,7 +163,8 @@ private:
SCH_LINE_WIRE_BUS_TOOL::SCH_LINE_WIRE_BUS_TOOL() : SCH_LINE_WIRE_BUS_TOOL::SCH_LINE_WIRE_BUS_TOOL() :
EE_TOOL_BASE<SCH_EDIT_FRAME>( "eeschema.InteractiveDrawingLineWireBus" ) EE_TOOL_BASE<SCH_EDIT_FRAME>( "eeschema.InteractiveDrawingLineWireBus" ),
m_inDrawingTool( false )
{ {
m_busUnfold = {}; m_busUnfold = {};
m_wires.reserve( 16 ); m_wires.reserve( 16 );
@ -278,6 +279,11 @@ bool SCH_LINE_WIRE_BUS_TOOL::IsDrawingLineWireOrBus( const SELECTION& aSelection
int SCH_LINE_WIRE_BUS_TOOL::DrawSegments( const TOOL_EVENT& aEvent ) int SCH_LINE_WIRE_BUS_TOOL::DrawSegments( const TOOL_EVENT& aEvent )
{ {
if( m_inDrawingTool )
return 0;
REENTRANCY_GUARD guard( &m_inDrawingTool );
DRAW_SEGMENT_EVENT_PARAMS* params = aEvent.Parameter<DRAW_SEGMENT_EVENT_PARAMS*>(); DRAW_SEGMENT_EVENT_PARAMS* params = aEvent.Parameter<DRAW_SEGMENT_EVENT_PARAMS*>();
std::string tool = aEvent.GetCommandStr().get(); std::string tool = aEvent.GetCommandStr().get();
@ -300,6 +306,11 @@ int SCH_LINE_WIRE_BUS_TOOL::DrawSegments( const TOOL_EVENT& aEvent )
int SCH_LINE_WIRE_BUS_TOOL::UnfoldBus( const TOOL_EVENT& aEvent ) int SCH_LINE_WIRE_BUS_TOOL::UnfoldBus( const TOOL_EVENT& aEvent )
{ {
if( m_inDrawingTool )
return 0;
REENTRANCY_GUARD guard( &m_inDrawingTool );
wxString* netPtr = aEvent.Parameter<wxString*>(); wxString* netPtr = aEvent.Parameter<wxString*>();
wxString net; wxString net;
SCH_LINE* segment = nullptr; SCH_LINE* segment = nullptr;
@ -591,6 +602,8 @@ int SCH_LINE_WIRE_BUS_TOOL::doDrawSegments( const std::string& aTool, int aType,
// //
if( evt->IsCancelInteractive() ) if( evt->IsCancelInteractive() )
{ {
m_frame->GetInfoBar()->Dismiss();
if( segment || m_busUnfold.in_progress ) if( segment || m_busUnfold.in_progress )
{ {
cleanup(); cleanup();

View File

@ -134,11 +134,10 @@ private:
void computeBreakPoint( const std::pair<SCH_LINE*, SCH_LINE*>& aSegments, VECTOR2I& aPosition ); void computeBreakPoint( const std::pair<SCH_LINE*, SCH_LINE*>& aSegments, VECTOR2I& aPosition );
private: private:
/// Data related to bus unfolding tool. bool m_inDrawingTool; // Reentrancy guard
BUS_UNFOLDING_T m_busUnfold;
/// Storage for the line segments while drawing BUS_UNFOLDING_T m_busUnfold;
std::vector<SCH_LINE*> m_wires; std::vector<SCH_LINE*> m_wires; // Lines being drawn
}; };
#endif /* SCH_LINE_WIRE_BUS_TOOL_H */ #endif /* SCH_LINE_WIRE_BUS_TOOL_H */

View File

@ -719,6 +719,9 @@ int SCH_MOVE_TOOL::Main( const TOOL_EVENT& aEvent )
// //
else if( evt->IsCancelInteractive() || evt->IsActivate() ) else if( evt->IsCancelInteractive() || evt->IsActivate() )
{ {
if( evt->IsCancelInteractive() )
m_frame->GetInfoBar()->Dismiss();
if( m_moveInProgress ) if( m_moveInProgress )
{ {
if( evt->IsActivate() ) if( evt->IsActivate() )

View File

@ -137,6 +137,8 @@ int SYMBOL_EDITOR_DRAWING_TOOLS::TwoClickPlace( const TOOL_EVENT& aEvent )
if( evt->IsCancelInteractive() ) if( evt->IsCancelInteractive() )
{ {
m_frame->GetInfoBar()->Dismiss();
if( item ) if( item )
{ {
cleanup(); cleanup();

View File

@ -204,6 +204,9 @@ int PL_EDIT_TOOL::Main( const TOOL_EVENT& aEvent )
// //
else if( evt->IsCancelInteractive() || evt->IsActivate() ) else if( evt->IsCancelInteractive() || evt->IsActivate() )
{ {
if( evt->IsCancelInteractive() )
m_frame->GetInfoBar()->Dismiss();
if( m_moveInProgress ) if( m_moveInProgress )
{ {
if( evt->IsActivate() ) if( evt->IsActivate() )