haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Warn the user when global track/via edits fail.

This commit is contained in:
Jeff Young 2018-12-30 19:35:56 +00:00
parent 1b7ebc7a4e
commit 061d993448
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
pcbnew/dialogs/dialog_global_edit_tracks_and_vias.cpp
View File

@ -23,6 +23,7 @@
*/ */
#include <fctsys.h> #include <fctsys.h>
#include <confirm.h>
#include <pcb_edit_frame.h> #include <pcb_edit_frame.h>
#include <class_drawpanel.h> #include <class_drawpanel.h>
#include <class_board.h> #include <class_board.h>
@ -66,6 +67,7 @@ private:
PCB_EDIT_FRAME* m_parent; PCB_EDIT_FRAME* m_parent;
BOARD* m_brd; BOARD* m_brd;
int* m_originalColWidths; int* m_originalColWidths;
bool m_failedDRC;
public: public:
DIALOG_GLOBAL_EDIT_TRACKS_AND_VIAS( PCB_EDIT_FRAME* aParent ); DIALOG_GLOBAL_EDIT_TRACKS_AND_VIAS( PCB_EDIT_FRAME* aParent );
@ -111,6 +113,8 @@ DIALOG_GLOBAL_EDIT_TRACKS_AND_VIAS::DIALOG_GLOBAL_EDIT_TRACKS_AND_VIAS( PCB_EDIT
for( int i = 0; i < m_netclassGrid->GetNumberCols(); ++i ) for( int i = 0; i < m_netclassGrid->GetNumberCols(); ++i )
m_originalColWidths[ i ] = m_netclassGrid->GetColSize( i ); m_originalColWidths[ i ] = m_netclassGrid->GetColSize( i );
m_failedDRC = false;
buildFilterLists(); buildFilterLists();
m_parent->UpdateTrackWidthSelectBox( m_trackWidthSelectBox ); m_parent->UpdateTrackWidthSelectBox( m_trackWidthSelectBox );
@ -255,6 +259,12 @@ void DIALOG_GLOBAL_EDIT_TRACKS_AND_VIAS::OnUpdateUI( wxUpdateUIEvent& )
{ {
m_trackWidthSelectBox->Enable( m_setToSpecifiedValues->GetValue() ); m_trackWidthSelectBox->Enable( m_setToSpecifiedValues->GetValue() );
m_viaSizesSelectBox->Enable( m_setToSpecifiedValues->GetValue() ); m_viaSizesSelectBox->Enable( m_setToSpecifiedValues->GetValue() );
if( m_failedDRC )
{
m_failedDRC = false;
DisplayError( this, _( "Some items failed DRC and were not modified." ) );
}
} }
@ -269,7 +279,9 @@ void DIALOG_GLOBAL_EDIT_TRACKS_AND_VIAS::processItem( PICKED_ITEMS_LIST* aUndoLi
{ {
brdSettings.SetTrackWidthIndex( (unsigned) m_trackWidthSelectBox->GetSelection() ); brdSettings.SetTrackWidthIndex( (unsigned) m_trackWidthSelectBox->GetSelection() );
brdSettings.SetViaSizeIndex( (unsigned) m_viaSizesSelectBox->GetSelection() ); brdSettings.SetViaSizeIndex( (unsigned) m_viaSizesSelectBox->GetSelection() );
m_parent->SetTrackSegmentWidth( aItem, aUndoList, false );
if( !m_parent->SetTrackSegmentWidth( aItem, aUndoList, false ) )
m_failedDRC = true;
} }
brdSettings.SetTrackWidthIndex( prevTrackWidthIndex ); brdSettings.SetTrackWidthIndex( prevTrackWidthIndex );
brdSettings.SetViaSizeIndex( prevViaSizeIndex ); brdSettings.SetViaSizeIndex( prevViaSizeIndex );
@ -289,7 +301,8 @@ void DIALOG_GLOBAL_EDIT_TRACKS_AND_VIAS::processItem( PICKED_ITEMS_LIST* aUndoLi
} }
else else
{ {
m_parent->SetTrackSegmentWidth( aItem, aUndoList, true ); if( !m_parent->SetTrackSegmentWidth( aItem, aUndoList, true ) )
m_failedDRC = true;
} }
} }
@ -345,7 +358,7 @@ bool DIALOG_GLOBAL_EDIT_TRACKS_AND_VIAS::TransferDataFromWindow()
m_parent->GetCanvas()->Refresh(); m_parent->GetCanvas()->Refresh();
} }
return true; return !m_failedDRC;
} }