haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Minor warning fixes

This commit is contained in:
Ian McInerney 2020-10-21 00:28:56 +01:00
parent 7a41ff74df
commit 06bf7943b7
4 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
eeschema/dialogs/dialog_change_symbols.cpp
View File

@ -236,6 +236,9 @@ void DIALOG_CHANGE_SYMBOLS::launchNewIdSymbolBrowser( wxCommandEvent& aEvent )
void DIALOG_CHANGE_SYMBOLS::updateFieldsList()
{
SCH_EDIT_FRAME* frame = dynamic_cast<SCH_EDIT_FRAME*>( GetParent() );
wxCHECK( frame, /* void */ );
LIB_ID newId;
SCH_SHEET_LIST hierarchy = frame->Schematic().GetSheets();

4
eeschema/dialogs/dialog_symbol_properties.cpp
View File

@ -1010,8 +1010,8 @@ void DIALOG_SYMBOL_PROPERTIES::OnUpdateUI( wxUpdateUIEvent& event )
{
wxGridCellEditor* cellEditor = m_fieldsGrid->GetCellEditor( REFERENCE, FDC_VALUE );
if( cellEditor->GetControl() )
SelectReferenceNumber( dynamic_cast<wxTextEntry*>( cellEditor->GetControl() ) );
if( wxTextEntry* txt = dynamic_cast<wxTextEntry*>( cellEditor->GetControl() ) )
SelectReferenceNumber( txt );
cellEditor->DecRef(); // we're done; must release

2
eeschema/sch_sheet.cpp
View File

@ -1016,7 +1016,7 @@ SCH_SHEET& SCH_SHEET::operator=( const SCH_ITEM& aItem )
m_pins.back()->SetParent( this );
}
for( const SCH_SHEET_INSTANCE instance : sheet->m_instances )
for( const SCH_SHEET_INSTANCE& instance : sheet->m_instances )
m_instances.emplace_back( instance );
}

7
pcbnew/dialogs/dialog_drc.cpp
View File

@ -307,10 +307,11 @@ void DIALOG_DRC::OnDRCItemSelected( wxDataViewEvent& aEvent )
const KIID& itemID = node ? RC_TREE_MODEL::ToUUID( aEvent.GetItem() ) : niluuid;
BOARD_ITEM* item = board->GetItem( itemID );
if( item )
if( item && node )
{
PCB_LAYER_ID principalLayer = item->GetLayer();
std::shared_ptr<RC_ITEM> rc_item = node->m_RcItem;
PCB_LAYER_ID principalLayer = item->GetLayer();
std::shared_ptr<RC_ITEM> rc_item = node->m_RcItem;
BOARD_ITEM* a = board->GetItem( rc_item->GetMainItemID() );
BOARD_ITEM* b = board->GetItem( rc_item->GetAuxItemID() );
BOARD_ITEM* c = board->GetItem( rc_item->GetAuxItem2ID() );