+ Resync with main r6397

+ Work in progress: VRML parser

3d-viewer/3d_frame.cpp

@@ -116,7 +116,7 @@ END_EVENT_TABLE()
 EDA_3D_FRAME::EDA_3D_FRAME( KIWAY* aKiway, PCB_BASE_FRAME* aParent,
         const wxString& aTitle, long style ) :
     KIWAY_PLAYER( aKiway, aParent, FRAME_PCB_DISPLAY3D, aTitle,
-            wxDefaultPosition, wxDefaultSize, style, wxT( "Frame3D" ) )
+            wxDefaultPosition, wxDefaultSize, style, VIEWER3D_FRAMENAME )
 {
     m_canvas        = NULL;
     m_reloadRequest = false;
@@ -227,6 +227,7 @@ EDA_3D_FRAME::~EDA_3D_FRAME()
     m_auimgr.UnInit();
 }
 
+
 void EDA_3D_FRAME::Exit3DFrame( wxCommandEvent& event )
 {
     Close( true );
@@ -235,9 +236,6 @@ void EDA_3D_FRAME::Exit3DFrame( wxCommandEvent& event )
 
 void EDA_3D_FRAME::OnCloseWindow( wxCloseEvent& Event )
 {
-    if( Parent() )
-        Parent()->m_Draw3DFrame = NULL;
-
     Destroy();
 }
 

3d-viewer/3d_viewer.h

@@ -54,6 +54,8 @@ class wxColourData;
 
 #define KICAD_DEFAULT_3D_DRAWFRAME_STYLE    (wxDEFAULT_FRAME_STYLE | wxWANTS_CHARS)
 
+#define VIEWER3D_FRAMENAME wxT( "Viewer3DFrameName" )
+
 
 class EDA_3D_FRAME : public KIWAY_PLAYER
 {

CMakeLists.txt

@@ -478,6 +478,9 @@ endif()
 # Find GLM library
 find_package( GLM 0.9.5.4 REQUIRED )
 
+# Find CURL library
+find_package( CURL REQUIRED )
+
 # Find Cairo library
 if( NOT CAIRO_FOUND )
     find_package( Cairo 1.8.1 QUIET )

README.txt

@@ -11,9 +11,9 @@ CMakeList.txt       - CMAKE build tool script
 COPYRIGHT.txt       - A copy of the GNU General Public License Version 2
 CTestConfig.cmake   - Support for CTest and CDash testing tools
 Doxyfile            - Doxygen config file for Kicad
-INSTALL.txt         - The release (binairy) installation instructions
+INSTALL.txt         - The release (binary) installation instructions
 TODO.txt            - Todo list
-uncrustify.cfg      - Uncrustify config file for uncrustify sorces formatting tool
+uncrustify.cfg      - Uncrustify config file for uncrustify sources formatting tool
 
 Subdirectories
 --------------

common/CMakeLists.txt

@@ -5,6 +5,7 @@ include_directories(
     ${CAIRO_INCLUDE_DIR}
     ${GLEW_INCLUDE_DIR}
     ${GLM_INCLUDE_DIR}
+    ${CURL_INCLUDE_DIRS}
     ../3d-viewer
     ../pcbnew
     ../polygon
@@ -201,6 +202,7 @@ set( COMMON_SRCS
     dsnlexer.cpp
     eda_dde.cpp
     eda_doc.cpp
+    eda_pattern_match.cpp
     filter_reader.cpp
 #    findkicadhelppath.cpp.notused      deprecated, use searchhelpfilefullpath.cpp
     gestfich.cpp
@@ -253,6 +255,9 @@ endif()
 
 set( COMMON_SRCS
     ${COMMON_SRCS}
+    kicad_curl/kicad_curl.cpp
+    kicad_curl/kicad_curl_easy.cpp
+
     view/view.cpp
     view/view_item.cpp
     view/view_group.cpp
@@ -278,7 +283,7 @@ set( COMMON_SRCS
 add_library( common STATIC ${COMMON_SRCS} )
 add_dependencies( common lib-dependencies )
 add_dependencies( common version_header )
-target_link_libraries( common ${Boost_LIBRARIES} )
+target_link_libraries( common ${Boost_LIBRARIES} ${CURL_LIBRARIES} )
 
 
 set( PCB_COMMON_SRCS

common/dialogs/dialog_get_component_base.cpp

@@ -1,5 +1,5 @@
 ///////////////////////////////////////////////////////////////////////////
-// C++ code generated with wxFormBuilder (version Nov  5 2013)
+// C++ code generated with wxFormBuilder (version Jun 17 2015)
 // http://www.wxformbuilder.org/
 //
 // PLEASE DO "NOT" EDIT THIS FILE!
@@ -14,7 +14,10 @@ DIALOG_GET_COMPONENT_BASE::DIALOG_GET_COMPONENT_BASE( wxWindow* parent, wxWindow
 	this->SetSizeHints( wxDefaultSize, wxDefaultSize );
 	
 	wxBoxSizer* bSizerMain;
-	bSizerMain = new wxBoxSizer( wxHORIZONTAL );
+	bSizerMain = new wxBoxSizer( wxVERTICAL );
+	
+	wxBoxSizer* bSizerUpper;
+	bSizerUpper = new wxBoxSizer( wxHORIZONTAL );
 	
 	wxBoxSizer* bSizerLeft;
 	bSizerLeft = new wxBoxSizer( wxVERTICAL );
@@ -34,24 +37,17 @@ DIALOG_GET_COMPONENT_BASE::DIALOG_GET_COMPONENT_BASE( wxWindow* parent, wxWindow
 	m_historyList = new wxListBox( this, ID_SEL_BY_LISTBOX, wxDefaultPosition, wxDefaultSize, 0, NULL, 0 ); 
 	m_historyList->SetMinSize( wxSize( 200,100 ) );
 	
-	bSizerLeft->Add( m_historyList, 1, wxALL|wxEXPAND, 5 );
+	bSizerLeft->Add( m_historyList, 1, wxEXPAND|wxBOTTOM|wxRIGHT|wxLEFT, 5 );
 	
 	
-	bSizerMain->Add( bSizerLeft, 1, wxEXPAND, 5 );
+	bSizerUpper->Add( bSizerLeft, 1, wxEXPAND, 5 );
 	
 	wxBoxSizer* bSizerRight;
 	bSizerRight = new wxBoxSizer( wxVERTICAL );
 	
-	m_buttonOK = new wxButton( this, wxID_OK, _("OK"), wxDefaultPosition, wxDefaultSize, 0 );
-	m_buttonOK->SetDefault(); 
-	bSizerRight->Add( m_buttonOK, 0, wxALL|wxEXPAND, 5 );
-	
 	m_buttonKW = new wxButton( this, ID_ACCEPT_KEYWORD, _("Search by Keyword"), wxDefaultPosition, wxDefaultSize, 0 );
 	bSizerRight->Add( m_buttonKW, 0, wxALL|wxEXPAND, 5 );
 	
-	m_buttonCancel = new wxButton( this, wxID_CANCEL, _("Cancel"), wxDefaultPosition, wxDefaultSize, 0 );
-	bSizerRight->Add( m_buttonCancel, 0, wxALL|wxEXPAND, 5 );
-	
 	m_buttonList = new wxButton( this, ID_LIST_ALL, _("List All"), wxDefaultPosition, wxDefaultSize, 0 );
 	bSizerRight->Add( m_buttonList, 0, wxALL|wxEXPAND, 5 );
 	
@@ -59,32 +55,46 @@ DIALOG_GET_COMPONENT_BASE::DIALOG_GET_COMPONENT_BASE( wxWindow* parent, wxWindow
 	bSizerRight->Add( m_buttonBrowse, 0, wxALL|wxEXPAND, 5 );
 	
 	
-	bSizerMain->Add( bSizerRight, 0, wxALIGN_CENTER_VERTICAL, 5 );
+	bSizerUpper->Add( bSizerRight, 0, wxALIGN_CENTER_VERTICAL, 5 );
+	
+	
+	bSizerMain->Add( bSizerUpper, 1, wxEXPAND, 5 );
+	
+	m_staticline1 = new wxStaticLine( this, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxLI_HORIZONTAL );
+	bSizerMain->Add( m_staticline1, 0, wxEXPAND|wxTOP|wxRIGHT, 5 );
+	
+	m_sdbSizer = new wxStdDialogButtonSizer();
+	m_sdbSizerOK = new wxButton( this, wxID_OK );
+	m_sdbSizer->AddButton( m_sdbSizerOK );
+	m_sdbSizerCancel = new wxButton( this, wxID_CANCEL );
+	m_sdbSizer->AddButton( m_sdbSizerCancel );
+	m_sdbSizer->Realize();
+	
+	bSizerMain->Add( m_sdbSizer, 0, wxEXPAND|wxALL, 5 );
 	
 	
 	this->SetSizer( bSizerMain );
 	this->Layout();
-	bSizerMain->Fit( this );
 	
 	this->Centre( wxBOTH );
 	
 	// Connect Events
 	m_historyList->Connect( wxEVT_COMMAND_LISTBOX_SELECTED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::Accept ), NULL, this );
-	m_buttonOK->Connect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::Accept ), NULL, this );
 	m_buttonKW->Connect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::Accept ), NULL, this );
-	m_buttonCancel->Connect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::OnCancel ), NULL, this );
 	m_buttonList->Connect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::Accept ), NULL, this );
 	m_buttonBrowse->Connect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::GetExtraSelection ), NULL, this );
+	m_sdbSizerCancel->Connect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::OnCancel ), NULL, this );
+	m_sdbSizerOK->Connect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::Accept ), NULL, this );
 }
 
 DIALOG_GET_COMPONENT_BASE::~DIALOG_GET_COMPONENT_BASE()
 {
 	// Disconnect Events
 	m_historyList->Disconnect( wxEVT_COMMAND_LISTBOX_SELECTED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::Accept ), NULL, this );
-	m_buttonOK->Disconnect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::Accept ), NULL, this );
 	m_buttonKW->Disconnect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::Accept ), NULL, this );
-	m_buttonCancel->Disconnect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::OnCancel ), NULL, this );
 	m_buttonList->Disconnect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::Accept ), NULL, this );
 	m_buttonBrowse->Disconnect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::GetExtraSelection ), NULL, this );
+	m_sdbSizerCancel->Disconnect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::OnCancel ), NULL, this );
+	m_sdbSizerOK->Disconnect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_GET_COMPONENT_BASE::Accept ), NULL, this );
 	
 }

common/dialogs/dialog_get_component_base.h

@@ -1,5 +1,5 @@
 ///////////////////////////////////////////////////////////////////////////
-// C++ code generated with wxFormBuilder (version Nov  5 2013)
+// C++ code generated with wxFormBuilder (version Jun 17 2015)
 // http://www.wxformbuilder.org/
 //
 // PLEASE DO "NOT" EDIT THIS FILE!
@@ -24,6 +24,7 @@ class DIALOG_SHIM;
 #include <wx/listbox.h>
 #include <wx/sizer.h>
 #include <wx/button.h>
+#include <wx/statline.h>
 #include <wx/dialog.h>
 
 ///////////////////////////////////////////////////////////////////////////
@@ -45,21 +46,23 @@ class DIALOG_GET_COMPONENT_BASE : public DIALOG_SHIM
 		wxTextCtrl* m_textCmpNameCtrl;
 		wxStaticText* m_staticTextHistory;
 		wxListBox* m_historyList;
-		wxButton* m_buttonOK;
 		wxButton* m_buttonKW;
-		wxButton* m_buttonCancel;
 		wxButton* m_buttonList;
 		wxButton* m_buttonBrowse;
+		wxStaticLine* m_staticline1;
+		wxStdDialogButtonSizer* m_sdbSizer;
+		wxButton* m_sdbSizerOK;
+		wxButton* m_sdbSizerCancel;
 		
 		// Virtual event handlers, overide them in your derived class
 		virtual void Accept( wxCommandEvent& event ) { event.Skip(); }
-		virtual void OnCancel( wxCommandEvent& event ) { event.Skip(); }
 		virtual void GetExtraSelection( wxCommandEvent& event ) { event.Skip(); }
+		virtual void OnCancel( wxCommandEvent& event ) { event.Skip(); }
 		
 	
 	public:
 		
-		DIALOG_GET_COMPONENT_BASE( wxWindow* parent, wxWindowID id = wxID_ANY, const wxString& title = wxEmptyString, const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxSize( -1,-1 ), long style = wxDEFAULT_DIALOG_STYLE|wxRESIZE_BORDER ); 
+		DIALOG_GET_COMPONENT_BASE( wxWindow* parent, wxWindowID id = wxID_ANY, const wxString& title = wxEmptyString, const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxSize( 361,285 ), long style = wxDEFAULT_DIALOG_STYLE|wxRESIZE_BORDER ); 
 		~DIALOG_GET_COMPONENT_BASE();
 	
 };

common/eda_pattern_match.cpp

@@ -0,0 +1,137 @@
+/*
+ * This program source code file is part of KiCad, a free EDA CAD application.
+ *
+ * Copyright (C) 2015 Chris Pavlina <pavlina.chris@gmail.com>
+ * Copyright (C) 2015 KiCad Developers, see change_log.txt for contributors.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, you may find one here:
+ * http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ * or you may search the http://www.gnu.org website for the version 2 license,
+ * or you may write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ */
+
+#include <eda_pattern_match.h>
+#include <wx/log.h>
+#include <climits>
+
+bool EDA_PATTERN_MATCH_SUBSTR::SetPattern( const wxString& aPattern )
+{
+    m_pattern = aPattern;
+    return true;
+}
+
+
+int EDA_PATTERN_MATCH_SUBSTR::Find( const wxString& aCandidate ) const
+{
+    int loc = aCandidate.Find( m_pattern );
+
+    return ( loc == wxNOT_FOUND ) ? EDA_PATTERN_NOT_FOUND : loc;
+}
+
+
+/**
+ * Context class to set wx loglevel for a block, and always restore it at the end.
+ */
+class WX_LOGLEVEL_CONTEXT
+{
+    wxLogLevel m_old_level;
+
+public:
+    WX_LOGLEVEL_CONTEXT( wxLogLevel level )
+    {
+        m_old_level = wxLog::GetLogLevel();
+        wxLog::SetLogLevel( level );
+    }
+
+    ~WX_LOGLEVEL_CONTEXT()
+    {
+        wxLog::SetLogLevel( m_old_level );
+    }
+};
+
+
+bool EDA_PATTERN_MATCH_REGEX::SetPattern( const wxString& aPattern )
+{
+    m_pattern = aPattern;
+
+    // Evil and undocumented: wxRegEx::Compile calls wxLogError on error, even
+    // though it promises to just return false. Silence the error.
+    WX_LOGLEVEL_CONTEXT ctx( wxLOG_FatalError );
+
+    return m_regex.Compile( aPattern, wxRE_ADVANCED );
+}
+
+
+int EDA_PATTERN_MATCH_REGEX::Find( const wxString& aCandidate ) const
+{
+    if( m_regex.IsValid() )
+    {
+        if( m_regex.Matches( aCandidate ) )
+        {
+            size_t start, len;
+            m_regex.GetMatch( &start, &len, 0 );
+            return ( start > INT_MAX ) ? INT_MAX : start;
+        }
+        else
+        {
+            return EDA_PATTERN_NOT_FOUND;
+        }
+    }
+    else
+    {
+        int loc = aCandidate.Find( m_pattern );
+        return ( loc == wxNOT_FOUND ) ? EDA_PATTERN_NOT_FOUND : loc;
+    }
+}
+
+
+bool EDA_PATTERN_MATCH_WILDCARD::SetPattern( const wxString& aPattern )
+{
+    // Compile the wildcard string to a regular expression
+    wxString regex;
+    regex.Alloc( 2 * aPattern.Length() );   // no need to keep resizing, we know the size roughly
+
+    const wxString to_replace = wxT( ".*+?^${}()|[]/\\" );
+
+    for( wxString::const_iterator it = aPattern.begin(); it < aPattern.end(); ++it )
+    {
+        wxUniChar c = *it;
+        if( c == '?' )
+        {
+            regex += wxT( "." );
+        }
+        else if( c == '*' )
+        {
+            regex += wxT( ".*" );
+        }
+        else if( to_replace.Find( c ) != wxNOT_FOUND )
+        {
+            regex += "\\";
+            regex += c;
+        }
+        else
+        {
+            regex += c;
+        }
+    }
+
+    return EDA_PATTERN_MATCH_REGEX::SetPattern( regex );
+}
+
+
+int EDA_PATTERN_MATCH_WILDCARD::Find( const wxString& aCandidate ) const
+{
+    return EDA_PATTERN_MATCH_REGEX::Find( aCandidate );
+}

common/kicad_curl/kicad_curl.cpp

@@ -0,0 +1,54 @@
+/*
+ * This program source code file is part of KiCad, a free EDA CAD application.
+ *
+ * Copyright (C) 2015 Mark Roszko <mark.roszko@gmail.com>
+ * Copyright (C) 2015 KiCad Developers, see CHANGELOG.TXT for contributors.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 3
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, you may find one here:
+ * http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ * or you may search the http://www.gnu.org website for the version 2 license,
+ * or you may write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ */
+
+#include <kicad_curl/kicad_curl.h>
+
+bool KICAD_CURL::Init()
+{
+    if ( curl_global_init( CURL_GLOBAL_ALL ) != CURLE_OK )
+    {
+        return false;
+    }
+    else
+    {
+        m_initialized = true;
+        return true;
+    }
+}
+
+
+void KICAD_CURL::Cleanup()
+{
+    if( m_initialized )
+        curl_global_cleanup();
+}
+
+
+std::string KICAD_CURL::GetVersion()
+{
+    return std::string( curl_version() );
+}
+
+
+bool KICAD_CURL::m_initialized = false;

common/kicad_curl/kicad_curl_easy.cpp

@@ -0,0 +1,163 @@
+/*
+ * This program source code file is part of KiCad, a free EDA CAD application.
+ *
+ * Copyright (C) 2015 Mark Roszko <mark.roszko@gmail.com>
+ * Copyright (C) 2015 KiCad Developers, see CHANGELOG.TXT for contributors.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 3
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, you may find one here:
+ * http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ * or you may search the http://www.gnu.org website for the version 2 license,
+ * or you may write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ */
+
+#include <kicad_curl/kicad_curl_easy.h>
+
+#include <cstddef>
+#include <exception>
+#include <stdarg.h>
+#include <sstream>
+#include <richio.h>
+
+static size_t write_callback (void *contents, size_t size, size_t nmemb, void *userp);
+
+
+KICAD_CURL_EASY::KICAD_CURL_EASY()
+    : m_headers( NULL )
+{
+    m_CURL = curl_easy_init();
+
+    if( m_CURL == NULL )
+    {
+        THROW_IO_ERROR( "Unable to initialize CURL session" );
+    }
+
+    m_Buffer.payload = (char*)malloc( 1 );
+    m_Buffer.size = 0;
+
+    curl_easy_setopt( m_CURL, CURLOPT_WRITEFUNCTION, write_callback );
+    curl_easy_setopt( m_CURL, CURLOPT_WRITEDATA, (void *)&m_Buffer );
+}
+
+
+KICAD_CURL_EASY::~KICAD_CURL_EASY()
+{
+    free(m_Buffer.payload);
+    curl_easy_cleanup(m_CURL);
+}
+
+
+bool KICAD_CURL_EASY::SetURL( const std::string& aURL )
+{
+    if( SetOption<const char *>( CURLOPT_URL, aURL.c_str() ) == CURLE_OK )
+    {
+        return true;
+    }
+    return false;
+}
+
+
+bool KICAD_CURL_EASY::SetUserAgent( const std::string& aAgent )
+{
+    if( SetOption<const char *>( CURLOPT_USERAGENT, aAgent.c_str() ) == CURLE_OK )
+    {
+        return true;
+    }
+    return false;
+}
+
+
+bool KICAD_CURL_EASY::SetFollowRedirects( bool aFollow )
+{
+    if( SetOption<long>( CURLOPT_FOLLOWLOCATION , (aFollow ? 1 : 0) ) == CURLE_OK )
+    {
+        return true;
+    }
+    return false;
+}
+
+
+void KICAD_CURL_EASY::SetHeader( const std::string& aName, const std::string& aValue )
+{
+    std::string header = aName + ':' + aValue;
+    m_headers = curl_slist_append( m_headers, header.c_str() );
+}
+
+
+std::string KICAD_CURL_EASY::GetErrorText(CURLcode code)
+{
+    return curl_easy_strerror(code);
+}
+
+
+static size_t write_callback( void *contents, size_t size, size_t nmemb, void *userp )
+{
+    /* calculate buffer size */
+    size_t realsize = size * nmemb;
+
+    /* cast pointer to fetch struct */
+    struct KICAD_EASY_CURL_BUFFER *p = ( struct KICAD_EASY_CURL_BUFFER * ) userp;
+
+    /* expand buffer */
+    p->payload = (char *) realloc( p->payload, p->size + realsize + 1 );
+
+    /* check buffer */
+    if ( p->payload == NULL )
+    {
+        wxLogError( wxT( "Failed to expand buffer in curl_callback" ) );
+
+        /* free buffer */
+        free( p->payload );
+
+        return -1;
+    }
+
+    /* copy contents to buffer */
+    memcpy( &(p->payload[p->size]), contents, realsize );
+
+    /* set new buffer size */
+    p->size += realsize;
+
+    /* ensure null termination */
+    p->payload[p->size] = 0;
+
+    /* return size */
+    return realsize;
+}
+
+
+void KICAD_CURL_EASY::Perform()
+{
+    if( m_headers != NULL )
+    {
+        curl_easy_setopt( m_CURL, CURLOPT_HTTPHEADER, m_headers );
+    }
+
+    if( m_Buffer.size > 0 )
+    {
+        free( m_Buffer.payload );
+        m_Buffer.payload = (char*)malloc( 1 );
+        m_Buffer.size = 0;
+    }
+
+    CURLcode res = curl_easy_perform( m_CURL );
+    if( res != CURLE_OK )
+    {
+        wxString msg = wxString::Format(
+            _( "CURL Request Failed: %s" ),
+            GetErrorText( res ) );
+
+        THROW_IO_ERROR( msg );
+    }
+}

common/kiway.cpp

@@ -212,7 +212,7 @@ KIFACE*  KIWAY::KiFACE( FACE_T aFaceId, bool doLoad )
         if( ! wxFileExists( dname ) )
             msg << wxT( "It is missing.\n" );
         else
-            msg << wxT( "Perhaps a wxWidgets shared (.dll or .so) file is missing.\n" );
+            msg << wxT( "Perhaps a shared library (.dll or .so) file is missing.\n" );
 
         msg << wxT( "From command line: argv[0]:\n'" );
         msg << wxStandardPaths::Get().GetExecutablePath() << wxT( "'\n" );

common/kiway_player.cpp

@@ -119,7 +119,6 @@ bool KIWAY_PLAYER::ShowModal( wxString* aResult, wxWindow* aResultantFocusWindow
             if( wlist[ii]->IsTopLevel() && wlist[ii]->IsEnabled() )
                 enabledTopLevelWindows.push_back( wlist[ii] );
 
-
         // exception safe way to disable all top level windows except the modal one,
         // re-enables only those that were disabled on exit
         wxWindowDisabler    toggle( this );

common/pgm_base.cpp

@@ -30,6 +30,7 @@
  *        (locale handling)
  */
 
+#include <kicad_curl/kicad_curl.h> /* Include before any wx file */
 #include <fctsys.h>
 #include <wx/html/htmlwin.h>
 #include <wx/fs_zip.h>
@@ -282,6 +283,7 @@ PGM_BASE::PGM_BASE()
 PGM_BASE::~PGM_BASE()
 {
     destroy();
+    KICAD_CURL::Cleanup();
 }
 
 
@@ -493,6 +495,13 @@ bool PGM_BASE::initPgm()
     wxSystemOptions::SetOption( wxOSX_FILEDIALOG_ALWAYS_SHOW_TYPES, 1 );
 #endif
 
+    // Initialize CURL
+    wxLogDebug( wxT( "Using %s" ), KICAD_CURL::GetVersion() );
+    if( !KICAD_CURL::Init() )
+    {
+        wxLogDebug( wxT( "Error initializing libcurl" ) );
+    }
+
     return true;
 }
 

cvpcb/class_DisplayFootprintsFrame.cpp

@@ -149,8 +149,10 @@ DISPLAY_FOOTPRINTS_FRAME::~DISPLAY_FOOTPRINTS_FRAME()
 
 void DISPLAY_FOOTPRINTS_FRAME::OnCloseWindow( wxCloseEvent& event )
 {
-    if( m_Draw3DFrame )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
-        m_Draw3DFrame->Close( true );
+
+    if( draw3DFrame )
+        draw3DFrame->Close( true );
 
     Destroy();
 }
@@ -382,25 +384,27 @@ bool DISPLAY_FOOTPRINTS_FRAME::GeneralControl( wxDC* aDC, const wxPoint& aPositi
 
 void DISPLAY_FOOTPRINTS_FRAME::Show3D_Frame( wxCommandEvent& event )
 {
-    if( m_Draw3DFrame )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
+
+    if( draw3DFrame )
     {
         // Raising the window does not show the window on Windows if iconized.
         // This should work on any platform.
-        if( m_Draw3DFrame->IsIconized() )
+        if( draw3DFrame->IsIconized() )
-             m_Draw3DFrame->Iconize( false );
+             draw3DFrame->Iconize( false );
 
-        m_Draw3DFrame->Raise();
+        draw3DFrame->Raise();
 
         // Raising the window does not set the focus on Linux.  This should work on any platform.
-        if( wxWindow::FindFocus() != m_Draw3DFrame )
+        if( wxWindow::FindFocus() != draw3DFrame )
-            m_Draw3DFrame->SetFocus();
+            draw3DFrame->SetFocus();
 
         return;
     }
 
-    m_Draw3DFrame = new EDA_3D_FRAME( &Kiway(), this, _( "3D Viewer" ) );
+    draw3DFrame = new EDA_3D_FRAME( &Kiway(), this, _( "3D Viewer" ) );
-    m_Draw3DFrame->Raise();     // Needed with some Window Managers
+    draw3DFrame->Raise();     // Needed with some Window Managers
-    m_Draw3DFrame->Show( true );
+    draw3DFrame->Show( true );
 }
 
 
@@ -489,7 +493,8 @@ void DISPLAY_FOOTPRINTS_FRAME::InitDisplay()
         msg.Printf( _( "Footprint: %s" ), GetChars( footprintName ) );
 
         SetTitle( msg );
-        const FOOTPRINT_INFO* module_info = parentframe->m_footprints.GetModuleInfo( footprintName );
+        const FOOTPRINT_INFO* module_info =
+                parentframe->m_footprints.GetModuleInfo( footprintName );
 
         const wxChar* libname;
 
@@ -530,8 +535,10 @@ void DISPLAY_FOOTPRINTS_FRAME::InitDisplay()
 
     GetCanvas()->Refresh();
 
-    if( m_Draw3DFrame )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
-        m_Draw3DFrame->NewDisplay();
+
+    if( draw3DFrame )
+        draw3DFrame->NewDisplay();
 }
 
 

cvpcb/cvframe.cpp

@@ -910,7 +910,8 @@ COMPONENT* CVPCB_MAINFRAME::GetSelectedComponent()
 DISPLAY_FOOTPRINTS_FRAME* CVPCB_MAINFRAME::GetFpViewerFrame()
 {
     // returns the Footprint Viewer frame, if exists, or NULL
-    return (DISPLAY_FOOTPRINTS_FRAME*) wxWindow::FindWindowByName( FOOTPRINTVIEWER_FRAME_NAME );
+    return dynamic_cast<DISPLAY_FOOTPRINTS_FRAME*>
+            ( wxWindow::FindWindowByName( FOOTPRINTVIEWER_FRAME_NAME ) );
 }
 
 

eeschema/class_drc_erc_item.cpp

@@ -54,6 +54,10 @@ wxString DRC_ITEM::GetErrorText() const
         return wxString( _("A no connect symbol is connected to more than 1 pin"));
     case ERCE_GLOBLABEL:
         return wxString( _("Global label not connected to any other global label") );
+    case ERCE_SIMILAR_LABELS:
+        return wxString( _("Labels are similar (lower/upper case difference only)") );
+    case ERCE_SIMILAR_GLBL_LABELS:
+        return wxString( _("Global labels are similar (lower/upper case difference only)") );
 
     default:
         return wxString( wxT("Unkown.") );

eeschema/class_libentry.cpp

@@ -886,7 +886,7 @@ bool LIB_PART::Load( LINE_READER& aLineReader, wxString& aErrorMsg )
         {
             p = strtok( line, " \t\n" );
 
-            if( stricmp( p, "ENDDEF" ) == 0 )
+            if( p && stricmp( p, "ENDDEF" ) == 0 )
                 break;
         }
 
@@ -948,6 +948,9 @@ bool LIB_PART::Load( LINE_READER& aLineReader, wxString& aErrorMsg )
         if( *line == '#' )      // a comment
             continue;
 
+        if( p == NULL )         // empty line
+            continue;
+
         if( line[0] == 'T'  &&  line[1] == 'i' )
             result = LoadDateAndTime( aLineReader );
         else if( *line == 'F' )
@@ -1036,7 +1039,12 @@ bool LIB_PART::LoadDrawEntries( LINE_READER& aLineReader, wxString& aErrorMsg )
             break;
 
         case '#':    // Comment
-                continue;
+            continue;
+
+        case '\n':
+        case '\r':
+        case 0:   // empty line
+            continue;
 
         default:
             aErrorMsg.Printf( wxT( "undefined DRAW command %c" ), line[0] );

eeschema/class_netlist_object.h

@@ -369,6 +369,32 @@ public:
      */
     void SortListbySheet();
 
+    /**
+     * Counts number of pins connected on the same net.
+     * Used to count all pins connected to a no connect symbol
+     * @return the pin count of the net starting at aNetStart
+     * @param aNetStart = index in list of net objects of the first item
+     */
+    int CountPinsInNet( unsigned aNetStart );
+
+    /**
+     * Function TestforNonOrphanLabel
+     * Sheet labels are expected to be connected to a hierarchical label.
+     * Hierarchical labels are expected to be connected to a sheet label.
+     * Global labels are expected to be not orphan (connected to at least one other global label.
+     * this function tests the connection to an other suitable label
+     */
+    void TestforNonOrphanLabel( unsigned aNetItemRef, unsigned aStartNet );
+
+    /**
+     * Function TestforSimilarLabels
+     * detects labels which are different when using case sensitive comparisons
+     * but are equal when using case insensitive comparisons
+     * It can be due to a mistake from designer, so this kind of labels
+     * is reported by TestforSimilarLabels
+     */
+    void TestforSimilarLabels();
+
 
     #if defined(DEBUG)
     void DumpNetTable()
@@ -403,7 +429,7 @@ private:
         return Objet1->GetNet() < Objet2->GetNet();
     }
 
-    /* Comparison routine to sort items by Sheet Number
+    /* Comparison routine to sort items by Sheet path
      */
     static bool sortItemsBySheet( const NETLIST_OBJECT* Objet1, const NETLIST_OBJECT* Objet2 )
     {

eeschema/component_tree_search_container.cpp

@@ -35,6 +35,8 @@
 #include <class_library.h>
 #include <macros.h>
 
+#include <eda_pattern_match.h>
+
 // Each node gets this lowest score initially, without any matches applied. Matches
 // will then increase this score depending on match quality.
 // This way, an empty search string will result in all components being displayed as they
@@ -113,6 +115,7 @@ COMPONENT_TREE_SEARCH_CONTAINER::~COMPONENT_TREE_SEARCH_CONTAINER()
 {
     BOOST_FOREACH( TREE_NODE* node, m_nodes )
         delete node;
+
     m_nodes.clear();
 }
 
@@ -225,12 +228,15 @@ LIB_ALIAS* COMPONENT_TREE_SEARCH_CONTAINER::GetSelectedAlias( int* aUnit )
 
     BOOST_FOREACH( TREE_NODE* node, m_nodes )
     {
-        if( node->MatchScore > 0 && node->TreeId == select_id ) {
+        if( node->MatchScore > 0 && node->TreeId == select_id )
+        {
             if( aUnit && node->Unit > 0 )
                 *aUnit = node->Unit;
+
             return node->Alias;
         }
     }
+
     return NULL;
 }
 
@@ -249,6 +255,72 @@ static int matchPosScore(int aPosition, int aMaximum)
 }
 
 
+namespace
+{
+class EDA_COMBINED_MATCHER
+{
+public:
+    EDA_COMBINED_MATCHER( const wxString &aPattern )
+    {
+        // Whatever syntax users prefer, it shall be matched.
+        AddMatcher( aPattern, new EDA_PATTERN_MATCH_REGEX() );
+        AddMatcher( aPattern, new EDA_PATTERN_MATCH_WILDCARD() );
+        // If any of the above matchers couldn't be created because the pattern
+        // syntax does not match, the substring will try its best.
+        AddMatcher( aPattern, new EDA_PATTERN_MATCH_SUBSTR() );
+    }
+
+    ~EDA_COMBINED_MATCHER()
+    {
+        BOOST_FOREACH( const EDA_PATTERN_MATCH* matcher, m_matchers )
+            delete matcher;
+    }
+
+    /*
+     * Look in all existing matchers, return the earliest match of any of
+     * the existing. Returns EDA_PATTERN_NOT_FOUND if no luck.
+     */
+    int Find( const wxString &aTerm, int *aMatchersTriggered )
+    {
+        int result = EDA_PATTERN_NOT_FOUND;
+
+        BOOST_FOREACH( const EDA_PATTERN_MATCH* matcher, m_matchers )
+        {
+            int local_find = matcher->Find( aTerm );
+
+            if ( local_find != EDA_PATTERN_NOT_FOUND )
+            {
+                *aMatchersTriggered += 1;
+
+                if ( local_find < result )
+                {
+                    result = local_find;
+                }
+            }
+        }
+
+        return result;
+    }
+
+private:
+    // Add matcher if it can compile the pattern.
+    void AddMatcher( const wxString &aPattern, EDA_PATTERN_MATCH *aMatcher )
+    {
+        if ( aMatcher->SetPattern( aPattern ) )
+        {
+            m_matchers.push_back( aMatcher );
+        }
+        else
+        {
+            delete aMatcher;
+        }
+    }
+
+    std::vector<const EDA_PATTERN_MATCH*> m_matchers;
+};
+}
+
+
 void COMPONENT_TREE_SEARCH_CONTAINER::UpdateSearchTerm( const wxString& aSearch )
 {
     if( m_tree == NULL )
@@ -286,6 +358,7 @@ void COMPONENT_TREE_SEARCH_CONTAINER::UpdateSearchTerm( const wxString& aSearch
     while ( tokenizer.HasMoreTokens() )
     {
         const wxString term = tokenizer.GetNextToken().Lower();
+        EDA_COMBINED_MATCHER matcher( term );
 
         BOOST_FOREACH( TREE_NODE* node, m_nodes )
         {
@@ -299,17 +372,18 @@ void COMPONENT_TREE_SEARCH_CONTAINER::UpdateSearchTerm( const wxString& aSearch
             // least two characters long. That avoids spurious, low quality
             // matches. Most abbreviations are at three characters long.
             int found_pos;
+            int matcher_fired = 0;
 
             if( term == node->MatchName )
                 node->MatchScore += 1000;  // exact match. High score :)
-            else if( (found_pos = node->MatchName.Find( term ) ) != wxNOT_FOUND )
+            else if( (found_pos = matcher.Find( node->MatchName, &matcher_fired ) ) != EDA_PATTERN_NOT_FOUND )
             {
                 // Substring match. The earlier in the string the better.  score += 20..40
                 node->MatchScore += matchPosScore( found_pos, 20 ) + 20;
             }
-            else if( node->Parent->MatchName.Find( term ) != wxNOT_FOUND )
+            else if( matcher.Find( node->Parent->MatchName, &matcher_fired ) != EDA_PATTERN_NOT_FOUND )
                 node->MatchScore += 19;   // parent name matches.         score += 19
-            else if( ( found_pos = node->SearchText.Find( term ) ) != wxNOT_FOUND )
+            else if( ( found_pos = matcher.Find( node->SearchText, &matcher_fired ) ) != EDA_PATTERN_NOT_FOUND )
             {
                 // If we have a very short search term (like one or two letters), we don't want
                 // to accumulate scores if they just happen to be in keywords or description as
@@ -322,6 +396,8 @@ void COMPONENT_TREE_SEARCH_CONTAINER::UpdateSearchTerm( const wxString& aSearch
             }
             else
                 node->MatchScore = 0;    // No match. That's it for this item.
+
+            node->MatchScore += 2 * matcher_fired;
         }
     }
 

eeschema/dialogs/dialog_erc.cpp

@@ -1,7 +1,7 @@
 /*
  * This program source code file is part of KiCad, a free EDA CAD application.
  *
- * Copyright (C) 2012 Jean-Pierre Charras, jp.charras at wanadoo.fr
+ * Copyright (C) 2015 Jean-Pierre Charras, jp.charras at wanadoo.fr
  * Copyright (C) 2012 Wayne Stambaugh <stambaughw@verizon.net>
  * Copyright (C) 1992-2015 KiCad Developers, see AUTHORS.txt for contributors.
  *
@@ -37,6 +37,7 @@
 #include <schframe.h>
 #include <invoke_sch_dialog.h>
 #include <project.h>
+#include <kiface_i.h>
 
 #include <netlist.h>
 #include <class_netlist_object.h>
@@ -48,10 +49,19 @@
 #include <erc.h>
 #include <id.h>
 
+extern int           DiagErc[PIN_NMAX][PIN_NMAX];
+extern int           DefaultDiagErc[PIN_NMAX][PIN_NMAX];
 
-bool DIALOG_ERC::m_writeErcFile = false;
 
 
+bool DIALOG_ERC::m_writeErcFile = false;            // saved only for the current session
+bool DIALOG_ERC::m_TestSimilarLabels = true;        // Save in project config
+bool DIALOG_ERC::m_diagErcTableInit = false;        // saved only for the current session
+bool DIALOG_ERC::m_tstUniqueGlobalLabels = true;    // saved only for the current session
+
+// Control identifiers for events
+#define ID_MATRIX_0 1800
+
 BEGIN_EVENT_TABLE( DIALOG_ERC, DIALOG_ERC_BASE )
     EVT_COMMAND_RANGE( ID_MATRIX_0, ID_MATRIX_0 + ( PIN_NMAX * PIN_NMAX ) - 1,
                        wxEVT_COMMAND_BUTTON_CLICKED, DIALOG_ERC::ChangeErrorLevel )
@@ -72,6 +82,8 @@ DIALOG_ERC::DIALOG_ERC( SCH_EDIT_FRAME* parent ) :
 
 DIALOG_ERC::~DIALOG_ERC()
 {
+    m_TestSimilarLabels = m_cbTestSimilarLabels->GetValue();
+    m_tstUniqueGlobalLabels = m_cbTestUniqueGlbLabels->GetValue();
 }
 
 
@@ -86,6 +98,8 @@ void DIALOG_ERC::Init()
     }
 
     m_WriteResultOpt->SetValue( m_writeErcFile );
+    m_cbTestSimilarLabels->SetValue( m_TestSimilarLabels );
+    m_cbTestUniqueGlbLabels->SetValue( m_tstUniqueGlobalLabels );
 
     SCH_SCREENS screens;
     updateMarkerCounts( &screens );
@@ -232,7 +246,7 @@ void DIALOG_ERC::OnLeftClickMarkersList( wxHtmlLinkEvent& event )
 
 void DIALOG_ERC::OnLeftDblClickMarkersList( wxMouseEvent& event )
 {
-    // Remember: OnLeftClickMarkersList was called just berfore
+    // Remember: OnLeftClickMarkersList was called just before
     // and therefore m_lastMarkerFound was initialized.
     // (NULL if not found)
     if( m_lastMarkerFound )
@@ -257,10 +271,10 @@ void DIALOG_ERC::ReBuildMatrixPanel()
     wxSize bitmap_size = dummy->GetSize();
     delete dummy;
 
-    if( !DiagErcTableInit )
+    if( !m_diagErcTableInit )
     {
         memcpy( DiagErc, DefaultDiagErc, sizeof(DefaultDiagErc) );
-        DiagErcTableInit = true;
+        m_diagErcTableInit = true;
     }
 
     wxPoint pos;
@@ -389,6 +403,10 @@ void DIALOG_ERC::ResetDefaultERCDiag( wxCommandEvent& event )
 {
     memcpy( DiagErc, DefaultDiagErc, sizeof( DiagErc ) );
     ReBuildMatrixPanel();
+    m_TestSimilarLabels = true;
+    m_cbTestSimilarLabels->SetValue( m_TestSimilarLabels );
+    m_tstUniqueGlobalLabels = true;
+    m_cbTestUniqueGlbLabels->SetValue( m_tstUniqueGlobalLabels );
 }
 
 
@@ -432,13 +450,9 @@ void DIALOG_ERC::TestErc( wxArrayString* aMessagesList )
 {
     wxFileName fn;
 
-    if( !DiagErcTableInit )
-    {
-        memcpy( DiagErc, DefaultDiagErc, sizeof( DefaultDiagErc ) );
-        DiagErcTableInit = true;
-    }
-
     m_writeErcFile = m_WriteResultOpt->GetValue();
+    m_TestSimilarLabels = m_cbTestSimilarLabels->GetValue();
+    m_tstUniqueGlobalLabels = m_cbTestUniqueGlbLabels->GetValue();
 
     // Build the whole sheet list in hierarchy (sheet, not screen)
     SCH_SHEET_LIST sheets;
@@ -511,12 +525,14 @@ void DIALOG_ERC::TestErc( wxArrayString* aMessagesList )
         case NET_HIERBUSLABELMEMBER:
         case NET_SHEETLABEL:
         case NET_SHEETBUSLABELMEMBER:
-        case NET_GLOBLABEL:
-
             // ERC problems when pin sheets do not match hierarchical labels.
             // Each pin sheet must match a hierarchical label
             // Each hierarchical label must match a pin sheet
-            TestLabel( objectsConnectedList.get(), net, nextNet );
+            objectsConnectedList->TestforNonOrphanLabel( net, nextNet );
+            break;
+        case NET_GLOBLABEL:
+            if( m_tstUniqueGlobalLabels )
+                objectsConnectedList->TestforNonOrphanLabel( net, nextNet );
             break;
 
         case NET_NOCONNECT:
@@ -524,7 +540,7 @@ void DIALOG_ERC::TestErc( wxArrayString* aMessagesList )
             // ERC problems when a noconnect symbol is connected to more than one pin.
             MinConn = NET_NC;
 
-            if( CountPinsInNet( objectsConnectedList.get(), nextNet ) > 1 )
+            if( objectsConnectedList->CountPinsInNet( nextNet ) > 1 )
                 Diagnose( objectsConnectedList->GetItem( net ), NULL, MinConn, UNC );
 
             break;
@@ -539,6 +555,11 @@ void DIALOG_ERC::TestErc( wxArrayString* aMessagesList )
         lastNet = net;
     }
 
+    // Test similar labels (i;e. labels which are identical when
+    // using case insensitive comparisons)
+    if( m_TestSimilarLabels )
+        objectsConnectedList->TestforSimilarLabels();
+
     // Displays global results:
     updateMarkerCounts( &screens );
 

eeschema/dialogs/dialog_erc.h

@@ -27,22 +27,12 @@
 
 #include <wx/htmllbox.h>
 #include <vector>
-
+#include <lib_pin.h>        // For PIN_NMAX definition
 
 #include <dialog_erc_base.h>
 #include "dialog_erc_listbox.h"
 
-/* Variable locales */
+// DIALOG_ERC class declaration
-extern int           DiagErc[PIN_NMAX][PIN_NMAX];
-extern bool          DiagErcTableInit; // go to true after DiagErc init
-extern int           DefaultDiagErc[PIN_NMAX][PIN_NMAX];
-
-/*  Control identifiers */
-#define ID_MATRIX_0 1800
-
-/*!
- * DIALOG_ERC class declaration
- */
 
 class DIALOG_ERC : public DIALOG_ERC_BASE
 {
@@ -54,6 +44,11 @@ private:
     bool            m_initialized;
     const SCH_MARKER* m_lastMarkerFound;
     static bool     m_writeErcFile;
+    static bool     m_diagErcTableInit; // go to true after DiagErc init
+    static bool     m_tstUniqueGlobalLabels;
+
+public:
+    static bool     m_TestSimilarLabels;
 
 public:
     DIALOG_ERC( SCH_EDIT_FRAME* parent );

eeschema/dialogs/dialog_erc_base.cpp

@@ -56,6 +56,9 @@ DIALOG_ERC_BASE::DIALOG_ERC_BASE( wxWindow* parent, wxWindowID id, const wxStrin
 	
 	sdiagSizer->Add( gSizeDiag, 0, wxEXPAND, 5 );
 	
+	m_staticline1 = new wxStaticLine( sdiagSizer->GetStaticBox(), wxID_ANY, wxDefaultPosition, wxDefaultSize, wxLI_HORIZONTAL );
+	sdiagSizer->Add( m_staticline1, 0, wxEXPAND|wxTOP|wxBOTTOM, 5 );
+	
 	m_WriteResultOpt = new wxCheckBox( sdiagSizer->GetStaticBox(), wxID_ANY, _("Create ERC file report"), wxDefaultPosition, wxDefaultSize, 0 );
 	sdiagSizer->Add( m_WriteResultOpt, 0, wxTOP|wxBOTTOM|wxRIGHT, 5 );
 	
@@ -83,7 +86,7 @@ DIALOG_ERC_BASE::DIALOG_ERC_BASE( wxWindow* parent, wxWindowID id, const wxStrin
 	bercSizer->Add( m_textMarkers, 0, wxTOP|wxRIGHT|wxLEFT, 5 );
 	
 	m_MarkersList = new ERC_HTML_LISTFRAME( m_PanelERC, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxHW_SCROLLBAR_AUTO|wxSUNKEN_BORDER );
-	bercSizer->Add( m_MarkersList, 1, wxALL|wxEXPAND, 5 );
+	bercSizer->Add( m_MarkersList, 1, wxEXPAND|wxALL, 5 );
 	
 	wxBoxSizer* bbuttonsSizer;
 	bbuttonsSizer = new wxBoxSizer( wxHORIZONTAL );
@@ -113,9 +116,30 @@ DIALOG_ERC_BASE::DIALOG_ERC_BASE( wxWindow* parent, wxWindowID id, const wxStrin
 	m_ResetOptButton = new wxButton( m_PanelERCOptions, ID_RESET_MATRIX, _("Initialize to Default"), wxDefaultPosition, wxDefaultSize, 0 );
 	m_panelMatrixSizer->Add( m_ResetOptButton, 0, wxALIGN_RIGHT|wxTOP|wxRIGHT|wxLEFT, 5 );
 	
+	m_staticText8 = new wxStaticText( m_PanelERCOptions, wxID_ANY, _("Pin to pin connections"), wxDefaultPosition, wxDefaultSize, wxALIGN_CENTRE );
+	m_staticText8->Wrap( -1 );
+	m_panelMatrixSizer->Add( m_staticText8, 0, wxRIGHT|wxLEFT|wxEXPAND, 5 );
+	
 	m_matrixPanel = new wxPanel( m_PanelERCOptions, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxTAB_TRAVERSAL );
 	m_panelMatrixSizer->Add( m_matrixPanel, 1, wxEXPAND | wxALL, 5 );
 	
+	m_staticline2 = new wxStaticLine( m_PanelERCOptions, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxLI_HORIZONTAL );
+	m_panelMatrixSizer->Add( m_staticline2, 0, wxEXPAND|wxTOP|wxBOTTOM, 5 );
+	
+	m_staticText9 = new wxStaticText( m_PanelERCOptions, wxID_ANY, _("Label to label connections"), wxDefaultPosition, wxDefaultSize, wxALIGN_CENTRE );
+	m_staticText9->Wrap( -1 );
+	m_panelMatrixSizer->Add( m_staticText9, 0, wxBOTTOM|wxRIGHT|wxLEFT|wxEXPAND, 5 );
+	
+	m_cbTestSimilarLabels = new wxCheckBox( m_PanelERCOptions, wxID_ANY, _("Test similar labels"), wxDefaultPosition, wxDefaultSize, 0 );
+	m_cbTestSimilarLabels->SetToolTip( _("Similar labels are labels (inside a sheet) which differs only by upper/lower case") );
+	
+	m_panelMatrixSizer->Add( m_cbTestSimilarLabels, 0, wxALL, 5 );
+	
+	m_cbTestUniqueGlbLabels = new wxCheckBox( m_PanelERCOptions, wxID_ANY, _("Test unique global labels"), wxDefaultPosition, wxDefaultSize, 0 );
+	m_cbTestUniqueGlbLabels->SetToolTip( _("Global labels are used to connect signals across the full hierarchy.\nThey are expected to be at least two labels with the same name.") );
+	
+	m_panelMatrixSizer->Add( m_cbTestUniqueGlbLabels, 0, wxALL, 5 );
+	
 	
 	m_PanelERCOptions->SetSizer( m_panelMatrixSizer );
 	m_PanelERCOptions->Layout();

eeschema/dialogs/dialog_erc_base.fbp

@@ -44,7 +44,7 @@
             <property name="minimum_size"></property>
             <property name="name">DIALOG_ERC_BASE</property>
             <property name="pos"></property>
-            <property name="size">519,457</property>
+            <property name="size">519,464</property>
             <property name="style">wxDEFAULT_DIALOG_STYLE|wxRESIZE_BORDER</property>
             <property name="subclass">DIALOG_SHIM; dialog_shim.h</property>
             <property name="title">Electrical Rules Checker</property>
@@ -815,6 +815,87 @@
                                                             </object>
                                                         </object>
                                                     </object>
+                                                    <object class="sizeritem" expanded="1">
+                                                        <property name="border">5</property>
+                                                        <property name="flag">wxEXPAND|wxTOP|wxBOTTOM</property>
+                                                        <property name="proportion">0</property>
+                                                        <object class="wxStaticLine" expanded="1">
+                                                            <property name="BottomDockable">1</property>
+                                                            <property name="LeftDockable">1</property>
+                                                            <property name="RightDockable">1</property>
+                                                            <property name="TopDockable">1</property>
+                                                            <property name="aui_layer"></property>
+                                                            <property name="aui_name"></property>
+                                                            <property name="aui_position"></property>
+                                                            <property name="aui_row"></property>
+                                                            <property name="best_size"></property>
+                                                            <property name="bg"></property>
+                                                            <property name="caption"></property>
+                                                            <property name="caption_visible">1</property>
+                                                            <property name="center_pane">0</property>
+                                                            <property name="close_button">1</property>
+                                                            <property name="context_help"></property>
+                                                            <property name="context_menu">1</property>
+                                                            <property name="default_pane">0</property>
+                                                            <property name="dock">Dock</property>
+                                                            <property name="dock_fixed">0</property>
+                                                            <property name="docking">Left</property>
+                                                            <property name="enabled">1</property>
+                                                            <property name="fg"></property>
+                                                            <property name="floatable">1</property>
+                                                            <property name="font"></property>
+                                                            <property name="gripper">0</property>
+                                                            <property name="hidden">0</property>
+                                                            <property name="id">wxID_ANY</property>
+                                                            <property name="max_size"></property>
+                                                            <property name="maximize_button">0</property>
+                                                            <property name="maximum_size"></property>
+                                                            <property name="min_size"></property>
+                                                            <property name="minimize_button">0</property>
+                                                            <property name="minimum_size"></property>
+                                                            <property name="moveable">1</property>
+                                                            <property name="name">m_staticline1</property>
+                                                            <property name="pane_border">1</property>
+                                                            <property name="pane_position"></property>
+                                                            <property name="pane_size"></property>
+                                                            <property name="permission">protected</property>
+                                                            <property name="pin_button">1</property>
+                                                            <property name="pos"></property>
+                                                            <property name="resize">Resizable</property>
+                                                            <property name="show">1</property>
+                                                            <property name="size"></property>
+                                                            <property name="style">wxLI_HORIZONTAL</property>
+                                                            <property name="subclass"></property>
+                                                            <property name="toolbar_pane">0</property>
+                                                            <property name="tooltip"></property>
+                                                            <property name="window_extra_style"></property>
+                                                            <property name="window_name"></property>
+                                                            <property name="window_style"></property>
+                                                            <event name="OnChar"></event>
+                                                            <event name="OnEnterWindow"></event>
+                                                            <event name="OnEraseBackground"></event>
+                                                            <event name="OnKeyDown"></event>
+                                                            <event name="OnKeyUp"></event>
+                                                            <event name="OnKillFocus"></event>
+                                                            <event name="OnLeaveWindow"></event>
+                                                            <event name="OnLeftDClick"></event>
+                                                            <event name="OnLeftDown"></event>
+                                                            <event name="OnLeftUp"></event>
+                                                            <event name="OnMiddleDClick"></event>
+                                                            <event name="OnMiddleDown"></event>
+                                                            <event name="OnMiddleUp"></event>
+                                                            <event name="OnMotion"></event>
+                                                            <event name="OnMouseEvents"></event>
+                                                            <event name="OnMouseWheel"></event>
+                                                            <event name="OnPaint"></event>
+                                                            <event name="OnRightDClick"></event>
+                                                            <event name="OnRightDown"></event>
+                                                            <event name="OnRightUp"></event>
+                                                            <event name="OnSetFocus"></event>
+                                                            <event name="OnSize"></event>
+                                                            <event name="OnUpdateUI"></event>
+                                                        </object>
+                                                    </object>
                                                     <object class="sizeritem" expanded="0">
                                                         <property name="border">5</property>
                                                         <property name="flag">wxTOP|wxBOTTOM|wxRIGHT</property>
@@ -1177,7 +1258,7 @@
                                     </object>
                                     <object class="sizeritem" expanded="1">
                                         <property name="border">5</property>
-                                        <property name="flag">wxALL|wxEXPAND</property>
+                                        <property name="flag">wxEXPAND|wxALL</property>
                                         <property name="proportion">1</property>
                                         <object class="wxHtmlWindow" expanded="1">
                                             <property name="BottomDockable">1</property>
@@ -1708,6 +1789,89 @@
                                             <event name="OnUpdateUI"></event>
                                         </object>
                                     </object>
+                                    <object class="sizeritem" expanded="1">
+                                        <property name="border">5</property>
+                                        <property name="flag">wxRIGHT|wxLEFT|wxEXPAND</property>
+                                        <property name="proportion">0</property>
+                                        <object class="wxStaticText" expanded="1">
+                                            <property name="BottomDockable">1</property>
+                                            <property name="LeftDockable">1</property>
+                                            <property name="RightDockable">1</property>
+                                            <property name="TopDockable">1</property>
+                                            <property name="aui_layer"></property>
+                                            <property name="aui_name"></property>
+                                            <property name="aui_position"></property>
+                                            <property name="aui_row"></property>
+                                            <property name="best_size"></property>
+                                            <property name="bg"></property>
+                                            <property name="caption"></property>
+                                            <property name="caption_visible">1</property>
+                                            <property name="center_pane">0</property>
+                                            <property name="close_button">1</property>
+                                            <property name="context_help"></property>
+                                            <property name="context_menu">1</property>
+                                            <property name="default_pane">0</property>
+                                            <property name="dock">Dock</property>
+                                            <property name="dock_fixed">0</property>
+                                            <property name="docking">Left</property>
+                                            <property name="enabled">1</property>
+                                            <property name="fg"></property>
+                                            <property name="floatable">1</property>
+                                            <property name="font"></property>
+                                            <property name="gripper">0</property>
+                                            <property name="hidden">0</property>
+                                            <property name="id">wxID_ANY</property>
+                                            <property name="label">Pin to pin connections</property>
+                                            <property name="max_size"></property>
+                                            <property name="maximize_button">0</property>
+                                            <property name="maximum_size"></property>
+                                            <property name="min_size"></property>
+                                            <property name="minimize_button">0</property>
+                                            <property name="minimum_size"></property>
+                                            <property name="moveable">1</property>
+                                            <property name="name">m_staticText8</property>
+                                            <property name="pane_border">1</property>
+                                            <property name="pane_position"></property>
+                                            <property name="pane_size"></property>
+                                            <property name="permission">protected</property>
+                                            <property name="pin_button">1</property>
+                                            <property name="pos"></property>
+                                            <property name="resize">Resizable</property>
+                                            <property name="show">1</property>
+                                            <property name="size"></property>
+                                            <property name="style">wxALIGN_CENTRE</property>
+                                            <property name="subclass"></property>
+                                            <property name="toolbar_pane">0</property>
+                                            <property name="tooltip"></property>
+                                            <property name="window_extra_style"></property>
+                                            <property name="window_name"></property>
+                                            <property name="window_style"></property>
+                                            <property name="wrap">-1</property>
+                                            <event name="OnChar"></event>
+                                            <event name="OnEnterWindow"></event>
+                                            <event name="OnEraseBackground"></event>
+                                            <event name="OnKeyDown"></event>
+                                            <event name="OnKeyUp"></event>
+                                            <event name="OnKillFocus"></event>
+                                            <event name="OnLeaveWindow"></event>
+                                            <event name="OnLeftDClick"></event>
+                                            <event name="OnLeftDown"></event>
+                                            <event name="OnLeftUp"></event>
+                                            <event name="OnMiddleDClick"></event>
+                                            <event name="OnMiddleDown"></event>
+                                            <event name="OnMiddleUp"></event>
+                                            <event name="OnMotion"></event>
+                                            <event name="OnMouseEvents"></event>
+                                            <event name="OnMouseWheel"></event>
+                                            <event name="OnPaint"></event>
+                                            <event name="OnRightDClick"></event>
+                                            <event name="OnRightDown"></event>
+                                            <event name="OnRightUp"></event>
+                                            <event name="OnSetFocus"></event>
+                                            <event name="OnSize"></event>
+                                            <event name="OnUpdateUI"></event>
+                                        </object>
+                                    </object>
                                     <object class="sizeritem" expanded="1">
                                         <property name="border">5</property>
                                         <property name="flag">wxEXPAND | wxALL</property>
@@ -1788,6 +1952,346 @@
                                             <event name="OnUpdateUI"></event>
                                         </object>
                                     </object>
+                                    <object class="sizeritem" expanded="1">
+                                        <property name="border">5</property>
+                                        <property name="flag">wxEXPAND|wxTOP|wxBOTTOM</property>
+                                        <property name="proportion">0</property>
+                                        <object class="wxStaticLine" expanded="1">
+                                            <property name="BottomDockable">1</property>
+                                            <property name="LeftDockable">1</property>
+                                            <property name="RightDockable">1</property>
+                                            <property name="TopDockable">1</property>
+                                            <property name="aui_layer"></property>
+                                            <property name="aui_name"></property>
+                                            <property name="aui_position"></property>
+                                            <property name="aui_row"></property>
+                                            <property name="best_size"></property>
+                                            <property name="bg"></property>
+                                            <property name="caption"></property>
+                                            <property name="caption_visible">1</property>
+                                            <property name="center_pane">0</property>
+                                            <property name="close_button">1</property>
+                                            <property name="context_help"></property>
+                                            <property name="context_menu">1</property>
+                                            <property name="default_pane">0</property>
+                                            <property name="dock">Dock</property>
+                                            <property name="dock_fixed">0</property>
+                                            <property name="docking">Left</property>
+                                            <property name="enabled">1</property>
+                                            <property name="fg"></property>
+                                            <property name="floatable">1</property>
+                                            <property name="font"></property>
+                                            <property name="gripper">0</property>
+                                            <property name="hidden">0</property>
+                                            <property name="id">wxID_ANY</property>
+                                            <property name="max_size"></property>
+                                            <property name="maximize_button">0</property>
+                                            <property name="maximum_size"></property>
+                                            <property name="min_size"></property>
+                                            <property name="minimize_button">0</property>
+                                            <property name="minimum_size"></property>
+                                            <property name="moveable">1</property>
+                                            <property name="name">m_staticline2</property>
+                                            <property name="pane_border">1</property>
+                                            <property name="pane_position"></property>
+                                            <property name="pane_size"></property>
+                                            <property name="permission">protected</property>
+                                            <property name="pin_button">1</property>
+                                            <property name="pos"></property>
+                                            <property name="resize">Resizable</property>
+                                            <property name="show">1</property>
+                                            <property name="size"></property>
+                                            <property name="style">wxLI_HORIZONTAL</property>
+                                            <property name="subclass"></property>
+                                            <property name="toolbar_pane">0</property>
+                                            <property name="tooltip"></property>
+                                            <property name="window_extra_style"></property>
+                                            <property name="window_name"></property>
+                                            <property name="window_style"></property>
+                                            <event name="OnChar"></event>
+                                            <event name="OnEnterWindow"></event>
+                                            <event name="OnEraseBackground"></event>
+                                            <event name="OnKeyDown"></event>
+                                            <event name="OnKeyUp"></event>
+                                            <event name="OnKillFocus"></event>
+                                            <event name="OnLeaveWindow"></event>
+                                            <event name="OnLeftDClick"></event>
+                                            <event name="OnLeftDown"></event>
+                                            <event name="OnLeftUp"></event>
+                                            <event name="OnMiddleDClick"></event>
+                                            <event name="OnMiddleDown"></event>
+                                            <event name="OnMiddleUp"></event>
+                                            <event name="OnMotion"></event>
+                                            <event name="OnMouseEvents"></event>
+                                            <event name="OnMouseWheel"></event>
+                                            <event name="OnPaint"></event>
+                                            <event name="OnRightDClick"></event>
+                                            <event name="OnRightDown"></event>
+                                            <event name="OnRightUp"></event>
+                                            <event name="OnSetFocus"></event>
+                                            <event name="OnSize"></event>
+                                            <event name="OnUpdateUI"></event>
+                                        </object>
+                                    </object>
+                                    <object class="sizeritem" expanded="1">
+                                        <property name="border">5</property>
+                                        <property name="flag">wxBOTTOM|wxRIGHT|wxLEFT|wxEXPAND</property>
+                                        <property name="proportion">0</property>
+                                        <object class="wxStaticText" expanded="1">
+                                            <property name="BottomDockable">1</property>
+                                            <property name="LeftDockable">1</property>
+                                            <property name="RightDockable">1</property>
+                                            <property name="TopDockable">1</property>
+                                            <property name="aui_layer"></property>
+                                            <property name="aui_name"></property>
+                                            <property name="aui_position"></property>
+                                            <property name="aui_row"></property>
+                                            <property name="best_size"></property>
+                                            <property name="bg"></property>
+                                            <property name="caption"></property>
+                                            <property name="caption_visible">1</property>
+                                            <property name="center_pane">0</property>
+                                            <property name="close_button">1</property>
+                                            <property name="context_help"></property>
+                                            <property name="context_menu">1</property>
+                                            <property name="default_pane">0</property>
+                                            <property name="dock">Dock</property>
+                                            <property name="dock_fixed">0</property>
+                                            <property name="docking">Left</property>
+                                            <property name="enabled">1</property>
+                                            <property name="fg"></property>
+                                            <property name="floatable">1</property>
+                                            <property name="font"></property>
+                                            <property name="gripper">0</property>
+                                            <property name="hidden">0</property>
+                                            <property name="id">wxID_ANY</property>
+                                            <property name="label">Label to label connections</property>
+                                            <property name="max_size"></property>
+                                            <property name="maximize_button">0</property>
+                                            <property name="maximum_size"></property>
+                                            <property name="min_size"></property>
+                                            <property name="minimize_button">0</property>
+                                            <property name="minimum_size"></property>
+                                            <property name="moveable">1</property>
+                                            <property name="name">m_staticText9</property>
+                                            <property name="pane_border">1</property>
+                                            <property name="pane_position"></property>
+                                            <property name="pane_size"></property>
+                                            <property name="permission">protected</property>
+                                            <property name="pin_button">1</property>
+                                            <property name="pos"></property>
+                                            <property name="resize">Resizable</property>
+                                            <property name="show">1</property>
+                                            <property name="size"></property>
+                                            <property name="style">wxALIGN_CENTRE</property>
+                                            <property name="subclass"></property>
+                                            <property name="toolbar_pane">0</property>
+                                            <property name="tooltip"></property>
+                                            <property name="window_extra_style"></property>
+                                            <property name="window_name"></property>
+                                            <property name="window_style"></property>
+                                            <property name="wrap">-1</property>
+                                            <event name="OnChar"></event>
+                                            <event name="OnEnterWindow"></event>
+                                            <event name="OnEraseBackground"></event>
+                                            <event name="OnKeyDown"></event>
+                                            <event name="OnKeyUp"></event>
+                                            <event name="OnKillFocus"></event>
+                                            <event name="OnLeaveWindow"></event>
+                                            <event name="OnLeftDClick"></event>
+                                            <event name="OnLeftDown"></event>
+                                            <event name="OnLeftUp"></event>
+                                            <event name="OnMiddleDClick"></event>
+                                            <event name="OnMiddleDown"></event>
+                                            <event name="OnMiddleUp"></event>
+                                            <event name="OnMotion"></event>
+                                            <event name="OnMouseEvents"></event>
+                                            <event name="OnMouseWheel"></event>
+                                            <event name="OnPaint"></event>
+                                            <event name="OnRightDClick"></event>
+                                            <event name="OnRightDown"></event>
+                                            <event name="OnRightUp"></event>
+                                            <event name="OnSetFocus"></event>
+                                            <event name="OnSize"></event>
+                                            <event name="OnUpdateUI"></event>
+                                        </object>
+                                    </object>
+                                    <object class="sizeritem" expanded="1">
+                                        <property name="border">5</property>
+                                        <property name="flag">wxALL</property>
+                                        <property name="proportion">0</property>
+                                        <object class="wxCheckBox" expanded="1">
+                                            <property name="BottomDockable">1</property>
+                                            <property name="LeftDockable">1</property>
+                                            <property name="RightDockable">1</property>
+                                            <property name="TopDockable">1</property>
+                                            <property name="aui_layer"></property>
+                                            <property name="aui_name"></property>
+                                            <property name="aui_position"></property>
+                                            <property name="aui_row"></property>
+                                            <property name="best_size"></property>
+                                            <property name="bg"></property>
+                                            <property name="caption"></property>
+                                            <property name="caption_visible">1</property>
+                                            <property name="center_pane">0</property>
+                                            <property name="checked">0</property>
+                                            <property name="close_button">1</property>
+                                            <property name="context_help"></property>
+                                            <property name="context_menu">1</property>
+                                            <property name="default_pane">0</property>
+                                            <property name="dock">Dock</property>
+                                            <property name="dock_fixed">0</property>
+                                            <property name="docking">Left</property>
+                                            <property name="enabled">1</property>
+                                            <property name="fg"></property>
+                                            <property name="floatable">1</property>
+                                            <property name="font"></property>
+                                            <property name="gripper">0</property>
+                                            <property name="hidden">0</property>
+                                            <property name="id">wxID_ANY</property>
+                                            <property name="label">Test similar labels</property>
+                                            <property name="max_size"></property>
+                                            <property name="maximize_button">0</property>
+                                            <property name="maximum_size"></property>
+                                            <property name="min_size"></property>
+                                            <property name="minimize_button">0</property>
+                                            <property name="minimum_size"></property>
+                                            <property name="moveable">1</property>
+                                            <property name="name">m_cbTestSimilarLabels</property>
+                                            <property name="pane_border">1</property>
+                                            <property name="pane_position"></property>
+                                            <property name="pane_size"></property>
+                                            <property name="permission">protected</property>
+                                            <property name="pin_button">1</property>
+                                            <property name="pos"></property>
+                                            <property name="resize">Resizable</property>
+                                            <property name="show">1</property>
+                                            <property name="size"></property>
+                                            <property name="style"></property>
+                                            <property name="subclass"></property>
+                                            <property name="toolbar_pane">0</property>
+                                            <property name="tooltip">Similar labels are labels (inside a sheet) which differs only by upper/lower case</property>
+                                            <property name="validator_data_type"></property>
+                                            <property name="validator_style">wxFILTER_NONE</property>
+                                            <property name="validator_type">wxDefaultValidator</property>
+                                            <property name="validator_variable"></property>
+                                            <property name="window_extra_style"></property>
+                                            <property name="window_name"></property>
+                                            <property name="window_style"></property>
+                                            <event name="OnChar"></event>
+                                            <event name="OnCheckBox"></event>
+                                            <event name="OnEnterWindow"></event>
+                                            <event name="OnEraseBackground"></event>
+                                            <event name="OnKeyDown"></event>
+                                            <event name="OnKeyUp"></event>
+                                            <event name="OnKillFocus"></event>
+                                            <event name="OnLeaveWindow"></event>
+                                            <event name="OnLeftDClick"></event>
+                                            <event name="OnLeftDown"></event>
+                                            <event name="OnLeftUp"></event>
+                                            <event name="OnMiddleDClick"></event>
+                                            <event name="OnMiddleDown"></event>
+                                            <event name="OnMiddleUp"></event>
+                                            <event name="OnMotion"></event>
+                                            <event name="OnMouseEvents"></event>
+                                            <event name="OnMouseWheel"></event>
+                                            <event name="OnPaint"></event>
+                                            <event name="OnRightDClick"></event>
+                                            <event name="OnRightDown"></event>
+                                            <event name="OnRightUp"></event>
+                                            <event name="OnSetFocus"></event>
+                                            <event name="OnSize"></event>
+                                            <event name="OnUpdateUI"></event>
+                                        </object>
+                                    </object>
+                                    <object class="sizeritem" expanded="1">
+                                        <property name="border">5</property>
+                                        <property name="flag">wxALL</property>
+                                        <property name="proportion">0</property>
+                                        <object class="wxCheckBox" expanded="1">
+                                            <property name="BottomDockable">1</property>
+                                            <property name="LeftDockable">1</property>
+                                            <property name="RightDockable">1</property>
+                                            <property name="TopDockable">1</property>
+                                            <property name="aui_layer"></property>
+                                            <property name="aui_name"></property>
+                                            <property name="aui_position"></property>
+                                            <property name="aui_row"></property>
+                                            <property name="best_size"></property>
+                                            <property name="bg"></property>
+                                            <property name="caption"></property>
+                                            <property name="caption_visible">1</property>
+                                            <property name="center_pane">0</property>
+                                            <property name="checked">0</property>
+                                            <property name="close_button">1</property>
+                                            <property name="context_help"></property>
+                                            <property name="context_menu">1</property>
+                                            <property name="default_pane">0</property>
+                                            <property name="dock">Dock</property>
+                                            <property name="dock_fixed">0</property>
+                                            <property name="docking">Left</property>
+                                            <property name="enabled">1</property>
+                                            <property name="fg"></property>
+                                            <property name="floatable">1</property>
+                                            <property name="font"></property>
+                                            <property name="gripper">0</property>
+                                            <property name="hidden">0</property>
+                                            <property name="id">wxID_ANY</property>
+                                            <property name="label">Test unique global labels</property>
+                                            <property name="max_size"></property>
+                                            <property name="maximize_button">0</property>
+                                            <property name="maximum_size"></property>
+                                            <property name="min_size"></property>
+                                            <property name="minimize_button">0</property>
+                                            <property name="minimum_size"></property>
+                                            <property name="moveable">1</property>
+                                            <property name="name">m_cbTestUniqueGlbLabels</property>
+                                            <property name="pane_border">1</property>
+                                            <property name="pane_position"></property>
+                                            <property name="pane_size"></property>
+                                            <property name="permission">protected</property>
+                                            <property name="pin_button">1</property>
+                                            <property name="pos"></property>
+                                            <property name="resize">Resizable</property>
+                                            <property name="show">1</property>
+                                            <property name="size"></property>
+                                            <property name="style"></property>
+                                            <property name="subclass"></property>
+                                            <property name="toolbar_pane">0</property>
+                                            <property name="tooltip">Global labels are used to connect signals across the full hierarchy.&#x0A;They are expected to be at least two labels with the same name.</property>
+                                            <property name="validator_data_type"></property>
+                                            <property name="validator_style">wxFILTER_NONE</property>
+                                            <property name="validator_type">wxDefaultValidator</property>
+                                            <property name="validator_variable"></property>
+                                            <property name="window_extra_style"></property>
+                                            <property name="window_name"></property>
+                                            <property name="window_style"></property>
+                                            <event name="OnChar"></event>
+                                            <event name="OnCheckBox"></event>
+                                            <event name="OnEnterWindow"></event>
+                                            <event name="OnEraseBackground"></event>
+                                            <event name="OnKeyDown"></event>
+                                            <event name="OnKeyUp"></event>
+                                            <event name="OnKillFocus"></event>
+                                            <event name="OnLeaveWindow"></event>
+                                            <event name="OnLeftDClick"></event>
+                                            <event name="OnLeftDown"></event>
+                                            <event name="OnLeftUp"></event>
+                                            <event name="OnMiddleDClick"></event>
+                                            <event name="OnMiddleDown"></event>
+                                            <event name="OnMiddleUp"></event>
+                                            <event name="OnMotion"></event>
+                                            <event name="OnMouseEvents"></event>
+                                            <event name="OnMouseWheel"></event>
+                                            <event name="OnPaint"></event>
+                                            <event name="OnRightDClick"></event>
+                                            <event name="OnRightDown"></event>
+                                            <event name="OnRightUp"></event>
+                                            <event name="OnSetFocus"></event>
+                                            <event name="OnSize"></event>
+                                            <event name="OnUpdateUI"></event>
+                                        </object>
+                                    </object>
                                 </object>
                             </object>
                         </object>

eeschema/dialogs/dialog_erc_base.h

@@ -23,6 +23,7 @@ class ERC_HTML_LISTFRAME;
 #include <wx/settings.h>
 #include <wx/textctrl.h>
 #include <wx/sizer.h>
+#include <wx/statline.h>
 #include <wx/checkbox.h>
 #include <wx/statbox.h>
 #include <wx/html/htmlwin.h>
@@ -56,6 +57,7 @@ class DIALOG_ERC_BASE : public DIALOG_SHIM
 		wxTextCtrl* m_LastWarningCount;
 		wxStaticText* m_LastErrCountText;
 		wxTextCtrl* m_LastErrCount;
+		wxStaticLine* m_staticline1;
 		wxCheckBox* m_WriteResultOpt;
 		wxStaticText* m_titleMessages;
 		wxTextCtrl* m_MessagesList;
@@ -66,7 +68,12 @@ class DIALOG_ERC_BASE : public DIALOG_SHIM
 		wxButton* m_buttonClose;
 		wxPanel* m_PanelERCOptions;
 		wxButton* m_ResetOptButton;
+		wxStaticText* m_staticText8;
 		wxPanel* m_matrixPanel;
+		wxStaticLine* m_staticline2;
+		wxStaticText* m_staticText9;
+		wxCheckBox* m_cbTestSimilarLabels;
+		wxCheckBox* m_cbTestUniqueGlbLabels;
 		
 		// Virtual event handlers, overide them in your derived class
 		virtual void OnCloseErcDialog( wxCloseEvent& event ) { event.Skip(); }
@@ -80,7 +87,7 @@ class DIALOG_ERC_BASE : public DIALOG_SHIM
 	
 	public:
 		
-		DIALOG_ERC_BASE( wxWindow* parent, wxWindowID id = wxID_ANY, const wxString& title = _("Electrical Rules Checker"), const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxSize( 519,457 ), long style = wxDEFAULT_DIALOG_STYLE|wxRESIZE_BORDER ); 
+		DIALOG_ERC_BASE( wxWindow* parent, wxWindowID id = wxID_ANY, const wxString& title = _("Electrical Rules Checker"), const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxSize( 519,464 ), long style = wxDEFAULT_DIALOG_STYLE|wxRESIZE_BORDER ); 
 		~DIALOG_ERC_BASE();
 	
 };

eeschema/dialogs/dialog_plot_schematic_base.cpp

@@ -18,33 +18,33 @@ DIALOG_PLOT_SCHEMATIC_BASE::DIALOG_PLOT_SCHEMATIC_BASE( wxWindow* parent, wxWind
 	wxBoxSizer* bMainSizer;
 	bMainSizer = new wxBoxSizer( wxVERTICAL );
 	
-	wxBoxSizer* bSizer6;
+	wxBoxSizer* bSizerDir;
-	bSizer6 = new wxBoxSizer( wxVERTICAL );
+	bSizerDir = new wxBoxSizer( wxHORIZONTAL );
 	
 	m_staticTextOutputDirectory = new wxStaticText( this, wxID_ANY, _("Output directory:"), wxDefaultPosition, wxDefaultSize, 0 );
 	m_staticTextOutputDirectory->Wrap( -1 );
-	bSizer6->Add( m_staticTextOutputDirectory, 0, wxALL, 5 );
+	bSizerDir->Add( m_staticTextOutputDirectory, 0, wxALL|wxALIGN_CENTER_VERTICAL, 5 );
-	
-	wxBoxSizer* bSizer5;
-	bSizer5 = new wxBoxSizer( wxHORIZONTAL );
 	
 	m_outputDirectoryName = new wxTextCtrl( this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxDefaultSize, 0 );
 	m_outputDirectoryName->SetMaxLength( 0 ); 
 	m_outputDirectoryName->SetToolTip( _("Target directory for plot files. Can be absolute or relative to the schematic main file location.") );
 	
-	bSizer5->Add( m_outputDirectoryName, 1, wxEXPAND|wxLEFT|wxRIGHT, 5 );
+	bSizerDir->Add( m_outputDirectoryName, 1, wxALL|wxALIGN_CENTER_VERTICAL, 5 );
 	
 	m_browseButton = new wxButton( this, wxID_ANY, _("Browse..."), wxDefaultPosition, wxDefaultSize, 0 );
-	bSizer5->Add( m_browseButton, 0, wxALIGN_CENTER_VERTICAL|wxLEFT|wxRIGHT, 5 );
+	bSizerDir->Add( m_browseButton, 0, wxALL|wxALIGN_CENTER_VERTICAL, 5 );
 	
 	
-	bSizer6->Add( bSizer5, 1, wxEXPAND, 5 );
+	bMainSizer->Add( bSizerDir, 0, wxBOTTOM|wxEXPAND, 10 );
-	
-	
-	bMainSizer->Add( bSizer6, 0, wxEXPAND|wxLEFT|wxTOP, 5 );
 	
 	m_optionsSizer = new wxBoxSizer( wxHORIZONTAL );
 	
+	wxString m_plotFormatOptChoices[] = { _("Postscript"), _("PDF"), _("SVG"), _("DXF"), _("HPGL") };
+	int m_plotFormatOptNChoices = sizeof( m_plotFormatOptChoices ) / sizeof( wxString );
+	m_plotFormatOpt = new wxRadioBox( this, wxID_ANY, _("Format"), wxDefaultPosition, wxDefaultSize, m_plotFormatOptNChoices, m_plotFormatOptChoices, 1, wxRA_SPECIFY_COLS );
+	m_plotFormatOpt->SetSelection( 1 );
+	m_optionsSizer->Add( m_plotFormatOpt, 0, wxEXPAND|wxRIGHT|wxLEFT, 5 );
+	
 	m_paperOptionsSizer = new wxStaticBoxSizer( new wxStaticBox( this, wxID_ANY, _("Paper Options") ), wxVERTICAL );
 	
 	wxString m_PaperSizeOptionChoices[] = { _("Schematic size"), _("Force size A4"), _("Force size A") };
@@ -85,12 +85,6 @@ DIALOG_PLOT_SCHEMATIC_BASE::DIALOG_PLOT_SCHEMATIC_BASE( wxWindow* parent, wxWind
 	
 	m_optionsSizer->Add( m_paperOptionsSizer, 0, wxEXPAND, 5 );
 	
-	wxString m_plotFormatOptChoices[] = { _("Postscript"), _("PDF"), _("SVG"), _("DXF"), _("HPGL") };
-	int m_plotFormatOptNChoices = sizeof( m_plotFormatOptChoices ) / sizeof( wxString );
-	m_plotFormatOpt = new wxRadioBox( this, wxID_ANY, _("Format"), wxDefaultPosition, wxDefaultSize, m_plotFormatOptNChoices, m_plotFormatOptChoices, 1, wxRA_SPECIFY_COLS );
-	m_plotFormatOpt->SetSelection( 1 );
-	m_optionsSizer->Add( m_plotFormatOpt, 0, wxEXPAND|wxLEFT, 5 );
-	
 	wxStaticBoxSizer* sbSizerPlotFormat;
 	sbSizerPlotFormat = new wxStaticBoxSizer( new wxStaticBox( this, wxID_ANY, _("General Options") ), wxVERTICAL );
 	
@@ -140,16 +134,16 @@ DIALOG_PLOT_SCHEMATIC_BASE::DIALOG_PLOT_SCHEMATIC_BASE( wxWindow* parent, wxWind
 	
 	bMainSizer->Add( m_optionsSizer, 0, wxEXPAND|wxLEFT|wxRIGHT|wxTOP, 5 );
 	
-	wxBoxSizer* bSizer4;
+	wxBoxSizer* bSizerMsgPanel;
-	bSizer4 = new wxBoxSizer( wxVERTICAL );
+	bSizerMsgPanel = new wxBoxSizer( wxVERTICAL );
 	
 	m_MessagesBox = new WX_HTML_REPORT_PANEL( this, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxTAB_TRAVERSAL );
 	m_MessagesBox->SetMinSize( wxSize( 300,150 ) );
 	
-	bSizer4->Add( m_MessagesBox, 1, wxEXPAND | wxALL, 5 );
+	bSizerMsgPanel->Add( m_MessagesBox, 1, wxEXPAND | wxALL, 5 );
 	
 	
-	bMainSizer->Add( bSizer4, 1, wxBOTTOM|wxEXPAND|wxLEFT|wxRIGHT, 5 );
+	bMainSizer->Add( bSizerMsgPanel, 1, wxBOTTOM|wxEXPAND|wxLEFT|wxRIGHT, 5 );
 	
 	
 	this->SetSizer( bMainSizer );
@@ -159,8 +153,8 @@ DIALOG_PLOT_SCHEMATIC_BASE::DIALOG_PLOT_SCHEMATIC_BASE( wxWindow* parent, wxWind
 	// Connect Events
 	this->Connect( wxEVT_CLOSE_WINDOW, wxCloseEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnCloseWindow ) );
 	m_browseButton->Connect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnOutputDirectoryBrowseClicked ), NULL, this );
-	m_HPGLPaperSizeOption->Connect( wxEVT_COMMAND_CHOICE_SELECTED, wxCommandEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnHPGLPageSelected ), NULL, this );
 	m_plotFormatOpt->Connect( wxEVT_COMMAND_RADIOBOX_SELECTED, wxCommandEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnPlotFormatSelection ), NULL, this );
+	m_HPGLPaperSizeOption->Connect( wxEVT_COMMAND_CHOICE_SELECTED, wxCommandEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnHPGLPageSelected ), NULL, this );
 	m_buttonPlotCurrent->Connect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnButtonPlotCurrentClick ), NULL, this );
 	m_buttonPlotAll->Connect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnButtonPlotAllClick ), NULL, this );
 	m_buttonQuit->Connect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnButtonCancelClick ), NULL, this );
@@ -171,8 +165,8 @@ DIALOG_PLOT_SCHEMATIC_BASE::~DIALOG_PLOT_SCHEMATIC_BASE()
 	// Disconnect Events
 	this->Disconnect( wxEVT_CLOSE_WINDOW, wxCloseEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnCloseWindow ) );
 	m_browseButton->Disconnect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnOutputDirectoryBrowseClicked ), NULL, this );
-	m_HPGLPaperSizeOption->Disconnect( wxEVT_COMMAND_CHOICE_SELECTED, wxCommandEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnHPGLPageSelected ), NULL, this );
 	m_plotFormatOpt->Disconnect( wxEVT_COMMAND_RADIOBOX_SELECTED, wxCommandEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnPlotFormatSelection ), NULL, this );
+	m_HPGLPaperSizeOption->Disconnect( wxEVT_COMMAND_CHOICE_SELECTED, wxCommandEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnHPGLPageSelected ), NULL, this );
 	m_buttonPlotCurrent->Disconnect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnButtonPlotCurrentClick ), NULL, this );
 	m_buttonPlotAll->Disconnect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnButtonPlotAllClick ), NULL, this );
 	m_buttonQuit->Disconnect( wxEVT_COMMAND_BUTTON_CLICKED, wxCommandEventHandler( DIALOG_PLOT_SCHEMATIC_BASE::OnButtonCancelClick ), NULL, this );

eeschema/dialogs/dialog_plot_schematic_base.fbp

@@ -94,17 +94,17 @@
                 <property name="orient">wxVERTICAL</property>
                 <property name="permission">none</property>
                 <object class="sizeritem" expanded="1">
-                    <property name="border">5</property>
+                    <property name="border">10</property>
-                    <property name="flag">wxEXPAND|wxLEFT|wxTOP</property>
+                    <property name="flag">wxBOTTOM|wxEXPAND</property>
                     <property name="proportion">0</property>
                     <object class="wxBoxSizer" expanded="1">
                         <property name="minimum_size"></property>
-                        <property name="name">bSizer6</property>
+                        <property name="name">bSizerDir</property>
-                        <property name="orient">wxVERTICAL</property>
+                        <property name="orient">wxHORIZONTAL</property>
                         <property name="permission">none</property>
                         <object class="sizeritem" expanded="1">
                             <property name="border">5</property>
-                            <property name="flag">wxALL</property>
+                            <property name="flag">wxALL|wxALIGN_CENTER_VERTICAL</property>
                             <property name="proportion">0</property>
                             <object class="wxStaticText" expanded="1">
                                 <property name="BottomDockable">1</property>
@@ -187,192 +187,181 @@
                         </object>
                         <object class="sizeritem" expanded="1">
                             <property name="border">5</property>
-                            <property name="flag">wxEXPAND</property>
+                            <property name="flag">wxALL|wxALIGN_CENTER_VERTICAL</property>
                             <property name="proportion">1</property>
-                            <object class="wxBoxSizer" expanded="1">
+                            <object class="wxTextCtrl" expanded="1">
+                                <property name="BottomDockable">1</property>
+                                <property name="LeftDockable">1</property>
+                                <property name="RightDockable">1</property>
+                                <property name="TopDockable">1</property>
+                                <property name="aui_layer"></property>
+                                <property name="aui_name"></property>
+                                <property name="aui_position"></property>
+                                <property name="aui_row"></property>
+                                <property name="best_size"></property>
+                                <property name="bg"></property>
+                                <property name="caption"></property>
+                                <property name="caption_visible">1</property>
+                                <property name="center_pane">0</property>
+                                <property name="close_button">1</property>
+                                <property name="context_help"></property>
+                                <property name="context_menu">1</property>
+                                <property name="default_pane">0</property>
+                                <property name="dock">Dock</property>
+                                <property name="dock_fixed">0</property>
+                                <property name="docking">Left</property>
+                                <property name="enabled">1</property>
+                                <property name="fg"></property>
+                                <property name="floatable">1</property>
+                                <property name="font"></property>
+                                <property name="gripper">0</property>
+                                <property name="hidden">0</property>
+                                <property name="id">wxID_ANY</property>
+                                <property name="max_size"></property>
+                                <property name="maximize_button">0</property>
+                                <property name="maximum_size"></property>
+                                <property name="maxlength">0</property>
+                                <property name="min_size"></property>
+                                <property name="minimize_button">0</property>
                                 <property name="minimum_size"></property>
-                                <property name="name">bSizer5</property>
+                                <property name="moveable">1</property>
-                                <property name="orient">wxHORIZONTAL</property>
+                                <property name="name">m_outputDirectoryName</property>
-                                <property name="permission">none</property>
+                                <property name="pane_border">1</property>
-                                <object class="sizeritem" expanded="1">
+                                <property name="pane_position"></property>
-                                    <property name="border">5</property>
+                                <property name="pane_size"></property>
-                                    <property name="flag">wxEXPAND|wxLEFT|wxRIGHT</property>
+                                <property name="permission">protected</property>
-                                    <property name="proportion">1</property>
+                                <property name="pin_button">1</property>
-                                    <object class="wxTextCtrl" expanded="1">
+                                <property name="pos"></property>
-                                        <property name="BottomDockable">1</property>
+                                <property name="resize">Resizable</property>
-                                        <property name="LeftDockable">1</property>
+                                <property name="show">1</property>
-                                        <property name="RightDockable">1</property>
+                                <property name="size"></property>
-                                        <property name="TopDockable">1</property>
+                                <property name="style"></property>
-                                        <property name="aui_layer"></property>
+                                <property name="subclass"></property>
-                                        <property name="aui_name"></property>
+                                <property name="toolbar_pane">0</property>
-                                        <property name="aui_position"></property>
+                                <property name="tooltip">Target directory for plot files. Can be absolute or relative to the schematic main file location.</property>
-                                        <property name="aui_row"></property>
+                                <property name="validator_data_type"></property>
-                                        <property name="best_size"></property>
+                                <property name="validator_style">wxFILTER_NONE</property>
-                                        <property name="bg"></property>
+                                <property name="validator_type">wxDefaultValidator</property>
-                                        <property name="caption"></property>
+                                <property name="validator_variable"></property>
-                                        <property name="caption_visible">1</property>
+                                <property name="value"></property>
-                                        <property name="center_pane">0</property>
+                                <property name="window_extra_style"></property>
-                                        <property name="close_button">1</property>
+                                <property name="window_name"></property>
-                                        <property name="context_help"></property>
+                                <property name="window_style"></property>
-                                        <property name="context_menu">1</property>
+                                <event name="OnChar"></event>
-                                        <property name="default_pane">0</property>
+                                <event name="OnEnterWindow"></event>
-                                        <property name="dock">Dock</property>
+                                <event name="OnEraseBackground"></event>
-                                        <property name="dock_fixed">0</property>
+                                <event name="OnKeyDown"></event>
-                                        <property name="docking">Left</property>
+                                <event name="OnKeyUp"></event>
-                                        <property name="enabled">1</property>
+                                <event name="OnKillFocus"></event>
-                                        <property name="fg"></property>
+                                <event name="OnLeaveWindow"></event>
-                                        <property name="floatable">1</property>
+                                <event name="OnLeftDClick"></event>
-                                        <property name="font"></property>
+                                <event name="OnLeftDown"></event>
-                                        <property name="gripper">0</property>
+                                <event name="OnLeftUp"></event>
-                                        <property name="hidden">0</property>
+                                <event name="OnMiddleDClick"></event>
-                                        <property name="id">wxID_ANY</property>
+                                <event name="OnMiddleDown"></event>
-                                        <property name="max_size"></property>
+                                <event name="OnMiddleUp"></event>
-                                        <property name="maximize_button">0</property>
+                                <event name="OnMotion"></event>
-                                        <property name="maximum_size"></property>
+                                <event name="OnMouseEvents"></event>
-                                        <property name="maxlength">0</property>
+                                <event name="OnMouseWheel"></event>
-                                        <property name="min_size"></property>
+                                <event name="OnPaint"></event>
-                                        <property name="minimize_button">0</property>
+                                <event name="OnRightDClick"></event>
-                                        <property name="minimum_size"></property>
+                                <event name="OnRightDown"></event>
-                                        <property name="moveable">1</property>
+                                <event name="OnRightUp"></event>
-                                        <property name="name">m_outputDirectoryName</property>
+                                <event name="OnSetFocus"></event>
-                                        <property name="pane_border">1</property>
+                                <event name="OnSize"></event>
-                                        <property name="pane_position"></property>
+                                <event name="OnText"></event>
-                                        <property name="pane_size"></property>
+                                <event name="OnTextEnter"></event>
-                                        <property name="permission">protected</property>
+                                <event name="OnTextMaxLen"></event>
-                                        <property name="pin_button">1</property>
+                                <event name="OnTextURL"></event>
-                                        <property name="pos"></property>
+                                <event name="OnUpdateUI"></event>
-                                        <property name="resize">Resizable</property>
+                            </object>
-                                        <property name="show">1</property>
+                        </object>
-                                        <property name="size"></property>
+                        <object class="sizeritem" expanded="1">
-                                        <property name="style"></property>
+                            <property name="border">5</property>
-                                        <property name="subclass"></property>
+                            <property name="flag">wxALL|wxALIGN_CENTER_VERTICAL</property>
-                                        <property name="toolbar_pane">0</property>
+                            <property name="proportion">0</property>
-                                        <property name="tooltip">Target directory for plot files. Can be absolute or relative to the schematic main file location.</property>
+                            <object class="wxButton" expanded="1">
-                                        <property name="validator_data_type"></property>
+                                <property name="BottomDockable">1</property>
-                                        <property name="validator_style">wxFILTER_NONE</property>
+                                <property name="LeftDockable">1</property>
-                                        <property name="validator_type">wxDefaultValidator</property>
+                                <property name="RightDockable">1</property>
-                                        <property name="validator_variable"></property>
+                                <property name="TopDockable">1</property>
-                                        <property name="value"></property>
+                                <property name="aui_layer"></property>
-                                        <property name="window_extra_style"></property>
+                                <property name="aui_name"></property>
-                                        <property name="window_name"></property>
+                                <property name="aui_position"></property>
-                                        <property name="window_style"></property>
+                                <property name="aui_row"></property>
-                                        <event name="OnChar"></event>
+                                <property name="best_size"></property>
-                                        <event name="OnEnterWindow"></event>
+                                <property name="bg"></property>
-                                        <event name="OnEraseBackground"></event>
+                                <property name="caption"></property>
-                                        <event name="OnKeyDown"></event>
+                                <property name="caption_visible">1</property>
-                                        <event name="OnKeyUp"></event>
+                                <property name="center_pane">0</property>
-                                        <event name="OnKillFocus"></event>
+                                <property name="close_button">1</property>
-                                        <event name="OnLeaveWindow"></event>
+                                <property name="context_help"></property>
-                                        <event name="OnLeftDClick"></event>
+                                <property name="context_menu">1</property>
-                                        <event name="OnLeftDown"></event>
+                                <property name="default">0</property>
-                                        <event name="OnLeftUp"></event>
+                                <property name="default_pane">0</property>
-                                        <event name="OnMiddleDClick"></event>
+                                <property name="dock">Dock</property>
-                                        <event name="OnMiddleDown"></event>
+                                <property name="dock_fixed">0</property>
-                                        <event name="OnMiddleUp"></event>
+                                <property name="docking">Left</property>
-                                        <event name="OnMotion"></event>
+                                <property name="enabled">1</property>
-                                        <event name="OnMouseEvents"></event>
+                                <property name="fg"></property>
-                                        <event name="OnMouseWheel"></event>
+                                <property name="floatable">1</property>
-                                        <event name="OnPaint"></event>
+                                <property name="font"></property>
-                                        <event name="OnRightDClick"></event>
+                                <property name="gripper">0</property>
-                                        <event name="OnRightDown"></event>
+                                <property name="hidden">0</property>
-                                        <event name="OnRightUp"></event>
+                                <property name="id">wxID_ANY</property>
-                                        <event name="OnSetFocus"></event>
+                                <property name="label">Browse...</property>
-                                        <event name="OnSize"></event>
+                                <property name="max_size"></property>
-                                        <event name="OnText"></event>
+                                <property name="maximize_button">0</property>
-                                        <event name="OnTextEnter"></event>
+                                <property name="maximum_size"></property>
-                                        <event name="OnTextMaxLen"></event>
+                                <property name="min_size"></property>
-                                        <event name="OnTextURL"></event>
+                                <property name="minimize_button">0</property>
-                                        <event name="OnUpdateUI"></event>
+                                <property name="minimum_size"></property>
-                                    </object>
+                                <property name="moveable">1</property>
-                                </object>
+                                <property name="name">m_browseButton</property>
-                                <object class="sizeritem" expanded="1">
+                                <property name="pane_border">1</property>
-                                    <property name="border">5</property>
+                                <property name="pane_position"></property>
-                                    <property name="flag">wxALIGN_CENTER_VERTICAL|wxLEFT|wxRIGHT</property>
+                                <property name="pane_size"></property>
-                                    <property name="proportion">0</property>
+                                <property name="permission">protected</property>
-                                    <object class="wxButton" expanded="1">
+                                <property name="pin_button">1</property>
-                                        <property name="BottomDockable">1</property>
+                                <property name="pos"></property>
-                                        <property name="LeftDockable">1</property>
+                                <property name="resize">Resizable</property>
-                                        <property name="RightDockable">1</property>
+                                <property name="show">1</property>
-                                        <property name="TopDockable">1</property>
+                                <property name="size"></property>
-                                        <property name="aui_layer"></property>
+                                <property name="style"></property>
-                                        <property name="aui_name"></property>
+                                <property name="subclass"></property>
-                                        <property name="aui_position"></property>
+                                <property name="toolbar_pane">0</property>
-                                        <property name="aui_row"></property>
+                                <property name="tooltip"></property>
-                                        <property name="best_size"></property>
+                                <property name="validator_data_type"></property>
-                                        <property name="bg"></property>
+                                <property name="validator_style">wxFILTER_NONE</property>
-                                        <property name="caption"></property>
+                                <property name="validator_type">wxDefaultValidator</property>
-                                        <property name="caption_visible">1</property>
+                                <property name="validator_variable"></property>
-                                        <property name="center_pane">0</property>
+                                <property name="window_extra_style"></property>
-                                        <property name="close_button">1</property>
+                                <property name="window_name"></property>
-                                        <property name="context_help"></property>
+                                <property name="window_style"></property>
-                                        <property name="context_menu">1</property>
+                                <event name="OnButtonClick">OnOutputDirectoryBrowseClicked</event>
-                                        <property name="default">0</property>
+                                <event name="OnChar"></event>
-                                        <property name="default_pane">0</property>
+                                <event name="OnEnterWindow"></event>
-                                        <property name="dock">Dock</property>
+                                <event name="OnEraseBackground"></event>
-                                        <property name="dock_fixed">0</property>
+                                <event name="OnKeyDown"></event>
-                                        <property name="docking">Left</property>
+                                <event name="OnKeyUp"></event>
-                                        <property name="enabled">1</property>
+                                <event name="OnKillFocus"></event>
-                                        <property name="fg"></property>
+                                <event name="OnLeaveWindow"></event>
-                                        <property name="floatable">1</property>
+                                <event name="OnLeftDClick"></event>
-                                        <property name="font"></property>
+                                <event name="OnLeftDown"></event>
-                                        <property name="gripper">0</property>
+                                <event name="OnLeftUp"></event>
-                                        <property name="hidden">0</property>
+                                <event name="OnMiddleDClick"></event>
-                                        <property name="id">wxID_ANY</property>
+                                <event name="OnMiddleDown"></event>
-                                        <property name="label">Browse...</property>
+                                <event name="OnMiddleUp"></event>
-                                        <property name="max_size"></property>
+                                <event name="OnMotion"></event>
-                                        <property name="maximize_button">0</property>
+                                <event name="OnMouseEvents"></event>
-                                        <property name="maximum_size"></property>
+                                <event name="OnMouseWheel"></event>
-                                        <property name="min_size"></property>
+                                <event name="OnPaint"></event>
-                                        <property name="minimize_button">0</property>
+                                <event name="OnRightDClick"></event>
-                                        <property name="minimum_size"></property>
+                                <event name="OnRightDown"></event>
-                                        <property name="moveable">1</property>
+                                <event name="OnRightUp"></event>
-                                        <property name="name">m_browseButton</property>
+                                <event name="OnSetFocus"></event>
-                                        <property name="pane_border">1</property>
+                                <event name="OnSize"></event>
-                                        <property name="pane_position"></property>
+                                <event name="OnUpdateUI"></event>
-                                        <property name="pane_size"></property>
-                                        <property name="permission">protected</property>
-                                        <property name="pin_button">1</property>
-                                        <property name="pos"></property>
-                                        <property name="resize">Resizable</property>
-                                        <property name="show">1</property>
-                                        <property name="size"></property>
-                                        <property name="style"></property>
-                                        <property name="subclass"></property>
-                                        <property name="toolbar_pane">0</property>
-                                        <property name="tooltip"></property>
-                                        <property name="validator_data_type"></property>
-                                        <property name="validator_style">wxFILTER_NONE</property>
-                                        <property name="validator_type">wxDefaultValidator</property>
-                                        <property name="validator_variable"></property>
-                                        <property name="window_extra_style"></property>
-                                        <property name="window_name"></property>
-                                        <property name="window_style"></property>
-                                        <event name="OnButtonClick">OnOutputDirectoryBrowseClicked</event>
-                                        <event name="OnChar"></event>
-                                        <event name="OnEnterWindow"></event>
-                                        <event name="OnEraseBackground"></event>
-                                        <event name="OnKeyDown"></event>
-                                        <event name="OnKeyUp"></event>
-                                        <event name="OnKillFocus"></event>
-                                        <event name="OnLeaveWindow"></event>
-                                        <event name="OnLeftDClick"></event>
-                                        <event name="OnLeftDown"></event>
-                                        <event name="OnLeftUp"></event>
-                                        <event name="OnMiddleDClick"></event>
-                                        <event name="OnMiddleDown"></event>
-                                        <event name="OnMiddleUp"></event>
-                                        <event name="OnMotion"></event>
-                                        <event name="OnMouseEvents"></event>
-                                        <event name="OnMouseWheel"></event>
-                                        <event name="OnPaint"></event>
-                                        <event name="OnRightDClick"></event>
-                                        <event name="OnRightDown"></event>
-                                        <event name="OnRightUp"></event>
-                                        <event name="OnSetFocus"></event>
-                                        <event name="OnSize"></event>
-                                        <event name="OnUpdateUI"></event>
-                                    </object>
-                                </object>
                             </object>
                         </object>
                     </object>
@@ -386,6 +375,96 @@
                         <property name="name">m_optionsSizer</property>
                         <property name="orient">wxHORIZONTAL</property>
                         <property name="permission">protected</property>
+                        <object class="sizeritem" expanded="1">
+                            <property name="border">5</property>
+                            <property name="flag">wxEXPAND|wxRIGHT|wxLEFT</property>
+                            <property name="proportion">0</property>
+                            <object class="wxRadioBox" expanded="1">
+                                <property name="BottomDockable">1</property>
+                                <property name="LeftDockable">1</property>
+                                <property name="RightDockable">1</property>
+                                <property name="TopDockable">1</property>
+                                <property name="aui_layer"></property>
+                                <property name="aui_name"></property>
+                                <property name="aui_position"></property>
+                                <property name="aui_row"></property>
+                                <property name="best_size"></property>
+                                <property name="bg"></property>
+                                <property name="caption"></property>
+                                <property name="caption_visible">1</property>
+                                <property name="center_pane">0</property>
+                                <property name="choices">&quot;Postscript&quot; &quot;PDF&quot; &quot;SVG&quot; &quot;DXF&quot; &quot;HPGL&quot;</property>
+                                <property name="close_button">1</property>
+                                <property name="context_help"></property>
+                                <property name="context_menu">1</property>
+                                <property name="default_pane">0</property>
+                                <property name="dock">Dock</property>
+                                <property name="dock_fixed">0</property>
+                                <property name="docking">Left</property>
+                                <property name="enabled">1</property>
+                                <property name="fg"></property>
+                                <property name="floatable">1</property>
+                                <property name="font"></property>
+                                <property name="gripper">0</property>
+                                <property name="hidden">0</property>
+                                <property name="id">wxID_ANY</property>
+                                <property name="label">Format</property>
+                                <property name="majorDimension">1</property>
+                                <property name="max_size"></property>
+                                <property name="maximize_button">0</property>
+                                <property name="maximum_size"></property>
+                                <property name="min_size"></property>
+                                <property name="minimize_button">0</property>
+                                <property name="minimum_size"></property>
+                                <property name="moveable">1</property>
+                                <property name="name">m_plotFormatOpt</property>
+                                <property name="pane_border">1</property>
+                                <property name="pane_position"></property>
+                                <property name="pane_size"></property>
+                                <property name="permission">protected</property>
+                                <property name="pin_button">1</property>
+                                <property name="pos"></property>
+                                <property name="resize">Resizable</property>
+                                <property name="selection">1</property>
+                                <property name="show">1</property>
+                                <property name="size"></property>
+                                <property name="style">wxRA_SPECIFY_COLS</property>
+                                <property name="subclass"></property>
+                                <property name="toolbar_pane">0</property>
+                                <property name="tooltip"></property>
+                                <property name="validator_data_type"></property>
+                                <property name="validator_style">wxFILTER_NONE</property>
+                                <property name="validator_type">wxDefaultValidator</property>
+                                <property name="validator_variable"></property>
+                                <property name="window_extra_style"></property>
+                                <property name="window_name"></property>
+                                <property name="window_style"></property>
+                                <event name="OnChar"></event>
+                                <event name="OnEnterWindow"></event>
+                                <event name="OnEraseBackground"></event>
+                                <event name="OnKeyDown"></event>
+                                <event name="OnKeyUp"></event>
+                                <event name="OnKillFocus"></event>
+                                <event name="OnLeaveWindow"></event>
+                                <event name="OnLeftDClick"></event>
+                                <event name="OnLeftDown"></event>
+                                <event name="OnLeftUp"></event>
+                                <event name="OnMiddleDClick"></event>
+                                <event name="OnMiddleDown"></event>
+                                <event name="OnMiddleUp"></event>
+                                <event name="OnMotion"></event>
+                                <event name="OnMouseEvents"></event>
+                                <event name="OnMouseWheel"></event>
+                                <event name="OnPaint"></event>
+                                <event name="OnRadioBox">OnPlotFormatSelection</event>
+                                <event name="OnRightDClick"></event>
+                                <event name="OnRightDown"></event>
+                                <event name="OnRightUp"></event>
+                                <event name="OnSetFocus"></event>
+                                <event name="OnSize"></event>
+                                <event name="OnUpdateUI"></event>
+                            </object>
+                        </object>
                         <object class="sizeritem" expanded="1">
                             <property name="border">5</property>
                             <property name="flag">wxEXPAND</property>
@@ -939,96 +1018,6 @@
                                 </object>
                             </object>
                         </object>
-                        <object class="sizeritem" expanded="1">
-                            <property name="border">5</property>
-                            <property name="flag">wxEXPAND|wxLEFT</property>
-                            <property name="proportion">0</property>
-                            <object class="wxRadioBox" expanded="1">
-                                <property name="BottomDockable">1</property>
-                                <property name="LeftDockable">1</property>
-                                <property name="RightDockable">1</property>
-                                <property name="TopDockable">1</property>
-                                <property name="aui_layer"></property>
-                                <property name="aui_name"></property>
-                                <property name="aui_position"></property>
-                                <property name="aui_row"></property>
-                                <property name="best_size"></property>
-                                <property name="bg"></property>
-                                <property name="caption"></property>
-                                <property name="caption_visible">1</property>
-                                <property name="center_pane">0</property>
-                                <property name="choices">&quot;Postscript&quot; &quot;PDF&quot; &quot;SVG&quot; &quot;DXF&quot; &quot;HPGL&quot;</property>
-                                <property name="close_button">1</property>
-                                <property name="context_help"></property>
-                                <property name="context_menu">1</property>
-                                <property name="default_pane">0</property>
-                                <property name="dock">Dock</property>
-                                <property name="dock_fixed">0</property>
-                                <property name="docking">Left</property>
-                                <property name="enabled">1</property>
-                                <property name="fg"></property>
-                                <property name="floatable">1</property>
-                                <property name="font"></property>
-                                <property name="gripper">0</property>
-                                <property name="hidden">0</property>
-                                <property name="id">wxID_ANY</property>
-                                <property name="label">Format</property>
-                                <property name="majorDimension">1</property>
-                                <property name="max_size"></property>
-                                <property name="maximize_button">0</property>
-                                <property name="maximum_size"></property>
-                                <property name="min_size"></property>
-                                <property name="minimize_button">0</property>
-                                <property name="minimum_size"></property>
-                                <property name="moveable">1</property>
-                                <property name="name">m_plotFormatOpt</property>
-                                <property name="pane_border">1</property>
-                                <property name="pane_position"></property>
-                                <property name="pane_size"></property>
-                                <property name="permission">protected</property>
-                                <property name="pin_button">1</property>
-                                <property name="pos"></property>
-                                <property name="resize">Resizable</property>
-                                <property name="selection">1</property>
-                                <property name="show">1</property>
-                                <property name="size"></property>
-                                <property name="style">wxRA_SPECIFY_COLS</property>
-                                <property name="subclass"></property>
-                                <property name="toolbar_pane">0</property>
-                                <property name="tooltip"></property>
-                                <property name="validator_data_type"></property>
-                                <property name="validator_style">wxFILTER_NONE</property>
-                                <property name="validator_type">wxDefaultValidator</property>
-                                <property name="validator_variable"></property>
-                                <property name="window_extra_style"></property>
-                                <property name="window_name"></property>
-                                <property name="window_style"></property>
-                                <event name="OnChar"></event>
-                                <event name="OnEnterWindow"></event>
-                                <event name="OnEraseBackground"></event>
-                                <event name="OnKeyDown"></event>
-                                <event name="OnKeyUp"></event>
-                                <event name="OnKillFocus"></event>
-                                <event name="OnLeaveWindow"></event>
-                                <event name="OnLeftDClick"></event>
-                                <event name="OnLeftDown"></event>
-                                <event name="OnLeftUp"></event>
-                                <event name="OnMiddleDClick"></event>
-                                <event name="OnMiddleDown"></event>
-                                <event name="OnMiddleUp"></event>
-                                <event name="OnMotion"></event>
-                                <event name="OnMouseEvents"></event>
-                                <event name="OnMouseWheel"></event>
-                                <event name="OnPaint"></event>
-                                <event name="OnRadioBox">OnPlotFormatSelection</event>
-                                <event name="OnRightDClick"></event>
-                                <event name="OnRightDown"></event>
-                                <event name="OnRightUp"></event>
-                                <event name="OnSetFocus"></event>
-                                <event name="OnSize"></event>
-                                <event name="OnUpdateUI"></event>
-                            </object>
-                        </object>
                         <object class="sizeritem" expanded="1">
                             <property name="border">5</property>
                             <property name="flag">wxEXPAND|wxLEFT</property>
@@ -1678,7 +1667,7 @@
                     <property name="proportion">1</property>
                     <object class="wxBoxSizer" expanded="1">
                         <property name="minimum_size"></property>
-                        <property name="name">bSizer4</property>
+                        <property name="name">bSizerMsgPanel</property>
                         <property name="orient">wxVERTICAL</property>
                         <property name="permission">none</property>
                         <object class="sizeritem" expanded="1">

eeschema/dialogs/dialog_plot_schematic_base.h

@@ -51,6 +51,7 @@ class DIALOG_PLOT_SCHEMATIC_BASE : public DIALOG_SHIM
 		wxTextCtrl* m_outputDirectoryName;
 		wxButton* m_browseButton;
 		wxBoxSizer* m_optionsSizer;
+		wxRadioBox* m_plotFormatOpt;
 		wxStaticBoxSizer* m_paperOptionsSizer;
 		wxRadioBox* m_PaperSizeOption;
 		wxStaticBoxSizer* m_paperHPGLSizer;
@@ -59,7 +60,6 @@ class DIALOG_PLOT_SCHEMATIC_BASE : public DIALOG_SHIM
 		wxRadioBox* m_plotOriginOpt;
 		wxStaticText* m_penHPLGWidthTitle;
 		wxTextCtrl* m_penHPGLWidthCtrl;
-		wxRadioBox* m_plotFormatOpt;
 		wxStaticText* m_defaultLineWidthTitle;
 		wxTextCtrl* m_DefaultLineSizeCtrl;
 		wxRadioBox* m_ModeColorOption;
@@ -73,8 +73,8 @@ class DIALOG_PLOT_SCHEMATIC_BASE : public DIALOG_SHIM
 		// Virtual event handlers, overide them in your derived class
 		virtual void OnCloseWindow( wxCloseEvent& event ) { event.Skip(); }
 		virtual void OnOutputDirectoryBrowseClicked( wxCommandEvent& event ) { event.Skip(); }
-		virtual void OnHPGLPageSelected( wxCommandEvent& event ) { event.Skip(); }
 		virtual void OnPlotFormatSelection( wxCommandEvent& event ) { event.Skip(); }
+		virtual void OnHPGLPageSelected( wxCommandEvent& event ) { event.Skip(); }
 		virtual void OnButtonPlotCurrentClick( wxCommandEvent& event ) { event.Skip(); }
 		virtual void OnButtonPlotAllClick( wxCommandEvent& event ) { event.Skip(); }
 		virtual void OnButtonCancelClick( wxCommandEvent& event ) { event.Skip(); }

eeschema/eeschema_config.cpp

@@ -51,6 +51,7 @@
 #include <dialogs/dialog_eeschema_options.h>
 #include <dialogs/dialog_libedit_options.h>
 #include <dialogs/dialog_schematic_find.h>
+#include <dialog_erc.h>
 
 #include <wildcards_and_files_ext.h>
 
@@ -438,16 +439,18 @@ PARAM_CFG_ARRAY& SCH_EDIT_FRAME::GetProjectFileParametersList()
     */
 
     m_projectFileParams.push_back( new PARAM_CFG_WXSTRING( wxT( "NetFmtName" ),
-                                                         &m_netListFormat) );
+                                            &m_netListFormat) );
     m_projectFileParams.push_back( new PARAM_CFG_BOOL( wxT( "SpiceForceRefPrefix" ),
-                                                    &m_spiceNetlistAddReferencePrefix, false ) );
+                                            &m_spiceNetlistAddReferencePrefix, false ) );
     m_projectFileParams.push_back( new PARAM_CFG_BOOL( wxT( "SpiceUseNetNumbers" ),
-                                                    &m_spiceNetlistUseNetcodeAsNetname, false ) );
+                                            &m_spiceNetlistUseNetcodeAsNetname, false ) );
 
     m_projectFileParams.push_back( new PARAM_CFG_INT( wxT( "LabSize" ),
-                                                      &s_defaultTextSize,
+                                            &s_defaultTextSize,
-                                                      DEFAULT_SIZE_TEXT, 5,
+                                            DEFAULT_SIZE_TEXT, 5, 1000 ) );
-                                                      1000 ) );
+
+    m_projectFileParams.push_back( new PARAM_CFG_BOOL( wxT( "ERC_TestSimilarLabels" ),
+                                            &DIALOG_ERC::m_TestSimilarLabels, true ) );
 
     return m_projectFileParams;
 }

eeschema/erc.cpp

@@ -119,9 +119,9 @@ const wxString CommentERC_V[] =
 /* Look up table which gives the diag for a pair of connected pins
  *  Can be modified by ERC options.
  *  at start up: must be loaded by DefaultDiagErc
+ *  Can be modified in dialog ERC
  */
 int  DiagErc[PIN_NMAX][PIN_NMAX];
-bool DiagErcTableInit;       // go to true after DiagErc init
 
 /**
  * Default Look up table which gives the ERC error level for a pair of connected pins
@@ -196,6 +196,8 @@ int TestDuplicateSheetNames( bool aCreateMarker )
                     continue;
 
                 // We have found a second sheet: compare names
+                // we are using case insensitive comparison to avoid mistakes between
+                // similar names like Mysheet and mysheet
                 if( ( (SCH_SHEET*) item )->GetName().CmpNoCase(
                         ( ( SCH_SHEET* ) test_item )->GetName() ) == 0 )
                 {
@@ -502,20 +504,19 @@ void TestOthersItems( NETLIST_OBJECT_LIST* aList,
     }
 }
 
-
+int NETLIST_OBJECT_LIST::CountPinsInNet( unsigned aNetStart )
-int CountPinsInNet( NETLIST_OBJECT_LIST* aList, unsigned aNetStart )
 {
     int count = 0;
-    int curr_net = aList->GetItemNet( aNetStart );
+    int curr_net = GetItemNet( aNetStart );
 
     /* Test pins connected to NetItemRef */
-    for( unsigned item = aNetStart; item < aList->size(); item++ )
+    for( unsigned item = aNetStart; item < size(); item++ )
     {
         // We examine only a given net. We stop the search if the net changes
-        if( curr_net != aList->GetItemNet( item ) )   // End of net
+        if( curr_net != GetItemNet( item ) )   // End of net
             break;
 
-        if( aList->GetItemType( item ) == NET_PIN )
+        if( GetItemType( item ) == NET_PIN )
             count++;
     }
 
@@ -571,7 +572,7 @@ bool WriteDiagnosticERC( const wxString& aFullFileName )
     msg << wxString::Format( _( "\n ** ERC messages: %d  Errors %d  Warnings %d\n" ),
                              total_count, err_count, warn_count );
 
-    // Currently: write report unsing UTF8 (as usual in Kicad).
+    // Currently: write report using UTF8 (as usual in Kicad).
     // TODO: see if we can use the current encoding page (mainly for Windows users),
     // Or other format (HTML?)
     file.Write( msg );
@@ -582,7 +583,7 @@ bool WriteDiagnosticERC( const wxString& aFullFileName )
 }
 
 
-void TestLabel( NETLIST_OBJECT_LIST* aList, unsigned aNetItemRef, unsigned aStartNet )
+void NETLIST_OBJECT_LIST::TestforNonOrphanLabel( unsigned aNetItemRef, unsigned aStartNet )
 {
     unsigned netItemTst = aStartNet;
     int      erc = 1;
@@ -594,24 +595,246 @@ void TestLabel( NETLIST_OBJECT_LIST* aList, unsigned aNetItemRef, unsigned aStar
             continue;
 
         /* Is always in the same net? */
-        if( ( netItemTst == aList->size() )
+        if( ( netItemTst == size() )
-          || ( aList->GetItemNet( aNetItemRef ) != aList->GetItemNet( netItemTst ) ) )
+          || ( GetItemNet( aNetItemRef ) != GetItemNet( netItemTst ) ) )
         {
             /* End Netcode found. */
             if( erc )
             {
                 /* Glabel or SheetLabel orphaned. */
-                Diagnose( aList->GetItem( aNetItemRef ), NULL, -1, WAR );
+                Diagnose( GetItem( aNetItemRef ), NULL, -1, WAR );
             }
 
             return;
         }
 
-        if( aList->GetItem( aNetItemRef )->IsLabelConnected( aList->GetItem( netItemTst ) ) )
+        if( GetItem( aNetItemRef )->IsLabelConnected( GetItem( netItemTst ) ) )
             erc = 0;
 
         //same thing, different order.
-        if( aList->GetItem( netItemTst )->IsLabelConnected( aList->GetItem( aNetItemRef ) ) )
+        if( GetItem( netItemTst )->IsLabelConnected( GetItem( aNetItemRef ) ) )
             erc = 0;
     }
 }
+
+
+// this code try to detect similar labels, i.e. labels which are identical
+// when they are compared using case insensitive coparisons.
+
+
+// A helper struct to compare NETLIST_OBJECT items by sheetpath and label texts
+// for a std::set<NETLIST_OBJECT*> container
+// the full text is "sheetpath+label" for local labels and "label" for global labels
+struct compare_labels
+{
+    bool operator() ( const NETLIST_OBJECT* lab1, const NETLIST_OBJECT* lab2 )
+    {
+        wxString str1 = lab1->m_SheetPath.Path() + lab1->m_Label;
+        wxString str2 = lab2->m_SheetPath.Path() + lab2->m_Label;
+
+        return str1.Cmp( str2 ) < 0;
+    }
+};
+
+struct compare_label_names
+{
+    bool operator() ( const NETLIST_OBJECT* lab1, const NETLIST_OBJECT* lab2 )
+    {
+        return lab1->m_Label.Cmp( lab2->m_Label ) < 0;
+    }
+};
+
+struct compare_paths
+{
+    bool operator() ( const NETLIST_OBJECT* lab1, const NETLIST_OBJECT* lab2 )
+    {
+        return lab1->m_SheetPath.Path().Cmp( lab2->m_SheetPath.Path() ) < 0;
+    }
+};
+
+// Helper functions to build the warning messages about Similar Labels:
+static int countIndenticalLabels( std::vector<NETLIST_OBJECT*>& aList, NETLIST_OBJECT* aLabel );
+static void SimilarLabelsDiagnose( NETLIST_OBJECT* aItemA, NETLIST_OBJECT* aItemB );
+
+
+void NETLIST_OBJECT_LIST::TestforSimilarLabels()
+{
+    // Similar labels which are different when using case sensitive comparisons
+    // but are equal when using case insensitive comparisons
+
+    // list of all labels (used the better item to build diag messages)
+    std::vector<NETLIST_OBJECT*> fullLabelList;
+    // list of all labels , each label appears only once (used to to detect similar labels)
+    std::set<NETLIST_OBJECT*, compare_labels> uniqueLabelList;
+    wxString msg;
+
+    // Build a list of differents labels. If inside a given sheet there are
+    // more than one given label, only one label is stored.
+    // not also the sheet labels are not taken in account for 2 reasons:
+    //  * they are in the root sheet but they are seen only from the child sheet
+    //  * any mismatch between child sheet hierarchical labels and the sheet label
+    //    already detected by ERC
+    for( unsigned netItem = 0; netItem < size(); ++netItem )
+    {
+        switch( GetItemType( netItem ) )
+        {
+        case NET_LABEL:
+        case NET_BUSLABELMEMBER:
+        case NET_PINLABEL:
+        case NET_GLOBBUSLABELMEMBER:
+        case NET_HIERLABEL:
+        case NET_HIERBUSLABELMEMBER:
+        case NET_GLOBLABEL:
+            // add this label in lists
+            uniqueLabelList.insert( GetItem( netItem ) );
+            fullLabelList.push_back( GetItem( netItem ) );
+            break;
+
+        case NET_SHEETLABEL:
+        case NET_SHEETBUSLABELMEMBER:
+        default:
+            break;
+        }
+    }
+
+    // build global labels and compare
+    std::set<NETLIST_OBJECT*, compare_label_names> loc_labelList;
+    std::set<NETLIST_OBJECT*>::const_iterator it;
+
+    for( it = uniqueLabelList.begin(); it != uniqueLabelList.end(); ++it )
+    {
+        if( (*it)->IsLabelGlobal() )
+            loc_labelList.insert( *it );
+    }
+
+    // compare global labels (same label names appears only once in list)
+    for( it = loc_labelList.begin(); it != loc_labelList.end(); ++it )
+    {
+        std::set<NETLIST_OBJECT*>::const_iterator it_aux = it;
+
+        for( ++it_aux; it_aux != loc_labelList.end(); ++it_aux )
+        {
+            if( (*it)->m_Label.CmpNoCase( (*it_aux)->m_Label ) == 0 )
+            {
+                // Create new marker for ERC.
+                int cntA = countIndenticalLabels( fullLabelList, *it );
+                int cntB = countIndenticalLabels( fullLabelList, *it_aux );
+
+                if( cntA <= cntB )
+                    SimilarLabelsDiagnose( (*it), (*it_aux) );
+                else
+                    SimilarLabelsDiagnose( (*it_aux), (*it) );
+            }
+        }
+    }
+
+    // Build paths list
+    std::set<NETLIST_OBJECT*, compare_paths> pathsList;
+
+    for( it = uniqueLabelList.begin(); it != uniqueLabelList.end(); ++it )
+        pathsList.insert( *it );
+
+    // Examine each label inside a sheet path:
+    for( it = pathsList.begin(); it != pathsList.end(); ++it )
+    {
+        loc_labelList.clear();
+
+        std::set<NETLIST_OBJECT*>::const_iterator it_aux = uniqueLabelList.begin();
+
+        for( ; it_aux != uniqueLabelList.end(); ++it_aux )
+        {
+            if( (*it)->m_SheetPath.Path() == (*it_aux)->m_SheetPath.Path() )
+                loc_labelList.insert( *it_aux );
+        }
+
+        // at this point, loc_labelList contains labels of the current sheet path.
+        // Detect similar labels (same label names appears only once in list)
+        std::set<NETLIST_OBJECT*>::const_iterator ref_it;
+
+        for( ref_it = loc_labelList.begin(); ref_it != loc_labelList.end(); ++ref_it )
+        {
+            NETLIST_OBJECT* ref_item = *ref_it;
+            it_aux = ref_it;
+
+            for( ++it_aux; it_aux != loc_labelList.end(); ++it_aux )
+            {
+                // global label versus global label was already examined.
+                // here, at least one label must be local
+                if( ref_item->IsLabelGlobal() && (*it_aux)->IsLabelGlobal() )
+                    continue;
+
+                if( ref_item->m_Label.CmpNoCase( (*it_aux)->m_Label ) == 0 )
+                {
+                    // Create new marker for ERC.
+                    int cntA = countIndenticalLabels( fullLabelList, ref_item );
+                    int cntB = countIndenticalLabels( fullLabelList, *it_aux );
+
+                    if( cntA <= cntB )
+                        SimilarLabelsDiagnose( ref_item, (*it_aux) );
+                    else
+                        SimilarLabelsDiagnose( (*it_aux), ref_item );
+                }
+            }
+        }
+    }
+}
+
+// Helper function: count the number of labels identical to aLabel
+//  for global label: global labels in the full project
+//  for local label: all labels in the current sheet
+static int countIndenticalLabels( std::vector<NETLIST_OBJECT*>& aList, NETLIST_OBJECT* aLabel )
+{
+    int count = 0;
+
+    if( aLabel->IsLabelGlobal() )
+    {
+        for( unsigned netItem = 0; netItem < aList.size(); ++netItem )
+        {
+            NETLIST_OBJECT* item = aList[netItem];
+
+            if( item->IsLabelGlobal() && item->m_Label == aLabel->m_Label )
+                count++;
+        }
+    }
+    else
+    {
+        for( unsigned netItem = 0; netItem < aList.size(); ++netItem )
+        {
+            NETLIST_OBJECT* item = aList[netItem];
+
+            if( item->m_Label == aLabel->m_Label &&
+                item->m_SheetPath.Path() == aLabel->m_SheetPath.Path() )
+                count++;
+        }
+    }
+
+    return count;
+}
+
+// Helper function: creates a marker for similar labels ERC warning
+static void SimilarLabelsDiagnose( NETLIST_OBJECT* aItemA, NETLIST_OBJECT* aItemB )
+{
+    // Create new marker for ERC.
+    SCH_MARKER* marker = new SCH_MARKER();
+
+    marker->SetTimeStamp( GetNewTimeStamp() );
+    marker->SetMarkerType( MARKER_BASE::MARKER_ERC );
+    marker->SetErrorLevel( MARKER_BASE::MARKER_SEVERITY_WARNING );
+    SCH_SCREEN* screen = aItemA->m_SheetPath.LastScreen();
+    screen->Append( marker );
+
+    wxString fmt = aItemA->IsLabelGlobal() ?
+                            _( "Global label '%s' (sheet '%s') looks like:" ) :
+                            _( "Local label '%s' (sheet '%s') looks like:" );
+    wxString msg;
+
+    msg.Printf( fmt, GetChars( aItemA->m_Label ), GetChars( aItemA->m_SheetPath.PathHumanReadable() ) );
+    marker->SetData( aItemA->IsLabelGlobal() && aItemB->IsLabelGlobal() ?
+                            ERCE_SIMILAR_GLBL_LABELS : ERCE_SIMILAR_LABELS,
+                     aItemA->m_Start, msg, aItemA->m_Start );
+
+    fmt = aItemB->IsLabelGlobal() ? _( "Global label '%s' (sheet '%s')" ) :
+                                    _( "Local label '%s' (sheet '%s')" );
+    msg.Printf( fmt, GetChars( aItemB->m_Label ), GetChars( aItemB->m_SheetPath.PathHumanReadable() ) );
+    marker->SetAuxiliaryData( msg, aItemB->m_Start );
+}

eeschema/erc.h

@@ -31,7 +31,7 @@
 #define _ERC_H
 
 
-class EDA_DRAW_PANEL;
+//class EDA_DRAW_PANEL;
 class NETLIST_OBJECT;
 class NETLIST_OBJECT_LIST;
 
@@ -58,6 +58,8 @@ extern const wxString CommentERC_V[];
 #define ERCE_HIERACHICAL_LABEL    6    // mismatch between hierarchical labels and pins sheets
 #define ERCE_NOCONNECT_CONNECTED  7    // a no connect symbol is connected to more than 1 pin
 #define ERCE_GLOBLABEL            8    // global label not connected to any other global label
+#define ERCE_SIMILAR_LABELS       9    // 2 labels are equal fir case insensitive comparisons
+#define ERCE_SIMILAR_GLBL_LABELS  10   // 2 labels are equal fir case insensitive comparisons
 
 /* Minimal connection table */
 #define NPI    4  // Net with Pin isolated, this pin has type Not Connected and must be left N.C.
@@ -73,14 +75,14 @@ extern const wxString CommentERC_V[];
  *
  * @param aFullFileName A wxString object containing the file name and path.
  */
-extern bool WriteDiagnosticERC( const wxString& aFullFileName );
+bool WriteDiagnosticERC( const wxString& aFullFileName );
 
 /**
  * Performs ERC testing and creates an ERC marker to show the ERC problem for aNetItemRef
  * or between aNetItemRef and aNetItemTst.
  *  if MinConn < 0: this is an error on labels
  */
-extern void Diagnose( NETLIST_OBJECT* NetItemRef, NETLIST_OBJECT* NetItemTst,
+void Diagnose( NETLIST_OBJECT* NetItemRef, NETLIST_OBJECT* NetItemTst,
                       int MinConnexion, int Diag );
 
 /**
@@ -92,27 +94,10 @@ extern void Diagnose( NETLIST_OBJECT* NetItemRef, NETLIST_OBJECT* NetItemTst,
  * @param aMinConnexion = a pointer to a variable to store the minimal connection
  * found( NOD, DRV, NPI, NET_NC)
  */
-extern void TestOthersItems( NETLIST_OBJECT_LIST* aList,
+void TestOthersItems( NETLIST_OBJECT_LIST* aList,
                              unsigned aNetItemRef, unsigned aNetStart,
                              int* aMinConnexion );
 
-/**
- * Counts number of pins connected on the same net.
- * Used to find all pins conected to a no connect symbol
- * @return the pin count of the net starting at aNetStart
- * @param aNetStart = index in list of net objects of the first item
- * @param aList = a reference to the list of connected objects
- */
-int CountPinsInNet( NETLIST_OBJECT_LIST* aList, unsigned aNetStart );
-
-
-/**
- * Function TestLabel
- * performs an ERC on a sheet labels to verify that it is connected to a corresponding
- * sub sheet global label.
- */
-extern void TestLabel( NETLIST_OBJECT_LIST* aList, unsigned aNetItemRef, unsigned aStartNet );
-
 /**
  * Function TestDuplicateSheetNames( )
  * inside a given sheet, one cannot have sheets with duplicate names (file
@@ -121,7 +106,7 @@ extern void TestLabel( NETLIST_OBJECT_LIST* aList, unsigned aNetItemRef, unsigne
  * @param aCreateMarker: true = create error markers in schematic,
  *                       false = calculate error count only
  */
-extern int TestDuplicateSheetNames( bool aCreateMarker );
+int TestDuplicateSheetNames( bool aCreateMarker );
 
 
 #endif  // _ERC_H

eeschema/netlist.cpp

@@ -52,19 +52,12 @@
 
 /** @brief Kicad can use case sensitive or case insensitive comparisons for labels
  * Currently, it uses case insensitive.
- * Can be changed by defining LABEL_CASE_SENSITIVE (uncomment next line).
+ * Can be changed by comment/uncomment next lines.
  */
-//#define LABEL_CASE_SENSITIVE
-/// Compiler controlled string compare function, either case independent or not:
 inline int CmpLabel_KEEPCASE( const wxString& aString1, const wxString& aString2 )
 {
-#ifdef LABEL_CASE_SENSITIVE
+    return aString1.Cmp( aString2 );          // case sensitive
-    // case specificity, the normal behavior:
+    //return aString1.CmpNoCase( aString2 );  // case insensitive
-    return aString1.Cmp( aString2 );
-#else
-    // case independence (only for guys who want that: not recommended)
-    return aString1.CmpNoCase( aString2 );
-#endif
 }
 
 

eeschema/sch_sheet.cpp

@@ -1253,6 +1253,31 @@ bool SCH_SHEET::IsModified() const
 }
 
 
+bool SCH_SHEET::IsAutoSaveRequired()
+{
+    if( m_screen->IsModify() )
+        return true;
+
+    bool      retv = false;
+    SCH_ITEM* item = m_screen->GetDrawItems();
+
+    while( item && !retv )
+    {
+        if( item->Type() == SCH_SHEET_T )
+        {
+            SCH_SHEET* sheet = static_cast<SCH_SHEET*>( item );
+
+            if( sheet->m_screen )
+                retv = sheet->m_screen->IsSave();
+        }
+
+        item = item->Next();
+    }
+
+    return retv;
+}
+
+
 void SCH_SHEET::ClearModifyStatus()
 {
     m_screen->ClrModify();

eeschema/sch_sheet.h

@@ -649,6 +649,13 @@ public:
      */
     void ClearModifyStatus();
 
+    /**
+     * Function IsAutoSaveRequired
+     * checks the entire hierarchy for any modifications that require auto save.
+     * @return True if the hierarchy is modified otherwise false.
+     */
+    bool IsAutoSaveRequired();
+
 #if defined(DEBUG)
     void Show( int nestLevel, std::ostream& os ) const;     // override
 #endif

eeschema/sch_sheet_path.cpp

@@ -684,18 +684,6 @@ void SCH_SHEET_LIST::BuildSheetList( SCH_SHEET* aSheet )
 }
 
 
-bool SCH_SHEET_LIST::IsAutoSaveRequired()
-{
-    for( SCH_SHEET_PATH* sheet = GetFirst(); sheet; sheet = GetNext() )
-    {
-        if( sheet->LastScreen() && sheet->LastScreen()->IsSave() )
-            return true;
-    }
-
-    return false;
-}
-
-
 void SCH_SHEET_LIST::AnnotatePowerSymbols( PART_LIBS* aLibs )
 {
     int ref = 1;

eeschema/sch_sheet_path.h

@@ -436,13 +436,6 @@ public:
      */
     SCH_SHEET_PATH* GetSheetByPath( const wxString aPath, bool aHumanReadable = true );
 
-    /**
-     * Function IsAutoSaveRequired
-     * checks the entire hierarchy for any modifications that require auto save.
-     * @return True if the hierarchy is modified otherwise false.
-     */
-    bool IsAutoSaveRequired();
-
     /**
      * Function AnnotatePowerSymbols
      * clear and annotates the entire hierarchy of the sheet path list.

eeschema/schframe.cpp

@@ -1179,12 +1179,9 @@ bool SCH_EDIT_FRAME::isAutoSaveRequired() const
 {
     // In case this event happens before g_RootSheet is initialized which does happen
     // on mingw64 builds.
-
     if( g_RootSheet != NULL )
     {
-        SCH_SHEET_LIST sheetList;
+        return g_RootSheet->IsAutoSaveRequired();
-
-        return sheetList.IsAutoSaveRequired();
     }
 
     return false;

include/eda_pattern_match.h

@@ -0,0 +1,98 @@
+/* -*- c++ -*-
+ * This program source code file is part of KiCad, a free EDA CAD application.
+ *
+ * Copyright (C) 2015 Chris Pavlina <pavlina.chris@gmail.com>
+ * Copyright (C) 2015 KiCad Developers, see change_log.txt for contributors.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, you may find one here:
+ * http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ * or you may search the http://www.gnu.org website for the version 2 license,
+ * or you may write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ */
+
+/**
+ * @file eda_pattern_match.h
+ * @brief Abstract pattern-matching tool and implementations.
+ */
+
+#ifndef EDA_PATTERN_MATCH_H
+#define EDA_PATTERN_MATCH_H
+
+#include <vector>
+#include <wx/wx.h>
+#include <wx/string.h>
+#include <wx/regex.h>
+
+static const int EDA_PATTERN_NOT_FOUND = wxNOT_FOUND;
+
+/*
+ * Interface for a pattern matcher, for which there are several implementations
+ */
+class EDA_PATTERN_MATCH
+{
+public:
+    virtual ~EDA_PATTERN_MATCH() {}
+
+    /**
+     * Set the pattern against which candidates will be matched. If the pattern
+     * can not be processed, returns false.
+     */
+    virtual bool SetPattern( const wxString& aPattern ) = 0;
+
+    /**
+     * Return the location of a match iff a given candidate string matches the set pattern.
+     * Otherwise, return EDA_PATTERN_NOT_FOUND.
+     */
+    virtual int Find( const wxString& aCandidate ) const = 0;
+};
+
+
+/*
+ * Match simple substring
+ */
+class EDA_PATTERN_MATCH_SUBSTR : public EDA_PATTERN_MATCH
+{
+public:
+    virtual bool SetPattern( const wxString& aPattern );
+    virtual int Find( const wxString& aCandidate ) const;
+
+protected:
+    wxString m_pattern;
+};
+
+
+/*
+ * Match regular expression
+ */
+class EDA_PATTERN_MATCH_REGEX : public EDA_PATTERN_MATCH
+{
+public:
+    virtual bool SetPattern( const wxString& aPattern );
+    virtual int Find( const wxString& aCandidate ) const;
+
+protected:
+    wxString m_pattern;
+    wxRegEx m_regex;
+};
+
+
+class EDA_PATTERN_MATCH_WILDCARD : public EDA_PATTERN_MATCH_REGEX
+{
+public:
+    virtual bool SetPattern( const wxString& aPattern );
+    virtual int Find( const wxString& aCandidate ) const;
+};
+
+#endif  // EDA_PATTERN_MATCH_H

include/kicad_curl/kicad_curl.h

@@ -0,0 +1,82 @@
+/*
+ * This program source code file is part of KiCad, a free EDA CAD application.
+ *
+ * Copyright (C) 2015 Mark Roszko <mark.roszko@gmail.com>
+ * Copyright (C) 2015 KiCad Developers, see CHANGELOG.TXT for contributors.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 3
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, you may find one here:
+ * http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ * or you may search the http://www.gnu.org website for the version 2 license,
+ * or you may write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ */
+#ifndef KICAD_CURL_H_
+#define KICAD_CURL_H_
+
+/*
+ * KICAD_CURL.h must be included before wxWidgets because on Windows,
+ * wxWidgets ends up including windows.h before winsocks2.h inside curl
+ * this causes build warnings
+ * Because we are before wx, we must explicitly define we are building with unicode.
+ * wxWidgets defaults to supporting unicode now, so this should be safe.
+ */
+#if defined(WIN32)
+    #ifndef UNICODE
+    #    define UNICODE
+    #endif
+
+    #ifndef _UNICODE
+    #    define _UNICODE
+    #endif
+#endif
+
+#include <curl/curl.h>
+#include <string>
+
+/**
+ * Class KICAD_CURL
+ * simple wrapper class to call curl_global_init and curl_global_cleanup for KiCad.
+ */
+class KICAD_CURL
+{
+public:
+    /**
+     * Function Init
+     * calls curl_global_init for the application. It must be used only once
+     * and before any curl functions that perform requests.
+     *
+     * @return bool - True if successful, false if CURL returned an error
+     */
+    static bool Init();
+
+    /**
+     * Function Cleanup
+     * calls curl_global_cleanup for the application. It must be used only after
+     * curl_global_init was called.
+     */
+    static void Cleanup();
+
+    /**
+     * Function GetVersion
+     * wrapper for curl_version(). Reports back a short string of loaded libraries.
+     *
+     * @return std::string - String reported by libcurl
+     */
+    static std::string GetVersion();
+
+private:
+    static bool m_initialized;
+};
+
+#endif // KICAD_CURL_H_

include/kicad_curl/kicad_curl_easy.h

@@ -0,0 +1,166 @@
+/*
+ * This program source code file is part of KiCad, a free EDA CAD application.
+ *
+ * Copyright (C) 2015 Mark Roszko <mark.roszko@gmail.com>
+ * Copyright (C) 2015 KiCad Developers, see CHANGELOG.TXT for contributors.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 3
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, you may find one here:
+ * http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ * or you may search the http://www.gnu.org website for the version 2 license,
+ * or you may write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ */
+#ifndef KICAD_CURL_EASY_H_
+#define KICAD_CURL_EASY_H_
+
+/*
+ * KICAD_CURL_EASY.h must included before wxWidgets because on Windows,
+ * wxWidgets ends up including windows.h before winsocks2.h inside curl
+ * this causes build warnings 
+ * Because we are before wx, we must explicitly define we are building with unicode
+ * wxWidgets defaults to supporting unicode now, so this should be safe.
+ */
+#if defined(WIN32)
+    #ifndef UNICODE
+    #    define UNICODE
+    #endif
+
+    #ifndef _UNICODE
+    #    define _UNICODE
+    #endif
+#endif
+
+
+#include <curl/curl.h>
+#include <string>
+
+/**
+ * Struct KICAD_EASY_CURL_BUFFER
+ * is a struct used for storing the libcurl received data in its callbacks.
+ * Do not use directly, KICAD_CURL_EASY uses it.
+ */
+struct KICAD_EASY_CURL_BUFFER
+{
+    char* payload;
+    size_t size;
+};
+
+
+/**
+ * Class KICAD_CURL_EASY
+ * wrapper interface around the curl_easy API
+ *
+ * Handling of using the curl_easy API to make a request and save the response to
+ * a memory buffer
+ *
+ * Here is a small example usage:
+ * @code
+ *   KICAD_CURL_EASY curl;
+ *   curl.SetURL("http://github.com");
+ *   curl.SetUserAgent("KiCad-EDA");
+ *   curl.SetHeader("Accept", "application/json");
+ *   curl.Perform();
+ * @endcode
+ */
+class KICAD_CURL_EASY
+{
+public:
+    KICAD_CURL_EASY();
+    ~KICAD_CURL_EASY();
+
+    /**
+     * Function perform
+     * equivalent to curl_easy_perform. Executes the request
+     * that was previously setup.
+     *
+     * @throw IO_ERROR, if there is a CURL request error
+     */
+    void Perform();
+
+    /**
+     * Function SetHeader
+     * sets an arbitrary header for the HTTP(s) request.
+     *
+     * @param aName is the left hand side of the header, i.e. Accept without the colon
+     * @param aValue is the right hand side of the header, i.e. application/json
+     */
+    void SetHeader( const std::string& aName, const std::string& aValue );
+
+    /**
+     * Function SetUserAgent
+     * sets the request user agent
+     *
+     * @param aAgent is the string to set for the user agent
+     * @return bool - True if successful, false if not
+     */
+    bool SetUserAgent( const std::string& aAgent );
+
+    /**
+     * Function SetURL
+     * sets the request URL
+     *
+     * @param aURL is the URL
+     * @return bool - True if successful, false if not
+     */
+    bool SetURL( const std::string& aURL );
+
+    /**
+     * Function SetFollowRedirects
+     * enables the following of HTTP(s) and other redirects, by default curl
+     * does not follow redirects.
+     *
+     * @param aFollow is a boolean where true will enable following redirects
+     * @return bool - True if successful, false if not
+     */
+    bool SetFollowRedirects( bool aFollow );
+
+    /**
+     * Function GetErrorText
+     * fetches CURL's "friendly" error string for a given error code
+     *
+     * @param aCode is CURL error code
+     * @return std::string - the corresponding error string for the given code
+     */
+    std::string GetErrorText( CURLcode aCode );
+
+    /**
+     * Function SetOption
+     * sets a curl option, only supports single parameter curl options
+     *
+     * @param aOption is CURL option, see CURL manual for options
+     * @param aArg is the argument being passed to CURL, ensure it is the right type per manual
+     * @return CURLcode - CURL error code, will return CURLE_OK unless a problem was encountered
+     */
+    template <typename T> CURLcode SetOption( CURLoption aOption, T aArg ) 
+    { 
+        return curl_easy_setopt( m_CURL, aOption, aArg ); 
+    }
+
+    /**
+     * Function GetBuffer
+     * returns a const pointer to the data buffer
+     *
+     * @return KICAD_EASY_CURL_BUFFER* - pointer to buffer
+     */
+    const KICAD_EASY_CURL_BUFFER* GetBuffer()
+    {
+        return &m_Buffer;
+    }
+private:
+    CURL *m_CURL;
+    struct curl_slist *m_headers;
+    struct KICAD_EASY_CURL_BUFFER m_Buffer;
+};
+
+#endif // KICAD_CURL_EASY_H_

include/wxBasePcbFrame.h

@@ -76,9 +76,6 @@ public:
     int m_FastGrid1;                // 1st fast grid setting (index in EDA_DRAW_FRAME::m_gridSelectBox)
     int m_FastGrid2;                // 2nd fast grid setting (index in EDA_DRAW_FRAME::m_gridSelectBox)
 
-    EDA_3D_FRAME* m_Draw3DFrame;
-
-
 protected:
     BOARD*              m_Pcb;
     GENERAL_COLLECTOR*  m_Collector;
@@ -111,6 +108,11 @@ public:
 
     ~PCB_BASE_FRAME();
 
+    /**
+     * @return a reference to the 3D viewer frame, when exists, or NULL
+     */
+    EDA_3D_FRAME* Get3DViewerFrame();
+
     /**
      * Function LoadFootprint
      * attempts to load \a aFootprintId from the footprint library table.
@@ -283,12 +285,17 @@ public:
      * puts up a dialog and allows the user to pick a library, for unspecified use.
      *
      * @param aNicknameExisting is the current choice to highlight
-     *
      * @return wxString - the library or wxEmptyString on abort.
      */
     wxString SelectLibrary( const wxString& aNicknameExisting );
 
-    MODULE* GetModuleByName();
+    /**
+     * Function GetFootprintFromBoardByReference
+     * @return a reference to the footprint found by its refence
+     * on the curent board. the reference is entered by the user from
+     * a dialog (by awxTextCtlr, or a list of available references)
+     */
+    MODULE* GetFootprintFromBoardByReference();
 
     /**
      * Function OnModify

include/wxPcbStruct.h

@@ -1552,6 +1552,8 @@ public:
     // Autoplacement:
     void OnPlaceOrRouteFootprints( wxCommandEvent& event );
 
+#if defined( KICAD_SCRIPTING_WXPYTHON )
+
     /**
      * Function ScriptingConsoleEnableDisable
      * enables or disabled the scripting console
@@ -1560,6 +1562,8 @@ public:
 
     void OnUpdateScriptingConsoleState( wxUpdateUIEvent& aEvent );
 
+#endif
+
     void OnSelectAutoPlaceMode( wxCommandEvent& aEvent );
 
     /**

pcbnew/CMakeLists.txt

@@ -88,6 +88,7 @@ set( PCBNEW_DIALOGS
     dialogs/dialog_gen_module_position_file_base.cpp
     dialogs/dialog_general_options.cpp
     dialogs/dialog_general_options_BoardEditor_base.cpp
+    dialogs/dialog_get_footprint_by_name_base.cpp
     dialogs/dialog_global_edit_tracks_and_vias.cpp
     dialogs/dialog_global_edit_tracks_and_vias_base.cpp
     dialogs/dialog_global_modules_fields_edition.cpp
@@ -678,6 +679,12 @@ if( KICAD_SCRIPTING )
         DESTINATION ${KICAD_DATA}/scripting/plugins
         FILE_PERMISSIONS OWNER_EXECUTE OWNER_READ OWNER_WRITE GROUP_EXECUTE GROUP_READ WORLD_EXECUTE WORLD_READ
     )
+
+    # scripting python shell
+    install( DIRECTORY ${PROJECT_SOURCE_DIR}/pcbnew/scripting/kicad_pyshell/
+        DESTINATION ${KICAD_DATA}/scripting/kicad_pyshell
+        FILE_PERMISSIONS OWNER_EXECUTE OWNER_READ OWNER_WRITE GROUP_EXECUTE GROUP_READ WORLD_EXECUTE WORLD_READ
+    )
 endif()
 
 if( KICAD_SCRIPTING_MODULES )

pcbnew/basepcbframe.cpp

@@ -39,6 +39,8 @@
 #include <base_units.h>
 #include <msgpanel.h>
 
+#include <3d_viewer.h>
+
 #include <pcbnew.h>
 #include <fp_lib_table.h>
 #include <pcbnew_id.h>
@@ -98,7 +100,6 @@ PCB_BASE_FRAME::PCB_BASE_FRAME( KIWAY* aKiway, wxWindow* aParent, FRAME_T aFrame
     EDA_DRAW_FRAME( aKiway, aParent, aFrameType, aTitle, aPos, aSize, aStyle, aFrameName )
 {
     m_Pcb                 = NULL;
-    m_Draw3DFrame         = NULL;   // Display Window in 3D mode (OpenGL)
 
     m_UserGridSize        = wxRealPoint( 100.0, 100.0 );
     m_UserGridUnit        = INCHES;
@@ -123,6 +124,14 @@ PCB_BASE_FRAME::~PCB_BASE_FRAME()
 }
 
 
+EDA_3D_FRAME* PCB_BASE_FRAME::Get3DViewerFrame()
+{
+    // return the 3D viewer frame, when exists, or NULL
+    return dynamic_cast<EDA_3D_FRAME*>
+        ( wxWindow::FindWindowByName( VIEWER3D_FRAMENAME ) );
+}
+
+
 FP_LIB_TABLE* PROJECT::PcbFootprintLibs()
 {
     // This is a lazy loading function, it loads the project specific table when

pcbnew/class_pad_draw_functions.cpp

@@ -423,6 +423,7 @@ void D_PAD::DrawShape( EDA_RECT* aClipBox, wxDC* aDC, PAD_DRAWINFO& aDrawInfo )
             blackpenstate = GetGRForceBlackPenState();
             GRForceBlackPen( false );
             aDrawInfo.m_HoleColor = WHITE;
+            aDrawInfo.m_NPHoleColor = WHITE;
         }
         else
         {

pcbnew/dialogs/dialog_copper_zones.cpp

@@ -452,7 +452,9 @@ bool DIALOG_COPPER_ZONE::AcceptOptions( bool aPromptForErrors, bool aUseExportab
             (double) m_settings.m_ThermalReliefCopperBridge / IU_PER_MILS );
     }
 
-    if( m_settings.m_ThermalReliefCopperBridge <= m_settings.m_ZoneMinThickness )
+    if( (   m_settings.GetPadConnection() == PAD_ZONE_CONN_THT_THERMAL
+         || m_settings.GetPadConnection() == PAD_ZONE_CONN_THERMAL )
+        && m_settings.m_ThermalReliefCopperBridge <= m_settings.m_ZoneMinThickness )
     {
         DisplayError( this,
                       _( "Thermal relief spoke must be greater than the minimum width." ) );

pcbnew/dialogs/dialog_find_base.fbp

@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
 <wxFormBuilder_Project>
-    <FileVersion major="1" minor="11" />
+    <FileVersion major="1" minor="13" />
     <object class="Project" expanded="1">
-        <property name="class_decoration"></property>
+        <property name="class_decoration" />
         <property name="code_generation">C++</property>
         <property name="disconnect_events">1</property>
         <property name="disconnect_mode">source_name</property>
@@ -16,9 +16,9 @@
         <property name="help_provider">none</property>
         <property name="internationalize">1</property>
         <property name="name">dialog_find</property>
-        <property name="namespace"></property>
+        <property name="namespace" />
         <property name="path">.</property>
-        <property name="precompiled_header"></property>
+        <property name="precompiled_header" />
         <property name="relative_path">1</property>
         <property name="skip_php_events">1</property>
         <property name="skip_python_events">1</property>
@@ -27,67 +27,67 @@
         <object class="Dialog" expanded="1">
             <property name="aui_managed">0</property>
             <property name="aui_manager_style">wxAUI_MGR_DEFAULT</property>
-            <property name="bg"></property>
+            <property name="bg" />
             <property name="center">wxBOTH</property>
-            <property name="context_help"></property>
+            <property name="context_help" />
             <property name="context_menu">1</property>
             <property name="enabled">1</property>
             <property name="event_handler">impl_virtual</property>
-            <property name="extra_style"></property>
+            <property name="extra_style" />
-            <property name="fg"></property>
+            <property name="fg" />
-            <property name="font"></property>
+            <property name="font" />
             <property name="hidden">0</property>
             <property name="id">wxID_ANY</property>
-            <property name="maximum_size"></property>
+            <property name="maximum_size" />
-            <property name="minimum_size"></property>
+            <property name="minimum_size" />
             <property name="name">DIALOG_FIND_BASE</property>
-            <property name="pos"></property>
+            <property name="pos" />
             <property name="size">-1,-1</property>
             <property name="style">wxDEFAULT_DIALOG_STYLE|wxRESIZE_BORDER</property>
             <property name="subclass">DIALOG_SHIM; dialog_shim.h</property>
             <property name="title">Find</property>
-            <property name="tooltip"></property>
+            <property name="tooltip" />
-            <property name="window_extra_style"></property>
+            <property name="window_extra_style" />
-            <property name="window_name"></property>
+            <property name="window_name" />
-            <property name="window_style"></property>
+            <property name="window_style" />
-            <event name="OnActivate"></event>
+            <event name="OnActivate" />
-            <event name="OnActivateApp"></event>
+            <event name="OnActivateApp" />
-            <event name="OnAuiFindManager"></event>
+            <event name="OnAuiFindManager" />
-            <event name="OnAuiPaneButton"></event>
+            <event name="OnAuiPaneButton" />
-            <event name="OnAuiPaneClose"></event>
+            <event name="OnAuiPaneClose" />
-            <event name="OnAuiPaneMaximize"></event>
+            <event name="OnAuiPaneMaximize" />
-            <event name="OnAuiPaneRestore"></event>
+            <event name="OnAuiPaneRestore" />
-            <event name="OnAuiRender"></event>
+            <event name="OnAuiRender" />
-            <event name="OnChar"></event>
+            <event name="OnChar" />
             <event name="OnClose">onClose</event>
-            <event name="OnEnterWindow"></event>
+            <event name="OnEnterWindow" />
-            <event name="OnEraseBackground"></event>
+            <event name="OnEraseBackground" />
-            <event name="OnHibernate"></event>
+            <event name="OnHibernate" />
-            <event name="OnIconize"></event>
+            <event name="OnIconize" />
-            <event name="OnIdle"></event>
+            <event name="OnIdle" />
-            <event name="OnInitDialog"></event>
+            <event name="OnInitDialog" />
-            <event name="OnKeyDown"></event>
+            <event name="OnKeyDown" />
-            <event name="OnKeyUp"></event>
+            <event name="OnKeyUp" />
-            <event name="OnKillFocus"></event>
+            <event name="OnKillFocus" />
-            <event name="OnLeaveWindow"></event>
+            <event name="OnLeaveWindow" />
-            <event name="OnLeftDClick"></event>
+            <event name="OnLeftDClick" />
-            <event name="OnLeftDown"></event>
+            <event name="OnLeftDown" />
-            <event name="OnLeftUp"></event>
+            <event name="OnLeftUp" />
-            <event name="OnMiddleDClick"></event>
+            <event name="OnMiddleDClick" />
-            <event name="OnMiddleDown"></event>
+            <event name="OnMiddleDown" />
-            <event name="OnMiddleUp"></event>
+            <event name="OnMiddleUp" />
-            <event name="OnMotion"></event>
+            <event name="OnMotion" />
-            <event name="OnMouseEvents"></event>
+            <event name="OnMouseEvents" />
-            <event name="OnMouseWheel"></event>
+            <event name="OnMouseWheel" />
-            <event name="OnPaint"></event>
+            <event name="OnPaint" />
-            <event name="OnRightDClick"></event>
+            <event name="OnRightDClick" />
-            <event name="OnRightDown"></event>
+            <event name="OnRightDown" />
-            <event name="OnRightUp"></event>
+            <event name="OnRightUp" />
-            <event name="OnSetFocus"></event>
+            <event name="OnSetFocus" />
-            <event name="OnSize"></event>
+            <event name="OnSize" />
-            <event name="OnUpdateUI"></event>
+            <event name="OnUpdateUI" />
             <object class="wxBoxSizer" expanded="1">
-                <property name="minimum_size"></property>
+                <property name="minimum_size" />
                 <property name="name">bSizerMain</property>
                 <property name="orient">wxHORIZONTAL</property>
                 <property name="permission">none</property>
@@ -96,7 +96,7 @@
                     <property name="flag">wxEXPAND|wxTOP|wxBOTTOM</property>
                     <property name="proportion">1</property>
                     <object class="wxBoxSizer" expanded="1">
-                        <property name="minimum_size"></property>
+                        <property name="minimum_size" />
                         <property name="name">bSizerLeft</property>
                         <property name="orient">wxVERTICAL</property>
                         <property name="permission">none</property>
@@ -109,78 +109,78 @@
                                 <property name="LeftDockable">1</property>
                                 <property name="RightDockable">1</property>
                                 <property name="TopDockable">1</property>
-                                <property name="aui_layer"></property>
+                                <property name="aui_layer" />
-                                <property name="aui_name"></property>
+                                <property name="aui_name" />
-                                <property name="aui_position"></property>
+                                <property name="aui_position" />
-                                <property name="aui_row"></property>
+                                <property name="aui_row" />
-                                <property name="best_size"></property>
+                                <property name="best_size" />
-                                <property name="bg"></property>
+                                <property name="bg" />
-                                <property name="caption"></property>
+                                <property name="caption" />
                                 <property name="caption_visible">1</property>
                                 <property name="center_pane">0</property>
                                 <property name="close_button">1</property>
-                                <property name="context_help"></property>
+                                <property name="context_help" />
                                 <property name="context_menu">1</property>
                                 <property name="default_pane">0</property>
                                 <property name="dock">Dock</property>
                                 <property name="dock_fixed">0</property>
                                 <property name="docking">Left</property>
                                 <property name="enabled">1</property>
-                                <property name="fg"></property>
+                                <property name="fg" />
                                 <property name="floatable">1</property>
-                                <property name="font"></property>
+                                <property name="font" />
                                 <property name="gripper">0</property>
                                 <property name="hidden">0</property>
                                 <property name="id">wxID_ANY</property>
                                 <property name="label">Search for:</property>
-                                <property name="max_size"></property>
+                                <property name="max_size" />
                                 <property name="maximize_button">0</property>
-                                <property name="maximum_size"></property>
+                                <property name="maximum_size" />
-                                <property name="min_size"></property>
+                                <property name="min_size" />
                                 <property name="minimize_button">0</property>
-                                <property name="minimum_size"></property>
+                                <property name="minimum_size" />
                                 <property name="moveable">1</property>
                                 <property name="name">m_staticText1</property>
                                 <property name="pane_border">1</property>
-                                <property name="pane_position"></property>
+                                <property name="pane_position" />
-                                <property name="pane_size"></property>
+                                <property name="pane_size" />
                                 <property name="permission">protected</property>
                                 <property name="pin_button">1</property>
-                                <property name="pos"></property>
+                                <property name="pos" />
                                 <property name="resize">Resizable</property>
                                 <property name="show">1</property>
-                                <property name="size"></property>
+                                <property name="size" />
-                                <property name="style"></property>
+                                <property name="style" />
-                                <property name="subclass"></property>
+                                <property name="subclass" />
                                 <property name="toolbar_pane">0</property>
-                                <property name="tooltip"></property>
+                                <property name="tooltip" />
-                                <property name="window_extra_style"></property>
+                                <property name="window_extra_style" />
-                                <property name="window_name"></property>
+                                <property name="window_name" />
-                                <property name="window_style"></property>
+                                <property name="window_style" />
                                 <property name="wrap">-1</property>
-                                <event name="OnChar"></event>
+                                <event name="OnChar" />
-                                <event name="OnEnterWindow"></event>
+                                <event name="OnEnterWindow" />
-                                <event name="OnEraseBackground"></event>
+                                <event name="OnEraseBackground" />
-                                <event name="OnKeyDown"></event>
+                                <event name="OnKeyDown" />
-                                <event name="OnKeyUp"></event>
+                                <event name="OnKeyUp" />
-                                <event name="OnKillFocus"></event>
+                                <event name="OnKillFocus" />
-                                <event name="OnLeaveWindow"></event>
+                                <event name="OnLeaveWindow" />
-                                <event name="OnLeftDClick"></event>
+                                <event name="OnLeftDClick" />
-                                <event name="OnLeftDown"></event>
+                                <event name="OnLeftDown" />
-                                <event name="OnLeftUp"></event>
+                                <event name="OnLeftUp" />
-                                <event name="OnMiddleDClick"></event>
+                                <event name="OnMiddleDClick" />
-                                <event name="OnMiddleDown"></event>
+                                <event name="OnMiddleDown" />
-                                <event name="OnMiddleUp"></event>
+                                <event name="OnMiddleUp" />
-                                <event name="OnMotion"></event>
+                                <event name="OnMotion" />
-                                <event name="OnMouseEvents"></event>
+                                <event name="OnMouseEvents" />
-                                <event name="OnMouseWheel"></event>
+                                <event name="OnMouseWheel" />
-                                <event name="OnPaint"></event>
+                                <event name="OnPaint" />
-                                <event name="OnRightDClick"></event>
+                                <event name="OnRightDClick" />
-                                <event name="OnRightDown"></event>
+                                <event name="OnRightDown" />
-                                <event name="OnRightUp"></event>
+                                <event name="OnRightUp" />
-                                <event name="OnSetFocus"></event>
+                                <event name="OnSetFocus" />
-                                <event name="OnSize"></event>
+                                <event name="OnSize" />
-                                <event name="OnUpdateUI"></event>
+                                <event name="OnUpdateUI" />
                             </object>
                         </object>
                         <object class="sizeritem" expanded="1">
@@ -192,86 +192,86 @@
                                 <property name="LeftDockable">1</property>
                                 <property name="RightDockable">1</property>
                                 <property name="TopDockable">1</property>
-                                <property name="aui_layer"></property>
+                                <property name="aui_layer" />
-                                <property name="aui_name"></property>
+                                <property name="aui_name" />
-                                <property name="aui_position"></property>
+                                <property name="aui_position" />
-                                <property name="aui_row"></property>
+                                <property name="aui_row" />
-                                <property name="best_size"></property>
+                                <property name="best_size" />
-                                <property name="bg"></property>
+                                <property name="bg" />
-                                <property name="caption"></property>
+                                <property name="caption" />
                                 <property name="caption_visible">1</property>
                                 <property name="center_pane">0</property>
                                 <property name="close_button">1</property>
-                                <property name="context_help"></property>
+                                <property name="context_help" />
                                 <property name="context_menu">1</property>
                                 <property name="default_pane">0</property>
                                 <property name="dock">Dock</property>
                                 <property name="dock_fixed">0</property>
                                 <property name="docking">Left</property>
                                 <property name="enabled">1</property>
-                                <property name="fg"></property>
+                                <property name="fg" />
                                 <property name="floatable">1</property>
-                                <property name="font"></property>
+                                <property name="font" />
                                 <property name="gripper">0</property>
                                 <property name="hidden">0</property>
                                 <property name="id">wxID_ANY</property>
-                                <property name="max_size"></property>
+                                <property name="max_size" />
                                 <property name="maximize_button">0</property>
-                                <property name="maximum_size"></property>
+                                <property name="maximum_size" />
                                 <property name="maxlength">0</property>
-                                <property name="min_size"></property>
+                                <property name="min_size" />
                                 <property name="minimize_button">0</property>
-                                <property name="minimum_size"></property>
+                                <property name="minimum_size" />
                                 <property name="moveable">1</property>
                                 <property name="name">m_SearchTextCtrl</property>
                                 <property name="pane_border">1</property>
-                                <property name="pane_position"></property>
+                                <property name="pane_position" />
-                                <property name="pane_size"></property>
+                                <property name="pane_size" />
                                 <property name="permission">protected</property>
                                 <property name="pin_button">1</property>
-                                <property name="pos"></property>
+                                <property name="pos" />
                                 <property name="resize">Resizable</property>
                                 <property name="show">1</property>
                                 <property name="size">200,-1</property>
-                                <property name="style"></property>
+                                <property name="style" />
-                                <property name="subclass"></property>
+                                <property name="subclass" />
                                 <property name="toolbar_pane">0</property>
-                                <property name="tooltip"></property>
+                                <property name="tooltip" />
-                                <property name="validator_data_type"></property>
+                                <property name="validator_data_type" />
                                 <property name="validator_style">wxFILTER_NONE</property>
                                 <property name="validator_type">wxDefaultValidator</property>
-                                <property name="validator_variable"></property>
+                                <property name="validator_variable" />
-                                <property name="value"></property>
+                                <property name="value" />
-                                <property name="window_extra_style"></property>
+                                <property name="window_extra_style" />
-                                <property name="window_name"></property>
+                                <property name="window_name" />
-                                <property name="window_style"></property>
+                                <property name="window_style" />
-                                <event name="OnChar"></event>
+                                <event name="OnChar" />
-                                <event name="OnEnterWindow"></event>
+                                <event name="OnEnterWindow" />
-                                <event name="OnEraseBackground"></event>
+                                <event name="OnEraseBackground" />
-                                <event name="OnKeyDown"></event>
+                                <event name="OnKeyDown" />
-                                <event name="OnKeyUp"></event>
+                                <event name="OnKeyUp" />
-                                <event name="OnKillFocus"></event>
+                                <event name="OnKillFocus" />
-                                <event name="OnLeaveWindow"></event>
+                                <event name="OnLeaveWindow" />
-                                <event name="OnLeftDClick"></event>
+                                <event name="OnLeftDClick" />
-                                <event name="OnLeftDown"></event>
+                                <event name="OnLeftDown" />
-                                <event name="OnLeftUp"></event>
+                                <event name="OnLeftUp" />
-                                <event name="OnMiddleDClick"></event>
+                                <event name="OnMiddleDClick" />
-                                <event name="OnMiddleDown"></event>
+                                <event name="OnMiddleDown" />
-                                <event name="OnMiddleUp"></event>
+                                <event name="OnMiddleUp" />
-                                <event name="OnMotion"></event>
+                                <event name="OnMotion" />
-                                <event name="OnMouseEvents"></event>
+                                <event name="OnMouseEvents" />
-                                <event name="OnMouseWheel"></event>
+                                <event name="OnMouseWheel" />
-                                <event name="OnPaint"></event>
+                                <event name="OnPaint" />
-                                <event name="OnRightDClick"></event>
+                                <event name="OnRightDClick" />
-                                <event name="OnRightDown"></event>
+                                <event name="OnRightDown" />
-                                <event name="OnRightUp"></event>
+                                <event name="OnRightUp" />
-                                <event name="OnSetFocus"></event>
+                                <event name="OnSetFocus" />
-                                <event name="OnSize"></event>
+                                <event name="OnSize" />
-                                <event name="OnText"></event>
+                                <event name="OnText" />
-                                <event name="OnTextEnter"></event>
+                                <event name="OnTextEnter" />
-                                <event name="OnTextMaxLen"></event>
+                                <event name="OnTextMaxLen" />
-                                <event name="OnTextURL"></event>
+                                <event name="OnTextURL" />
-                                <event name="OnUpdateUI"></event>
+                                <event name="OnUpdateUI" />
                             </object>
                         </object>
                         <object class="sizeritem" expanded="1">
@@ -283,83 +283,83 @@
                                 <property name="LeftDockable">1</property>
                                 <property name="RightDockable">1</property>
                                 <property name="TopDockable">1</property>
-                                <property name="aui_layer"></property>
+                                <property name="aui_layer" />
-                                <property name="aui_name"></property>
+                                <property name="aui_name" />
-                                <property name="aui_position"></property>
+                                <property name="aui_position" />
-                                <property name="aui_row"></property>
+                                <property name="aui_row" />
-                                <property name="best_size"></property>
+                                <property name="best_size" />
-                                <property name="bg"></property>
+                                <property name="bg" />
-                                <property name="caption"></property>
+                                <property name="caption" />
                                 <property name="caption_visible">1</property>
                                 <property name="center_pane">0</property>
                                 <property name="checked">0</property>
                                 <property name="close_button">1</property>
-                                <property name="context_help"></property>
+                                <property name="context_help" />
                                 <property name="context_menu">1</property>
                                 <property name="default_pane">0</property>
                                 <property name="dock">Dock</property>
                                 <property name="dock_fixed">0</property>
                                 <property name="docking">Left</property>
                                 <property name="enabled">1</property>
-                                <property name="fg"></property>
+                                <property name="fg" />
                                 <property name="floatable">1</property>
-                                <property name="font"></property>
+                                <property name="font" />
                                 <property name="gripper">0</property>
                                 <property name="hidden">0</property>
                                 <property name="id">wxID_ANY</property>
                                 <property name="label">Do not warp mouse pointer</property>
-                                <property name="max_size"></property>
+                                <property name="max_size" />
                                 <property name="maximize_button">0</property>
-                                <property name="maximum_size"></property>
+                                <property name="maximum_size" />
-                                <property name="min_size"></property>
+                                <property name="min_size" />
                                 <property name="minimize_button">0</property>
-                                <property name="minimum_size"></property>
+                                <property name="minimum_size" />
                                 <property name="moveable">1</property>
                                 <property name="name">m_NoMouseWarpCheckBox</property>
                                 <property name="pane_border">1</property>
-                                <property name="pane_position"></property>
+                                <property name="pane_position" />
-                                <property name="pane_size"></property>
+                                <property name="pane_size" />
                                 <property name="permission">protected</property>
                                 <property name="pin_button">1</property>
-                                <property name="pos"></property>
+                                <property name="pos" />
                                 <property name="resize">Resizable</property>
                                 <property name="show">1</property>
-                                <property name="size"></property>
+                                <property name="size" />
-                                <property name="style"></property>
+                                <property name="style" />
-                                <property name="subclass"></property>
+                                <property name="subclass" />
                                 <property name="toolbar_pane">0</property>
-                                <property name="tooltip"></property>
+                                <property name="tooltip" />
-                                <property name="validator_data_type"></property>
+                                <property name="validator_data_type" />
                                 <property name="validator_style">wxFILTER_NONE</property>
                                 <property name="validator_type">wxDefaultValidator</property>
-                                <property name="validator_variable"></property>
+                                <property name="validator_variable" />
-                                <property name="window_extra_style"></property>
+                                <property name="window_extra_style" />
-                                <property name="window_name"></property>
+                                <property name="window_name" />
-                                <property name="window_style"></property>
+                                <property name="window_style" />
-                                <event name="OnChar"></event>
+                                <event name="OnChar" />
-                                <event name="OnCheckBox"></event>
+                                <event name="OnCheckBox" />
-                                <event name="OnEnterWindow"></event>
+                                <event name="OnEnterWindow" />
-                                <event name="OnEraseBackground"></event>
+                                <event name="OnEraseBackground" />
-                                <event name="OnKeyDown"></event>
+                                <event name="OnKeyDown" />
-                                <event name="OnKeyUp"></event>
+                                <event name="OnKeyUp" />
-                                <event name="OnKillFocus"></event>
+                                <event name="OnKillFocus" />
-                                <event name="OnLeaveWindow"></event>
+                                <event name="OnLeaveWindow" />
-                                <event name="OnLeftDClick"></event>
+                                <event name="OnLeftDClick" />
-                                <event name="OnLeftDown"></event>
+                                <event name="OnLeftDown" />
-                                <event name="OnLeftUp"></event>
+                                <event name="OnLeftUp" />
-                                <event name="OnMiddleDClick"></event>
+                                <event name="OnMiddleDClick" />
-                                <event name="OnMiddleDown"></event>
+                                <event name="OnMiddleDown" />
-                                <event name="OnMiddleUp"></event>
+                                <event name="OnMiddleUp" />
-                                <event name="OnMotion"></event>
+                                <event name="OnMotion" />
-                                <event name="OnMouseEvents"></event>
+                                <event name="OnMouseEvents" />
-                                <event name="OnMouseWheel"></event>
+                                <event name="OnMouseWheel" />
-                                <event name="OnPaint"></event>
+                                <event name="OnPaint" />
-                                <event name="OnRightDClick"></event>
+                                <event name="OnRightDClick" />
-                                <event name="OnRightDown"></event>
+                                <event name="OnRightDown" />
-                                <event name="OnRightUp"></event>
+                                <event name="OnRightUp" />
-                                <event name="OnSetFocus"></event>
+                                <event name="OnSetFocus" />
-                                <event name="OnSize"></event>
+                                <event name="OnSize" />
-                                <event name="OnUpdateUI"></event>
+                                <event name="OnUpdateUI" />
                             </object>
                         </object>
                     </object>
@@ -369,7 +369,7 @@
                     <property name="flag">wxALL</property>
                     <property name="proportion">0</property>
                     <object class="wxBoxSizer" expanded="1">
-                        <property name="minimum_size"></property>
+                        <property name="minimum_size" />
                         <property name="name">bSizerRight</property>
                         <property name="orient">wxVERTICAL</property>
                         <property name="permission">none</property>
@@ -382,17 +382,17 @@
                                 <property name="LeftDockable">1</property>
                                 <property name="RightDockable">1</property>
                                 <property name="TopDockable">1</property>
-                                <property name="aui_layer"></property>
+                                <property name="aui_layer" />
-                                <property name="aui_name"></property>
+                                <property name="aui_name" />
-                                <property name="aui_position"></property>
+                                <property name="aui_position" />
-                                <property name="aui_row"></property>
+                                <property name="aui_row" />
-                                <property name="best_size"></property>
+                                <property name="best_size" />
-                                <property name="bg"></property>
+                                <property name="bg" />
-                                <property name="caption"></property>
+                                <property name="caption" />
                                 <property name="caption_visible">1</property>
                                 <property name="center_pane">0</property>
                                 <property name="close_button">1</property>
-                                <property name="context_help"></property>
+                                <property name="context_help" />
                                 <property name="context_menu">1</property>
                                 <property name="default">1</property>
                                 <property name="default_pane">0</property>
@@ -400,65 +400,65 @@
                                 <property name="dock_fixed">0</property>
                                 <property name="docking">Left</property>
                                 <property name="enabled">1</property>
-                                <property name="fg"></property>
+                                <property name="fg" />
                                 <property name="floatable">1</property>
-                                <property name="font"></property>
+                                <property name="font" />
                                 <property name="gripper">0</property>
                                 <property name="hidden">0</property>
                                 <property name="id">wxID_ANY</property>
                                 <property name="label">Find Item</property>
-                                <property name="max_size"></property>
+                                <property name="max_size" />
                                 <property name="maximize_button">0</property>
-                                <property name="maximum_size"></property>
+                                <property name="maximum_size" />
-                                <property name="min_size"></property>
+                                <property name="min_size" />
                                 <property name="minimize_button">0</property>
-                                <property name="minimum_size"></property>
+                                <property name="minimum_size" />
                                 <property name="moveable">1</property>
                                 <property name="name">m_button1</property>
                                 <property name="pane_border">1</property>
-                                <property name="pane_position"></property>
+                                <property name="pane_position" />
-                                <property name="pane_size"></property>
+                                <property name="pane_size" />
                                 <property name="permission">protected</property>
                                 <property name="pin_button">1</property>
-                                <property name="pos"></property>
+                                <property name="pos" />
                                 <property name="resize">Resizable</property>
                                 <property name="show">1</property>
-                                <property name="size"></property>
+                                <property name="size" />
-                                <property name="style"></property>
+                                <property name="style" />
-                                <property name="subclass"></property>
+                                <property name="subclass" />
                                 <property name="toolbar_pane">0</property>
-                                <property name="tooltip"></property>
+                                <property name="tooltip" />
-                                <property name="validator_data_type"></property>
+                                <property name="validator_data_type" />
                                 <property name="validator_style">wxFILTER_NONE</property>
                                 <property name="validator_type">wxDefaultValidator</property>
-                                <property name="validator_variable"></property>
+                                <property name="validator_variable" />
-                                <property name="window_extra_style"></property>
+                                <property name="window_extra_style" />
-                                <property name="window_name"></property>
+                                <property name="window_name" />
-                                <property name="window_style"></property>
+                                <property name="window_style" />
                                 <event name="OnButtonClick">onButtonFindItemClick</event>
-                                <event name="OnChar"></event>
+                                <event name="OnChar" />
-                                <event name="OnEnterWindow"></event>
+                                <event name="OnEnterWindow" />
-                                <event name="OnEraseBackground"></event>
+                                <event name="OnEraseBackground" />
-                                <event name="OnKeyDown"></event>
+                                <event name="OnKeyDown" />
-                                <event name="OnKeyUp"></event>
+                                <event name="OnKeyUp" />
-                                <event name="OnKillFocus"></event>
+                                <event name="OnKillFocus" />
-                                <event name="OnLeaveWindow"></event>
+                                <event name="OnLeaveWindow" />
-                                <event name="OnLeftDClick"></event>
+                                <event name="OnLeftDClick" />
-                                <event name="OnLeftDown"></event>
+                                <event name="OnLeftDown" />
-                                <event name="OnLeftUp"></event>
+                                <event name="OnLeftUp" />
-                                <event name="OnMiddleDClick"></event>
+                                <event name="OnMiddleDClick" />
-                                <event name="OnMiddleDown"></event>
+                                <event name="OnMiddleDown" />
-                                <event name="OnMiddleUp"></event>
+                                <event name="OnMiddleUp" />
-                                <event name="OnMotion"></event>
+                                <event name="OnMotion" />
-                                <event name="OnMouseEvents"></event>
+                                <event name="OnMouseEvents" />
-                                <event name="OnMouseWheel"></event>
+                                <event name="OnMouseWheel" />
-                                <event name="OnPaint"></event>
+                                <event name="OnPaint" />
-                                <event name="OnRightDClick"></event>
+                                <event name="OnRightDClick" />
-                                <event name="OnRightDown"></event>
+                                <event name="OnRightDown" />
-                                <event name="OnRightUp"></event>
+                                <event name="OnRightUp" />
-                                <event name="OnSetFocus"></event>
+                                <event name="OnSetFocus" />
-                                <event name="OnSize"></event>
+                                <event name="OnSize" />
-                                <event name="OnUpdateUI"></event>
+                                <event name="OnUpdateUI" />
                             </object>
                         </object>
                         <object class="sizeritem" expanded="1">
@@ -470,17 +470,17 @@
                                 <property name="LeftDockable">1</property>
                                 <property name="RightDockable">1</property>
                                 <property name="TopDockable">1</property>
-                                <property name="aui_layer"></property>
+                                <property name="aui_layer" />
-                                <property name="aui_name"></property>
+                                <property name="aui_name" />
-                                <property name="aui_position"></property>
+                                <property name="aui_position" />
-                                <property name="aui_row"></property>
+                                <property name="aui_row" />
-                                <property name="best_size"></property>
+                                <property name="best_size" />
-                                <property name="bg"></property>
+                                <property name="bg" />
-                                <property name="caption"></property>
+                                <property name="caption" />
                                 <property name="caption_visible">1</property>
                                 <property name="center_pane">0</property>
                                 <property name="close_button">1</property>
-                                <property name="context_help"></property>
+                                <property name="context_help" />
                                 <property name="context_menu">1</property>
                                 <property name="default">0</property>
                                 <property name="default_pane">0</property>
@@ -488,65 +488,65 @@
                                 <property name="dock_fixed">0</property>
                                 <property name="docking">Left</property>
                                 <property name="enabled">1</property>
-                                <property name="fg"></property>
+                                <property name="fg" />
                                 <property name="floatable">1</property>
-                                <property name="font"></property>
+                                <property name="font" />
                                 <property name="gripper">0</property>
                                 <property name="hidden">0</property>
                                 <property name="id">wxID_ANY</property>
                                 <property name="label">Find Marker</property>
-                                <property name="max_size"></property>
+                                <property name="max_size" />
                                 <property name="maximize_button">0</property>
-                                <property name="maximum_size"></property>
+                                <property name="maximum_size" />
-                                <property name="min_size"></property>
+                                <property name="min_size" />
                                 <property name="minimize_button">0</property>
-                                <property name="minimum_size"></property>
+                                <property name="minimum_size" />
                                 <property name="moveable">1</property>
                                 <property name="name">m_button2</property>
                                 <property name="pane_border">1</property>
-                                <property name="pane_position"></property>
+                                <property name="pane_position" />
-                                <property name="pane_size"></property>
+                                <property name="pane_size" />
                                 <property name="permission">protected</property>
                                 <property name="pin_button">1</property>
-                                <property name="pos"></property>
+                                <property name="pos" />
                                 <property name="resize">Resizable</property>
                                 <property name="show">1</property>
-                                <property name="size"></property>
+                                <property name="size" />
-                                <property name="style"></property>
+                                <property name="style" />
-                                <property name="subclass"></property>
+                                <property name="subclass" />
                                 <property name="toolbar_pane">0</property>
-                                <property name="tooltip"></property>
+                                <property name="tooltip" />
-                                <property name="validator_data_type"></property>
+                                <property name="validator_data_type" />
                                 <property name="validator_style">wxFILTER_NONE</property>
                                 <property name="validator_type">wxDefaultValidator</property>
-                                <property name="validator_variable"></property>
+                                <property name="validator_variable" />
-                                <property name="window_extra_style"></property>
+                                <property name="window_extra_style" />
-                                <property name="window_name"></property>
+                                <property name="window_name" />
-                                <property name="window_style"></property>
+                                <property name="window_style" />
                                 <event name="OnButtonClick">onButtonFindMarkerClick</event>
-                                <event name="OnChar"></event>
+                                <event name="OnChar" />
-                                <event name="OnEnterWindow"></event>
+                                <event name="OnEnterWindow" />
-                                <event name="OnEraseBackground"></event>
+                                <event name="OnEraseBackground" />
-                                <event name="OnKeyDown"></event>
+                                <event name="OnKeyDown" />
-                                <event name="OnKeyUp"></event>
+                                <event name="OnKeyUp" />
-                                <event name="OnKillFocus"></event>
+                                <event name="OnKillFocus" />
-                                <event name="OnLeaveWindow"></event>
+                                <event name="OnLeaveWindow" />
-                                <event name="OnLeftDClick"></event>
+                                <event name="OnLeftDClick" />
-                                <event name="OnLeftDown"></event>
+                                <event name="OnLeftDown" />
-                                <event name="OnLeftUp"></event>
+                                <event name="OnLeftUp" />
-                                <event name="OnMiddleDClick"></event>
+                                <event name="OnMiddleDClick" />
-                                <event name="OnMiddleDown"></event>
+                                <event name="OnMiddleDown" />
-                                <event name="OnMiddleUp"></event>
+                                <event name="OnMiddleUp" />
-                                <event name="OnMotion"></event>
+                                <event name="OnMotion" />
-                                <event name="OnMouseEvents"></event>
+                                <event name="OnMouseEvents" />
-                                <event name="OnMouseWheel"></event>
+                                <event name="OnMouseWheel" />
-                                <event name="OnPaint"></event>
+                                <event name="OnPaint" />
-                                <event name="OnRightDClick"></event>
+                                <event name="OnRightDClick" />
-                                <event name="OnRightDown"></event>
+                                <event name="OnRightDown" />
-                                <event name="OnRightUp"></event>
+                                <event name="OnRightUp" />
-                                <event name="OnSetFocus"></event>
+                                <event name="OnSetFocus" />
-                                <event name="OnSize"></event>
+                                <event name="OnSize" />
-                                <event name="OnUpdateUI"></event>
+                                <event name="OnUpdateUI" />
                             </object>
                         </object>
                         <object class="sizeritem" expanded="1">
@@ -558,17 +558,17 @@
                                 <property name="LeftDockable">1</property>
                                 <property name="RightDockable">1</property>
                                 <property name="TopDockable">1</property>
-                                <property name="aui_layer"></property>
+                                <property name="aui_layer" />
-                                <property name="aui_name"></property>
+                                <property name="aui_name" />
-                                <property name="aui_position"></property>
+                                <property name="aui_position" />
-                                <property name="aui_row"></property>
+                                <property name="aui_row" />
-                                <property name="best_size"></property>
+                                <property name="best_size" />
-                                <property name="bg"></property>
+                                <property name="bg" />
-                                <property name="caption"></property>
+                                <property name="caption" />
                                 <property name="caption_visible">1</property>
                                 <property name="center_pane">0</property>
                                 <property name="close_button">1</property>
-                                <property name="context_help"></property>
+                                <property name="context_help" />
                                 <property name="context_menu">1</property>
                                 <property name="default">0</property>
                                 <property name="default_pane">0</property>
@@ -576,65 +576,65 @@
                                 <property name="dock_fixed">0</property>
                                 <property name="docking">Left</property>
                                 <property name="enabled">1</property>
-                                <property name="fg"></property>
+                                <property name="fg" />
                                 <property name="floatable">1</property>
-                                <property name="font"></property>
+                                <property name="font" />
                                 <property name="gripper">0</property>
                                 <property name="hidden">0</property>
                                 <property name="id">wxID_CANCEL</property>
                                 <property name="label">Close</property>
-                                <property name="max_size"></property>
+                                <property name="max_size" />
                                 <property name="maximize_button">0</property>
-                                <property name="maximum_size"></property>
+                                <property name="maximum_size" />
-                                <property name="min_size"></property>
+                                <property name="min_size" />
                                 <property name="minimize_button">0</property>
-                                <property name="minimum_size"></property>
+                                <property name="minimum_size" />
                                 <property name="moveable">1</property>
                                 <property name="name">m_button3</property>
                                 <property name="pane_border">1</property>
-                                <property name="pane_position"></property>
+                                <property name="pane_position" />
-                                <property name="pane_size"></property>
+                                <property name="pane_size" />
                                 <property name="permission">protected</property>
                                 <property name="pin_button">1</property>
-                                <property name="pos"></property>
+                                <property name="pos" />
                                 <property name="resize">Resizable</property>
                                 <property name="show">1</property>
-                                <property name="size"></property>
+                                <property name="size" />
-                                <property name="style"></property>
+                                <property name="style" />
-                                <property name="subclass"></property>
+                                <property name="subclass" />
                                 <property name="toolbar_pane">0</property>
-                                <property name="tooltip"></property>
+                                <property name="tooltip" />
-                                <property name="validator_data_type"></property>
+                                <property name="validator_data_type" />
                                 <property name="validator_style">wxFILTER_NONE</property>
                                 <property name="validator_type">wxDefaultValidator</property>
-                                <property name="validator_variable"></property>
+                                <property name="validator_variable" />
-                                <property name="window_extra_style"></property>
+                                <property name="window_extra_style" />
-                                <property name="window_name"></property>
+                                <property name="window_name" />
-                                <property name="window_style"></property>
+                                <property name="window_style" />
                                 <event name="OnButtonClick">onButtonCloseClick</event>
-                                <event name="OnChar"></event>
+                                <event name="OnChar" />
-                                <event name="OnEnterWindow"></event>
+                                <event name="OnEnterWindow" />
-                                <event name="OnEraseBackground"></event>
+                                <event name="OnEraseBackground" />
-                                <event name="OnKeyDown"></event>
+                                <event name="OnKeyDown" />
-                                <event name="OnKeyUp"></event>
+                                <event name="OnKeyUp" />
-                                <event name="OnKillFocus"></event>
+                                <event name="OnKillFocus" />
-                                <event name="OnLeaveWindow"></event>
+                                <event name="OnLeaveWindow" />
-                                <event name="OnLeftDClick"></event>
+                                <event name="OnLeftDClick" />
-                                <event name="OnLeftDown"></event>
+                                <event name="OnLeftDown" />
-                                <event name="OnLeftUp"></event>
+                                <event name="OnLeftUp" />
-                                <event name="OnMiddleDClick"></event>
+                                <event name="OnMiddleDClick" />
-                                <event name="OnMiddleDown"></event>
+                                <event name="OnMiddleDown" />
-                                <event name="OnMiddleUp"></event>
+                                <event name="OnMiddleUp" />
-                                <event name="OnMotion"></event>
+                                <event name="OnMotion" />
-                                <event name="OnMouseEvents"></event>
+                                <event name="OnMouseEvents" />
-                                <event name="OnMouseWheel"></event>
+                                <event name="OnMouseWheel" />
-                                <event name="OnPaint"></event>
+                                <event name="OnPaint" />
-                                <event name="OnRightDClick"></event>
+                                <event name="OnRightDClick" />
-                                <event name="OnRightDown"></event>
+                                <event name="OnRightDown" />
-                                <event name="OnRightUp"></event>
+                                <event name="OnRightUp" />
-                                <event name="OnSetFocus"></event>
+                                <event name="OnSetFocus" />
-                                <event name="OnSize"></event>
+                                <event name="OnSize" />
-                                <event name="OnUpdateUI"></event>
+                                <event name="OnUpdateUI" />
                             </object>
                         </object>
                     </object>

pcbnew/dialogs/dialog_get_footprint_by_name.h

@@ -0,0 +1,68 @@
+/*
+ * This program source code file is part of KiCad, a free EDA CAD application.
+ *
+ * Copyright (C) 2015 Jean-Pierre Charras, jean-pierre.charras@ujf-grenoble.fr
+ * Copyright (C) 1992-2015 KiCad Developers, see AUTHORS.txt for contributors.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, you may find one here:
+ * http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ * or you may search the http://www.gnu.org website for the version 2 license,
+ * or you may write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
+ */
+
+/**
+ * @file dialog_get_footprint_by_name.h
+ */
+
+#ifndef DIALOG_GET_FOOTPRINT_BY_NAME_H
+#define DIALOG_GET_FOOTPRINT_BY_NAME_H
+
+#include <dialog_get_footprint_by_name_base.h>
+
+/**
+ * DIALOG_GET_FOOTPRINT_BY_NAME is a helper dialog to select a footprint by its reference
+ * One can enter any reference or select it in the list of fp references
+ * Get a footprint ref from user and return a pointer to the corresponding footprint
+ */
+class DIALOG_GET_FOOTPRINT_BY_NAME: public DIALOG_GET_FOOTPRINT_BY_NAME_BASE
+{
+public:
+    DIALOG_GET_FOOTPRINT_BY_NAME( PCB_BASE_FRAME* aParent, wxArrayString& aFpList ) :
+        DIALOG_GET_FOOTPRINT_BY_NAME_BASE( aParent )
+    {
+        m_sdbSizerOK->SetDefault();
+        m_choiceFpList->Append( aFpList );
+
+        // Dialog should not shrink beyond it's minimal size.
+        GetSizer()->SetSizeHints( this );
+    }
+
+    // returns the selected text (fp reference)
+    const wxString GetValue()
+    {
+        return m_SearchTextCtrl->GetValue();
+    }
+
+private:
+    // Called when selecting an item from the item list
+	void OnSelectFootprint( wxCommandEvent& aEvent )
+    {
+        if( m_choiceFpList->GetSelection() >= 0 )
+            m_SearchTextCtrl->SetValue(
+                m_choiceFpList->GetString( m_choiceFpList->GetSelection() ).BeforeFirst( ' ' ) );
+    }
+};
+
+#endif  // #ifndef DIALOG_GET_FOOTPRINT_BY_NAME_H

pcbnew/dialogs/dialog_get_footprint_by_name_base.cpp

@@ -0,0 +1,79 @@
+///////////////////////////////////////////////////////////////////////////
+// C++ code generated with wxFormBuilder (version Jun 17 2015)
+// http://www.wxformbuilder.org/
+//
+// PLEASE DO "NOT" EDIT THIS FILE!
+///////////////////////////////////////////////////////////////////////////
+
+#include "dialog_get_footprint_by_name_base.h"
+
+///////////////////////////////////////////////////////////////////////////
+
+DIALOG_GET_FOOTPRINT_BY_NAME_BASE::DIALOG_GET_FOOTPRINT_BY_NAME_BASE( wxWindow* parent, wxWindowID id, const wxString& title, const wxPoint& pos, const wxSize& size, long style ) : DIALOG_SHIM( parent, id, title, pos, size, style )
+{
+	this->SetSizeHints( wxDefaultSize, wxDefaultSize );
+	
+	wxBoxSizer* bSizerMain;
+	bSizerMain = new wxBoxSizer( wxVERTICAL );
+	
+	wxBoxSizer* bSizerUpper;
+	bSizerUpper = new wxBoxSizer( wxHORIZONTAL );
+	
+	wxFlexGridSizer* fgSizer1;
+	fgSizer1 = new wxFlexGridSizer( 0, 2, 0, 0 );
+	fgSizer1->SetFlexibleDirection( wxBOTH );
+	fgSizer1->SetNonFlexibleGrowMode( wxFLEX_GROWMODE_SPECIFIED );
+	
+	m_staticTextRef = new wxStaticText( this, wxID_ANY, _("Reference:"), wxDefaultPosition, wxDefaultSize, 0 );
+	m_staticTextRef->Wrap( -1 );
+	fgSizer1->Add( m_staticTextRef, 0, wxTOP|wxRIGHT|wxLEFT|wxALIGN_CENTER_VERTICAL, 5 );
+	
+	m_SearchTextCtrl = new wxTextCtrl( this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxSize( 200,-1 ), 0 );
+	m_SearchTextCtrl->SetMaxLength( 0 ); 
+	fgSizer1->Add( m_SearchTextCtrl, 0, wxEXPAND|wxALL|wxALIGN_CENTER_VERTICAL, 5 );
+	
+	m_staticTextRef1 = new wxStaticText( this, wxID_ANY, _("Available:"), wxDefaultPosition, wxDefaultSize, 0 );
+	m_staticTextRef1->Wrap( -1 );
+	fgSizer1->Add( m_staticTextRef1, 0, wxALL|wxALIGN_CENTER_VERTICAL, 5 );
+	
+	wxArrayString m_choiceFpListChoices;
+	m_choiceFpList = new wxChoice( this, wxID_ANY, wxDefaultPosition, wxDefaultSize, m_choiceFpListChoices, 0 );
+	m_choiceFpList->SetSelection( 0 );
+	fgSizer1->Add( m_choiceFpList, 0, wxALL|wxEXPAND|wxALIGN_CENTER_VERTICAL, 5 );
+	
+	
+	bSizerUpper->Add( fgSizer1, 1, wxEXPAND, 5 );
+	
+	
+	bSizerMain->Add( bSizerUpper, 1, wxEXPAND, 5 );
+	
+	m_staticline1 = new wxStaticLine( this, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxLI_HORIZONTAL );
+	bSizerMain->Add( m_staticline1, 0, wxEXPAND|wxTOP|wxBOTTOM, 5 );
+	
+	m_sdbSizer = new wxStdDialogButtonSizer();
+	m_sdbSizerOK = new wxButton( this, wxID_OK );
+	m_sdbSizer->AddButton( m_sdbSizerOK );
+	m_sdbSizerCancel = new wxButton( this, wxID_CANCEL );
+	m_sdbSizer->AddButton( m_sdbSizerCancel );
+	m_sdbSizer->Realize();
+	
+	bSizerMain->Add( m_sdbSizer, 0, wxEXPAND|wxBOTTOM|wxRIGHT|wxLEFT, 5 );
+	
+	
+	this->SetSizer( bSizerMain );
+	this->Layout();
+	
+	this->Centre( wxBOTH );
+	
+	// Connect Events
+	this->Connect( wxEVT_CLOSE_WINDOW, wxCloseEventHandler( DIALOG_GET_FOOTPRINT_BY_NAME_BASE::onClose ) );
+	m_choiceFpList->Connect( wxEVT_COMMAND_CHOICE_SELECTED, wxCommandEventHandler( DIALOG_GET_FOOTPRINT_BY_NAME_BASE::OnSelectFootprint ), NULL, this );
+}
+
+DIALOG_GET_FOOTPRINT_BY_NAME_BASE::~DIALOG_GET_FOOTPRINT_BY_NAME_BASE()
+{
+	// Disconnect Events
+	this->Disconnect( wxEVT_CLOSE_WINDOW, wxCloseEventHandler( DIALOG_GET_FOOTPRINT_BY_NAME_BASE::onClose ) );
+	m_choiceFpList->Disconnect( wxEVT_COMMAND_CHOICE_SELECTED, wxCommandEventHandler( DIALOG_GET_FOOTPRINT_BY_NAME_BASE::OnSelectFootprint ), NULL, this );
+	
+}

pcbnew/dialogs/dialog_get_footprint_by_name_base.fbp

@@ -0,0 +1,580 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
+<wxFormBuilder_Project>
+    <FileVersion major="1" minor="13" />
+    <object class="Project" expanded="1">
+        <property name="class_decoration"></property>
+        <property name="code_generation">C++</property>
+        <property name="disconnect_events">1</property>
+        <property name="disconnect_mode">source_name</property>
+        <property name="disconnect_php_events">0</property>
+        <property name="disconnect_python_events">0</property>
+        <property name="embedded_files_path">res</property>
+        <property name="encoding">UTF-8</property>
+        <property name="event_generation">connect</property>
+        <property name="file">dialog_get_footprint_by_name_base</property>
+        <property name="first_id">1000</property>
+        <property name="help_provider">none</property>
+        <property name="internationalize">1</property>
+        <property name="name">dialog_get_footprint_by_name</property>
+        <property name="namespace"></property>
+        <property name="path">.</property>
+        <property name="precompiled_header"></property>
+        <property name="relative_path">1</property>
+        <property name="skip_lua_events">1</property>
+        <property name="skip_php_events">1</property>
+        <property name="skip_python_events">1</property>
+        <property name="ui_table">UI</property>
+        <property name="use_enum">0</property>
+        <property name="use_microsoft_bom">0</property>
+        <object class="Dialog" expanded="1">
+            <property name="aui_managed">0</property>
+            <property name="aui_manager_style">wxAUI_MGR_DEFAULT</property>
+            <property name="bg"></property>
+            <property name="center">wxBOTH</property>
+            <property name="context_help"></property>
+            <property name="context_menu">1</property>
+            <property name="enabled">1</property>
+            <property name="event_handler">impl_virtual</property>
+            <property name="extra_style"></property>
+            <property name="fg"></property>
+            <property name="font"></property>
+            <property name="hidden">0</property>
+            <property name="id">wxID_ANY</property>
+            <property name="maximum_size"></property>
+            <property name="minimum_size"></property>
+            <property name="name">DIALOG_GET_FOOTPRINT_BY_NAME_BASE</property>
+            <property name="pos"></property>
+            <property name="size">341,176</property>
+            <property name="style">wxDEFAULT_DIALOG_STYLE|wxRESIZE_BORDER</property>
+            <property name="subclass">DIALOG_SHIM; dialog_shim.h</property>
+            <property name="title">Search for footprint</property>
+            <property name="tooltip"></property>
+            <property name="window_extra_style"></property>
+            <property name="window_name"></property>
+            <property name="window_style"></property>
+            <event name="OnActivate"></event>
+            <event name="OnActivateApp"></event>
+            <event name="OnAuiFindManager"></event>
+            <event name="OnAuiPaneButton"></event>
+            <event name="OnAuiPaneClose"></event>
+            <event name="OnAuiPaneMaximize"></event>
+            <event name="OnAuiPaneRestore"></event>
+            <event name="OnAuiRender"></event>
+            <event name="OnChar"></event>
+            <event name="OnClose">onClose</event>
+            <event name="OnEnterWindow"></event>
+            <event name="OnEraseBackground"></event>
+            <event name="OnHibernate"></event>
+            <event name="OnIconize"></event>
+            <event name="OnIdle"></event>
+            <event name="OnInitDialog"></event>
+            <event name="OnKeyDown"></event>
+            <event name="OnKeyUp"></event>
+            <event name="OnKillFocus"></event>
+            <event name="OnLeaveWindow"></event>
+            <event name="OnLeftDClick"></event>
+            <event name="OnLeftDown"></event>
+            <event name="OnLeftUp"></event>
+            <event name="OnMiddleDClick"></event>
+            <event name="OnMiddleDown"></event>
+            <event name="OnMiddleUp"></event>
+            <event name="OnMotion"></event>
+            <event name="OnMouseEvents"></event>
+            <event name="OnMouseWheel"></event>
+            <event name="OnPaint"></event>
+            <event name="OnRightDClick"></event>
+            <event name="OnRightDown"></event>
+            <event name="OnRightUp"></event>
+            <event name="OnSetFocus"></event>
+            <event name="OnSize"></event>
+            <event name="OnUpdateUI"></event>
+            <object class="wxBoxSizer" expanded="1">
+                <property name="minimum_size"></property>
+                <property name="name">bSizerMain</property>
+                <property name="orient">wxVERTICAL</property>
+                <property name="permission">none</property>
+                <object class="sizeritem" expanded="1">
+                    <property name="border">5</property>
+                    <property name="flag">wxEXPAND</property>
+                    <property name="proportion">1</property>
+                    <object class="wxBoxSizer" expanded="1">
+                        <property name="minimum_size"></property>
+                        <property name="name">bSizerUpper</property>
+                        <property name="orient">wxHORIZONTAL</property>
+                        <property name="permission">none</property>
+                        <object class="sizeritem" expanded="1">
+                            <property name="border">5</property>
+                            <property name="flag">wxEXPAND</property>
+                            <property name="proportion">1</property>
+                            <object class="wxFlexGridSizer" expanded="1">
+                                <property name="cols">2</property>
+                                <property name="flexible_direction">wxBOTH</property>
+                                <property name="growablecols"></property>
+                                <property name="growablerows"></property>
+                                <property name="hgap">0</property>
+                                <property name="minimum_size"></property>
+                                <property name="name">fgSizer1</property>
+                                <property name="non_flexible_grow_mode">wxFLEX_GROWMODE_SPECIFIED</property>
+                                <property name="permission">none</property>
+                                <property name="rows">0</property>
+                                <property name="vgap">0</property>
+                                <object class="sizeritem" expanded="1">
+                                    <property name="border">5</property>
+                                    <property name="flag">wxTOP|wxRIGHT|wxLEFT|wxALIGN_CENTER_VERTICAL</property>
+                                    <property name="proportion">0</property>
+                                    <object class="wxStaticText" expanded="1">
+                                        <property name="BottomDockable">1</property>
+                                        <property name="LeftDockable">1</property>
+                                        <property name="RightDockable">1</property>
+                                        <property name="TopDockable">1</property>
+                                        <property name="aui_layer"></property>
+                                        <property name="aui_name"></property>
+                                        <property name="aui_position"></property>
+                                        <property name="aui_row"></property>
+                                        <property name="best_size"></property>
+                                        <property name="bg"></property>
+                                        <property name="caption"></property>
+                                        <property name="caption_visible">1</property>
+                                        <property name="center_pane">0</property>
+                                        <property name="close_button">1</property>
+                                        <property name="context_help"></property>
+                                        <property name="context_menu">1</property>
+                                        <property name="default_pane">0</property>
+                                        <property name="dock">Dock</property>
+                                        <property name="dock_fixed">0</property>
+                                        <property name="docking">Left</property>
+                                        <property name="enabled">1</property>
+                                        <property name="fg"></property>
+                                        <property name="floatable">1</property>
+                                        <property name="font"></property>
+                                        <property name="gripper">0</property>
+                                        <property name="hidden">0</property>
+                                        <property name="id">wxID_ANY</property>
+                                        <property name="label">Reference:</property>
+                                        <property name="max_size"></property>
+                                        <property name="maximize_button">0</property>
+                                        <property name="maximum_size"></property>
+                                        <property name="min_size"></property>
+                                        <property name="minimize_button">0</property>
+                                        <property name="minimum_size"></property>
+                                        <property name="moveable">1</property>
+                                        <property name="name">m_staticTextRef</property>
+                                        <property name="pane_border">1</property>
+                                        <property name="pane_position"></property>
+                                        <property name="pane_size"></property>
+                                        <property name="permission">protected</property>
+                                        <property name="pin_button">1</property>
+                                        <property name="pos"></property>
+                                        <property name="resize">Resizable</property>
+                                        <property name="show">1</property>
+                                        <property name="size"></property>
+                                        <property name="style"></property>
+                                        <property name="subclass"></property>
+                                        <property name="toolbar_pane">0</property>
+                                        <property name="tooltip"></property>
+                                        <property name="window_extra_style"></property>
+                                        <property name="window_name"></property>
+                                        <property name="window_style"></property>
+                                        <property name="wrap">-1</property>
+                                        <event name="OnChar"></event>
+                                        <event name="OnEnterWindow"></event>
+                                        <event name="OnEraseBackground"></event>
+                                        <event name="OnKeyDown"></event>
+                                        <event name="OnKeyUp"></event>
+                                        <event name="OnKillFocus"></event>
+                                        <event name="OnLeaveWindow"></event>
+                                        <event name="OnLeftDClick"></event>
+                                        <event name="OnLeftDown"></event>
+                                        <event name="OnLeftUp"></event>
+                                        <event name="OnMiddleDClick"></event>
+                                        <event name="OnMiddleDown"></event>
+                                        <event name="OnMiddleUp"></event>
+                                        <event name="OnMotion"></event>
+                                        <event name="OnMouseEvents"></event>
+                                        <event name="OnMouseWheel"></event>
+                                        <event name="OnPaint"></event>
+                                        <event name="OnRightDClick"></event>
+                                        <event name="OnRightDown"></event>
+                                        <event name="OnRightUp"></event>
+                                        <event name="OnSetFocus"></event>
+                                        <event name="OnSize"></event>
+                                        <event name="OnUpdateUI"></event>
+                                    </object>
+                                </object>
+                                <object class="sizeritem" expanded="1">
+                                    <property name="border">5</property>
+                                    <property name="flag">wxEXPAND|wxALL|wxALIGN_CENTER_VERTICAL</property>
+                                    <property name="proportion">0</property>
+                                    <object class="wxTextCtrl" expanded="1">
+                                        <property name="BottomDockable">1</property>
+                                        <property name="LeftDockable">1</property>
+                                        <property name="RightDockable">1</property>
+                                        <property name="TopDockable">1</property>
+                                        <property name="aui_layer"></property>
+                                        <property name="aui_name"></property>
+                                        <property name="aui_position"></property>
+                                        <property name="aui_row"></property>
+                                        <property name="best_size"></property>
+                                        <property name="bg"></property>
+                                        <property name="caption"></property>
+                                        <property name="caption_visible">1</property>
+                                        <property name="center_pane">0</property>
+                                        <property name="close_button">1</property>
+                                        <property name="context_help"></property>
+                                        <property name="context_menu">1</property>
+                                        <property name="default_pane">0</property>
+                                        <property name="dock">Dock</property>
+                                        <property name="dock_fixed">0</property>
+                                        <property name="docking">Left</property>
+                                        <property name="enabled">1</property>
+                                        <property name="fg"></property>
+                                        <property name="floatable">1</property>
+                                        <property name="font"></property>
+                                        <property name="gripper">0</property>
+                                        <property name="hidden">0</property>
+                                        <property name="id">wxID_ANY</property>
+                                        <property name="max_size"></property>
+                                        <property name="maximize_button">0</property>
+                                        <property name="maximum_size"></property>
+                                        <property name="maxlength">0</property>
+                                        <property name="min_size"></property>
+                                        <property name="minimize_button">0</property>
+                                        <property name="minimum_size"></property>
+                                        <property name="moveable">1</property>
+                                        <property name="name">m_SearchTextCtrl</property>
+                                        <property name="pane_border">1</property>
+                                        <property name="pane_position"></property>
+                                        <property name="pane_size"></property>
+                                        <property name="permission">protected</property>
+                                        <property name="pin_button">1</property>
+                                        <property name="pos"></property>
+                                        <property name="resize">Resizable</property>
+                                        <property name="show">1</property>
+                                        <property name="size">200,-1</property>
+                                        <property name="style"></property>
+                                        <property name="subclass"></property>
+                                        <property name="toolbar_pane">0</property>
+                                        <property name="tooltip"></property>
+                                        <property name="validator_data_type"></property>
+                                        <property name="validator_style">wxFILTER_NONE</property>
+                                        <property name="validator_type">wxDefaultValidator</property>
+                                        <property name="validator_variable"></property>
+                                        <property name="value"></property>
+                                        <property name="window_extra_style"></property>
+                                        <property name="window_name"></property>
+                                        <property name="window_style"></property>
+                                        <event name="OnChar"></event>
+                                        <event name="OnEnterWindow"></event>
+                                        <event name="OnEraseBackground"></event>
+                                        <event name="OnKeyDown"></event>
+                                        <event name="OnKeyUp"></event>
+                                        <event name="OnKillFocus"></event>
+                                        <event name="OnLeaveWindow"></event>
+                                        <event name="OnLeftDClick"></event>
+                                        <event name="OnLeftDown"></event>
+                                        <event name="OnLeftUp"></event>
+                                        <event name="OnMiddleDClick"></event>
+                                        <event name="OnMiddleDown"></event>
+                                        <event name="OnMiddleUp"></event>
+                                        <event name="OnMotion"></event>
+                                        <event name="OnMouseEvents"></event>
+                                        <event name="OnMouseWheel"></event>
+                                        <event name="OnPaint"></event>
+                                        <event name="OnRightDClick"></event>
+                                        <event name="OnRightDown"></event>
+                                        <event name="OnRightUp"></event>
+                                        <event name="OnSetFocus"></event>
+                                        <event name="OnSize"></event>
+                                        <event name="OnText"></event>
+                                        <event name="OnTextEnter"></event>
+                                        <event name="OnTextMaxLen"></event>
+                                        <event name="OnTextURL"></event>
+                                        <event name="OnUpdateUI"></event>
+                                    </object>
+                                </object>
+                                <object class="sizeritem" expanded="1">
+                                    <property name="border">5</property>
+                                    <property name="flag">wxALL|wxALIGN_CENTER_VERTICAL</property>
+                                    <property name="proportion">0</property>
+                                    <object class="wxStaticText" expanded="1">
+                                        <property name="BottomDockable">1</property>
+                                        <property name="LeftDockable">1</property>
+                                        <property name="RightDockable">1</property>
+                                        <property name="TopDockable">1</property>
+                                        <property name="aui_layer"></property>
+                                        <property name="aui_name"></property>
+                                        <property name="aui_position"></property>
+                                        <property name="aui_row"></property>
+                                        <property name="best_size"></property>
+                                        <property name="bg"></property>
+                                        <property name="caption"></property>
+                                        <property name="caption_visible">1</property>
+                                        <property name="center_pane">0</property>
+                                        <property name="close_button">1</property>
+                                        <property name="context_help"></property>
+                                        <property name="context_menu">1</property>
+                                        <property name="default_pane">0</property>
+                                        <property name="dock">Dock</property>
+                                        <property name="dock_fixed">0</property>
+                                        <property name="docking">Left</property>
+                                        <property name="enabled">1</property>
+                                        <property name="fg"></property>
+                                        <property name="floatable">1</property>
+                                        <property name="font"></property>
+                                        <property name="gripper">0</property>
+                                        <property name="hidden">0</property>
+                                        <property name="id">wxID_ANY</property>
+                                        <property name="label">Available:</property>
+                                        <property name="max_size"></property>
+                                        <property name="maximize_button">0</property>
+                                        <property name="maximum_size"></property>
+                                        <property name="min_size"></property>
+                                        <property name="minimize_button">0</property>
+                                        <property name="minimum_size"></property>
+                                        <property name="moveable">1</property>
+                                        <property name="name">m_staticTextRef1</property>
+                                        <property name="pane_border">1</property>
+                                        <property name="pane_position"></property>
+                                        <property name="pane_size"></property>
+                                        <property name="permission">protected</property>
+                                        <property name="pin_button">1</property>
+                                        <property name="pos"></property>
+                                        <property name="resize">Resizable</property>
+                                        <property name="show">1</property>
+                                        <property name="size"></property>
+                                        <property name="style"></property>
+                                        <property name="subclass"></property>
+                                        <property name="toolbar_pane">0</property>
+                                        <property name="tooltip"></property>
+                                        <property name="window_extra_style"></property>
+                                        <property name="window_name"></property>
+                                        <property name="window_style"></property>
+                                        <property name="wrap">-1</property>
+                                        <event name="OnChar"></event>
+                                        <event name="OnEnterWindow"></event>
+                                        <event name="OnEraseBackground"></event>
+                                        <event name="OnKeyDown"></event>
+                                        <event name="OnKeyUp"></event>
+                                        <event name="OnKillFocus"></event>
+                                        <event name="OnLeaveWindow"></event>
+                                        <event name="OnLeftDClick"></event>
+                                        <event name="OnLeftDown"></event>
+                                        <event name="OnLeftUp"></event>
+                                        <event name="OnMiddleDClick"></event>
+                                        <event name="OnMiddleDown"></event>
+                                        <event name="OnMiddleUp"></event>
+                                        <event name="OnMotion"></event>
+                                        <event name="OnMouseEvents"></event>
+                                        <event name="OnMouseWheel"></event>
+                                        <event name="OnPaint"></event>
+                                        <event name="OnRightDClick"></event>
+                                        <event name="OnRightDown"></event>
+                                        <event name="OnRightUp"></event>
+                                        <event name="OnSetFocus"></event>
+                                        <event name="OnSize"></event>
+                                        <event name="OnUpdateUI"></event>
+                                    </object>
+                                </object>
+                                <object class="sizeritem" expanded="1">
+                                    <property name="border">5</property>
+                                    <property name="flag">wxALL|wxEXPAND|wxALIGN_CENTER_VERTICAL</property>
+                                    <property name="proportion">0</property>
+                                    <object class="wxChoice" expanded="1">
+                                        <property name="BottomDockable">1</property>
+                                        <property name="LeftDockable">1</property>
+                                        <property name="RightDockable">1</property>
+                                        <property name="TopDockable">1</property>
+                                        <property name="aui_layer"></property>
+                                        <property name="aui_name"></property>
+                                        <property name="aui_position"></property>
+                                        <property name="aui_row"></property>
+                                        <property name="best_size"></property>
+                                        <property name="bg"></property>
+                                        <property name="caption"></property>
+                                        <property name="caption_visible">1</property>
+                                        <property name="center_pane">0</property>
+                                        <property name="choices"></property>
+                                        <property name="close_button">1</property>
+                                        <property name="context_help"></property>
+                                        <property name="context_menu">1</property>
+                                        <property name="default_pane">0</property>
+                                        <property name="dock">Dock</property>
+                                        <property name="dock_fixed">0</property>
+                                        <property name="docking">Left</property>
+                                        <property name="enabled">1</property>
+                                        <property name="fg"></property>
+                                        <property name="floatable">1</property>
+                                        <property name="font"></property>
+                                        <property name="gripper">0</property>
+                                        <property name="hidden">0</property>
+                                        <property name="id">wxID_ANY</property>
+                                        <property name="max_size"></property>
+                                        <property name="maximize_button">0</property>
+                                        <property name="maximum_size"></property>
+                                        <property name="min_size"></property>
+                                        <property name="minimize_button">0</property>
+                                        <property name="minimum_size"></property>
+                                        <property name="moveable">1</property>
+                                        <property name="name">m_choiceFpList</property>
+                                        <property name="pane_border">1</property>
+                                        <property name="pane_position"></property>
+                                        <property name="pane_size"></property>
+                                        <property name="permission">protected</property>
+                                        <property name="pin_button">1</property>
+                                        <property name="pos"></property>
+                                        <property name="resize">Resizable</property>
+                                        <property name="selection">0</property>
+                                        <property name="show">1</property>
+                                        <property name="size"></property>
+                                        <property name="style"></property>
+                                        <property name="subclass"></property>
+                                        <property name="toolbar_pane">0</property>
+                                        <property name="tooltip"></property>
+                                        <property name="validator_data_type"></property>
+                                        <property name="validator_style">wxFILTER_NONE</property>
+                                        <property name="validator_type">wxDefaultValidator</property>
+                                        <property name="validator_variable"></property>
+                                        <property name="window_extra_style"></property>
+                                        <property name="window_name"></property>
+                                        <property name="window_style"></property>
+                                        <event name="OnChar"></event>
+                                        <event name="OnChoice">OnSelectFootprint</event>
+                                        <event name="OnEnterWindow"></event>
+                                        <event name="OnEraseBackground"></event>
+                                        <event name="OnKeyDown"></event>
+                                        <event name="OnKeyUp"></event>
+                                        <event name="OnKillFocus"></event>
+                                        <event name="OnLeaveWindow"></event>
+                                        <event name="OnLeftDClick"></event>
+                                        <event name="OnLeftDown"></event>
+                                        <event name="OnLeftUp"></event>
+                                        <event name="OnMiddleDClick"></event>
+                                        <event name="OnMiddleDown"></event>
+                                        <event name="OnMiddleUp"></event>
+                                        <event name="OnMotion"></event>
+                                        <event name="OnMouseEvents"></event>
+                                        <event name="OnMouseWheel"></event>
+                                        <event name="OnPaint"></event>
+                                        <event name="OnRightDClick"></event>
+                                        <event name="OnRightDown"></event>
+                                        <event name="OnRightUp"></event>
+                                        <event name="OnSetFocus"></event>
+                                        <event name="OnSize"></event>
+                                        <event name="OnUpdateUI"></event>
+                                    </object>
+                                </object>
+                            </object>
+                        </object>
+                    </object>
+                </object>
+                <object class="sizeritem" expanded="1">
+                    <property name="border">5</property>
+                    <property name="flag">wxEXPAND|wxTOP|wxBOTTOM</property>
+                    <property name="proportion">0</property>
+                    <object class="wxStaticLine" expanded="1">
+                        <property name="BottomDockable">1</property>
+                        <property name="LeftDockable">1</property>
+                        <property name="RightDockable">1</property>
+                        <property name="TopDockable">1</property>
+                        <property name="aui_layer"></property>
+                        <property name="aui_name"></property>
+                        <property name="aui_position"></property>
+                        <property name="aui_row"></property>
+                        <property name="best_size"></property>
+                        <property name="bg"></property>
+                        <property name="caption"></property>
+                        <property name="caption_visible">1</property>
+                        <property name="center_pane">0</property>
+                        <property name="close_button">1</property>
+                        <property name="context_help"></property>
+                        <property name="context_menu">1</property>
+                        <property name="default_pane">0</property>
+                        <property name="dock">Dock</property>
+                        <property name="dock_fixed">0</property>
+                        <property name="docking">Left</property>
+                        <property name="enabled">1</property>
+                        <property name="fg"></property>
+                        <property name="floatable">1</property>
+                        <property name="font"></property>
+                        <property name="gripper">0</property>
+                        <property name="hidden">0</property>
+                        <property name="id">wxID_ANY</property>
+                        <property name="max_size"></property>
+                        <property name="maximize_button">0</property>
+                        <property name="maximum_size"></property>
+                        <property name="min_size"></property>
+                        <property name="minimize_button">0</property>
+                        <property name="minimum_size"></property>
+                        <property name="moveable">1</property>
+                        <property name="name">m_staticline1</property>
+                        <property name="pane_border">1</property>
+                        <property name="pane_position"></property>
+                        <property name="pane_size"></property>
+                        <property name="permission">protected</property>
+                        <property name="pin_button">1</property>
+                        <property name="pos"></property>
+                        <property name="resize">Resizable</property>
+                        <property name="show">1</property>
+                        <property name="size"></property>
+                        <property name="style">wxLI_HORIZONTAL</property>
+                        <property name="subclass"></property>
+                        <property name="toolbar_pane">0</property>
+                        <property name="tooltip"></property>
+                        <property name="window_extra_style"></property>
+                        <property name="window_name"></property>
+                        <property name="window_style"></property>
+                        <event name="OnChar"></event>
+                        <event name="OnEnterWindow"></event>
+                        <event name="OnEraseBackground"></event>
+                        <event name="OnKeyDown"></event>
+                        <event name="OnKeyUp"></event>
+                        <event name="OnKillFocus"></event>
+                        <event name="OnLeaveWindow"></event>
+                        <event name="OnLeftDClick"></event>
+                        <event name="OnLeftDown"></event>
+                        <event name="OnLeftUp"></event>
+                        <event name="OnMiddleDClick"></event>
+                        <event name="OnMiddleDown"></event>
+                        <event name="OnMiddleUp"></event>
+                        <event name="OnMotion"></event>
+                        <event name="OnMouseEvents"></event>
+                        <event name="OnMouseWheel"></event>
+                        <event name="OnPaint"></event>
+                        <event name="OnRightDClick"></event>
+                        <event name="OnRightDown"></event>
+                        <event name="OnRightUp"></event>
+                        <event name="OnSetFocus"></event>
+                        <event name="OnSize"></event>
+                        <event name="OnUpdateUI"></event>
+                    </object>
+                </object>
+                <object class="sizeritem" expanded="1">
+                    <property name="border">5</property>
+                    <property name="flag">wxEXPAND|wxBOTTOM|wxRIGHT|wxLEFT</property>
+                    <property name="proportion">0</property>
+                    <object class="wxStdDialogButtonSizer" expanded="1">
+                        <property name="Apply">0</property>
+                        <property name="Cancel">1</property>
+                        <property name="ContextHelp">0</property>
+                        <property name="Help">0</property>
+                        <property name="No">0</property>
+                        <property name="OK">1</property>
+                        <property name="Save">0</property>
+                        <property name="Yes">0</property>
+                        <property name="minimum_size"></property>
+                        <property name="name">m_sdbSizer</property>
+                        <property name="permission">protected</property>
+                        <event name="OnApplyButtonClick"></event>
+                        <event name="OnCancelButtonClick"></event>
+                        <event name="OnContextHelpButtonClick"></event>
+                        <event name="OnHelpButtonClick"></event>
+                        <event name="OnNoButtonClick"></event>
+                        <event name="OnOKButtonClick"></event>
+                        <event name="OnSaveButtonClick"></event>
+                        <event name="OnYesButtonClick"></event>
+                    </object>
+                </object>
+            </object>
+        </object>
+    </object>
+</wxFormBuilder_Project>

pcbnew/dialogs/dialog_get_footprint_by_name_base.h

@@ -0,0 +1,62 @@
+///////////////////////////////////////////////////////////////////////////
+// C++ code generated with wxFormBuilder (version Jun 17 2015)
+// http://www.wxformbuilder.org/
+//
+// PLEASE DO "NOT" EDIT THIS FILE!
+///////////////////////////////////////////////////////////////////////////
+
+#ifndef __DIALOG_GET_FOOTPRINT_BY_NAME_BASE_H__
+#define __DIALOG_GET_FOOTPRINT_BY_NAME_BASE_H__
+
+#include <wx/artprov.h>
+#include <wx/xrc/xmlres.h>
+#include <wx/intl.h>
+class DIALOG_SHIM;
+
+#include "dialog_shim.h"
+#include <wx/string.h>
+#include <wx/stattext.h>
+#include <wx/gdicmn.h>
+#include <wx/font.h>
+#include <wx/colour.h>
+#include <wx/settings.h>
+#include <wx/textctrl.h>
+#include <wx/choice.h>
+#include <wx/sizer.h>
+#include <wx/statline.h>
+#include <wx/button.h>
+#include <wx/dialog.h>
+
+///////////////////////////////////////////////////////////////////////////
+
+
+///////////////////////////////////////////////////////////////////////////////
+/// Class DIALOG_GET_FOOTPRINT_BY_NAME_BASE
+///////////////////////////////////////////////////////////////////////////////
+class DIALOG_GET_FOOTPRINT_BY_NAME_BASE : public DIALOG_SHIM
+{
+	private:
+	
+	protected:
+		wxStaticText* m_staticTextRef;
+		wxTextCtrl* m_SearchTextCtrl;
+		wxStaticText* m_staticTextRef1;
+		wxChoice* m_choiceFpList;
+		wxStaticLine* m_staticline1;
+		wxStdDialogButtonSizer* m_sdbSizer;
+		wxButton* m_sdbSizerOK;
+		wxButton* m_sdbSizerCancel;
+		
+		// Virtual event handlers, overide them in your derived class
+		virtual void onClose( wxCloseEvent& event ) { event.Skip(); }
+		virtual void OnSelectFootprint( wxCommandEvent& event ) { event.Skip(); }
+		
+	
+	public:
+		
+		DIALOG_GET_FOOTPRINT_BY_NAME_BASE( wxWindow* parent, wxWindowID id = wxID_ANY, const wxString& title = _("Search for footprint"), const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxSize( 341,176 ), long style = wxDEFAULT_DIALOG_STYLE|wxRESIZE_BORDER ); 
+		~DIALOG_GET_FOOTPRINT_BY_NAME_BASE();
+	
+};
+
+#endif //__DIALOG_GET_FOOTPRINT_BY_NAME_BASE_H__

pcbnew/edit.cpp

@@ -703,7 +703,7 @@ void PCB_EDIT_FRAME::Process_Special_Functions( wxCommandEvent& event )
         break;
 
     case ID_POPUP_PCB_GET_AND_MOVE_MODULE_REQUEST:      // get module by name and move it
-        SetCurItem( GetModuleByName() );
+        SetCurItem( GetFootprintFromBoardByReference() );
         module = (MODULE*) GetCurItem();
 
         if( module == NULL )

pcbnew/files.cpp

@@ -597,8 +597,10 @@ bool PCB_EDIT_FRAME::OpenProjectFiles( const std::vector<wxString>& aFileSet, in
     SetMsgPanel( GetBoard() );
 
     // Refresh the 3D view, if any
-    if( m_Draw3DFrame )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
-        m_Draw3DFrame->NewDisplay();
+
+    if( draw3DFrame )
+        draw3DFrame->NewDisplay();
 
 #if 0 && defined(DEBUG)
     // Output the board object tree to stdout, but please run from command prompt:

pcbnew/footprint_wizard_frame.cpp

@@ -210,8 +210,10 @@ FOOTPRINT_WIZARD_FRAME::FOOTPRINT_WIZARD_FRAME( KIWAY* aKiway,
 
 FOOTPRINT_WIZARD_FRAME::~FOOTPRINT_WIZARD_FRAME()
 {
-    if( m_Draw3DFrame )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
-        m_Draw3DFrame->Destroy();
+
+    if( draw3DFrame )
+        draw3DFrame->Destroy();
 }
 
 
@@ -513,26 +515,28 @@ bool FOOTPRINT_WIZARD_FRAME::GeneralControl( wxDC* aDC, const wxPoint& aPosition
 
 void FOOTPRINT_WIZARD_FRAME::Show3D_Frame( wxCommandEvent& event )
 {
-    if( m_Draw3DFrame )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
+
+    if( draw3DFrame )
     {
         // Raising the window does not show the window on Windows if iconized.
         // This should work on any platform.
-        if( m_Draw3DFrame->IsIconized() )
+        if( draw3DFrame->IsIconized() )
-            m_Draw3DFrame->Iconize( false );
+            draw3DFrame->Iconize( false );
 
-        m_Draw3DFrame->Raise();
+        draw3DFrame->Raise();
 
         // Raising the window does not set the focus on Linux.  This should work on any platform.
-        if( wxWindow::FindFocus() != m_Draw3DFrame )
+        if( wxWindow::FindFocus() != draw3DFrame )
-            m_Draw3DFrame->SetFocus();
+            draw3DFrame->SetFocus();
 
         return;
     }
 
-    m_Draw3DFrame = new EDA_3D_FRAME( &Kiway(), this, wxEmptyString );
+    draw3DFrame = new EDA_3D_FRAME( &Kiway(), this, wxEmptyString );
     Update3D_Frame( false );
-    m_Draw3DFrame->Raise();     // Needed with some Window Managers
+    draw3DFrame->Raise();     // Needed with some Window Managers
-    m_Draw3DFrame->Show( true );
+    draw3DFrame->Show( true );
 }
 
 
@@ -543,20 +547,22 @@ void FOOTPRINT_WIZARD_FRAME::Show3D_Frame( wxCommandEvent& event )
  */
 void FOOTPRINT_WIZARD_FRAME::Update3D_Frame( bool aForceReloadFootprint )
 {
-    if( m_Draw3DFrame == NULL )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
+
+    if( draw3DFrame == NULL )
         return;
 
     wxString frm3Dtitle;
     frm3Dtitle.Printf( _( "ModView: 3D Viewer [%s]" ), GetChars( m_wizardName ) );
-    m_Draw3DFrame->SetTitle( frm3Dtitle );
+    draw3DFrame->SetTitle( frm3Dtitle );
 
     if( aForceReloadFootprint )
     {
-        m_Draw3DFrame->ReloadRequest();
+        draw3DFrame->ReloadRequest();
 
         // Force 3D screen refresh immediately
         if( GetBoard()->m_Modules )
-            m_Draw3DFrame->NewDisplay();
+            draw3DFrame->NewDisplay();
     }
 }
 

pcbnew/github/CMakeLists.txt

@@ -24,28 +24,15 @@
 
 # Download avhttp and install the headers, not actually compiled
 #################################################
-include( download_avhttp )
-
-find_package( OpenSSL REQUIRED )
-#message( STATUS "OPENSSL_FOUND:${OPENSSL_FOUND}  OPENSSL_LIBRARIES:${OPENSSL_LIBRARIES}" )
-
-# FindOpenSSL.cmake does not set this var into cache, so is not globally visible,
-# do it here incase some other link image needs these libraries
-set( OPENSSL_LIBRARIES   "${OPENSSL_LIBRARIES}"   CACHE FILEPATH "OpenSSL link libraries" )
-set( OPENSSL_INCLUDE_DIR "${OPENSSL_INCLUDE_DIR}" CACHE FILEPATH "OpenSSL include dir" )
 
 # These are additions to any inherited from pcbnew dir:
-include_directories( . ${OPENSSL_INCLUDE_DIR} ${AVHTTP_INCLUDE_DIR} )
+include_directories( . )
 
 # Tell AVHTTP we have SSL.
-add_definitions( -DAVHTTP_ENABLE_OPENSSL )
-
-# tone down the compiler warnings for avhttp header library:
-set( CMAKE_CXX_FLAGS
-    "${CMAKE_CXX_FLAGS} -Wno-sign-compare -Wno-reorder -Wno-unused-variable -Wno-unused-function -Wno-strict-aliasing" )
-
 set( GITHUB_PLUGIN_SRCS
-    github_plugin.cpp github_getliblist.cpp html_link_parser.cpp
+    github_plugin.cpp 
+    github_getliblist.cpp
+    html_link_parser.cpp
     )
 
 add_library( github_plugin STATIC ${GITHUB_PLUGIN_SRCS} )
@@ -53,7 +40,7 @@ add_library( github_plugin STATIC ${GITHUB_PLUGIN_SRCS} )
 # No, you don't get github without boost and openssl. Boost_LIBRARIES now moved up
 # into CMakeLists.txt for pcbnew and cvpcb:
 target_link_libraries( github_plugin
-    ${OPENSSL_LIBRARIES}
+    common
     )
 
 if( MINGW )
@@ -64,9 +51,4 @@ if( MINGW )
 endif()
 
 add_dependencies( github_plugin boost )
-add_dependencies( github_plugin avhttp )
-
-if( MINGW AND NOT OPENSSL_ROOT_DIR )
-    add_dependencies( github_plugin openssl )
-endif()
 

pcbnew/github/github_getliblist.cpp

@@ -41,35 +41,7 @@
  *  JP Charras.
  */
 
-
+#include <kicad_curl/kicad_curl_easy.h> /* Include before any wx file */
-#if 0
-/*
- *  FIX ME
- *  I do not include avhttp.hpp here, because it is already included in
- *  github_plugin.cpp
- *  and if it is also included in this file, the link fails (double definiton of modules)
- *  therefore, the GITHUB_GETLIBLIST method which uses avhttp to download dats from gitub
- *  is in github_plugin.cpp
- */
-
-#ifndef WIN32_LEAN_AND_MEAN
-// when WIN32_LEAN_AND_MEAN is defined, some useless includes in <window.h>
-// are skipped, and this avoid some compil issues
-#define WIN32_LEAN_AND_MEAN
-#endif
-
-#ifdef WIN32
-// defines needed by avhttp
-// Minimal Windows version is XP: Google for _WIN32_WINNT
- #define _WIN32_WINNT   0x0501
- #define WINVER         0x0501
-#endif
-
-#include <wx/wx.h>
-#include <avhttp.hpp>
-
-#endif
-
 #include <wx/uri.h>
 
 #include <github_getliblist.h>
@@ -97,7 +69,7 @@ bool GITHUB_GETLIBLIST::Get3DshapesLibsList( wxArrayString* aList,
     wxString errorMsg;
 
     fullURLCommand = repoURL.utf8_str();
-    bool success = remote_get_json( &fullURLCommand, &errorMsg );
+    bool success = remoteGetJSON( fullURLCommand, &errorMsg );
 
     if( !success )
     {
@@ -147,7 +119,7 @@ bool GITHUB_GETLIBLIST::GetFootprintLibraryList( wxArrayString& aList )
 
     while( 1 )
     {
-        bool success = remote_get_json( &fullURLCommand, &errorMsg );
+        bool success = remoteGetJSON( fullURLCommand, &errorMsg );
 
         if( !success )
         {
@@ -232,3 +204,37 @@ bool GITHUB_GETLIBLIST::repoURL2listURL( const wxString& aRepoURL,
 
     return false;
 }
+
+
+bool GITHUB_GETLIBLIST::remoteGetJSON( const std::string& aFullURLCommand, wxString* aMsgError )
+{
+    KICAD_CURL_EASY kcurl;
+    
+    wxLogDebug( wxT( "Attempting to download: " ) + aFullURLCommand );
+
+    kcurl.SetURL(aFullURLCommand);
+    kcurl.SetUserAgent("KiCad-EDA");
+    kcurl.SetHeader("Accept", m_option_string);
+    kcurl.SetFollowRedirects(true);
+
+    try
+    {
+        kcurl.Perform();
+        m_image.assign(kcurl.GetBuffer()->payload, kcurl.GetBuffer()->size);
+        return true;
+    }
+    catch( const IO_ERROR& ioe )
+    {
+        if( aMsgError )
+        {
+            UTF8 fmt( _( "Error fetching JSON data from URL '%s'.\nReason: '%s'" ) );
+            
+            std::string msg = StrPrintf( fmt.c_str(), 
+                                         aFullURLCommand.c_str(),
+                                         TO_UTF8( ioe.errorText ) );
+
+            *aMsgError = FROM_UTF8( msg.c_str() );
+        }
+        return false;
+    }
+}

pcbnew/github/github_getliblist.h

@@ -103,7 +103,7 @@ protected:
             int aItemCountMax, int aPage = 1 );
 
     /**
-     * Function remote_get_json
+     * Function remoteGetJSON
      * Download a json text from a github repo.  The text image
      * is received into the m_input_stream.
      * @param aFullURLCommand the full command, i.e. the url with options like
@@ -111,7 +111,7 @@ protected:
      * @param aMsgError a pointer to a wxString which can store an error message
      * @return true if OK, false if error (which an error message in *aMsgError
      */
-    bool remote_get_json( std::string* aFullURLCommand, wxString* aMsgError );
+    bool remoteGetJSON( const std::string& aFullURLCommand, wxString* aMsgError );
 
     wxString m_github_path;     ///< Something like https://api.github.com/orgs/KiCad
     std::string m_image;        ///< image of the downloaded data in its entirety.

pcbnew/github/github_plugin.cpp

@@ -38,8 +38,7 @@ I have lost my enthusiasm for local caching until a faster time stamp retrieval
 mechanism can be found, or github gets more servers.  But note that the occasionally
 slow response is the exception rather than the norm.  Normally the response is
 down around a 1/3 of a second.  The information we would use is in the header
-named "Last-Modified" as seen below.  This would need parsing, but avhttp may
+named "Last-Modified" as seen below. 
-offer some help there, if not, then boost async probably does.
 
 
 HTTP/1.1 200 OK
@@ -64,20 +63,7 @@ X-GitHub-Request-Id: 411087C2:659E:50FD6E6:52E67F66
 Vary: Accept-Encoding
 
 */
-
+#include <kicad_curl/kicad_curl_easy.h> /* Include before any wx file */
-
-#ifndef WIN32_LEAN_AND_MEAN
-// when WIN32_LEAN_AND_MEAN is defined, some useless includes in <window.h>
-// are skipped, and this avoid some compil issues
-#define WIN32_LEAN_AND_MEAN
-#endif
-
-#ifdef WIN32
- // defines needed by avhttp
- // Minimal Windows version is XP: Google for _WIN32_WINNT
- #define _WIN32_WINNT   0x0501
- #define WINVER         0x0501
-#endif
 
 #include <sstream>
 #include <boost/ptr_container/ptr_map.hpp>
@@ -88,10 +74,6 @@ Vary: Accept-Encoding
 #include <wx/uri.h>
 
 #include <fctsys.h>
-// Under Windows Mingw/msys, avhttp.hpp should be included after fctsys.h
-// in fact after wx/wx.h, included by fctsys.h,
-// to avoid issues (perhaps due to incompatible defines)
-#include <avhttp.hpp>                       // chinese SSL magic
 
 #include <io_mgr.h>
 #include <richio.h>
@@ -103,6 +85,7 @@ Vary: Accept-Encoding
 #include <fp_lib_table.h>       // ExpandSubstitutions()
 #include <github_getliblist.h>
 
+
 using namespace std;
 
 
@@ -431,7 +414,7 @@ void GITHUB_PLUGIN::cacheLib( const wxString& aLibraryPath, const PROPERTIES* aP
         m_gh_cache = new GH_CACHE();
 
         // INIT_LOGGER( "/tmp", "test.log" );
-        remote_get_zip( aLibraryPath );
+        remoteGetZip( aLibraryPath );
         // UNINIT_LOGGER();
 
         m_lib_path = aLibraryPath;
@@ -460,7 +443,7 @@ void GITHUB_PLUGIN::cacheLib( const wxString& aLibraryPath, const PROPERTIES* aP
 }
 
 
-bool GITHUB_PLUGIN::repoURL_zipURL( const wxString& aRepoURL, string* aZipURL )
+bool GITHUB_PLUGIN::repoURL_zipURL( const wxString& aRepoURL, std::string& aZipURL )
 {
     // e.g. "https://github.com/liftoff-sr/pretty_footprints"
     //D(printf("aRepoURL:%s\n", TO_UTF8( aRepoURL ) );)
@@ -470,12 +453,12 @@ bool GITHUB_PLUGIN::repoURL_zipURL( const wxString& aRepoURL, string* aZipURL )
     if( repo.HasServer() && repo.HasPath() )
     {
         // scheme might be "http" or if truly github.com then "https".
-        wxString zip_url = repo.GetScheme();
+        wxString zip_url;
-
-        zip_url += "://";
 
         if( repo.GetServer() == "github.com" )
         {
+            //codeload.github.com only supports https
+            zip_url = "https://";
 #if 0       // A proper code path would be this one, but it is not the fastest.
             zip_url += repo.GetServer();
             zip_url += repo.GetPath();      // path comes with a leading '/'
@@ -488,8 +471,6 @@ bool GITHUB_PLUGIN::repoURL_zipURL( const wxString& aRepoURL, string* aZipURL )
 
             // In order to bypass this redirect, saving time, we use the
             // redirected URL on first attempt to save one HTTP GET hit.
-            // avhttp would do the redirect behind the scenes normally, but that would
-            // be slower than doing this bypass.
             zip_url += "codeload.github.com";
             zip_url += repo.GetPath();      // path comes with a leading '/'
             zip_url += "/zip/master";
@@ -498,9 +479,11 @@ bool GITHUB_PLUGIN::repoURL_zipURL( const wxString& aRepoURL, string* aZipURL )
 
         else
         {
+            zip_url = repo.GetScheme();
+            zip_url += "://";
+
             // This is the generic code path for any server which can serve
             // up zip files. The schemes tested include: http and https.
-            // (I don't know what the avhttp library supports beyond that.)
 
             // zip_url goal: "<scheme>://<server>[:<port>]/<path>"
 
@@ -526,124 +509,48 @@ bool GITHUB_PLUGIN::repoURL_zipURL( const wxString& aRepoURL, string* aZipURL )
             // this code path with the needs of one particular inflexible server.
         }
 
-        *aZipURL = zip_url.utf8_str();
+        aZipURL = zip_url.utf8_str();
         return true;
     }
     return false;
 }
 
 
-void GITHUB_PLUGIN::remote_get_zip( const wxString& aRepoURL ) throw( IO_ERROR )
+void GITHUB_PLUGIN::remoteGetZip( const wxString& aRepoURL ) throw( IO_ERROR )
 {
-    string  zip_url;
+    std::string  zip_url;
 
-    if( !repoURL_zipURL( aRepoURL, &zip_url ) )
+    if( !repoURL_zipURL( aRepoURL, zip_url ) )
     {
         wxString msg = wxString::Format( _( "Unable to parse URL:\n'%s'" ), GetChars( aRepoURL ) );
         THROW_IO_ERROR( msg );
     }
 
-    boost::asio::io_service io;
+    wxLogDebug( wxT( "Attempting to download: " ) + zip_url );
-    avhttp::http_stream     h( io );
-    avhttp::request_opts    options;
 
-    options.insert( "Accept",       "application/zip" );
+    KICAD_CURL_EASY kcurl;
-    options.insert( "User-Agent",   "http://kicad-pcb.org" );   // THAT WOULD BE ME.
+
-    h.request_options( options );
+    kcurl.SetURL(zip_url.c_str());
+    kcurl.SetUserAgent("KiCad-EDA");
+    kcurl.SetHeader("Accept", "application/zip");
+    kcurl.SetFollowRedirects(true);
 
     try
     {
-        ostringstream os;
+        kcurl.Perform();
-
+        m_zip_image.assign(kcurl.GetBuffer()->payload, kcurl.GetBuffer()->size);
-        h.open( zip_url );      // only one file, therefore do it synchronously.
-        os << &h;
-
-        // Keep zip file byte image in RAM.  That plus the MODULE_MAP will constitute
-        // the cache.  We don't cache the MODULEs per se, we parse those as needed from
-        // this zip file image.
-        m_zip_image = os.str();
-
-        // 4 lines, using SSL, top that.
     }
-    catch( const boost::system::system_error& e )
+    catch( const IO_ERROR& ioe )
     {
-        // https "GET" has faild, report this to API caller.
-        static const char errorcmd[] = "http GET command failed";  // Do not translate this message
-
         UTF8 fmt( _( "%s\nCannot get/download Zip archive: '%s'\nfor library path: '%s'.\nReason: '%s'" ) );
 
-        string msg = StrPrintf( fmt.c_str(),
+        std::string msg = StrPrintf( fmt.c_str(), 
-                errorcmd,
+                                     zip_url.c_str(), 
-                // Report both secret zip_url and Lib Path, to user.  The secret
+                                     TO_UTF8( aRepoURL ),
-                // zip_url may go bad at some point in future if github changes
+                                     TO_UTF8( ioe.errorText ) );
-                // their server architecture.  Then fix repoURL_zipURL() to reflect
-                // new architecture.
-                zip_url.c_str(), TO_UTF8( aRepoURL ),
-                e.what() );
 
         THROW_IO_ERROR( msg );
     }
-    catch( const exception& exc )
-    {
-        UTF8 error( _( "Exception '%s' in avhttp while open()-ing URI:'%s'" ) );
-
-        string msg = StrPrintf( error.c_str(), exc.what(), zip_url.c_str() );
-        THROW_IO_ERROR( msg );
-    }
-}
-
-
-// This GITHUB_GETLIBLIST method should not be here, but in github_getliblist.cpp !
-// However it is here just because we need to include <avhttp.hpp> to compile it.
-// and when we include avhttp in two .cpp files, the link fails because it detects duplicate
-// avhttp functions.
-// So until it is fixed, this code is here.
-bool GITHUB_GETLIBLIST::remote_get_json( std::string* aFullURLCommand, wxString* aMsgError )
-{
-    boost::asio::io_service io;
-    avhttp::http_stream     h( io );
-    avhttp::request_opts    options;
-
-
-    options.insert( "Accept", m_option_string );
-    options.insert( "User-Agent", "http://kicad-pcb.org" );   // THAT WOULD BE ME.
-    h.request_options( options );
-
-    try
-    {
-        std::ostringstream os;
-
-        h.open( *aFullURLCommand );      // only one file, therefore do it synchronously.
-        os << &h;
-
-        // Keep downloaded text file image in RAM.
-        m_image = os.str();
-
-        // 4 lines, using SSL, top that.
-    }
-    catch( boost::system::system_error& e )
-    {
-        // https "GET" has faild, report this to API caller.
-        static const char errorcmd[] = "https GET command failed";  // Do not translate this message
-
-        UTF8 fmt( _( "%s\nCannot get/download data from: '%s'\nReason: '%s'" ) );
-
-        std::string msg = StrPrintf( fmt.c_str(),
-                errorcmd,
-                // Report secret list_url to user.  The secret
-                // list_url may go bad at some point in future if github changes
-                // their server architecture.  Then fix repoURL_zipURL() to reflect
-                // new architecture.
-                aFullURLCommand->c_str(), e.what() );
-
-        if( aMsgError )
-        {
-            *aMsgError = FROM_UTF8( msg.c_str() );
-            return false;
-        }
-    }
-
-    return true;
 }
 
 #if 0 && defined(STANDALONE)

pcbnew/github/github_plugin.h

@@ -210,14 +210,14 @@ protected:
      * @param  aZipURL is where to put the zip file URL.
      * @return bool - true if @a aRepoULR was parseable, else false
      */
-    static bool repoURL_zipURL( const wxString& aRepoURL, std::string* aZipURL );
+    static bool repoURL_zipURL( const wxString& aRepoURL, std::string& aZipURL );
 
     /**
-     * Function remote_get_zip
+     * Function remoteGetZip
      * fetches a zip file image from a github repo synchronously.  The byte image
      * is received into the m_input_stream.
      */
-    void remote_get_zip( const wxString& aRepoURL ) throw( IO_ERROR );
+    void remoteGetZip( const wxString& aRepoURL ) throw( IO_ERROR );
 
     wxString    m_lib_path;     ///< from aLibraryPath, something like https://github.com/liftoff-sr/pretty_footprints
     std::string m_zip_image;    ///< byte image of the zip file in its entirety.

pcbnew/modedit.cpp

@@ -192,8 +192,10 @@ void FOOTPRINT_EDIT_FRAME::LoadModuleFromBoard( wxCommandEvent& event )
     GetScreen()->ClearUndoRedoList();
     GetScreen()->ClrModify();
 
-    if( m_Draw3DFrame )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
-        m_Draw3DFrame->NewDisplay();
+
+    if( draw3DFrame )
+        draw3DFrame->NewDisplay();
 }
 
 
@@ -370,8 +372,10 @@ void FOOTPRINT_EDIT_FRAME::Process_Special_Functions( wxCommandEvent& event )
                 updateView();
                 m_canvas->Refresh();
 
-                if( m_Draw3DFrame )
+                EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
-                    m_Draw3DFrame->NewDisplay();
+
+                if( draw3DFrame )
+                    draw3DFrame->NewDisplay();
 
                 GetScreen()->ClrModify();
             }
@@ -513,9 +517,12 @@ void FOOTPRINT_EDIT_FRAME::Process_Special_Functions( wxCommandEvent& event )
         GetScreen()->ClrModify();
         Zoom_Automatique( false );
         m_canvas->Refresh();
+        {
+        EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
 
-        if( m_Draw3DFrame )
+        if( draw3DFrame )
-            m_Draw3DFrame->NewDisplay();
+            draw3DFrame->NewDisplay();
+        }
 
         break;
 
@@ -572,8 +579,12 @@ void FOOTPRINT_EDIT_FRAME::Process_Special_Functions( wxCommandEvent& event )
 
         Zoom_Automatique( false );
 
-        if( m_Draw3DFrame )
+        {
-            m_Draw3DFrame->NewDisplay();
+        EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
+
+        if( draw3DFrame )
+            draw3DFrame->NewDisplay();
+        }
 
         GetScreen()->ClrModify();
 

pcbnew/moduleframe.cpp

@@ -672,25 +672,27 @@ void FOOTPRINT_EDIT_FRAME::OnUpdateSelectCurrentLib( wxUpdateUIEvent& aEvent )
 
 void FOOTPRINT_EDIT_FRAME::Show3D_Frame( wxCommandEvent& event )
 {
-    if( m_Draw3DFrame )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
+
+    if( draw3DFrame )
     {
         // Raising the window does not show the window on Windows if iconized.
         // This should work on any platform.
-        if( m_Draw3DFrame->IsIconized() )
+        if( draw3DFrame->IsIconized() )
-             m_Draw3DFrame->Iconize( false );
+             draw3DFrame->Iconize( false );
 
-        m_Draw3DFrame->Raise();
+        draw3DFrame->Raise();
 
         // Raising the window does not set the focus on Linux.  This should work on any platform.
-        if( wxWindow::FindFocus() != m_Draw3DFrame )
+        if( wxWindow::FindFocus() != draw3DFrame )
-            m_Draw3DFrame->SetFocus();
+            draw3DFrame->SetFocus();
 
         return;
     }
 
-    m_Draw3DFrame = new EDA_3D_FRAME( &Kiway(), this, _( "3D Viewer" ) );
+    draw3DFrame = new EDA_3D_FRAME( &Kiway(), this, _( "3D Viewer" ) );
-    m_Draw3DFrame->Raise();     // Needed with some Window Managers
+    draw3DFrame->Raise();     // Needed with some Window Managers
-    m_Draw3DFrame->Show( true );
+    draw3DFrame->Show( true );
 }
 
 
@@ -735,9 +737,10 @@ void FOOTPRINT_EDIT_FRAME::OnModify()
 {
     PCB_BASE_FRAME::OnModify();
 
-    if( m_Draw3DFrame )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
-        m_Draw3DFrame->ReloadRequest();
+
-}
+    if( draw3DFrame )
+        draw3DFrame->ReloadRequest();}
 
 
 void FOOTPRINT_EDIT_FRAME::updateTitle()

pcbnew/modules.cpp

@@ -1,10 +1,10 @@
 /*
  * This program source code file is part of KiCad, a free EDA CAD application.
  *
- * Copyright (C) 2012 Jean-Pierre Charras, jean-pierre.charras@ujf-grenoble.fr
+ * Copyright (C) 2015 Jean-Pierre Charras, jean-pierre.charras@ujf-grenoble.fr
  * Copyright (C) 2012 SoftPLC Corporation, Dick Hollenbeck <dick@softplc.com>
  * Copyright (C) 2012 Wayne Stambaugh <stambaughw@verizon.net>
- * Copyright (C) 1992-2012 KiCad Developers, see AUTHORS.txt for contributors.
+ * Copyright (C) 1992-2015 KiCad Developers, see AUTHORS.txt for contributors.
  *
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU General Public License
@@ -41,7 +41,7 @@
 
 #include <pcbnew.h>
 #include <drag.h>
-
+#include <dialog_get_footprint_by_name.h>
 
 static void MoveFootprint( EDA_DRAW_PANEL* aPanel, wxDC* aDC,
                            const wxPoint& aPosition, bool aErase );
@@ -56,17 +56,23 @@ static PICKED_ITEMS_LIST s_PickedList;                  /* a picked list to
                                                          * and dragged tracks
                                                          */
 
-/* Get a module name from user and return a pointer to the corresponding module
+
- */
+MODULE* PCB_BASE_FRAME::GetFootprintFromBoardByReference()
-MODULE* PCB_BASE_FRAME::GetModuleByName()
 {
-    wxString          moduleName;
+    wxString        moduleName;
-    MODULE*           module = NULL;
+    MODULE*         module = NULL;
+    wxArrayString   fplist;
 
-    wxTextEntryDialog dlg( this, _( "Reference:" ), _( "Search for footprint" ), moduleName );
+    // Build list of available fp references, to display them in dialog
+    for( MODULE* fp = GetBoard()->m_Modules; fp; fp = fp->Next() )
+        fplist.Add( fp->GetReference() + wxT("    ( ") + fp->GetValue() + wxT(" )") );
 
-    if( dlg.ShowModal() != wxID_OK )
+    fplist.Sort();
-        return NULL;    //Aborted by user
+
+    DIALOG_GET_FOOTPRINT_BY_NAME dlg( this, fplist );
+
+    if( dlg.ShowModal() != wxID_OK )    //Aborted by user
+        return NULL;
 
     moduleName = dlg.GetValue();
     moduleName.Trim( true );

pcbnew/modview_frame.cpp

@@ -283,8 +283,10 @@ FOOTPRINT_VIEWER_FRAME::FOOTPRINT_VIEWER_FRAME( KIWAY* aKiway, wxWindow* aParent
 
 FOOTPRINT_VIEWER_FRAME::~FOOTPRINT_VIEWER_FRAME()
 {
-    if( m_Draw3DFrame )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
-        m_Draw3DFrame->Destroy();
+
+    if( draw3DFrame )
+        draw3DFrame->Destroy();
 }
 
 
@@ -613,47 +615,51 @@ bool FOOTPRINT_VIEWER_FRAME::GeneralControl( wxDC* aDC, const wxPoint& aPosition
 
 void FOOTPRINT_VIEWER_FRAME::Show3D_Frame( wxCommandEvent& event )
 {
-    if( m_Draw3DFrame )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
+
+    if( draw3DFrame )
     {
         // Raising the window does not show the window on Windows if iconized.
         // This should work on any platform.
-        if( m_Draw3DFrame->IsIconized() )
+        if( draw3DFrame->IsIconized() )
-             m_Draw3DFrame->Iconize( false );
+             draw3DFrame->Iconize( false );
 
-        m_Draw3DFrame->Raise();
+        draw3DFrame->Raise();
 
         // Raising the window does not set the focus on Linux.  This should work on any platform.
-        if( wxWindow::FindFocus() != m_Draw3DFrame )
+        if( wxWindow::FindFocus() != draw3DFrame )
-            m_Draw3DFrame->SetFocus();
+            draw3DFrame->SetFocus();
 
         return;
     }
 
-    m_Draw3DFrame = new EDA_3D_FRAME( &Kiway(), this, wxEmptyString );
+    draw3DFrame = new EDA_3D_FRAME( &Kiway(), this, wxEmptyString );
     Update3D_Frame( false );
-    m_Draw3DFrame->Raise();     // Needed with some Window Managers
+    draw3DFrame->Raise();     // Needed with some Window Managers
-    m_Draw3DFrame->Show( true );
+    draw3DFrame->Show( true );
 }
 
 
 void FOOTPRINT_VIEWER_FRAME::Update3D_Frame( bool aForceReloadFootprint )
 {
-    if( m_Draw3DFrame == NULL )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
+
+    if( draw3DFrame == NULL )
         return;
 
     wxString frm3Dtitle = wxString::Format(
                 _( "ModView: 3D Viewer [%s]" ),
                 GetChars( getCurFootprintName() ) );
 
-    m_Draw3DFrame->SetTitle( frm3Dtitle );
+    draw3DFrame->SetTitle( frm3Dtitle );
 
     if( aForceReloadFootprint )
     {
-        m_Draw3DFrame->ReloadRequest();
+        draw3DFrame->ReloadRequest();
 
         // Force 3D screen refresh immediately
         if( GetBoard()->m_Modules )
-            m_Draw3DFrame->NewDisplay();
+            draw3DFrame->NewDisplay();
     }
 }
 

pcbnew/pcbframe.cpp

@@ -70,8 +70,6 @@
 #include <tool/tool_dispatcher.h>
 #include <tools/common_actions.h>
 
-#include <scripting/python_console_frame.h>
-
 #if defined(KICAD_SCRIPTING) || defined(KICAD_SCRIPTING_WXPYTHON)
 #include <python_scripting.h>
 #endif
@@ -209,10 +207,12 @@ BEGIN_EVENT_TABLE( PCB_EDIT_FRAME, PCB_BASE_FRAME )
     EVT_TOOL( ID_TOOLBARH_PCB_MODE_TRACKS, PCB_EDIT_FRAME::OnSelectAutoPlaceMode )
     EVT_TOOL( ID_TOOLBARH_PCB_FREEROUTE_ACCESS, PCB_EDIT_FRAME::Access_to_External_Tool )
 
+#if defined( KICAD_SCRIPTING_WXPYTHON )
     // has meaning only with KICAD_SCRIPTING_WXPYTHON enabled
     EVT_TOOL( ID_TOOLBARH_PCB_SCRIPTING_CONSOLE, PCB_EDIT_FRAME::ScriptingConsoleEnableDisable )
     EVT_UPDATE_UI( ID_TOOLBARH_PCB_SCRIPTING_CONSOLE,
                    PCB_EDIT_FRAME::OnUpdateScriptingConsoleState )
+#endif
 
     // Option toolbar
     EVT_TOOL( ID_TB_OPTIONS_DRC_OFF,
@@ -637,26 +637,28 @@ void PCB_EDIT_FRAME::OnCloseWindow( wxCloseEvent& Event )
 
 void PCB_EDIT_FRAME::Show3D_Frame( wxCommandEvent& event )
 {
-    if( m_Draw3DFrame )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
+
+    if( draw3DFrame )
     {
         // Raising the window does not show the window on Windows if iconized.
         // This should work on any platform.
-        if( m_Draw3DFrame->IsIconized() )
+        if( draw3DFrame->IsIconized() )
-             m_Draw3DFrame->Iconize( false );
+             draw3DFrame->Iconize( false );
 
-        m_Draw3DFrame->Raise();
+        draw3DFrame->Raise();
 
         // Raising the window does not set the focus on Linux.  This should work on any platform.
-        if( wxWindow::FindFocus() != m_Draw3DFrame )
+        if( wxWindow::FindFocus() != draw3DFrame )
-            m_Draw3DFrame->SetFocus();
+            draw3DFrame->SetFocus();
 
         return;
     }
 
-    m_Draw3DFrame = new EDA_3D_FRAME( &Kiway(), this, _( "3D Viewer" ) );
+    draw3DFrame = new EDA_3D_FRAME( &Kiway(), this, _( "3D Viewer" ) );
-    m_Draw3DFrame->SetDefaultFileName( GetBoard()->GetFileName() );
+    draw3DFrame->SetDefaultFileName( GetBoard()->GetFileName() );
-    m_Draw3DFrame->Raise();     // Needed with some Window Managers
+    draw3DFrame->Raise();     // Needed with some Window Managers
-    m_Draw3DFrame->Show( true );
+    draw3DFrame->Show( true );
 }
 
 
@@ -937,8 +939,10 @@ void PCB_EDIT_FRAME::OnModify( )
 {
     PCB_BASE_FRAME::OnModify();
 
-    if( m_Draw3DFrame )
+    EDA_3D_FRAME* draw3DFrame = Get3DViewerFrame();
-        m_Draw3DFrame->ReloadRequest();
+
+    if( draw3DFrame )
+        draw3DFrame->ReloadRequest();
 }
 
 
@@ -980,8 +984,7 @@ void PCB_EDIT_FRAME::UpdateTitle()
 }
 
 
-wxSize PYTHON_CONSOLE_FRAME::m_frameSize;   ///< The size of the PYTHON_CONSOLE_FRAME frame, stored during a session
+#if defined( KICAD_SCRIPTING_WXPYTHON )
-wxPoint PYTHON_CONSOLE_FRAME::m_framePos;   ///< The position ofPYTHON_CONSOLE_FRAME  the frame, stored during a session
 
 void PCB_EDIT_FRAME::ScriptingConsoleEnableDisable( wxCommandEvent& aEvent )
 {
@@ -990,13 +993,18 @@ void PCB_EDIT_FRAME::ScriptingConsoleEnableDisable( wxCommandEvent& aEvent )
     bool pythonPanelShown = true;
 
     if( pythonPanelFrame == NULL )
-        pythonPanelFrame = new PYTHON_CONSOLE_FRAME( this, pythonConsoleNameId() );
+        pythonPanelFrame = CreatePythonShellWindow( this, pythonConsoleNameId() );
     else
         pythonPanelShown = ! pythonPanelFrame->IsShown();
 
-    pythonPanelFrame->Show( pythonPanelShown );
+    if( pythonPanelFrame )
+        pythonPanelFrame->Show( pythonPanelShown );
+    else
+        wxMessageBox( wxT( "Error: unable to create the Python Console" ) );
 }
 
+#endif
+
 
 void PCB_EDIT_FRAME::OnSelectAutoPlaceMode( wxCommandEvent& aEvent )
 {

pcbnew/pcbnew.cpp

@@ -242,36 +242,26 @@ static bool scriptingSetup()
         }
     }
 
-    // TODO: make this path definable by the user, and set more than one path
+    // wizard plugins are stored in ../share/kicad/scripting/plugins.
-    // (and remove the fixed paths from <src>/scripting/kicadplugins.i)
+    // so add the base scripting path to python scripting default search paths
-
-    // wizard plugins are stored in kicad/bin/plugins.
-    // so add this path to python scripting default search paths
     // which are ( [KICAD_PATH] is an environment variable to define)
+    // [KICAD_PATH]/scripting
     // [KICAD_PATH]/scripting/plugins
     // Add this default search path:
-    path_frag = Pgm().GetExecutablePath() + wxT( "../share/kicad/scripting/plugins" );
+    path_frag = Pgm().GetExecutablePath() + wxT( "../share/kicad/scripting" );
 
 #elif defined( __WXMAC__ )
-    // TODO:
-    // For scripting currently only the bundle scripting path and the path
-    // defined by $(KICAD_PATH)/scripting/plugins is defined.
-    // These paths are defined here and in kicadplugins.i
-    // In future, probably more paths are of interest:
-    // * User folder (~/Library/Application Support/kicad/scripting/plugins)
-    //   => GetOSXKicadUserDataDir() + wxT( "/scripting/plugins" );
-    // * Machine folder (/Library/Application Support/kicad/scripting/plugins)
-    //   => GetOSXKicadMachineDataDir() + wxT( "/scripting/plugins" );
 
     // This path is given to LoadPlugins() from kicadplugins.i, which
-    // only supports one path. Only use bundle scripting path for now.
+    // only supports one path, the bundle scripting path for now.
-    path_frag = GetOSXKicadDataDir() + wxT( "/scripting/plugins" );
+    // All other paths are determined by the pcbnew.py initialisation code
+    path_frag = GetOSXKicadDataDir() + wxT( "/scripting" );
 
     // Add default paths to PYTHONPATH
     wxString pypath;
 
-    // Bundle scripting folder (<kicad.app>/Contents/SharedSupport/scripting/plugins)
+    // Bundle scripting folder (<kicad.app>/Contents/SharedSupport/scripting)
-    pypath += GetOSXKicadDataDir() + wxT( "/scripting/plugins" );
+    pypath += GetOSXKicadDataDir() + wxT( "/scripting" );
 
     // $(KICAD_PATH)/scripting/plugins is always added in kicadplugins.i
     if( wxGetenv("KICAD_PATH") != NULL )
@@ -304,9 +294,11 @@ static bool scriptingSetup()
     wxSetEnv( wxT( "PYTHONPATH" ), pypath );
 
     // Add this default search path:
-    path_frag = Pgm().GetExecutablePath() + wxT( "../share/kicad/scripting/plugins" );
+    path_frag = Pgm().GetExecutablePath() + wxT( "../share/kicad/scripting" );
 #endif
 
+    // path_frag is the path to the bundled scripts and plugins, all other paths are
+    // determined by the python pcbnew.py initialisation code.
     if( !pcbnewInitPythonScripting( TO_UTF8( path_frag ) ) )
     {
         wxLogError( wxT( "pcbnewInitPythonScripting() failed." ) );
@@ -378,7 +370,7 @@ void IFACE::OnKifaceEnd()
 {
     end_common();
 
-#if KICAD_SCRIPTING_WXPYTHON
+#if defined( KICAD_SCRIPTING_WXPYTHON )
     // Restore the thread state and tell Python to cleanup after itself.
     // wxPython will do its own cleanup as part of that process.
     // This should only be called if python was setup correctly.

pcbnew/scripting/kicad_pyshell/__init__.py

@@ -0,0 +1,223 @@
+# -*- coding: utf-8 -*-
+"""KiCad Python Shell.
+
+This module provides the python shell for KiCad.
+
+Currently the shell is only available inside PCBNEW.
+
+PCBNEW starts the shell once, by calling makePcbnewShellWindow() the
+first time it is opened, subsequently the shell window is just hidden
+or shown, as per user requirements.
+
+IF makePcbnewShellWindow() is called again, a second/third shell window
+can be created.  PCBNEW does not do this, but a user may call this from
+the first shell if they require.
+
+"""
+import wx
+import sys
+import os
+
+from wx.py import crust, editor, version, dispatcher
+from wx.py.editor import EditorNotebook
+
+import pcbnew
+
+INTRO = "KiCAD:PCBNEW - Python Shell - PyAlaMode %s" % version.VERSION
+
+
+class PcbnewPyShell(editor.EditorNotebookFrame):
+
+    """The Pythonshell of PCBNEW."""
+
+    def _setup_startup(self):
+        """Initialise the startup script."""
+        # Create filename for startup script.
+        self.startup_file = os.path.join(self.config_dir,
+                                         "PyShell_pcbnew_startup.py")
+        self.execStartupScript = True
+
+        # Check if startup script exists
+        if not os.path.isfile(self.startup_file):
+            # Not, so create a default.
+            default_startup = open(self.startup_file, 'w')
+            # provide the content for the default startup file.
+            default_startup.write(
+                "### DEFAULT STARTUP FILE FOR KiCad:PCBNEW Python Shell\n" +
+                "# Enter any Python code you would like to execute when" +
+                " the PCBNEW python shell first runs.\n" +
+                "\n" +
+                "# Eg:\n" +
+                "\n" +
+                "# import pcbnew\n" +
+                "# board = pcbnew.GetBoard()\n")
+            default_startup.close()
+
+    def _setup(self):
+        """
+        Setup prior to first buffer creation.
+
+        Called automatically by base class during init.
+        """
+        self.notebook = EditorNotebook(parent=self)
+        intro = 'Py %s' % version.VERSION
+        import imp
+        module = imp.new_module('__main__')
+        import __builtin__
+        module.__dict__['__builtins__'] = __builtin__
+        namespace = module.__dict__.copy()
+
+        self.config_dir = pcbnew.GetKicadConfigPath()
+        self.dataDir = self.config_dir
+
+        self._setup_startup()
+        self.history_file = os.path.join(self.config_dir,
+                                         "PyShell_pcbnew.history")
+
+        self.config_file = os.path.join(self.config_dir,
+                                        "PyShell_pcbnew.cfg")
+        self.config = wx.FileConfig(localFilename=self.config_file)
+        self.config.SetRecordDefaults(True)
+        self.autoSaveSettings = False
+        self.autoSaveHistory = False
+        self.LoadSettings()
+
+        self.crust = crust.Crust(parent=self.notebook,
+                                 intro=intro, locals=namespace,
+                                 rootLabel="locals()",
+                                 startupScript=self.startup_file,
+                                 execStartupScript=self.execStartupScript)
+
+        self.shell = self.crust.shell
+        # Override the filling so that status messages go to the status bar.
+        self.crust.filling.tree.setStatusText = self.SetStatusText
+        # Override the shell so that status messages go to the status bar.
+        self.shell.setStatusText = self.SetStatusText
+        # Fix a problem with the sash shrinking to nothing.
+        self.crust.filling.SetSashPosition(200)
+        self.notebook.AddPage(page=self.crust, text='*Shell*', select=True)
+        self.setEditor(self.crust.editor)
+        self.crust.editor.SetFocus()
+
+        self.LoadHistory()
+
+    def OnAbout(self, event):
+        """Display an About window."""
+        title = 'About : KiCad:PCBNEW - Python Shell'
+        text = "Enahnced Python Shell for KiCad:PCBNEW\n\n" + \
+               "This KiCad Python Shell is based on wxPython PyAlaMode.\n\n" + \
+               "see: http://wiki.wxpython.org/PyAlaMode\n\n" + \
+               "KiCad Revision: %s\n" % "??.??" + \
+               "PyAlaMode Revision : %s\n" % version.VERSION + \
+               "Platform: %s\n" % sys.platform + \
+               "Python Version: %s\n" % sys.version.split()[0] + \
+               "wxPython Version: %s\n" % wx.VERSION_STRING + \
+               ("\t(%s)\n" % ", ".join(wx.PlatformInfo[1:]))
+
+        dialog = wx.MessageDialog(self, text, title,
+                                  wx.OK | wx.ICON_INFORMATION)
+        dialog.ShowModal()
+        dialog.Destroy()
+
+    def EditStartupScript(self):
+        """Open a Edit buffer of the startup script file."""
+        self.bufferCreate(filename=self.startup_file)
+
+    def LoadSettings(self):
+        """Load settings for the shell."""
+        if self.config is not None:
+            editor.EditorNotebookFrame.LoadSettings(self, self.config)
+            self.autoSaveSettings = \
+                self.config.ReadBool('Options/AutoSaveSettings', False)
+            self.execStartupScript = \
+                self.config.ReadBool('Options/ExecStartupScript', True)
+            self.autoSaveHistory = \
+                self.config.ReadBool('Options/AutoSaveHistory', False)
+            self.hideFoldingMargin = \
+                self.config.ReadBool('Options/HideFoldingMargin', True)
+
+    def SaveSettings(self, force=False):
+        """
+        Save settings for the shell.
+
+        Arguments:
+
+        force -- False - Autosaving.  True - Manual Saving.
+        """
+        if self.config is not None:
+            # always save these
+            self.config.WriteBool('Options/AutoSaveSettings',
+                                  self.autoSaveSettings)
+            if self.autoSaveSettings or force:
+                editor.EditorNotebookFrame.SaveSettings(self, self.config)
+
+                self.config.WriteBool('Options/AutoSaveHistory',
+                                      self.autoSaveHistory)
+                self.config.WriteBool('Options/ExecStartupScript',
+                                      self.execStartupScript)
+                self.config.WriteBool('Options/HideFoldingMargin',
+                                      self.hideFoldingMargin)
+            if self.autoSaveHistory:
+                self.SaveHistory()
+
+    def DoSaveSettings(self):
+        """Menu function to trigger saving the shells settings."""
+        if self.config is not None:
+            self.SaveSettings(force=True)
+            self.config.Flush()
+
+    def SaveHistory(self):
+        """Save shell history to the shell history file."""
+        if self.dataDir:
+            try:
+                name = self.history_file
+                f = file(name, 'w')
+                hist = []
+                enc = wx.GetDefaultPyEncoding()
+                for h in self.shell.history:
+                    if isinstance(h, unicode):
+                        h = h.encode(enc)
+                    hist.append(h)
+                hist = '\x00\n'.join(hist)
+                f.write(hist)
+                f.close()
+            except:
+                d = wx.MessageDialog(self, "Error saving history file.",
+                                     "Error", wx.ICON_EXCLAMATION | wx.OK)
+                d.ShowModal()
+                d.Destroy()
+                raise
+
+    def LoadHistory(self):
+        """Load shell history from the shell history file."""
+        if self.dataDir:
+            name = self.history_file
+            if os.path.exists(name):
+                try:
+                    f = file(name, 'U')
+                    hist = f.read()
+                    f.close()
+                    self.shell.history = hist.split('\x00\n')
+                    dispatcher.send(signal="Shell.loadHistory",
+                                    history=self.shell.history)
+                except:
+                    d = wx.MessageDialog(self,
+                                         "Error loading history file!",
+                                         "Error", wx.ICON_EXCLAMATION | wx.OK)
+                    d.ShowModal()
+                    d.Destroy()
+
+
+def makePcbnewShellWindow(parent=None):
+    """
+    Create a new Shell Window and return its handle.
+
+    Arguments:
+    parent -- The parent window to attach to.
+
+    Returns:
+    The handle to the new window.
+    """
+    pyshell = PcbnewPyShell(parent, id=-1, title=INTRO)
+    pyshell.Show()
+    return pyshell

pcbnew/toolbars_update_user_interface.cpp

@@ -104,6 +104,9 @@ void PCB_EDIT_FRAME::OnUpdateLayerSelectBox( wxUpdateUIEvent& aEvent )
     m_SelLayerBox->SetLayerSelection( GetActiveLayer() );
 }
 
+
+#if defined( KICAD_SCRIPTING_WXPYTHON )
+
 // Used only when the DKICAD_SCRIPTING_WXPYTHON option is on
 void PCB_EDIT_FRAME::OnUpdateScriptingConsoleState( wxUpdateUIEvent& aEvent )
 {
@@ -112,6 +115,8 @@ void PCB_EDIT_FRAME::OnUpdateScriptingConsoleState( wxUpdateUIEvent& aEvent )
     aEvent.Check( pythonPanelShown );
 }
 
+#endif
+
 
 void PCB_EDIT_FRAME::OnUpdateZoneDisplayStyle( wxUpdateUIEvent& aEvent )
 {

pcbnew/tools/selection_tool.cpp

@@ -727,7 +727,7 @@ int SELECTION_TOOL::find( const TOOL_EVENT& aEvent )
 
 int SELECTION_TOOL::findMove( const TOOL_EVENT& aEvent )
 {
-    MODULE* module = m_frame->GetModuleByName();
+    MODULE* module = m_frame->GetFootprintFromBoardByReference();
 
     if( module )
     {

plugins/3d/vrml/v2/vrml2_base.cpp

@@ -63,9 +63,9 @@ bool WRL2BASE::SetParent( WRL2NODE* aParent )
 }
 
 
-WRL2NODE* WRL2BASE::FindNode( const char *aNodeName, const WRL2NODE *aCaller )
+WRL2NODE* WRL2BASE::FindNode( const std::string& aNodeName, const WRL2NODE *aCaller )
 {
-    if( NULL == aNodeName || 0 == aNodeName[0] )
+    if( aNodeName.empty() )
         return NULL;
 
     if( !m_Name.compare( aNodeName ) )
@@ -178,158 +178,13 @@ bool WRL2BASE::Read( WRLPROC& proc )
         return false;
     }
 
-    std::string glob;
+    WRL2NODE* node = NULL;
-    bool hasComma = false;
-    WRL2NODES ntype;
 
-    while( proc.ReadName( glob ) )
+    while( !readNode( proc, this, node ) );
-    {
-        // Process node name:
-        // the names encountered at this point should be one of the
-        // built-in node names or one of:
-        // DEF, USE
-        // PROTO, EXTERNPROTO
-        // ROUTE
-        // any PROTO or EXTERNPROTO defined name
-        // since we do not support PROTO or EXTERNPROTO, any unmatched names are
-        // assumed to be defined via PROTO/EXTERNPROTO and deleted according to
-        // a typical pattern.
-        if( !glob.compare( "USE" ) )
-        {
-            // XXX - implement
-        }
 
-        if( !glob.compare( "DEF" ) )
+    if( proc.eof() )
-        {
+        return true;
-            // XXX - implement
-        }
 
-        if( !glob.compare( "PROTO" ) )
-        {
-            if( !proc.ReadName( glob ) || !proc.ReadName( glob ) || !proc.DiscardList() )
-            {
-                #ifdef DEBUG
-                std::cerr << __FILE__ << ": " << __FUNCTION__ << ": " << __LINE__ << "\n";
-                std::cerr << proc.GetError() <<  "\n";
-                #endif
-            }
-        }
-
-        if( !glob.compare( "EXTERNPROTO" ) )
-        {
-            // XXX - implement
-        }
-
-        if( !glob.compare( "ROUTE" ) )
-        {
-            // XXX - implement
-        }
-
-        ntype = getNodeTypeID( glob );
-
-        switch( ntype )
-        {
-        //
-        // items to be implemented:
-        //
-        case WRL2_APPEARANCE:
-            // note:
-            break;
-
-        case WRL2_BOX:
-            break;
-
-        case WRL2_COLOR:
-            break;
-
-        case WRL2_CONE:
-            break;
-
-        case WRL2_COORDINATE:
-            break;
-
-        case WRL2_CYLINDER:
-            break;
-
-        case WRL2_ELEVATIONGRID:
-            break;
-
-        case WRL2_EXTRUSION:
-            break;
-
-        case WRL2_INDEXEDFACESET:
-            break;
-
-        case WRL2_MATERIAL:
-            break;
-
-        case WRL2_NORMAL:
-            break;
-
-        case WRL2_SHAPE:
-            break;
-
-        case WRL2_SPHERE:
-            break;
-
-        case WRL2_TRANSFORM:
-        case WRL2_GROUP:
-            break;
-
-        //
-        // items not implemented or for optional future implementation:
-        //
-        case WRL2_ANCHOR:
-        case WRL2_AUDIOCLIP:
-        case WRL2_BACKGROUND:
-        case WRL2_BILLBOARD:
-        case WRL2_COLLISION:
-        case WRL2_COLORINTERPOLATOR:
-        case WRL2_COORDINATEINTERPOLATOR:
-        case WRL2_CYLINDERSENSOR:
-        case WRL2_DIRECTIONALLIGHT:
-        case WRL2_FOG:
-        case WRL2_FONTSTYLE:
-        case WRL2_IMAGETEXTURE:
-        case WRL2_INDEXEDLINESET:
-        case WRL2_INLINE:
-        case WRL2_LOD:
-        case WRL2_MOVIETEXTURE:
-        case WRL2_NAVIGATIONINFO:
-        case WRL2_NORMALINTERPOLATOR:
-        case WRL2_ORIENTATIONINTERPOLATOR:
-        case WRL2_PIXELTEXTURE:
-        case WRL2_PLANESENSOR:
-        case WRL2_POINTLIGHT:
-        case WRL2_POINTSET:
-        case WRL2_POSITIONINTERPOLATOR:
-        case WRL2_PROXIMITYSENSOR:
-        case WRL2_SCALARINTERPOLATOR:
-        case WRL2_SCRIPT:
-        case WRL2_SOUND:
-        case WRL2_SPHERESENSOR:
-        case WRL2_SPOTLIGHT:
-        case WRL2_SWITCH:
-        case WRL2_TEXT:
-        case WRL2_TEXTURECOORDINATE:
-        case WRL2_TEXTURETRANSFORM:
-        case WRL2_TIMESENSOR:
-        case WRL2_TOUCHSENSOR:
-        case WRL2_VIEWPOINT:
-        case WRL2_VISIBILITYSENSOR:
-        case WRL2_WORLDINFO:
-        case WRL2_INVALID:
-        default:    // any nodes which may have been defined via PROTO/EXTERNPROTO
-            break;
-        }
-
-        //xxx;
-    };
-
-    // XXX - determine why ReadName failed
-
-    // XXX -
-    #warning TO BE IMPLEMENTED
     return false;
 }
 
@@ -338,3 +193,280 @@ bool WRL2BASE::isDangling( void )
 {
     return false;
 }
+
+
+bool WRL2BASE::implementUse( WRLPROC& proc, WRL2NODE* aParent )
+{
+    if( !aParent )
+    {
+        #ifdef DEBUG
+        std::cerr << __FILE__ << ": " << __FUNCTION__ << ": " << __LINE__ << "\n";
+        std::cerr << " * [BUG] invoked with NULL parent\n";
+        #endif
+
+        return false;
+    }
+
+    std::string glob;
+
+    if( !proc.ReadName( glob ) )
+    {
+        #ifdef DEBUG
+        std::cerr << __FILE__ << ": " << __FUNCTION__ << ": " << __LINE__ << "\n";
+        std::cerr << proc.GetError() <<  "\n";
+        #endif
+
+        return false;
+    }
+
+    WRL2NODE* ref = aParent->FindNode( glob, NULL );
+
+    // return 'true' - the file may be defective but it may still be somewhat OK
+    if( NULL == ref )
+    {
+        #ifdef DEBUG
+        std::cerr << __FILE__ << ": " << __FUNCTION__ << ": " << __LINE__ << "\n";
+        std::cerr << " * [INFO] node '" << glob << "' not found\n";
+        #endif
+
+        return true;
+    }
+
+    if( !aParent->AddRefNode( ref ) )
+    {
+        #ifdef DEBUG
+        std::cerr << __FILE__ << ": " << __FUNCTION__ << ": " << __LINE__ << "\n";
+        std::cerr << " * [INFO] failed to add node '" << glob << "' (";
+        std::cerr << ref->GetNodeTypeName( ref->GetNodeType() ) << ") to parent of type ";
+        std::cerr << aParent->GetNodeTypeName( aParent->GetNodeType() ) << "\n";
+        #endif
+
+        return false;
+    }
+
+    return true;
+}
+
+
+bool WRL2BASE::implementDef( WRLPROC& proc, WRL2NODE* aParent )
+{
+    // XXX - TO BE IMPLEMENTED
+    return false;
+}
+
+
+bool WRL2BASE::readNode( WRLPROC& proc, WRL2NODE* aParent, WRL2NODE** aNode )
+{
+    if( NULL == aNode )
+    {
+        #ifdef DEBUG
+        std::cerr << __FILE__ << ": " << __FUNCTION__ << ": " << __LINE__ << "\n";
+        std::cerr << " * [BUG] invalid node handle (NULL)\n";
+        #endif
+
+        return false;
+    }
+
+    if( NULL == aParent )
+    {
+        #ifdef DEBUG
+        std::cerr << __FILE__ << ": " << __FUNCTION__ << ": " << __LINE__ << "\n";
+        std::cerr << " * [BUG] invalid parent pointer (NULL)\n";
+        #endif
+
+        return false;
+    }
+
+    *aNode = NULL;
+
+    std::string glob;
+    bool hasComma = false;
+    WRL2NODES ntype;
+
+    if( !proc.ReadName( glob ) )
+    {
+        #ifdef DEBUG
+        std::cerr << __FILE__ << ": " << __FUNCTION__ << ": " << __LINE__ << "\n";
+        std::cerr << proc.GetError() <<  "\n";
+        #endif
+
+        return false;
+    }
+
+    // Process node name:
+    // the names encountered at this point should be one of the
+    // built-in node names or one of:
+    // DEF, USE
+    // PROTO, EXTERNPROTO
+    // ROUTE
+    // any PROTO or EXTERNPROTO defined name
+    // since we do not support PROTO or EXTERNPROTO, any unmatched names are
+    // assumed to be defined via PROTO/EXTERNPROTO and deleted according to
+    // a typical pattern.
+    if( !glob.compare( "USE" ) )
+    {
+        if( !implementUse( aParent ) )
+        {
+            #ifdef DEBUG
+            std::cerr << __FILE__ << ": " << __FUNCTION__ << ": " << __LINE__ << "\n";
+            std::cerr << proc.GetError() <<  "\n";
+            #endif
+
+            return false;
+        }
+
+        return true;
+    }
+
+    if( !glob.compare( "DEF" ) )
+    {
+        // XXX - implement
+        implementDef( aParent );
+    }
+
+    if( !glob.compare( "PROTO" ) )
+    {
+        if( !proc.ReadName( glob ) || !proc.DiscardList() )
+        {
+            #ifdef DEBUG
+            std::cerr << __FILE__ << ": " << __FUNCTION__ << ": " << __LINE__ << "\n";
+            std::cerr << proc.GetError() <<  "\n";
+            #endif
+
+            return false;
+        }
+
+        return true;
+    }
+
+    if( !glob.compare( "EXTERNPROTO" ) )
+    {
+        if( !proc.ReadName( glob ) || !proc.ReadName( glob ) || !proc.DiscardList() )
+        {
+            #ifdef DEBUG
+            std::cerr << __FILE__ << ": " << __FUNCTION__ << ": " << __LINE__ << "\n";
+            std::cerr << proc.GetError() <<  "\n";
+            #endif
+
+            return false;
+        }
+
+        return true;
+    }
+
+    if( !glob.compare( "ROUTE" ) )
+    {
+        if( !proc.ReadGlob( glob ) || !proc.ReadGlob( glob ) || !proc.ReadGlob( glob ) )
+        {
+            #ifdef DEBUG
+            std::cerr << __FILE__ << ": " << __FUNCTION__ << ": " << __LINE__ << "\n";
+            std::cerr << proc.GetError() <<  "\n";
+            #endif
+
+            return false;
+        }
+
+        return true;
+    }
+
+    ntype = getNodeTypeID( glob );
+
+    switch( ntype )
+    {
+        //
+        // items to be implemented:
+        //
+    case WRL2_APPEARANCE:
+        // note:
+        break;
+
+    case WRL2_BOX:
+        break;
+
+    case WRL2_COLOR:
+        break;
+
+    case WRL2_CONE:
+        break;
+
+    case WRL2_COORDINATE:
+        break;
+
+    case WRL2_CYLINDER:
+        break;
+
+    case WRL2_ELEVATIONGRID:
+        break;
+
+    case WRL2_EXTRUSION:
+        break;
+
+    case WRL2_INDEXEDFACESET:
+        break;
+
+    case WRL2_MATERIAL:
+        break;
+
+    case WRL2_NORMAL:
+        break;
+
+    case WRL2_SHAPE:
+        break;
+
+    case WRL2_SPHERE:
+        break;
+
+    case WRL2_TRANSFORM:
+    case WRL2_GROUP:
+        break;
+
+        //
+        // items not implemented or for optional future implementation:
+        //
+    case WRL2_ANCHOR:
+    case WRL2_AUDIOCLIP:
+    case WRL2_BACKGROUND:
+    case WRL2_BILLBOARD:
+    case WRL2_COLLISION:
+    case WRL2_COLORINTERPOLATOR:
+    case WRL2_COORDINATEINTERPOLATOR:
+    case WRL2_CYLINDERSENSOR:
+    case WRL2_DIRECTIONALLIGHT:
+    case WRL2_FOG:
+    case WRL2_FONTSTYLE:
+    case WRL2_IMAGETEXTURE:
+    case WRL2_INDEXEDLINESET:
+    case WRL2_INLINE:
+    case WRL2_LOD:
+    case WRL2_MOVIETEXTURE:
+    case WRL2_NAVIGATIONINFO:
+    case WRL2_NORMALINTERPOLATOR:
+    case WRL2_ORIENTATIONINTERPOLATOR:
+    case WRL2_PIXELTEXTURE:
+    case WRL2_PLANESENSOR:
+    case WRL2_POINTLIGHT:
+    case WRL2_POINTSET:
+    case WRL2_POSITIONINTERPOLATOR:
+    case WRL2_PROXIMITYSENSOR:
+    case WRL2_SCALARINTERPOLATOR:
+    case WRL2_SCRIPT:
+    case WRL2_SOUND:
+    case WRL2_SPHERESENSOR:
+    case WRL2_SPOTLIGHT:
+    case WRL2_SWITCH:
+    case WRL2_TEXT:
+    case WRL2_TEXTURECOORDINATE:
+    case WRL2_TEXTURETRANSFORM:
+    case WRL2_TIMESENSOR:
+    case WRL2_TOUCHSENSOR:
+    case WRL2_VIEWPOINT:
+    case WRL2_VISIBILITYSENSOR:
+    case WRL2_WORLDINFO:
+    case WRL2_INVALID:
+    default:    // any nodes which may have been defined via PROTO/EXTERNPROTO
+        break;
+    }
+
+    // XXX - TO BE IMPLEMENTED
+    return NULL;
+}

plugins/3d/vrml/v2/vrml2_base.h

@@ -70,6 +70,13 @@ public:
     void unlinkRefNode( const WRL2NODE* aNode );
     bool isDangling( void );
 
+    // handle cases of USE / DEF
+    bool implementUse( WRLPROC& proc, WRL2NODE* aParent );
+    bool implementDef( WRLPROC& proc, WRL2NODE* aParent );
+
+    // read in a VRML node
+    bool readNode( WRLPROC& proc, WRL2NODE* aParent, WRL2NODE** aNode );
+
 public:
     WRL2BASE();
     virtual ~WRL2BASE();
@@ -81,7 +88,7 @@ public:
     // functions inherited from WRL2NODE
     bool Read( WRLPROC& proc );
     bool SetParent( WRL2NODE* aParent );
-    WRL2NODE* FindNode( const char *aNodeName, const WRL2NODE *aCaller );
+    WRL2NODE* FindNode( const std::string& aNodeName, const WRL2NODE *aCaller );
     bool AddRefNode( WRL2NODE* aNode );
     bool AddChildNode( WRL2NODE* aNode );
 };

plugins/3d/vrml/v2/vrml2_node.cpp

@@ -268,7 +268,7 @@ WRL2NODES WRL2NODE::getNodeTypeID( const std::string aNodeName )
 }
 
 
-const char* WRL2NODE::GetError( void )
+std::string WRL2NODE::GetError( void )
 {
-    return m_error.c_str();
+    return m_error;
 }

plugins/3d/vrml/v2/vrml2_node.h

@@ -162,13 +162,13 @@ public:
      * @param aCaller is a pointer to the node invoking this function
      * @return is a valid node pointer on success, otherwise NULL
      */
-    virtual WRL2NODE* FindNode( const char *aNodeName, const WRL2NODE *aCaller ) = 0;
+    virtual WRL2NODE* FindNode( const std::string& aNodeName, const WRL2NODE *aCaller ) = 0;
 
     virtual bool AddRefNode( WRL2NODE* aNode ) = 0;
 
     virtual bool AddChildNode( WRL2NODE* aNode ) = 0;
 
-    const char* GetError( void );
+    std::string GetError( void );
 };
 
 #endif  // VRML2_NODE_H

plugins/3d/vrml/v2/wrlproc.cpp

@@ -2144,3 +2144,18 @@ bool WRLPROC::ReadMFVec3f( std::vector< WRLVEC3F >& aMFVec3f )
     ++m_linepos;
     return true;
 }
+
+
+bool WRLPROC::eof( void )
+{
+    if( !m_file.is_open() )
+        return false;
+
+    return m_file.eof();
+}
+
+
+std::string WRLPROC::GetError( void )
+{
+    return m_error;
+}

plugins/3d/vrml/v2/wrlproc.h

@@ -67,9 +67,13 @@ public:
 
     bool Open( const std::string& aFileName );
     void Close();
+    bool eof( void );
 
+    // return the VRML Version
     WRLVERSION GetVRMLType( void );
 
+    std::string GetError( void );
+
     // helper routines
 
     // read up to the next whitespace or comma

scripting/kicadplugins.i

@@ -78,21 +78,59 @@ def ReloadPlugins():
             ReloadPlugin(k)
 
 
-def LoadPlugins(plugpath):
+def LoadPlugins(bundlepath=None):
+    """
+    Initialise Scripting/Plugin python environment and load plugins.
+
+    Arguments:
+    scriptpath -- The path to the bundled scripts.
+                  The bunbled Plugins are relative to this path, in the
+                  "plugins" subdirectory.
+
+    NOTE: These are all of the possible "default" search paths for kicad
+          python scripts.  These paths will ONLY be added to the python
+          search path ONLY IF they already exist.
+
+        The Scripts bundled with the KiCad installation:
+            <bundlepath>/
+            <bundlepath>/plugins/
+
+        The Scripts relative to the KiCad search path environment variable:
+            [KICAD_PATH]/scripting/
+            [KICAD_PATH]/scripting/plugins/
+
+        The Scripts relative to the KiCad Users configuration:
+            <kicad_config_path>/scripting/
+            <kicad_config_path>/scripting/plugins/
+
+        And on Linux ONLY, extra paths relative to the users home directory:
+            ~/.kicad_plugins/
+            ~/.kicad/scripting/
+            ~/.kicad/scripting/plugins/
+    """
     import os
     import sys
+    import pcbnew
 
     kicad_path = os.environ.get('KICAD_PATH')
+    config_path = pcbnew.GetKicadConfigPath()
     plugin_directories=[]
 
-    if plugpath:
+    if bundlepath:
-        plugin_directories.append(plugpath)
+        plugin_directories.append(bundlepath)
+        plugin_directories.append(os.path.join(bundlepath, 'plugins'))
 
     if kicad_path:
+        plugin_directories.append(os.path.join(kicad_path, 'scripting'))
         plugin_directories.append(os.path.join(kicad_path, 'scripting', 'plugins'))
 
+    if config_path:
+        plugin_directories.append(os.path.join(config_path, 'scripting'))
+        plugin_directories.append(os.path.join(config_path, 'scripting', 'plugins'))
+
     if sys.platform.startswith('linux'):
         plugin_directories.append(os.environ['HOME']+'/.kicad_plugins/')
+        plugin_directories.append(os.environ['HOME']+'/.kicad/scripting/')
         plugin_directories.append(os.environ['HOME']+'/.kicad/scripting/plugins/')
 
     for plugins_dir in plugin_directories:

scripting/python_scripting.cpp

@@ -136,7 +136,7 @@ static void swigSwitchPythonBuiltin()
 
 PyThreadState* g_PythonMainTState;
 
-bool pcbnewInitPythonScripting( const char * aUserPluginsPath )
+bool pcbnewInitPythonScripting( const char * aUserScriptingPath )
 {
     swigAddBuiltin();           // add builtin functions
     swigAddModules();           // add our own modules
@@ -191,7 +191,7 @@ bool pcbnewInitPythonScripting( const char * aUserPluginsPath )
         snprintf( cmd, sizeof(cmd), "import sys, traceback\n"
                       "sys.path.append(\".\")\n"
                       "import pcbnew\n"
-                      "pcbnew.LoadPlugins(\"%s\")", aUserPluginsPath );
+                      "pcbnew.LoadPlugins(\"%s\")", aUserScriptingPath );
         PyRun_SimpleString( cmd );
     }
 
@@ -227,20 +227,15 @@ void RedirectStdio()
 }
 
 
-wxWindow* CreatePythonShellWindow( wxWindow* parent )
+wxWindow* CreatePythonShellWindow( wxWindow* parent, const wxString& aFramenameId )
 {
-    const char* pycrust_panel =
+    const char* pcbnew_pyshell =
-        "import wx\n"
+        "import kicad_pyshell\n"
-        "from wx.py import shell, version\n"
-        "\n"
-        "intro = \"PyCrust %s - KiCAD Python Shell\" % version.VERSION\n"
         "\n"
         "def makeWindow(parent):\n"
-        "    pycrust = shell.Shell(parent, -1, introText=intro)\n"
+        "    return kicad_pyshell.makePcbnewShellWindow(parent)\n"
-        "    return pycrust\n"
         "\n";
 
-
     wxWindow*   window = NULL;
     PyObject*   result;
 
@@ -257,7 +252,7 @@ wxWindow* CreatePythonShellWindow( wxWindow* parent )
     Py_DECREF( builtins );
 
     // Execute the code to make the makeWindow function we defined above
-    result = PyRun_String( pycrust_panel, Py_file_input, globals, globals );
+    result = PyRun_String( pcbnew_pyshell, Py_file_input, globals, globals );
 
     // Was there an exception?
     if( !result )
@@ -297,6 +292,8 @@ wxWindow* CreatePythonShellWindow( wxWindow* parent )
 
         wxASSERT_MSG( success, _T( "Returned object was not a wxWindow!" ) );
         Py_DECREF( result );
+
+        window->SetName( aFramenameId );
     }
 
     // Release the python objects we still have

scripting/python_scripting.h

@@ -24,14 +24,14 @@
  * Initializes the Python engine inside pcbnew
  */
 
-bool        pcbnewInitPythonScripting( const char * aUserPluginsPath );
+bool        pcbnewInitPythonScripting( const char * aUserScriptingPath );
 void        pcbnewFinishPythonScripting();
 
 
 #ifdef KICAD_SCRIPTING_WXPYTHON
 
 void        RedirectStdio();
-wxWindow*   CreatePythonShellWindow( wxWindow* parent );
+wxWindow*   CreatePythonShellWindow( wxWindow* parent, const wxString& aFramenameId );
 
 class PyLOCK
 {