haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

FP editor: ensure a newly created pad PTH has a hole. 

When a new pad type PTH is created from a SMD pad master , previously its
hole had a null size because the master pad had a null size.
Also allows a HEATSINK pad to be added to a SMD footprint.
This commit is contained in:
jean-pierre charras 2024-01-11 15:36:20 +01:00
parent d0236ca751
commit 0ac23f9099
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
pcbnew/tools/pad_tool.cpp
View File

@ -1,7 +1,7 @@
/* /*
* This program source code file is part of KiCad, a free EDA CAD application. * This program source code file is part of KiCad, a free EDA CAD application.
* *
* Copyright (C) 2017-2023 KiCad Developers, see AUTHORS.txt for contributors. * Copyright (C) 2017-2024 KiCad Developers, see AUTHORS.txt for contributors.
* *
* This program is free software; you can redistribute it and/or * This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License * modify it under the terms of the GNU General Public License
@ -565,13 +565,17 @@ int PAD_TOOL::PlacePad( const TOOL_EVENT& aEvent )
// If the footprint type and master pad type directly conflict then make some // If the footprint type and master pad type directly conflict then make some
// adjustments. Otherwise assume the user set what they wanted. // adjustments. Otherwise assume the user set what they wanted.
// Note also a HEATSINK pad (thermal via) is allowed in SMD footprint
if( ( m_board->GetFirstFootprint()->GetAttributes() & FP_SMD ) if( ( m_board->GetFirstFootprint()->GetAttributes() & FP_SMD )
&& master->GetAttribute() == PAD_ATTRIB::PTH ) && master->GetAttribute() == PAD_ATTRIB::PTH )
{ {
pad->SetAttribute( PAD_ATTRIB::SMD ); if( pad->GetProperty() != PAD_PROP::HEATSINK )
pad->SetShape( PAD_SHAPE::ROUNDRECT ); {
pad->SetSizeX( 1.5 * pad->GetSizeY() ); pad->SetAttribute( PAD_ATTRIB::SMD );
pad->SetLayerSet( PAD::SMDMask() ); pad->SetShape( PAD_SHAPE::ROUNDRECT );
pad->SetSizeX( 1.5 * pad->GetSizeY() );
pad->SetLayerSet( PAD::SMDMask() );
}
} }
else if( ( m_board->GetFirstFootprint()->GetAttributes() & FP_THROUGH_HOLE ) else if( ( m_board->GetFirstFootprint()->GetAttributes() & FP_THROUGH_HOLE )
&& master->GetAttribute() == PAD_ATTRIB::SMD ) && master->GetAttribute() == PAD_ATTRIB::SMD )
@ -579,6 +583,13 @@ int PAD_TOOL::PlacePad( const TOOL_EVENT& aEvent )
pad->SetAttribute( PAD_ATTRIB::PTH ); pad->SetAttribute( PAD_ATTRIB::PTH );
pad->SetShape( PAD_SHAPE::CIRCLE ); pad->SetShape( PAD_SHAPE::CIRCLE );
pad->SetSize( VECTOR2I( pad->GetSizeX(), pad->GetSizeX() ) ); pad->SetSize( VECTOR2I( pad->GetSizeX(), pad->GetSizeX() ) );
// Gives an acceptable drill size: it cannot be 0, but from pad master
// it is currently 0, therefore change it:
pad->SetDrillShape( PAD_DRILL_SHAPE_CIRCLE );
int hole_size = pad->GetSizeX() / 2;
pad->SetDrillSize( VECTOR2I( hole_size, hole_size ) );
pad->SetLayerSet( PAD::PTHMask() ); pad->SetLayerSet( PAD::PTHMask() );
} }