haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make sure sort is deterministic. 

Fixes https://gitlab.com/kicad/code/kicad/-/issues/15336
This commit is contained in:
Jeff Young 2023-10-04 18:05:12 +01:00
parent c2d7b26ebd
commit 0d51729537
1 changed files with 14 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
3d-viewer/3d_rendering/opengl/3d_model.cpp
View File

@ -482,23 +482,21 @@ void MODEL_3D::Draw( bool aTransparent, float aOpacity, bool aUseSelectedMateria
// Sort from back to front // Sort from back to front
std::sort( materialsSorted.begin(), materialsSorted.end(), std::sort( materialsSorted.begin(), materialsSorted.end(),
[&]( std::pair<const MODEL_3D::MATERIAL*, float>& a, [&]( std::pair<const MODEL_3D::MATERIAL*, float>& a,
std::pair<const MODEL_3D::MATERIAL*, float>& b ) { std::pair<const MODEL_3D::MATERIAL*, float>& b )
// If A is inside B, then A is rendered first {
if( b.first->m_bbox.Inside( a.first->m_bbox ) ) bool aInsideB = a.first->m_bbox.Inside( b.first->m_bbox );
{ bool bInsideA = b.first->m_bbox.Inside( a.first->m_bbox );
return true;
}
else
{
if( a.first->m_bbox.Inside( b.first->m_bbox ) )
{
return false;
}
}
return a.second > b.second; // If A is inside B, then A is rendered first
} ); if( aInsideB != bInsideA )
return bInsideA;
if( a.second != b.second )
return a.second > b.second;
return a.first > b.first; // compare pointers as a last resort
} );
for( const std::pair<const MODEL_3D::MATERIAL*, float>& mat : materialsSorted ) for( const std::pair<const MODEL_3D::MATERIAL*, float>& mat : materialsSorted )
{ {