Make sure pads are unlocked when editing footprint from board.

Fixes https://gitlab.com/kicad/code/kicad/issues/7274

include/eda_item.h

@@ -118,6 +118,7 @@ typedef const INSPECTOR_FUNC& INSPECTOR;
 #define DO_NOT_DRAW    (1 << 16)   ///< Used to disable draw function
 #define IS_PASTED      (1 << 17)   ///< Modifier on IS_NEW which indicates it came from clipboard
 #define LOCKED         (1 << 18)   ///< Pcbnew: locked from movement and deletion
+                                   ///< NB: stored in m_status flags, NOT m_flags.
 #define UNUSED         (1 << 19)
 #define MALFORMED_F_COURTYARD (1 << 20)
 #define MALFORMED_B_COURTYARD (1 << 21)

pcbnew/load_select_footprint.cpp

@@ -113,6 +113,9 @@ bool FOOTPRINT_EDIT_FRAME::LoadFootprintFromBoard( FOOTPRINT* aFootprint )
     newFootprint->ClearFlags();
     newFootprint->RunOnChildren( []( BOARD_ITEM* aItem )
                                  {
+                                     if( aItem->Type() == PCB_PAD_T )
+                                        aItem->SetLocked( false );
+
                                      aItem->ClearFlags();
                                  } );
 

pcbnew/pcb_base_frame.cpp

@@ -160,7 +160,7 @@ void PCB_BASE_FRAME::AddFootprintToBoard( FOOTPRINT* aFootprint )
     {
         GetBoard()->Add( aFootprint, ADD_MODE::APPEND );
 
-        aFootprint->SetFlags(IS_NEW );
+        aFootprint->SetFlags( IS_NEW );
         aFootprint->SetPosition( wxPoint( 0, 0 ) ); // cursor in GAL may not be initialized yet
 
         // Put it on FRONT layer (note that it might be stored flipped if the lib is an archive