haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Apply OSX select-all-when-tabbing fix to other platforms. 

Fixes: lp:1822890
* https://bugs.launchpad.net/kicad/+bug/1822890
This commit is contained in:
Jeff Young 2019-04-03 19:53:13 +01:00
parent a6a6785316
commit 0fb956cdbe
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
common/dialog_shim.cpp
View File

@ -241,7 +241,6 @@ bool DIALOG_SHIM::Enable( bool enable )
} }
#ifdef __WXMAC__
// Recursive descent doing a SelectAll() in wxTextCtrls. // Recursive descent doing a SelectAll() in wxTextCtrls.
// MacOS User Interface Guidelines state that when tabbing to a text control all its // MacOS User Interface Guidelines state that when tabbing to a text control all its
// text should be selected. Since wxWidgets fails to implement this, we do it here. // text should be selected. Since wxWidgets fails to implement this, we do it here.
@ -262,7 +261,6 @@ static void selectAllInTextCtrls( wxWindowList& children )
selectAllInTextCtrls( child->GetChildren() ); selectAllInTextCtrls( child->GetChildren() );
} }
} }
#endif
#ifdef __WXMAC__ #ifdef __WXMAC__
@ -296,9 +294,10 @@ void DIALOG_SHIM::OnPaint( wxPaintEvent &event )
{ {
#ifdef __WXMAC__ #ifdef __WXMAC__
fixOSXCancelButtonIssue( this ); fixOSXCancelButtonIssue( this );
selectAllInTextCtrls( GetChildren() );
#endif #endif
selectAllInTextCtrls( GetChildren() );
if( m_initialFocusTarget ) if( m_initialFocusTarget )
m_initialFocusTarget->SetFocus(); m_initialFocusTarget->SetFocus();
else else