haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libeval_compiler: thou shalt not return pointers to std::vector members! (fixes an use-after-free crash in complex rule evaluation invoked by the router) 

Fixes: https://gitlab.com/kicad/code/kicad/-/issues/9451
This commit is contained in:
Tomasz Wlostowski 2021-10-29 16:47:29 +02:00
parent e1846c33d9
commit 1051f11683
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
include/libeval_compiler/libeval_compiler.h
View File

@ -293,12 +293,16 @@ public:
virtual ~CONTEXT()
{
for( auto &v : m_ownedValues )
{
delete v;
}
}
VALUE* AllocValue()
{
m_ownedValues.emplace_back();
return &m_ownedValues.back();
m_ownedValues.emplace_back( new VALUE );
return m_ownedValues.back();
}
void Push( VALUE* v )
@ -332,7 +336,7 @@ public:
void ReportError( const wxString& aErrorMsg );
private:
std::vector<VALUE> m_ownedValues;
std::vector<VALUE*> m_ownedValues;
VALUE* m_stack[100]; // std::stack not performant enough
int m_stackPtr;