haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Pcbnew: fix not wanted changes in .kicad_pcb files when the board has no changes. 

Some items (tracks and footprint graphic items) when reading were added in reverse order
of the initial file, creating useless differences and breaking source comparisons.
This commit is contained in:
jean-pierre charras 2020-05-04 14:01:35 +02:00
parent c155d80213
commit 12d1d3a844
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
eeschema/dialogs/dialog_edit_component_in_schematic.cpp
View File

@ -81,9 +81,10 @@ DIALOG_EDIT_COMPONENT_IN_SCHEMATIC::DIALOG_EDIT_COMPONENT_IN_SCHEMATIC( SCH_EDIT
auto cfg = dynamic_cast<EESCHEMA_SETTINGS*>( Kiface().KifaceSettings() ); auto cfg = dynamic_cast<EESCHEMA_SETTINGS*>( Kiface().KifaceSettings() );
if( cfg ) if( cfg )
{
m_shownColumns = cfg->m_Appearance.edit_component_visible_columns; m_shownColumns = cfg->m_Appearance.edit_component_visible_columns;
m_grid->ShowHideColumns( m_shownColumns );
m_grid->ShowHideColumns( m_shownColumns ); }
wxToolTip::Enable( true ); wxToolTip::Enable( true );
m_stdDialogButtonSizerOK->SetDefault(); m_stdDialogButtonSizerOK->SetDefault();

12
pcbnew/pcb_parser.cpp
View File

@ -597,15 +597,15 @@ BOARD* PCB_PARSER::parseBOARD_unchecked()
break; break;
case T_segment: case T_segment:
m_board->Add( parseTRACK(), ADD_MODE::INSERT ); m_board->Add( parseTRACK(), ADD_MODE::APPEND );
break; break;
case T_arc: case T_arc:
m_board->Add( parseARC(), ADD_MODE::INSERT ); m_board->Add( parseARC(), ADD_MODE::APPEND );
break; break;
case T_via: case T_via:
m_board->Add( parseVIA(), ADD_MODE::INSERT ); m_board->Add( parseVIA(), ADD_MODE::APPEND );
break; break;
case T_zone: case T_zone:
@ -2540,7 +2540,7 @@ MODULE* PCB_PARSER::parseMODULE_unchecked( wxArrayString* aInitialComments )
break; break;
default: default:
module->Add( text ); module->Add( text, ADD_MODE::APPEND );
} }
} }
break; break;
@ -2554,7 +2554,7 @@ MODULE* PCB_PARSER::parseMODULE_unchecked( wxArrayString* aInitialComments )
{ {
em->SetParent( module.get() ); em->SetParent( module.get() );
em->SetDrawCoord(); em->SetDrawCoord();
module->Add( em ); module->Add( em, ADD_MODE::APPEND );
} }
else else
delete em; delete em;
@ -2570,7 +2570,7 @@ MODULE* PCB_PARSER::parseMODULE_unchecked( wxArrayString* aInitialComments )
EDGE_MODULE* em = parseEDGE_MODULE(); EDGE_MODULE* em = parseEDGE_MODULE();
em->SetParent( module.get() ); em->SetParent( module.get() );
em->SetDrawCoord(); em->SetDrawCoord();
module->Add( em ); module->Add( em, ADD_MODE::APPEND );
} }
break; break;