haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

symbol editor: allows rotation of fields in derived symbols. 

Fields in derived symbols are editable, so the context menu must allow rotations.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/18003
This commit is contained in:
jean-pierre charras 2024-05-27 17:02:00 +02:00
parent 3cc653b6ff
commit 1322e0bc73
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
eeschema/symbol_editor/symbol_edit_frame.cpp
View File

@ -431,6 +431,15 @@ void SYMBOL_EDIT_FRAME::setupUIConditions()
return IsSymbolEditable() && !IsSymbolAlias(); return IsSymbolEditable() && !IsSymbolAlias();
}; };
auto isEditableInAliasCond =
[this]( const SELECTION& )
{
// Less restrictive than isEditableCond
// Symbols fields (root symbols and aliases) from the new s-expression libraries
// or in the schematic are editable.
return IsSymbolEditable();
};
auto symbolModifiedCondition = auto symbolModifiedCondition =
[this]( const SELECTION& sel ) [this]( const SELECTION& sel )
{ {
@ -482,8 +491,10 @@ void SYMBOL_EDIT_FRAME::setupUIConditions()
mgr->SetConditions( ACTIONS::selectAll, ENABLE( haveSymbolCond ) ); mgr->SetConditions( ACTIONS::selectAll, ENABLE( haveSymbolCond ) );
mgr->SetConditions( ACTIONS::unselectAll, ENABLE( haveSymbolCond ) ); mgr->SetConditions( ACTIONS::unselectAll, ENABLE( haveSymbolCond ) );
mgr->SetConditions( EE_ACTIONS::rotateCW, ENABLE( isEditableCond ) ); // These actions in symbol editor when editing alias field rotations are allowed.
mgr->SetConditions( EE_ACTIONS::rotateCCW, ENABLE( isEditableCond ) ); mgr->SetConditions( EE_ACTIONS::rotateCW, ENABLE( isEditableInAliasCond ) );
mgr->SetConditions( EE_ACTIONS::rotateCCW, ENABLE( isEditableInAliasCond ) );
mgr->SetConditions( EE_ACTIONS::mirrorH, ENABLE( isEditableCond ) ); mgr->SetConditions( EE_ACTIONS::mirrorH, ENABLE( isEditableCond ) );
mgr->SetConditions( EE_ACTIONS::mirrorV, ENABLE( isEditableCond ) ); mgr->SetConditions( EE_ACTIONS::mirrorV, ENABLE( isEditableCond ) );