haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

More explicit error message for unnumbered pins.

This commit is contained in:
Jeff Young 2022-11-02 12:32:46 +00:00
parent cc825ebafe
commit 13b097396b
1 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pcbnew/netlist_reader/board_netlist_updater.cpp
View File

@ -842,9 +842,18 @@ bool BOARD_NETLIST_UPDATER::testConnectivity( NETLIST& aNetlist,
{ {
padNumber = component->GetNet( jj ).GetPinName(); padNumber = component->GetNet( jj ).GetPinName();
if( footprint->FindPadByNumber( padNumber ) ) if( padNumber.IsEmpty() )
continue; // OK, pad found {
// bad symbol, report error
msg.Printf( _( "Symbol %s has pins with no number. These pins can not be matched "
"to pads in %s." ),
component->GetReference(),
footprint->GetFPID().Format().wx_str() );
m_reporter->Report( msg, RPT_SEVERITY_ERROR );
++m_errorCount;
}
else if( !footprint->FindPadByNumber( padNumber ) )
{
// not found: bad footprint, report error // not found: bad footprint, report error
msg.Printf( _( "%s pad %s not found in %s." ), msg.Printf( _( "%s pad %s not found in %s." ),
component->GetReference(), component->GetReference(),
@ -854,6 +863,7 @@ bool BOARD_NETLIST_UPDATER::testConnectivity( NETLIST& aNetlist,
++m_errorCount; ++m_errorCount;
} }
} }
}
return true; return true;
} }