haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PNS: Work around collision checking issues in shove mode 

Need to special-case shove mode since 942ee13c introduced
collision checking in all modes.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/14836
This commit is contained in:
Jon Evans 2023-05-29 18:19:29 -04:00
parent bb90aa24b7
commit 141cc85ff3
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
pcbnew/router/pns_line_placer.cpp
View File

@ -1534,9 +1534,21 @@ bool LINE_PLACER::FixRoute( const VECTOR2I& aP, ITEM* aEndItem, bool aForceFinis
// Collisions still prevent fixing unless "Allow DRC violations" is checked
// Note that collisions can occur even in walk/shove modes if the beginning of the trace
// collides (for example if the starting track width is too high)
if( !Settings().AllowDRCViolations() && m_world->CheckColliding( &pl ) )
return false;
// collides (for example if the starting track width is too high).
if( !Settings().AllowDRCViolations() )
{
NODE* checkNode = ( Settings().Mode() == RM_Shove ) ? m_shove->CurrentNode() : m_world;
std::optional<OBSTACLE> obs = checkNode->CheckColliding( &pl );
if( obs )
{
// TODO: Determine why the shove node sometimes reports collisions against shoved objects.
// For now, to work around this issue, we consider only solids in shove mode.
if( Settings().Mode() != RM_Shove || obs->m_item->OfKind( ITEM::SOLID_T ) )
return false;
}
}
const SHAPE_LINE_CHAIN& l = pl.CLine();