haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

More explicit pad-missing message when net involved. 

Fixes https://gitlab.com/kicad/code/kicad/-/issues/16489
This commit is contained in:
Jeff Young 2024-01-01 10:45:18 +00:00
parent 58b7eda47a
commit 15a2d65a0c
1 changed files with 18 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
pcbnew/drc/drc_test_provider_schematic_parity.cpp
View File

@ -114,8 +114,8 @@ void DRC_TEST_PROVIDER_SCHEMATIC_PARITY::testNetlist( NETLIST& aNetlist )
wxString msg; wxString msg;
msg.Printf( _( "Missing footprint %s (%s)" ), msg.Printf( _( "Missing footprint %s (%s)" ),
component->GetReference(), component->GetReference(),
component->GetValue() ); component->GetValue() );
std::shared_ptr<DRC_ITEM> drcItem = DRC_ITEM::Create( DRCE_MISSING_FOOTPRINT ); std::shared_ptr<DRC_ITEM> drcItem = DRC_ITEM::Create( DRCE_MISSING_FOOTPRINT );
@ -149,7 +149,7 @@ void DRC_TEST_PROVIDER_SCHEMATIC_PARITY::testNetlist( NETLIST& aNetlist )
{ {
wxString msg; wxString msg;
msg.Printf( _( "Pad missing net given by schematic (%s)." ), msg.Printf( _( "Pad missing net given by schematic (%s)." ),
sch_net.GetNetName() ); sch_net.GetNetName() );
std::shared_ptr<DRC_ITEM> drcItem = DRC_ITEM::Create( DRCE_NET_CONFLICT ); std::shared_ptr<DRC_ITEM> drcItem = DRC_ITEM::Create( DRCE_NET_CONFLICT );
drcItem->SetErrorMessage( msg ); drcItem->SetErrorMessage( msg );
@ -160,8 +160,8 @@ void DRC_TEST_PROVIDER_SCHEMATIC_PARITY::testNetlist( NETLIST& aNetlist )
{ {
wxString msg; wxString msg;
msg.Printf( _( "Pad net (%s) doesn't match net given by schematic (%s)." ), msg.Printf( _( "Pad net (%s) doesn't match net given by schematic (%s)." ),
pcb_netname, pcb_netname,
sch_net.GetNetName() ); sch_net.GetNetName() );
std::shared_ptr<DRC_ITEM> drcItem = DRC_ITEM::Create( DRCE_NET_CONFLICT ); std::shared_ptr<DRC_ITEM> drcItem = DRC_ITEM::Create( DRCE_NET_CONFLICT );
drcItem->SetErrorMessage( msg ); drcItem->SetErrorMessage( msg );
@ -180,8 +180,19 @@ void DRC_TEST_PROVIDER_SCHEMATIC_PARITY::testNetlist( NETLIST& aNetlist )
if( !footprint->FindPadByNumber( sch_net.GetPinName() ) ) if( !footprint->FindPadByNumber( sch_net.GetPinName() ) )
{ {
wxString msg; wxString msg;
msg.Printf( _( "No pad found for pin %s in schematic." ),
sch_net.GetPinName() ); if( sch_net.GetNetName().StartsWith( wxT( "unconnected-" ) ) )
{
msg = sch_net.GetPinName();
}
else
{
msg = wxString::Format( wxT( "%s (%s)" ),
sch_net.GetPinName(),
sch_net.GetNetName() );
}
msg.Printf( _( "No pad found for pin %s in schematic." ), msg );
std::shared_ptr<DRC_ITEM> drcItem = DRC_ITEM::Create( DRCE_NET_CONFLICT ); std::shared_ptr<DRC_ITEM> drcItem = DRC_ITEM::Create( DRCE_NET_CONFLICT );
drcItem->SetErrorMessage( msg ); drcItem->SetErrorMessage( msg );