haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Coverity fixes.

This commit is contained in:
Jeff Young 2022-04-09 20:12:07 +01:00
parent 8fc652270e
commit 18fb2ddff6
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pcbnew/dialogs/dialog_drc.cpp
View File

@ -442,19 +442,22 @@ void DIALOG_DRC::OnDRCItemSelected( wxDataViewEvent& aEvent )
} }
else if( rc_item->GetErrorCode() == DRCE_DIFF_PAIR_UNCOUPLED_LENGTH_TOO_LONG ) else if( rc_item->GetErrorCode() == DRCE_DIFF_PAIR_UNCOUPLED_LENGTH_TOO_LONG )
{ {
PCB_TRACK* track = dynamic_cast<PCB_TRACK*>( item ); BOARD_CONNECTED_ITEM* connectedItem = dynamic_cast<PCB_TRACK*>( item );
int net = track->GetNetCode(); int net = connectedItem ? connectedItem->GetNetCode() : -1;
std::vector<BOARD_ITEM*> segs; std::vector<BOARD_ITEM*> items;
wxASSERT( net > 0 ); // Without a net how can it be a diff-pair?
for( const KIID& id : rc_item->GetIDs() ) for( const KIID& id : rc_item->GetIDs() )
{ {
PCB_TRACK* candidate = dynamic_cast<PCB_TRACK*>( board->GetItem( id ) ); auto* candidate = dynamic_cast<BOARD_CONNECTED_ITEM*>( board->GetItem( id ) );
wxASSERT( candidate );
if( candidate && candidate->GetNetCode() == net ) if( candidate && candidate->GetNetCode() == net )
segs.push_back( candidate ); items.push_back( candidate );
} }
m_frame->FocusOnItems( segs, principalLayer ); m_frame->FocusOnItems( items, principalLayer );
} }
else if( m_centerMarkerOnIdle ) else if( m_centerMarkerOnIdle )
{ {