haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Safely load python plugins 

Catch potential exceptions when doing the initial python plugin load

Fixes https://gitlab.com/kicad/code/kicad/issues/12231
This commit is contained in:
Seth Hillbrand 2023-01-17 12:55:39 -08:00
parent 60ba245474
commit 1d223d1439
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pcbnew/python/scripting/pcb_scripting_tool.cpp
View File

@ -80,8 +80,13 @@ void SCRIPTING_TOOL::ReloadPlugins()
// Remove all action plugins so that we don't keep references to old versions // Remove all action plugins so that we don't keep references to old versions
ACTION_PLUGINS::UnloadAll(); ACTION_PLUGINS::UnloadAll();
try
{
PyLOCK lock; PyLOCK lock;
callLoadPlugins(); callLoadPlugins();
}
catch( ... )
{}
} }
@ -91,10 +96,15 @@ int SCRIPTING_TOOL::reloadPlugins( const TOOL_EVENT& aEvent )
// Remove all action plugins so that we don't keep references to old versions // Remove all action plugins so that we don't keep references to old versions
ACTION_PLUGINS::UnloadAll(); ACTION_PLUGINS::UnloadAll();
try
{ {
PyLOCK lock; PyLOCK lock;
callLoadPlugins(); callLoadPlugins();
} }
catch( ... )
{
return -1;
}
if( !m_isFootprintEditor ) if( !m_isFootprintEditor )
{ {