haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Eagle plugin footprint QA test issue. 

Apparently mapping Eagle footprint layers to the KiCad Dwg_User
that were previously mapped to UNDEFINED_LAYER breaks the QA test
and causes the footprint editor to crash when opening Eagle
footprints.  This means that the potential data loss issue when
loading Eagle footprints is still in play.

(cherry picked from commit c72457482c)
This commit is contained in:
Wayne Stambaugh 2022-08-22 09:11:14 -04:00
parent c2c4609272
commit 1e09f0e8b0
2 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pcbnew/plugins/eagle/eagle_plugin.cpp
View File

@ -3017,17 +3017,9 @@ std::tuple<PCB_LAYER_ID, LSET, bool> EAGLE_PLUGIN::defaultKicadLayer( int aEagle
case EAGLE_LAYER::HOLES: case EAGLE_LAYER::HOLES:
default: default:
if( aIsLibraryCache ) if( aIsLibraryCache )
{ kiLayer = UNDEFINED_LAYER;
if( aEagleLayer != EAGLE_LAYER::MILLING && aEagleLayer != EAGLE_LAYER::TTEST &&
aEagleLayer != EAGLE_LAYER::BTEST && aEagleLayer != EAGLE_LAYER::HOLES )
kiLayer = Dwgs_User;
else
kiLayer = UNDEFINED_LAYER;
}
else else
{
kiLayer = UNSELECTED_LAYER; kiLayer = UNSELECTED_LAYER;
}
break; break;
} }

5
pcbnew/plugins/eagle/eagle_plugin.h
View File

@ -213,8 +213,9 @@ private:
* *
* @note The Eagle MILLING, TTEST, BTEST, and HOLES layers are set to #UNDEFINED_LAYER * @note The Eagle MILLING, TTEST, BTEST, and HOLES layers are set to #UNDEFINED_LAYER
* for historical purposes. All other Eagle layers that do not directly map to * for historical purposes. All other Eagle layers that do not directly map to
* KiCad layers will be set to the #Dwg_User layer when loading Eagle footprint * KiCad layers will be set to #UNDEFINED_LAYER when loading Eagle footprint
* libraries to prevent data loss. * libraries. This should be addressed in the future because in some cases this
* will cause data loss.
* *
* @see #EAGLE_LAYER and defaultKiCadLayer(). * @see #EAGLE_LAYER and defaultKiCadLayer().
* *