haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix access into empty container. 

Fixes https://gitlab.com/kicad/code/kicad/issues/6840

(cherry picked from commit 359c29639f)
This commit is contained in:
Jeff Young 2020-12-24 19:42:41 +00:00 committed by Seth Hillbrand
parent 07568f87c3
commit 1f6ff4a519
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
common/lib_tree_model_adapter.cpp
View File

@ -145,12 +145,11 @@ void LIB_TREE_MODEL_ADAPTER::UpdateSearchString( wxString const& aSearch )
// is called, GetParent() will return nullptr. While this works for some calls, it // is called, GetParent() will return nullptr. While this works for some calls, it
// segfaults when we have our first library expanded. // segfaults when we have our first library expanded.
// The tree will be expanded again below when we get our matches // The tree will be expanded again below when we get our matches
if( !aSearch.IsNull() ) if( !aSearch.IsNull() && m_tree.Children.size() )
m_widget->Collapse( wxDataViewItem( &*m_tree.Children[0] ) ); m_widget->Collapse( wxDataViewItem( &*m_tree.Children[0] ) );
// Even with the updateLock, wxWidgets sometimes ties its knickers in // Even with the updateLock, wxWidgets sometimes ties its knickers in a knot trying to
// a knot when trying to run a wxdataview_selection_changed_callback() // run a wxdataview_selection_changed_callback() on a row that has been deleted.
// on a row that has been deleted.
// https://bugs.launchpad.net/kicad/+bug/1756255 // https://bugs.launchpad.net/kicad/+bug/1756255
m_widget->UnselectAll(); m_widget->UnselectAll();