haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Coverity fixup.

This commit is contained in:
Jeff Young 2022-02-01 10:36:54 +00:00
parent 56d204c4c9
commit 1f8c29c395
1 changed files with 5 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
pcbnew/drc/drc_test_provider_text_dims.cpp
View File

@ -106,17 +106,8 @@ bool DRC_TEST_PROVIDER_TEXT_DIMS::Run()
if( !reportProgress( ii++, count, delta ) ) if( !reportProgress( ii++, count, delta ) )
return false; return false;
wxASSERT( item->Type() == PCB_TEXT_T
|| item->Type() == PCB_TEXTBOX_T
|| item->Type() == PCB_FP_TEXT_T
|| item->Type() == PCB_FP_TEXTBOX_T );
DRC_CONSTRAINT constraint; DRC_CONSTRAINT constraint;
int actualH = 0; EDA_TEXT* text = nullptr;
int actualT = 0;
bool visible = false;
EDA_TEXT* text = nullptr;
switch( item->Type() ) switch( item->Type() )
{ {
@ -127,13 +118,12 @@ bool DRC_TEST_PROVIDER_TEXT_DIMS::Run()
default: UNIMPLEMENTED_FOR( item->GetClass() ); break; default: UNIMPLEMENTED_FOR( item->GetClass() ); break;
} }
visible = text->IsVisible(); if( !text || !text->IsVisible() )
actualH = text->GetTextHeight();
actualT = text->GetTextThickness();
if( !visible )
return true; return true;
int actualH = text->GetTextHeight();
int actualT = text->GetTextThickness();
if( !m_drcEngine->IsErrorLimitExceeded( DRCE_TEXT_HEIGHT ) ) if( !m_drcEngine->IsErrorLimitExceeded( DRCE_TEXT_HEIGHT ) )
{ {
constraint = m_drcEngine->EvalRules( TEXT_HEIGHT_CONSTRAINT, item, nullptr, constraint = m_drcEngine->EvalRules( TEXT_HEIGHT_CONSTRAINT, item, nullptr,