haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Minor performance enhancements.

This commit is contained in:
Jeff Young 2019-06-04 13:49:11 +01:00
parent 1ea001d497
commit 1fe848f37c
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
eeschema/dialogs/dialog_migrate_buses.cpp
View File

@ -21,6 +21,7 @@
#include <sch_connection.h> #include <sch_connection.h>
#include <connection_graph.h> #include <connection_graph.h>
#include <tool/tool_manager.h> #include <tool/tool_manager.h>
#include <tool/actions.h>
#include <dialog_migrate_buses.h> #include <dialog_migrate_buses.h>
/** /**
@ -122,13 +123,13 @@ void DIALOG_MIGRATE_BUSES::updateUi()
} }
std::vector<wxString> DIALOG_MIGRATE_BUSES::getProposedLabels( std::vector<wxString> aLabelList ) std::vector<wxString> DIALOG_MIGRATE_BUSES::getProposedLabels( const std::vector<wxString>& aLabelList )
{ {
int lowest_start = INT_MAX; int lowest_start = INT_MAX;
int highest_end = -1; int highest_end = -1;
int widest_bus = -1; int widest_bus = -1;
for( auto label : aLabelList ) for( const wxString& label : aLabelList )
{ {
SCH_CONNECTION conn; SCH_CONNECTION conn;
conn.ConfigureFromLabel( label ); conn.ConfigureFromLabel( label );
@ -149,7 +150,7 @@ std::vector<wxString> DIALOG_MIGRATE_BUSES::getProposedLabels( std::vector<wxStr
SCH_CONNECTION conn; SCH_CONNECTION conn;
std::vector<wxString> proposals; std::vector<wxString> proposals;
for( auto label : aLabelList ) for( const wxString& label : aLabelList )
{ {
conn.ConfigureFromLabel( label ); conn.ConfigureFromLabel( label );
wxString proposal = conn.VectorPrefix(); wxString proposal = conn.VectorPrefix();

2
eeschema/dialogs/dialog_migrate_buses.h
View File

@ -59,7 +59,7 @@ private:
void updateUi(); void updateUi();
std::vector<wxString> getProposedLabels( std::vector<wxString> aLabelList ); std::vector<wxString> getProposedLabels( const std::vector<wxString>& aLabelList );
void onItemSelected( wxListEvent& aEvent ); void onItemSelected( wxListEvent& aEvent );