haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pcbnew: MODULEs are not BOARD_CONNECTED_ITEMS 

Handling ratsnest requires first checking for modules, handling their
pads and then checking that the remaining elements derive from
BOARD_CONNECTED_ITEM

Fixes https://gitlab.com/kicad/code/kicad/issues/5131
This commit is contained in:
Seth Hillbrand 2020-08-10 10:59:23 -07:00
parent 23a5b0ca5f
commit 211cbadc24
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pcbnew/tools/pcb_inspection_tool.cpp
View File

@ -500,12 +500,7 @@ void PCB_INSPECTION_TOOL::calculateSelectionRatsnest()
for( EDA_ITEM* item : selection ) for( EDA_ITEM* item : selection )
{ {
BOARD_CONNECTED_ITEM* boardItem = dyn_cast<BOARD_CONNECTED_ITEM*>( item ); if( item->Type() == PCB_MODULE_T )
if( !boardItem )
continue;
if( boardItem->Type() == PCB_MODULE_T )
{ {
for( auto pad : static_cast<MODULE*>( item )->Pads() ) for( auto pad : static_cast<MODULE*>( item )->Pads() )
{ {
@ -513,9 +508,10 @@ void PCB_INSPECTION_TOOL::calculateSelectionRatsnest()
items.push_back( pad ); items.push_back( pad );
} }
} }
else if( boardItem->GetLocalRatsnestVisible() || displayOptions().m_ShowModuleRatsnest ) else if( BOARD_CONNECTED_ITEM* boardItem = dyn_cast<BOARD_CONNECTED_ITEM*>( item ) )
{ {
items.push_back( boardItem ); if( boardItem->GetLocalRatsnestVisible() || displayOptions().m_ShowModuleRatsnest )
items.push_back( boardItem );
} }
} }