Fail GAL on its header leaking audit

Maybe we should rethink directly accessing GAL so much, but at least 600 files didn't need GAL leaked into them due to view_overlay.h

common/board_printout.cpp

@@ -28,6 +28,7 @@
 
 #include <view/view.h>
 #include <gal/gal_print.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <gal/painter.h>
 #include <pcbplot.h>
 #include <settings/app_settings.h>

common/drawing_sheet/ds_proxy_view_item.cpp

@@ -29,6 +29,7 @@
 #include <drawing_sheet/ds_draw_item.h>
 #include <drawing_sheet/ds_data_item.h>
 #include <drawing_sheet/ds_painter.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <project.h>
 #include <view/view.h>
 

common/eda_draw_frame.cpp

@@ -32,6 +32,7 @@
 #include <dialogs/hotkey_cycle_popup.h>
 #include <eda_draw_frame.h>
 #include <file_history.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <id.h>
 #include <kiface_base.h>
 #include <lockfile.h>

common/font/outline_font.cpp

@@ -34,6 +34,7 @@
 #include <trigo.h>
 #include <font/fontconfig.h>
 #include <convert_basic_shapes_to_polygon.h>
+#include <core/utf8.h>
 
 using namespace KIFONT;
 

common/preview_items/draw_context.cpp

@@ -21,6 +21,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
+#include <gal/graphics_abstraction_layer.h>
 #include <preview_items/draw_context.h>
 #include <preview_items/preview_utils.h>
 #include <view/view.h>

common/preview_items/polygon_item.cpp

@@ -22,6 +22,7 @@
  */
 
 #include <preview_items/polygon_item.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <gal/painter.h>
 #include <view/view.h>
 

common/preview_items/two_point_assistant.cpp

@@ -21,6 +21,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
+#include <gal/graphics_abstraction_layer.h>
 #include <preview_items/two_point_assistant.h>
 #include <preview_items/draw_context.h>
 #include <preview_items/preview_utils.h>

common/tool/grid_helper.cpp

@@ -25,6 +25,7 @@
 #include <functional>
 using namespace std::placeholders;
 
+#include <gal/graphics_abstraction_layer.h>
 #include <math/util.h>      // for KiROUND
 #include <math/vector2d.h>
 #include <tool/tool_manager.h>
@@ -158,3 +159,7 @@ VECTOR2I GRID_HELPER::Align( const VECTOR2I& aPoint, const VECTOR2D& aGrid,
 }
 
 
+bool GRID_HELPER::canUseGrid() const
+{
+    return m_enableGrid && m_toolMgr->GetView()->GetGAL()->GetGridSnapping();
+}

eeschema/dialogs/panel_eeschema_color_settings.cpp

@@ -22,6 +22,7 @@
 
 #include <eeschema_settings.h>
 #include <gal/gal_display_options.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <layer_ids.h>
 #include <lib_shape.h>
 #include <math/vector2wx.h>

eeschema/erc.cpp

@@ -31,6 +31,7 @@
 #include <common.h>     // for ExpandEnvVarSubstitutions
 #include <erc.h>
 #include <erc_sch_pin_context.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <string_utils.h>
 #include <lib_pin.h>
 #include <sch_edit_frame.h>

eeschema/lib_field.cpp

@@ -28,6 +28,7 @@
 #include <sch_draw_panel.h>
 #include <eda_draw_frame.h>
 #include <plotters/plotter.h>
+#include <font/font.h>
 #include <trigo.h>
 #include <base_units.h>
 #include <widgets/msgpanel.h>

eeschema/lib_item.cpp

@@ -24,6 +24,7 @@
  */
 
 #include <pgm_base.h>
+#include <font/font.h>
 #include <settings/settings_manager.h>
 #include <eeschema_settings.h>
 #include <sch_draw_panel.h>

eeschema/lib_text.cpp

@@ -22,6 +22,7 @@
  */
 
 #include <common.h>
+#include <font/font.h>
 #include <sch_draw_panel.h>
 #include <plotters/plotter.h>
 #include <trigo.h>

eeschema/navlib/nl_schematic_plugin_impl.cpp

@@ -21,6 +21,7 @@
 #include "nl_schematic_plugin_impl.h"
 
 // KiCAD includes
+#include <gal/graphics_abstraction_layer.h>
 #include <sch_base_frame.h>
 #include <bitmaps.h>
 #include <class_draw_panel_gal.h>

eeschema/sch_base_frame.cpp

@@ -29,6 +29,7 @@
 #include <pgm_base.h>
 #include <eda_list_dialog.h>
 #include <eeschema_settings.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <project/project_file.h>
 #include <symbol_editor/symbol_editor_settings.h>
 #include <sch_draw_panel.h>

eeschema/sch_edit_frame.cpp

@@ -33,6 +33,7 @@
 #include <dialogs/dialog_symbol_fields_table.h>
 #include <eeschema_id.h>
 #include <executable_names.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <gestfich.h>
 #include <dialogs/html_message_box.h>
 #include <core/ignore.h>

eeschema/sch_screen.cpp

@@ -24,6 +24,7 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
  */
 
+#include <stack>
 #include <wx/filefn.h>
 
 #include <eda_item.h>

eeschema/symbol_editor/symbol_edit_frame.cpp

@@ -32,6 +32,7 @@
 #include <eeschema_id.h>
 #include <eeschema_settings.h>
 #include <env_paths.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <kiface_base.h>
 #include <kiplatform/app.h>
 #include <kiway_express.h>

eeschema/symbol_viewer_frame.cpp

@@ -30,6 +30,7 @@
 #include <dialogs/html_message_box.h>
 #include <eeschema_id.h>
 #include <eeschema_settings.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <kiface_base.h>
 #include <kiway.h>
 #include <kiway_express.h>

eeschema/tools/ee_grid_helper.cpp

@@ -25,6 +25,7 @@
 
 #include <functional>
 #include <macros.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <sch_item.h>
 #include <sch_line.h>
 #include <sch_painter.h>

eeschema/tools/ee_inspection_tool.cpp

@@ -27,6 +27,7 @@
 #include <kiway.h>
 #include <confirm.h>
 #include <string_utils.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <tool/conditional_menu.h>
 #include <tool/selection_conditions.h>
 #include <tools/ee_actions.h>

eeschema/tools/ee_point_editor.cpp

@@ -30,6 +30,7 @@ using namespace std::placeholders;
 #include <tool/tool_manager.h>
 #include <sch_commit.h>
 #include <view/view_controls.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <geometry/seg.h>
 #include <tools/ee_actions.h>
 #include <tools/ee_selection_tool.h>

eeschema/tools/ee_selection_tool.cpp

@@ -24,6 +24,7 @@
 
 #include <core/typeinfo.h>
 #include <core/kicad_algo.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <geometry/shape_compound.h>
 #include <ee_actions.h>
 #include <ee_collectors.h>

eeschema/tools/sch_drawing_tools.cpp

@@ -29,6 +29,7 @@
 #include <tools/sch_line_wire_bus_tool.h>
 #include <tools/ee_selection_tool.h>
 #include <tools/ee_grid_helper.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <ee_actions.h>
 #include <sch_edit_frame.h>
 #include <pgm_base.h>

eeschema/tools/sch_line_wire_bus_tool.cpp

@@ -38,6 +38,7 @@
 #include <layer_ids.h>
 #include <math/vector2d.h>
 #include <advanced_config.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <tool/actions.h>
 #include <tool/conditional_menu.h>
 #include <tool/selection.h>

eeschema/tools/sch_move_tool.cpp

@@ -25,6 +25,7 @@
 #include <cmath>
 #include <wx/log.h>
 #include <trigo.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <tool/tool_manager.h>
 #include <tools/ee_grid_helper.h>
 #include <tools/ee_selection_tool.h>

eeschema/tools/symbol_editor_drawing_tools.cpp

@@ -26,6 +26,7 @@
 #include <optional>
 #include <symbol_edit_frame.h>
 #include <sch_commit.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <tools/symbol_editor_drawing_tools.h>
 #include <tools/symbol_editor_pin_tool.h>
 #include <tools/ee_grid_helper.h>

eeschema/tools/symbol_editor_move_tool.cpp

@@ -27,6 +27,7 @@
 #include <ee_actions.h>
 #include <ee_grid_helper.h>
 #include <eda_item.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <lib_shape.h>
 #include <sch_commit.h>
 #include <wx/log.h>

eeschema/widgets/symbol_preview_widget.cpp

@@ -20,6 +20,7 @@
 #include "symbol_preview_widget.h"
 #include <sch_view.h>
 #include <gal/gal_display_options.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <math/vector2wx.h>
 #include <symbol_lib_table.h>
 #include <sch_preview_panel.h>

gerbview/gerbview_frame.cpp

@@ -23,6 +23,7 @@
 #include <pgm_base.h>
 #include <bitmaps.h>
 #include <wildcards_and_files_ext.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <gerbview_frame.h>
 #include <gerbview_id.h>
 #include <gerber_file_image.h>

gerbview/gerbview_printout.cpp

@@ -24,6 +24,7 @@
 
 #include <base_units.h>
 #include <base_screen.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <gerbview_frame.h>
 #include <gerber_file_image.h>
 #include <gerber_file_image_list.h>

include/font/outline_font.h

@@ -27,7 +27,6 @@
 #ifndef OUTLINE_FONT_H_
 #define OUTLINE_FONT_H_
 
-#include <gal/graphics_abstraction_layer.h>
 #include <geometry/shape_poly_set.h>
 #ifdef _MSC_VER
 #include <ft2build.h>

include/tool/grid_helper.h

@@ -161,10 +161,7 @@ protected:
      * Check whether it is possible to use the grid -- this depends both on local grid helper
      * settings and global (tool manager) KiCad settings.
      */
-    bool canUseGrid() const
-    {
-        return m_enableGrid && m_toolMgr->GetView()->GetGAL()->GetGridSnapping();
-    }
+    bool canUseGrid() const;
 
     VECTOR2I computeNearest( const VECTOR2I& aPoint, const VECTOR2I& aGrid,
                              const VECTOR2I& aOffset ) const;

include/view/view_overlay.h

@@ -28,7 +28,6 @@
 #define __VIEW_OVERLAY_H
 
 #include <view/view_item.h>
-#include <gal/graphics_abstraction_layer.h>
 
 #include <vector>
 #include <deque>

pagelayout_editor/pl_editor_frame.cpp

@@ -32,6 +32,7 @@
 #include <panel_hotkeys_editor.h>
 #include <confirm.h>
 #include <kiplatform/app.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <gal/painter.h>
 #include <wildcards_and_files_ext.h>
 #include <tool/selection.h>

pcbnew/board_item.cpp

@@ -33,6 +33,7 @@
 #include <board_design_settings.h>
 #include <pcb_group.h>
 #include <footprint.h>
+#include <font/font.h>
 
 
 BOARD_ITEM::~BOARD_ITEM()

pcbnew/dialogs/dialog_board_reannotate.cpp

@@ -30,6 +30,7 @@
 #include <confirm.h>
 #include <ctype.h>
 #include <dialog_board_reannotate.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <string_utils.h>  // StrNumCmp
 #include <kiface_base.h>
 #include <pcbnew_settings.h>

pcbnew/dialogs/dialog_pad_properties.cpp

@@ -33,6 +33,7 @@
 #include <confirm.h>
 #include <core/arraydim.h>
 #include <convert_basic_shapes_to_polygon.h> // for enum RECT_CHAMFER_POSITIONS definition
+#include <gal/graphics_abstraction_layer.h>
 #include <geometry/shape_segment.h>
 #include <dialog_pad_properties.h>
 #include <dialogs/html_message_box.h>

pcbnew/dialogs/panel_pcbnew_color_settings.cpp

@@ -23,6 +23,7 @@
 #include <pgm_base.h>
 #include <board.h>
 #include <layer_ids.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <panel_pcbnew_color_settings.h>
 #include <math/vector2wx.h>
 #include <widgets/wx_panel.h>

pcbnew/footprint_edit_frame.cpp

@@ -42,6 +42,7 @@
 #include <footprint_info_impl.h>
 #include <footprint_tree_pane.h>
 #include <fp_lib_table.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <kiface_base.h>
 #include <kiplatform/app.h>
 #include <kiway.h>

pcbnew/footprint_preview_panel.cpp

@@ -31,6 +31,7 @@
 #include <eda_draw_frame.h>
 #include <footprint_preview_panel.h>
 #include <fp_lib_table.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <kiway.h>
 #include <math/box2.h>
 #include <pcb_painter.h>

pcbnew/footprint_viewer_frame.cpp

@@ -39,6 +39,7 @@
 #include <widgets/msgpanel.h>
 #include <widgets/wx_listbox.h>
 #include <widgets/wx_aui_utils.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <pcb_draw_panel_gal.h>
 #include <pcb_painter.h>
 #include <pcbnew_id.h>

pcbnew/fp_tree_synchronizing_adapter.cpp

@@ -30,6 +30,7 @@
 #include <footprint_preview_panel.h>
 #include <fp_lib_table.h>
 #include <footprint_info_impl.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <string_utils.h>
 #include <board.h>
 #include <footprint.h>

pcbnew/navlib/nl_pcbnew_plugin_impl.cpp

@@ -24,6 +24,7 @@
 #include <board.h>
 #include <pcb_base_frame.h>
 #include <bitmaps.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <class_draw_panel_gal.h>
 #include <view/view.h>
 #include <view/wx_view_controls.h>

pcbnew/pcb_base_edit_frame.cpp

@@ -33,6 +33,7 @@
 #include <pgm_base.h>
 #include <board.h>
 #include <board_design_settings.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <pcb_dimension.h>
 #include <footprint.h>
 #include <footprint_info_impl.h>

pcbnew/pcb_dimension.cpp

@@ -28,6 +28,7 @@
 #include <pcb_edit_frame.h>
 #include <base_units.h>
 #include <convert_basic_shapes_to_polygon.h>
+#include <font/font.h>
 #include <pcb_dimension.h>
 #include <pcb_text.h>
 #include <geometry/shape_compound.h>

pcbnew/pcb_edit_frame.cpp

@@ -41,6 +41,7 @@
 #include <dialogs/dialog_net_inspector.h>
 #include <dialog_board_setup.h>
 #include <invoke_pcb_dialog.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <board.h>
 #include <pcb_group.h>
 #include <board_design_settings.h>

pcbnew/pcbnew_printout.cpp

@@ -28,6 +28,7 @@
 #include "pcbnew_printout.h"
 #include <board.h>
 #include <math/util.h>      // for KiROUND
+#include <gal/graphics_abstraction_layer.h>
 #include <pcb_painter.h>
 #include <pcbnew_settings.h>
 #include <view/view.h>

pcbnew/plugins/eagle/eagle_plugin.cpp

@@ -58,6 +58,7 @@ Load() TODO's
 #include <wx/log.h>
 #include <wx/wfstream.h>
 #include <wx/txtstrm.h>
+#include <wx/window.h>
 
 #include <convert_basic_shapes_to_polygon.h>
 #include <string_utils.h>

pcbnew/plugins/easyeda/pcb_easyeda_parser.cpp

@@ -33,6 +33,7 @@
 
 #include <wx/log.h>
 
+#include <font/font.h>
 #include <footprint.h>
 #include <progress_reporter.h>
 #include <board.h>

pcbnew/plugins/easyedapro/pcb_easyedapro_parser.cpp

@@ -46,6 +46,7 @@
 #include <pcb_track.h>
 #include <pcb_shape.h>
 #include <pcb_text.h>
+#include <font/font.h>
 #include <geometry/shape_arc.h>
 #include <geometry/shape_circle.h>
 #include <geometry/shape_simple.h>

pcbnew/python/scripting/pcbnew_action_plugins.cpp

@@ -30,6 +30,7 @@
 #include <board_commit.h>
 #include <board_design_settings.h>
 #include <footprint.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <pcb_track.h>
 #include <zone.h>
 #include <menus_helpers.h>

pcbnew/ratsnest/ratsnest_view_item.cpp

@@ -31,6 +31,7 @@
 #include <ratsnest/ratsnest_view_item.h>
 
 #include <kiface_base.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <pcbnew_settings.h>
 #include <pcb_painter.h>
 #include <ratsnest/ratsnest_data.h>

pcbnew/router/pns_kicad_iface.cpp

@@ -37,6 +37,7 @@
 #include <tool/tool_manager.h>
 #include <settings/app_settings.h>
 
+#include <gal/graphics_abstraction_layer.h>
 #include <pcb_painter.h>
 
 #include <geometry/shape.h>

pcbnew/router/pns_tool_base.cpp

@@ -23,6 +23,7 @@
 #include <functional>
 using namespace std::placeholders;
 
+#include <gal/graphics_abstraction_layer.h>
 #include <pcb_painter.h>
 #include <pcbnew_settings.h>
 

pcbnew/router/router_preview_item.cpp

@@ -22,6 +22,7 @@
 #include <deque>
 #include <gal/color4d.h>
 
+#include <gal/graphics_abstraction_layer.h>
 #include <geometry/shape_rect.h>
 #include <geometry/shape_simple.h>
 #include <pcb_painter.h>

pcbnew/router/router_tool.cpp

@@ -47,6 +47,7 @@ using namespace std::placeholders;
 #include <connectivity/connectivity_data.h>
 #include <connectivity/connectivity_algo.h>
 #include <confirm.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <bitmaps.h>
 #include <string_utils.h>
 #include <gal/painter.h>

pcbnew/tools/drawing_tool.cpp

@@ -32,6 +32,7 @@
 #include <footprint_editor_settings.h>
 #include <dialogs/dialog_text_properties.h>
 #include <dialogs/dialog_track_via_size.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <geometry/geometry_utils.h>
 #include <geometry/shape_segment.h>
 #include <import_gfx/dialog_import_gfx.h>

pcbnew/tools/drawing_tool.h

@@ -27,6 +27,7 @@
 #ifndef __DRAWING_TOOL_H
 #define __DRAWING_TOOL_H
 
+#include <stack>
 #include <optional>
 #include <tool/tool_menu.h>
 #include <tools/pcb_tool_base.h>

pcbnew/tools/edit_tool_move_fct.cpp

@@ -29,6 +29,7 @@
 #include <kiplatform/ui.h>
 #include <board.h>
 #include <board_commit.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <pad.h>
 #include <pcb_group.h>
 #include <pcb_edit_frame.h>

pcbnew/tools/pcb_control.cpp

@@ -40,6 +40,7 @@
 #include <board_item.h>
 #include <dialogs/dialog_paste_special.h>
 #include <pcb_dimension.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <footprint.h>
 #include <pcb_group.h>
 #include <pcb_textbox.h>

pcbnew/tools/pcb_grid_helper.cpp

@@ -34,6 +34,7 @@
 #include <pcb_group.h>
 #include <pcb_track.h>
 #include <zone.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <geometry/oval.h>
 #include <geometry/shape_circle.h>
 #include <geometry/shape_line_chain.h>

pcbnew/tools/pcb_picker_tool.cpp

@@ -26,6 +26,7 @@
 #include "pcb_picker_tool.h"
 #include "pcb_actions.h"
 #include "pcb_grid_helper.h"
+#include <gal/graphics_abstraction_layer.h>
 #include <view/view_controls.h>
 #include <tools/zone_filler_tool.h>
 

pcbnew/tools/pcb_point_editor.cpp

@@ -30,6 +30,7 @@ using namespace std::placeholders;
 #include <advanced_config.h>
 #include <tool/tool_manager.h>
 #include <view/view_controls.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <geometry/seg.h>
 #include <confirm.h>
 #include <tools/pcb_actions.h>

pcbnew/tools/pcb_tool_base.cpp

@@ -25,6 +25,7 @@
 
 #include <tool/tool_manager.h>
 #include <board_commit.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <footprint.h>
 #include <pcb_draw_panel_gal.h>
 #include <pgm_base.h>

pcbnew/tools/pcb_viewer_tools.cpp

@@ -26,6 +26,7 @@
 #include <pcbnew_settings.h>
 #include <footprint_editor_settings.h>
 #include <3d_viewer/eda_3d_viewer_frame.h>
+#include <gal/graphics_abstraction_layer.h>
 #include <kiplatform/ui.h>
 #include <pcb_base_frame.h>
 #include <preview_items/ruler_item.h>

qa/qa_utils/pcb_test_frame.h

@@ -31,6 +31,7 @@
 #include <memory>
 
 #include <pcb_draw_panel_gal.h>
+#include <gal/graphics_abstraction_layer.h>
 
 using std::unique_ptr;